@webex/plugin-meetings 3.8.1 → 3.9.0-multipleLLM.1

package/test/unit/spec/media/properties.ts

@@ -6,6 +6,8 @@ import * as tsSdpModule from '@webex/ts-sdp';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
 import {Defer} from '@webex/common';
 import MediaConnectionAwaiter from '../../../../src/media/MediaConnectionAwaiter';
+import Metrics from '../../../../src/metrics';
+import BEHAVIORAL_METRICS from '../../../../src/metrics/constants';
 
 describe('MediaProperties', () => {
   let mediaProperties;
@@ -389,4 +391,139 @@ describe('MediaProperties', () => {
       });
     });
   });
+
+  // issue types and subtypes used in these tests are just examples
+  // they don't reflect real issue types/subtypes used in production
+  describe('sendMediaIssueMetric', () => {
+    let sendBehavioralMetricStub;
+    let clock;
+
+    beforeEach(() => {
+      clock = sinon.useFakeTimers();
+      sendBehavioralMetricStub = sinon.stub(Metrics, 'sendBehavioralMetric');
+    });
+
+    afterEach(() => {
+      clock.restore();
+    });
+
+    it('should send a behavioral metric with correct parameters', () => {
+      const issueType = 'audio';
+      const issueSubType = 'packet-loss';
+      const correlationId = 'test-correlation-id-123';
+
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+
+      assert.calledOnce(sendBehavioralMetricStub);
+      assert.calledWith(sendBehavioralMetricStub, BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED, {
+        correlationId,
+        'audio_packet-loss': 1,
+      });
+    });
+
+    it('should increment count while being throttled and reset it once metric goes out', () => {
+      const issueType = 'video';
+      const issueSubType = 'freeze';
+      const correlationId = 'test-correlation-id';
+
+      // Call multiple times with same issue type/subtype
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+
+      // First call should go through immediately, subsequent calls are throttled
+      assert.calledOnce(sendBehavioralMetricStub);
+      assert.calledWith(sendBehavioralMetricStub, BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED, {
+        correlationId,
+        video_freeze: 1, // Only the first call goes through due to throttling
+      });
+      sendBehavioralMetricStub.resetHistory();
+
+      assert.equal(mediaProperties.mediaIssueCounters['video_freeze'], 2); // counter should be reset after the first metric goes out, hence only 2 not 3 here
+
+      clock.tick(5 * 60 * 1000); // Advance time by 5 minutes to expire throttle
+
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          video_freeze: 2,
+        }
+      );
+    });
+
+    it('should track different issue types separately in counters', () => {
+      const correlationId = 'test-correlation-id';
+
+      // Send different issue types
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('video', 'freeze', correlationId);
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('audio', 'packet-loss', correlationId);
+      mediaProperties.sendMediaIssueMetric('video', 'freeze', correlationId);
+
+      // First call should go through immediately, subsequent calls are throttled
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          'audio_packet-loss': 1,
+        }
+      );
+
+      // But the counters should be tracked separately
+      assert.equal(mediaProperties.mediaIssueCounters['audio_packet-loss'], 3);
+      assert.equal(mediaProperties.mediaIssueCounters['video_freeze'], 2);
+
+      sendBehavioralMetricStub.resetHistory();
+
+      clock.tick(5 * 60 * 1000); // Advance time by 5 minutes to expire throttle
+
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          video_freeze: 2,
+          'audio_packet-loss': 3,
+        }
+      );
+    });
+
+    it('should flush throttled metrics when unsetPeerConnection is called', () => {
+      const issueType = 'share';
+      const issueSubType = 'connection-lost';
+      const correlationId = 'test-correlation-id';
+
+      // Send metrics multiple times
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+      mediaProperties.sendMediaIssueMetric(issueType, issueSubType, correlationId);
+
+      // First call should go through immediately
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          'share_connection-lost': 1,
+        }
+      );
+      sendBehavioralMetricStub.resetHistory();
+
+      // Call unsetPeerConnection which should flush throttled metrics
+      mediaProperties.unsetPeerConnection();
+
+      assert.calledOnceWithExactly(
+        sendBehavioralMetricStub,
+        BEHAVIORAL_METRICS.MEDIA_ISSUE_DETECTED,
+        {
+          correlationId,
+          'share_connection-lost': 1,
+        }
+      );
+    });
+  });
 });

package/test/unit/spec/meeting/brbState.ts

@@ -1,12 +1,14 @@
 import sinon from 'sinon';
-import {assert} from '@webex/test-helper-chai';
+import {assert, expect} from '@webex/test-helper-chai';
 
 import testUtils from '../../../utils/testUtils';
 import {BrbState, createBrbState} from '@webex/plugin-meetings/src/meeting/brbState';
+import {MediaType} from '@webex/internal-media-core';
 
 describe('plugin-meetings', () => {
   let meeting: any;
   let brbState: BrbState;
+  let setBrbStub: sinon.SinonStub;
 
   beforeEach(async () => {
     meeting = {
@@ -21,14 +23,20 @@ describe('plugin-meetings', () => {
         setSourceStateOverride: sinon.stub(),
       },
       meetingRequest: {
-        setBrb: sinon.stub().resolves(),
+        setBrb: () => {},
       },
     };
 
+    setBrbStub = sinon.stub(meeting.meetingRequest, 'setBrb').resolves();
+
     brbState = new BrbState(meeting, false);
     await testUtils.flushPromises();
   });
 
+  afterEach(() => {
+    sinon.restore();
+  });
+
   describe('brbState library', () => {
     it('takes into account current status when instantiated', async () => {
       // create a new BrbState instance
@@ -96,12 +104,12 @@ describe('plugin-meetings', () => {
       assert.isTrue(meeting.meetingRequest.setBrb.calledOnce);
     });
 
-    it('sets source state override when client state does not match server state', async () => {
+    it('updates source state override', async () => {
       brbState.enable(true, meeting.sendSlotManager);
       brbState.handleServerBrbUpdate(true);
       await testUtils.flushPromises();
 
-      assert.isTrue(meeting.sendSlotManager.setSourceStateOverride.calledOnce);
+      assert.isTrue(meeting.sendSlotManager.setSourceStateOverride.called);
     });
 
     it('handles server update', async () => {
@@ -129,5 +137,16 @@ describe('plugin-meetings', () => {
       sendLocalBrbStateToServerStub.restore();
       handleServerBrbUpdateSpy.restore();
     });
+
+    it('should reject when sendLocalBrbStateToServer fails', async () => {
+      const error = new Error('send failed');
+      setBrbStub.rejects(error);
+
+      const enablePromise = brbState.enable(true, meeting.sendSlotManager);
+      await expect(enablePromise).to.be.rejectedWith(error);
+
+      assert.isFalse(brbState.state.syncToServerInProgress);
+      expect(meeting.sendSlotManager.setSourceStateOverride.called).to.be.false;
+    });
   });
 });

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -32,9 +32,13 @@ describe('plugin-meetings', () => {
         isClosedCaptionActive: null,
         canStartManualCaption: null,
         canStopManualCaption: null,
+        isLocalRecordingStarted: null,
+        isLocalRecordingStopped: null,
+        isLocalRecordingPaused: null,
         isManualCaptionActive: null,
         isPremiseRecordingEnabled: null,
         isSaveTranscriptsEnabled: null,
+        isSpokenLanguageAutoDetectionEnabled: null,
         isWebexAssistantActive: null,
         canViewCaptionPanel: null,
         isRealTimeTranslationEnabled: null,
@@ -102,6 +106,8 @@ describe('plugin-meetings', () => {
         canEnableRemoteDesktopControl: null,
         canDisableRemoteDesktopControl: null,
         canMoveToLobby: null,
+        canEnablePollingQA: null,
+        canDisablePollingQA: null,
 
         ...expected,
       };
@@ -127,6 +133,9 @@ describe('plugin-meetings', () => {
       'canPauseRecording',
       'canResumeRecording',
       'canStopRecording',
+      'isLocalRecordingStarted',
+      'isLocalRecordingStopped',
+      'isLocalRecordingPaused',
       'canSetMuteOnEntry',
       'canUnsetMuteOnEntry',
       'canSetDisallowUnmute',
@@ -143,6 +152,7 @@ describe('plugin-meetings', () => {
       'isManualCaptionActive',
       'isPremiseRecordingEnabled',
       'isSaveTranscriptsEnabled',
+      'isSpokenLanguageAutoDetectionEnabled',
       'isWebexAssistantActive',
       'canViewCaptionPanel',
       'isRealTimeTranslationEnabled',
@@ -210,6 +220,8 @@ describe('plugin-meetings', () => {
       'canEnableRemoteDesktopControl',
       'canDisableRemoteDesktopControl',
       'canMoveToLobby',
+      'canEnablePollingQA',
+      'canDisablePollingQA',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();