@webex/plugin-meetings 3.8.1-next.8 → 3.8.1

package/test/unit/spec/meeting/index.js

@@ -1223,46 +1223,6 @@ describe('plugin-meetings', () => {
         });
       });
 
-      describe('#update spoken language', () => {
-        beforeEach(() => {
-          webex.internal.voicea.onSpokenLanguageUpdate = sinon.stub();
-          meeting.transcription = {languageOptions: {currentSpokenLanguage: 'en'}};
-        });
-        afterEach(() => {
-          // Restore the original methods after each test
-          sinon.restore();
-        });
-        it('should call voicea.onSpokenLanguageUpdate when joined', async () => {
-
-          meeting.joinedWith = {state: 'JOINED'};
-          await meeting.locusInfo.emitScoped(
-            {function: 'test', file: 'test'},
-            LOCUSINFO.EVENTS.CONTROLS_MEETING_TRANSCRIPTION_SPOKEN_LANGUAGE_UPDATED,
-            {spokenLanguage: 'fr'},
-          );
-          assert.calledWith(webex.internal.voicea.onSpokenLanguageUpdate, 'fr');
-          assert.equal(meeting.transcription.languageOptions.currentSpokenLanguage, 'fr');
-          assert.calledWith(
-            TriggerProxy.trigger,
-            meeting,
-            {file: 'meeting/index', function: 'setupLocusControlsListener'},
-            EVENT_TRIGGERS.MEETING_TRANSCRIPTION_SPOKEN_LANGUAGE_UPDATED
-          );
-        });
-
-        it('should also call voicea.onSpokenLanguageUpdate when not joined', async () => {
-
-          meeting.joinedWith = {state: 'NOT_JOINED'};
-          await meeting.locusInfo.emitScoped(
-            {function: 'test', file: 'test'},
-            LOCUSINFO.EVENTS.CONTROLS_MEETING_TRANSCRIPTION_SPOKEN_LANGUAGE_UPDATED,
-            {spokenLanguage: 'de'},
-          );
-          assert.calledWith(webex.internal.voicea.onSpokenLanguageUpdate, 'de');
-          assert.equal(meeting.transcription.languageOptions.currentSpokenLanguage, 'de');
-        });
-      });
-
       describe('#startTranscription', () => {
         beforeEach(() => {
           webex.internal.voicea.on = sinon.stub();
@@ -2227,9 +2187,8 @@ describe('plugin-meetings', () => {
               someReachabilityMetric1: 'some value1',
               someReachabilityMetric2: 'some value2',
               selectedCandidatePairChanges: 2,
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
               numTransports: 1,
               iceCandidatesCount: 0,
             }
@@ -2276,9 +2235,8 @@ describe('plugin-meetings', () => {
               signalingState: 'unknown',
               connectionState: 'unknown',
               iceConnectionState: 'unknown',
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
             })
           );
 
@@ -2344,9 +2302,8 @@ describe('plugin-meetings', () => {
               selectedCandidatePairChanges: 2,
               numTransports: 1,
               iceCandidatesCount: 0,
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
             }
           );
         });
@@ -2404,9 +2361,8 @@ describe('plugin-meetings', () => {
               signalingState: 'have-local-offer',
               connectionState: 'connecting',
               iceConnectionState: 'checking',
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
             })
           );
 
@@ -2464,9 +2420,8 @@ describe('plugin-meetings', () => {
               signalingState: 'have-local-offer',
               connectionState: 'connecting',
               iceConnectionState: 'checking',
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
             })
           );
 
@@ -2988,9 +2943,8 @@ describe('plugin-meetings', () => {
               selectedCandidatePairChanges: 2,
               numTransports: 1,
               iceCandidatesCount: 0,
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
             },
           ]);
 
@@ -3197,9 +3151,8 @@ describe('plugin-meetings', () => {
               retriedWithTurnServer: true,
               isJoinWithMediaRetry: false,
               iceCandidatesCount: 0,
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
             },
           ]);
           meeting.roap.doTurnDiscovery;
@@ -3362,9 +3315,8 @@ describe('plugin-meetings', () => {
               iceCandidatesCount: 3,
               '701_error': 3,
               '701_turn_host_lookup_received_error': 1,
-              subnet_reachable: null,
-              selected_cluster: 'some.cluster',
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: 'some.cluster',
             }
           );
 
@@ -3427,9 +3379,8 @@ describe('plugin-meetings', () => {
               iceConnectionState: 'unknown',
               selectedCandidatePairChanges: 2,
               numTransports: 1,
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
               iceCandidatesCount: 0,
             }
           );
@@ -3491,9 +3442,8 @@ describe('plugin-meetings', () => {
               numTransports: 1,
               '701_error': 2,
               '701_turn_host_lookup_received_error': 1,
-              subnet_reachable: null,
-              selected_cluster: null,
-              selected_subnet: null,
+              isSubnetReachable: null,
+              selectedCluster: null,
               iceCandidatesCount: 0,
             }
           );
@@ -3501,7 +3451,7 @@ describe('plugin-meetings', () => {
           assert.isOk(errorThrown);
         });
 
-        it('should send subnet reachablity metrics if media connection success', async () => {
+        it('should send valid isSubnetReachability if media connection success', async () => {
           meeting.roap.doTurnDiscovery = sinon.stub().returns({
             turnServerInfo: undefined,
             turnDiscoverySkippedReason: undefined,
@@ -3515,12 +3465,6 @@ describe('plugin-meetings', () => {
             stopReachability: sinon.stub(),
             isSubnetReachable: sinon.stub().returns(false),
           };
-          meeting.mediaServerIp =  '1.2.3.4';
-          meeting.mediaConnections = [
-            {
-              mediaAgentCluster: 'some.cluster',
-            }
-          ]
 
           const forceRtcMetricsSend = sinon.stub().resolves();
           const closeMediaConnectionStub = sinon.stub();
@@ -3548,13 +3492,12 @@ describe('plugin-meetings', () => {
             isJoinWithMediaRetry: false,
             iceCandidatesCount: 0,
             reachability_public_udp_success: 5,
-            subnet_reachable: false,
-            selected_cluster: 'some.cluster',
-            selected_subnet: '1.X.X.X',
+            isSubnetReachable: false,
+            selectedCluster: null,
           });
         });
 
-        it('should send subnet reachablity metrics if media connection fails', async () => {
+        it('should send valid isSubnetReachability if media connection fails', async () => {
           let errorThrown = undefined;
 
           meeting.roap.doTurnDiscovery = sinon.stub().returns({
@@ -3570,12 +3513,6 @@ describe('plugin-meetings', () => {
             stopReachability: sinon.stub(),
             isSubnetReachable: sinon.stub().returns(true),
           };
-          meeting.mediaServerIp =  '1.2.3.4';
-          meeting.mediaConnections = [
-            {
-              mediaAgentCluster: 'some.cluster',
-            }
-          ]
 
           const forceRtcMetricsSend = sinon.stub().resolves();
           const closeMediaConnectionStub = sinon.stub();
@@ -3617,9 +3554,8 @@ describe('plugin-meetings', () => {
               selectedCandidatePairChanges: 2,
               numTransports: 1,
               reachability_public_udp_success: 5,
-              subnet_reachable: true,
-              selected_cluster: 'some.cluster',
-              selected_subnet: '1.X.X.X',
+              isSubnetReachable: true,
+              selectedCluster: null,
               iceCandidatesCount: 0,
             }
           );
@@ -4216,7 +4152,7 @@ describe('plugin-meetings', () => {
           meeting.deviceUrl = 'device url';
           meeting.selfId = 'self id';
           meeting.brbState = createBrbState(meeting, false);
-          sinon.stub(meeting.brbState, 'enable').resolves();
+          meeting.brbState.enable = sinon.stub().resolves();
         });
 
         afterEach(() => {
@@ -4280,19 +4216,6 @@ describe('plugin-meetings', () => {
 
             assert.notCalled(meeting.audio.handleServerRemoteMuteUpdate);
           });
-
-          it('should reject when brb enable fails', async () => {
-            meeting.brbState.enable.restore();
-
-            const error = new Error();
-            meeting.meetingRequest.setBrb = sinon.stub().rejects(error);
-        
-            await expect(
-              meeting.beRightBack(true)
-            ).to.be.rejectedWith(error);  
-             
-            assert.isFalse(meeting.brbState.state.syncToServerInProgress);
-          });
         });
       });
 
@@ -10088,24 +10011,6 @@ describe('plugin-meetings', () => {
           );
         });
 
-        it('listens to CONTROLS_POLLING_QA_CHANGED', async () => {
-          const state = {example: 'value'};
-
-          await meeting.locusInfo.emitScoped(
-            {function: 'test', file: 'test'},
-            LOCUSINFO.EVENTS.CONTROLS_POLLING_QA_CHANGED,
-            {state}
-          );
-
-          assert.calledWith(
-            TriggerProxy.trigger,
-            meeting,
-            {file: 'meeting/index', function: 'setupLocusControlsListener'},
-            EVENT_TRIGGERS.MEETING_CONTROLS_POLLING_QA_UPDATED,
-            {state}
-          );
-        });
-
         it('listens to the locus interpretation update event', () => {
           const interpretation = {
             siLanguages: [{languageCode: 20, languageName: 'en'}],
@@ -11698,14 +11603,6 @@ describe('plugin-meetings', () => {
             requiredHints: [DISPLAY_HINTS.DISABLE_RDC_MEETING_OPTION],
             displayHints: userDisplayHints,
           });
-          assert.calledWith(ControlsOptionsUtil.hasHints, {
-            requiredHints: [DISPLAY_HINTS.ENABLE_ATTENDEE_START_POLLING_QA],
-            displayHints: userDisplayHints,
-          });
-          assert.calledWith(ControlsOptionsUtil.hasHints, {
-            requiredHints: [DISPLAY_HINTS.DISABLE_ATTENDEE_START_POLLING_QA],
-            displayHints: userDisplayHints,
-          });
 
           assert.calledWith(
             TriggerProxy.trigger,

package/test/unit/spec/reachability/index.ts

@@ -2764,10 +2764,14 @@ describe('isSubnetReachable', () => {
   });
 
   it('returns true if the subnet is reachable', () => {
-    assert(reachability.isSubnetReachable('1'));
+    assert(reachability.isSubnetReachable('1.2.3.4'));
   });
 
   it(`returns false if the subnet is unreachable`, () => {
-    assert(!reachability.isSubnetReachable('11'));
+    assert(!reachability.isSubnetReachable('11.2.3.4'));
+  });
+
+  it('returns null if the subnet is not provided', () => {
+    assert.isNull(reachability.isSubnetReachable(undefined));
   });
 });