@webex/plugin-meetings 3.8.0-next.79 → 3.8.0-next.80

package/dist/types/meetings/index.d.ts

@@ -236,6 +236,15 @@ export default class Meetings extends WebexPlugin {
      * @returns {undefined}
      */
     private _toggleDisableAudioMainDtx;
+    /**
+     * API to toggle usage of audio twcc support
+     *
+     * @param {Boolean} newValue
+     * @private
+     * @memberof Meetings
+     * @returns {undefined}
+     */
+    private _toggleEnableAudioTwccForMultistream;
     /**
      * API to toggle stopping ICE Candidates Gathering after first relay candidate,
      * needs to be called before webex.meetings.joinWithMedia()

package/dist/webinar/index.js

@@ -458,7 +458,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       }, _callee7);
     }))();
   },
-  version: "3.8.0-next.79"
+  version: "3.8.0-next.80"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,7 +43,7 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.8.0-next.79",
+    "@webex/plugin-meetings": "3.8.0-next.80",
     "@webex/plugin-rooms": "3.8.0-next.27",
     "@webex/test-helper-chai": "3.8.0-next.22",
     "@webex/test-helper-mocha": "3.8.0-next.22",
@@ -63,7 +63,7 @@
   "dependencies": {
     "@webex/common": "3.8.0-next.22",
     "@webex/event-dictionary-ts": "^1.0.1753",
-    "@webex/internal-media-core": "2.16.0",
+    "@webex/internal-media-core": "2.17.0",
     "@webex/internal-plugin-conversation": "3.8.0-next.27",
     "@webex/internal-plugin-device": "3.8.0-next.22",
     "@webex/internal-plugin-llm": "3.8.0-next.25",
@@ -71,8 +71,8 @@
     "@webex/internal-plugin-metrics": "3.8.0-next.22",
     "@webex/internal-plugin-support": "3.8.0-next.27",
     "@webex/internal-plugin-user": "3.8.0-next.22",
-    "@webex/internal-plugin-voicea": "3.8.0-next.79",
-    "@webex/media-helpers": "3.8.0-next.26",
+    "@webex/internal-plugin-voicea": "3.8.0-next.80",
+    "@webex/media-helpers": "3.8.0-next.27",
     "@webex/plugin-people": "3.8.0-next.24",
     "@webex/plugin-rooms": "3.8.0-next.27",
     "@webex/ts-sdp": "^1.8.1",
@@ -93,5 +93,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.8.0-next.79"
+  "version": "3.8.0-next.80"
 }

package/src/config.ts

@@ -99,5 +99,6 @@ export default {
     reachabilityGetClusterTimeout: 5000,
     logUploadIntervalMultiplicationFactor: 0, // if set to 0 or undefined, logs won't be uploaded periodically, if you want periodic logs, recommended value is 1
     stopIceGatheringAfterFirstRelayCandidate: false,
+    enableAudioTwccForMultistream: false,
   },
 };

package/src/media/index.ts

@@ -144,6 +144,7 @@ Media.createMediaConnection = (
     bundlePolicy?: BundlePolicy;
     iceCandidatesTimeout?: number;
     disableAudioMainDtx?: boolean;
+    enableAudioTwcc?: boolean;
     stopIceGatheringAfterFirstRelayCandidate?: boolean;
   }
 ) => {
@@ -157,6 +158,7 @@ Media.createMediaConnection = (
     bundlePolicy,
     iceCandidatesTimeout,
     disableAudioMainDtx,
+    enableAudioTwcc,
     stopIceGatheringAfterFirstRelayCandidate,
   } = options;
 
@@ -175,6 +177,7 @@ Media.createMediaConnection = (
   if (isMultistream) {
     const config: MultistreamConnectionConfig = {
       iceServers,
+      disableAudioTwcc: !enableAudioTwcc,
     };
 
     if (bundlePolicy) {

package/src/meeting/index.ts

@@ -7050,6 +7050,8 @@ export default class Meeting extends StatelessWebexPlugin {
         iceCandidatesTimeout: this.config.iceCandidatesGatheringTimeout,
         // @ts-ignore - config coming from registerPlugin
         disableAudioMainDtx: this.config.experimental.disableAudioMainDtx,
+        // @ts-ignore - config coming from registerPlugin
+        enableAudioTwcc: this.config.enableAudioTwccForMultistream,
         stopIceGatheringAfterFirstRelayCandidate:
           // @ts-ignore - config coming from registerPlugin
           this.config.stopIceGatheringAfterFirstRelayCandidate,

package/src/meetings/index.ts

@@ -827,6 +827,26 @@ export default class Meetings extends WebexPlugin {
     }
   }
 
+  /**
+   * API to toggle usage of audio twcc support
+   *
+   * @param {Boolean} newValue
+   * @private
+   * @memberof Meetings
+   * @returns {undefined}
+   */
+  private _toggleEnableAudioTwccForMultistream(newValue: boolean) {
+    if (typeof newValue !== 'boolean') {
+      return;
+    }
+
+    // @ts-ignore
+    if (this.config.enableAudioTwccForMultistream !== newValue) {
+      // @ts-ignore
+      this.config.enableAudioTwccForMultistream = newValue;
+    }
+  }
+
   /**
    * API to toggle stopping ICE Candidates Gathering after first relay candidate,
    * needs to be called before webex.meetings.joinWithMedia()

package/test/unit/spec/media/index.ts

@@ -4,7 +4,7 @@ import Media from '@webex/plugin-meetings/src/media/index';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import StaticConfig from '@webex/plugin-meetings/src/common/config';
-import { BrowserInfo } from '@webex/web-capabilities';
+import {BrowserInfo} from '@webex/web-capabilities';
 
 describe('createMediaConnection', () => {
   let clock;
@@ -80,7 +80,10 @@ describe('createMediaConnection', () => {
       enableRtx: ENABLE_RTX,
       enableExtmap: ENABLE_EXTMAP,
       turnServerInfo: {
-        urls: ['turns:turn-server-url-1:443?transport=tcp', 'turns:turn-server-url-2:443?transport=tcp'],
+        urls: [
+          'turns:turn-server-url-1:443?transport=tcp',
+          'turns:turn-server-url-2:443?transport=tcp',
+        ],
         username: 'turn username',
         password: 'turn password',
       },
@@ -92,7 +95,10 @@ describe('createMediaConnection', () => {
       {
         iceServers: [
           {
-            urls: ['turns:turn-server-url-1:443?transport=tcp', 'turns:turn-server-url-2:443?transport=tcp'],
+            urls: [
+              'turns:turn-server-url-1:443?transport=tcp',
+              'turns:turn-server-url-2:443?transport=tcp',
+            ],
             username: 'turn username',
             credential: 'turn password',
           },
@@ -155,12 +161,16 @@ describe('createMediaConnection', () => {
       },
       rtcMetrics,
       turnServerInfo: {
-        urls: ['turns:turn-server-url-1:443?transport=tcp', 'turns:turn-server-url-2:443?transport=tcp'],
+        urls: [
+          'turns:turn-server-url-1:443?transport=tcp',
+          'turns:turn-server-url-2:443?transport=tcp',
+        ],
         username: 'turn username',
         password: 'turn password',
       },
       bundlePolicy: 'max-bundle',
       disableAudioMainDtx: false,
+      enableAudioTwcc: true,
     });
     assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
@@ -168,21 +178,27 @@ describe('createMediaConnection', () => {
       {
         iceServers: [
           {
-            urls: ['turns:turn-server-url-1:443?transport=tcp', 'turns:turn-server-url-2:443?transport=tcp'],
+            urls: [
+              'turns:turn-server-url-1:443?transport=tcp',
+              'turns:turn-server-url-2:443?transport=tcp',
+            ],
             username: 'turn username',
             credential: 'turn password',
           },
         ],
         bundlePolicy: 'max-bundle',
         disableAudioMainDtx: false,
+        disableAudioTwcc: false,
       },
       'meeting id'
     );
 
     // check if rtcMetrics callbacks are configured correctly
     const addMetricsCallback = multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[2];
-    const closeMetricsCallback = multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[3];
-    const sendMetricsInQueueCallback = multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[4];
+    const closeMetricsCallback =
+      multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[3];
+    const sendMetricsInQueueCallback =
+      multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[4];
 
     assert.isFunction(addMetricsCallback);
     assert.isFunction(closeMetricsCallback);
@@ -212,7 +228,8 @@ describe('createMediaConnection', () => {
     assert.calledWith(
       multistreamRoapMediaConnectionConstructorStub,
       {
-        iceServers: []
+        iceServers: [],
+        disableAudioTwcc: true,
       },
       'meeting id'
     );
@@ -235,6 +252,7 @@ describe('createMediaConnection', () => {
         iceServers: [],
         doFullIce: true,
         stopIceGatheringAfterFirstRelayCandidate: true,
+        disableAudioTwcc: true,
       },
       'meeting id'
     );
@@ -257,6 +275,7 @@ describe('createMediaConnection', () => {
         iceServers: [],
         doFullIce: true,
         stopIceGatheringAfterFirstRelayCandidate: false,
+        disableAudioTwcc: true,
       },
       'meeting id'
     );
@@ -292,6 +311,7 @@ describe('createMediaConnection', () => {
         multistreamRoapMediaConnectionConstructorStub,
         {
           iceServers: [],
+          disableAudioTwcc: true,
         },
         'meeting id'
       );
@@ -321,6 +341,7 @@ describe('createMediaConnection', () => {
       multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [],
+        disableAudioTwcc: true,
       },
       'meeting id'
     );
@@ -349,6 +370,35 @@ describe('createMediaConnection', () => {
       multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [],
+        disableAudioTwcc: true,
+      },
+      'meeting id'
+    );
+  });
+
+  it('MultistreamRoapMediaConnection disable audio twcc by default', () => {
+    const multistreamRoapMediaConnectionConstructorStub = sinon
+      .stub(InternalMediaCoreModule, 'MultistreamRoapMediaConnection')
+      .returns(fakeRoapMediaConnection);
+
+    Media.createMediaConnection(true, 'debug string', 'meeting id', {
+      mediaProperties: {
+        mediaDirection: {
+          sendAudio: true,
+          sendVideo: true,
+          sendShare: false,
+          receiveAudio: true,
+          receiveVideo: true,
+          receiveShare: true,
+        },
+      },
+    });
+    assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
+    assert.calledWith(
+      multistreamRoapMediaConnectionConstructorStub,
+      {
+        iceServers: [],
+        disableAudioTwcc: true,
       },
       'meeting id'
     );

package/test/unit/spec/meetings/index.js

@@ -413,6 +413,19 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('#_toggleEnableAudioTwccForMultistream', () => {
+      it('should have _toggleEnableAudioTwccForMultistream', () => {
+        assert.equal(typeof webex.meetings._toggleEnableAudioTwccForMultistream, 'function');
+      });
+
+      describe('success', () => {
+        it('should update meetings to enable audio twcc support', () => {
+          webex.meetings._toggleEnableAudioTwccForMultistream(true);
+          assert.equal(webex.meetings.config.enableAudioTwccForMultistream, true);
+        });
+      });
+    });
+
     describe('#_toggleStopIceGatheringAfterFirstRelayCandidate', () => {
       it('should have _toggleStopIceGatheringAfterFirstRelayCandidate', () => {
         assert.equal(typeof webex.meetings._toggleStopIceGatheringAfterFirstRelayCandidate, 'function');