@webex/plugin-meetings 3.8.0-next.70 → 3.8.0-next.72

package/test/unit/spec/locus-info/index.js

@@ -836,7 +836,7 @@ describe('plugin-meetings', () => {
           selfWithBrbChanged.controls.brb = enabled;
 
           locusInfo.emitScoped = sinon.stub();
-          locusInfo.updateSelf(selfWithBrbChanged, []);
+          locusInfo.updateSelf(selfWithBrbChanged);
 
           assert.calledWith(
             locusInfo.emitScoped,
@@ -856,14 +856,15 @@ describe('plugin-meetings', () => {
 
           const selfWithBrbChanged = cloneDeep(self);
           selfWithBrbChanged.controls.brb = value;
-          locusInfo.self = selfWithBrbChanged;
+
+          locusInfo.updateSelf(selfWithBrbChanged);
 
           locusInfo.emitScoped = sinon.stub();
 
           const newSelf = cloneDeep(self);
           newSelf.controls.brb = value;
 
-          locusInfo.updateSelf(newSelf, []);
+          locusInfo.updateSelf(newSelf);
 
           assert.neverCalledWith(
             locusInfo.emitScoped,
@@ -880,14 +881,14 @@ describe('plugin-meetings', () => {
       it('should not trigger SELF_MEETING_BRB_CHANGED when brb state is undefined', () => {
         const selfWithBrbChanged = cloneDeep(self);
         selfWithBrbChanged.controls.brb = false;
-        locusInfo.self = selfWithBrbChanged;
+        locusInfo.updateSelf(selfWithBrbChanged);
 
         locusInfo.emitScoped = sinon.stub();
 
         const newSelf = cloneDeep(self);
         newSelf.controls.brb = undefined;
 
-        locusInfo.updateSelf(newSelf, []);
+        locusInfo.updateSelf(newSelf);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -910,7 +911,7 @@ describe('plugin-meetings', () => {
         ];
 
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithLayoutChanged, []);
+        locusInfo.updateSelf(selfWithLayoutChanged);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -936,11 +937,11 @@ describe('plugin-meetings', () => {
         ];
 
         // Set the layout prior to stubbing to validate it does not change.
-        locusInfo.updateSelf(selfWithLayoutChanged, []);
+        locusInfo.updateSelf(selfWithLayoutChanged);
 
         locusInfo.emitScoped = sinon.stub();
 
-        locusInfo.updateSelf(selfWithLayoutChanged, []);
+        locusInfo.updateSelf(selfWithLayoutChanged);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -954,11 +955,11 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger MEDIA_INACTIVITY on server media inactivity', () => {
-        locusInfo.self = self;
-
         locusInfo.webex.internal.device.url = selfWithInactivity.deviceUrl;
+        locusInfo.updateSelf(self);
+
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithInactivity, []);
+        locusInfo.updateSelf(selfWithInactivity);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -980,7 +981,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithMutedByOthers, []);
+        locusInfo.updateSelf(selfWithMutedByOthers);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -993,10 +994,10 @@ describe('plugin-meetings', () => {
         );
 
         // but sometimes "previous self" is defined, but without controls.audio.muted, so we test this here:
-        locusInfo.self = cloneDeep(self);
+        locusInfo.updateSelf(self);
         locusInfo.self.controls.audio = {};
 
-        locusInfo.updateSelf(selfWithMutedByOthers, []);
+        locusInfo.updateSelf(selfWithMutedByOthers);
         assert.calledWith(
           locusInfo.emitScoped,
           {
@@ -1016,7 +1017,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithMutedByOthersFalse, []);
+        locusInfo.updateSelf(selfWithMutedByOthersFalse);
 
         // we might get some calls to emitScoped, but we need to check that none of them are for SELF_REMOTE_MUTE_STATUS_UPDATED
         locusInfo.emitScoped.getCalls().forEach((x) => {
@@ -1025,20 +1026,20 @@ describe('plugin-meetings', () => {
       });
 
       it('should not trigger SELF_REMOTE_MUTE_STATUS_UPDATED when being removed from meeting', () => {
+        locusInfo.webex.internal.device.url = self.deviceUrl;
         const selfWithMutedByOthers = cloneDeep(self);
 
         selfWithMutedByOthers.controls.audio.muted = true;
 
-        locusInfo.self = selfWithMutedByOthers;
+        locusInfo.updateSelf(selfWithMutedByOthers);
 
         // when user gets removed from meeting we receive a Locus DTO without any self.controls
         const selfWithoutControls = cloneDeep(self);
 
         selfWithoutControls.controls = undefined;
 
-        locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithoutControls, []);
+        locusInfo.updateSelf(selfWithoutControls);
 
         // we might get some calls to emitScoped, but we need to check that none of them are for SELF_REMOTE_MUTE_STATUS_UPDATED
         locusInfo.emitScoped.getCalls().forEach((x) => {
@@ -1047,14 +1048,14 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger SELF_REMOTE_MUTE_STATUS_UPDATED on othersMuted', () => {
-        locusInfo.self = self;
+        locusInfo.webex.internal.device.url = self.deviceUrl;
+        locusInfo.updateSelf(self);
         const selfWithMutedByOthers = cloneDeep(self);
 
         selfWithMutedByOthers.controls.audio.muted = true;
 
-        locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithMutedByOthers, []);
+        locusInfo.updateSelf(selfWithMutedByOthers);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1078,7 +1079,7 @@ describe('plugin-meetings', () => {
 
           locusInfo.webex.internal.device.url = self.deviceUrl;
           locusInfo.emitScoped = sinon.stub();
-          locusInfo.updateSelf(selfWithMutedByOthers, []);
+          locusInfo.updateSelf(selfWithMutedByOthers);
 
           assert.calledWith(
             locusInfo.emitScoped,
@@ -1091,10 +1092,10 @@ describe('plugin-meetings', () => {
           );
 
           // but sometimes "previous self" is defined, but without controls.audio.muted, so we test this here:
-          locusInfo.self = cloneDeep(self);
+          locusInfo.updateSelf(self);
           locusInfo.self.controls.video = {};
 
-          locusInfo.updateSelf(selfWithMutedByOthers, []);
+          locusInfo.updateSelf(selfWithMutedByOthers);
           assert.calledWith(
             locusInfo.emitScoped,
             {
@@ -1114,7 +1115,7 @@ describe('plugin-meetings', () => {
 
           locusInfo.webex.internal.device.url = self.deviceUrl;
           locusInfo.emitScoped = sinon.stub();
-          locusInfo.updateSelf(selfWithMutedByOthersFalse, []);
+          locusInfo.updateSelf(selfWithMutedByOthersFalse);
 
           // we might get some calls to emitScoped, but we need to check that none of them are for SELF_REMOTE_VIDEO_MUTE_STATUS_UPDATED
           locusInfo.emitScoped.getCalls().forEach((x) => {
@@ -1123,14 +1124,14 @@ describe('plugin-meetings', () => {
         });
 
         it('should emit event when remoteVideoMuted changed', () => {
-          locusInfo.self = self;
+          locusInfo.webex.internal.device.url = self.deviceUrl;
+          locusInfo.updateSelf(self);
           const selfWithMutedByOthers = cloneDeep(self);
 
           selfWithMutedByOthers.controls.video.muted = true;
 
-          locusInfo.webex.internal.device.url = self.deviceUrl;
           locusInfo.emitScoped = sinon.stub();
-          locusInfo.updateSelf(selfWithMutedByOthers, []);
+          locusInfo.updateSelf(selfWithMutedByOthers);
 
           assert.calledWith(
             locusInfo.emitScoped,
@@ -1145,13 +1146,13 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger SELF_MEETING_BREAKOUTS_CHANGED when breakouts changed', () => {
-        locusInfo.self = self;
+        locusInfo.updateSelf(self);
         const selfWithBreakoutsChanged = cloneDeep(self);
 
         selfWithBreakoutsChanged.controls.breakout.sessions.active[0].name = 'new name';
 
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithBreakoutsChanged, []);
+        locusInfo.updateSelf(selfWithBreakoutsChanged);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1184,16 +1185,16 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger SELF_REMOTE_MUTE_STATUS_UPDATED if muted and disallowUnmute changed', () => {
-        locusInfo.self = self;
+        locusInfo.webex.internal.device.url = self.deviceUrl;
+        locusInfo.updateSelf(self);
         const selfWithMutedByOthersAndDissalowUnmute = cloneDeep(self);
 
         // first simulate remote mute
         selfWithMutedByOthersAndDissalowUnmute.controls.audio.muted = true;
         selfWithMutedByOthersAndDissalowUnmute.controls.audio.disallowUnmute = true;
 
-        locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithMutedByOthersAndDissalowUnmute, []);
+        locusInfo.updateSelf(selfWithMutedByOthersAndDissalowUnmute);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1211,7 +1212,7 @@ describe('plugin-meetings', () => {
         selfWithMutedByOthers.controls.audio.muted = true;
         selfWithMutedByOthers.controls.audio.disallowUnmute = false;
 
-        locusInfo.updateSelf(selfWithMutedByOthers, []);
+        locusInfo.updateSelf(selfWithMutedByOthers);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1225,15 +1226,15 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger LOCAL_UNMUTE_REQUIRED on localAudioUnmuteRequired', () => {
-        locusInfo.self = self;
+        locusInfo.webex.internal.device.url = self.deviceUrl;
+        locusInfo.updateSelf(self);
         const selfWithLocalUnmuteRequired = cloneDeep(self);
 
         selfWithLocalUnmuteRequired.controls.audio.muted = false;
         selfWithLocalUnmuteRequired.controls.audio.localAudioUnmuteRequired = true;
 
-        locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithLocalUnmuteRequired, []);
+        locusInfo.updateSelf(selfWithLocalUnmuteRequired);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1250,16 +1251,16 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger LOCAL_UNMUTE_REQUESTED when receiving requestedToUnmute=true', () => {
-        locusInfo.self = self;
+        locusInfo.webex.internal.device.url = self.deviceUrl;
+        locusInfo.updateSelf(self);
         const selfWithRequestedToUnmute = cloneDeep(self);
 
         selfWithRequestedToUnmute.controls.audio.requestedToUnmute = true;
         selfWithRequestedToUnmute.controls.audio.lastModifiedRequestedToUnmute =
           '2023-06-16T19:25:04.369Z';
 
-        locusInfo.webex.internal.device.url = self.deviceUrl;
         locusInfo.emitScoped = sinon.stub();
-        locusInfo.updateSelf(selfWithRequestedToUnmute, []);
+        locusInfo.updateSelf(selfWithRequestedToUnmute);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1277,7 +1278,7 @@ describe('plugin-meetings', () => {
         selfWithoutRequestedToUnmute.controls.audio.requestedToUnmute = false;
 
         locusInfo.emitScoped.resetHistory();
-        locusInfo.updateSelf(selfWithoutRequestedToUnmute, []);
+        locusInfo.updateSelf(selfWithoutRequestedToUnmute);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -1291,15 +1292,14 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger SELF_OBSERVING when moving meeting to DX', () => {
-        locusInfo.self = self;
+        locusInfo.webex.internal.device.url = self.deviceUrl;
+        locusInfo.updateSelf(self);
         const selfInitiatedMove = cloneDeep(self);
 
         // Inital move meeting is iniated
         selfInitiatedMove.devices[0].intent.type = 'MOVE_MEDIA';
 
-        locusInfo.webex.internal.device.url = self.deviceUrl;
-
-        locusInfo.updateSelf(selfInitiatedMove, []);
+        locusInfo.updateSelf(selfInitiatedMove);
 
         locusInfo.emitScoped = sinon.stub();
         // When dx joined the meeting after move
@@ -1307,7 +1307,7 @@ describe('plugin-meetings', () => {
 
         selfAfterDxJoins.devices[0].intent.type = 'OBSERVE';
 
-        locusInfo.updateSelf(selfAfterDxJoins, []);
+        locusInfo.updateSelf(selfAfterDxJoins);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1325,11 +1325,11 @@ describe('plugin-meetings', () => {
         selfClone.canNotViewTheParticipantList = false; // same
 
         // Set the layout prior to stubbing to validate it does not change.
-        locusInfo.updateSelf(self, []);
+        locusInfo.updateSelf(self);
 
         locusInfo.emitScoped = sinon.stub();
 
-        locusInfo.updateSelf(selfClone, []);
+        locusInfo.updateSelf(selfClone);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -1348,11 +1348,11 @@ describe('plugin-meetings', () => {
         selfClone.canNotViewTheParticipantList = true; // different
 
         // Set the layout prior to stubbing to validate it does not change.
-        locusInfo.updateSelf(self, []);
+        locusInfo.updateSelf(self);
 
         locusInfo.emitScoped = sinon.stub();
 
-        locusInfo.updateSelf(selfClone, []);
+        locusInfo.updateSelf(selfClone);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1371,11 +1371,11 @@ describe('plugin-meetings', () => {
         selfClone.isSharingBlocked = false; // same
 
         // Set the layout prior to stubbing to validate it does not change.
-        locusInfo.updateSelf(self, []);
+        locusInfo.updateSelf(self);
 
         locusInfo.emitScoped = sinon.stub();
 
-        locusInfo.updateSelf(selfClone, []);
+        locusInfo.updateSelf(selfClone);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -1394,11 +1394,11 @@ describe('plugin-meetings', () => {
         selfClone.isSharingBlocked = true; // different
 
         // Set the layout prior to stubbing to validate it does not change.
-        locusInfo.updateSelf(self, []);
+        locusInfo.updateSelf(self);
 
         locusInfo.emitScoped = sinon.stub();
 
-        locusInfo.updateSelf(selfClone, []);
+        locusInfo.updateSelf(selfClone);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1412,12 +1412,12 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger SELF_ROLES_CHANGED if self roles changed', () => {
-        locusInfo.self = self;
+        locusInfo.updateSelf(self);
         locusInfo.emitScoped = sinon.stub();
         const sampleNewSelf = cloneDeep(self);
         sampleNewSelf.controls.role.roles = [{type: 'COHOST', hasRole: true}];
 
-        locusInfo.updateSelf(sampleNewSelf, []);
+        locusInfo.updateSelf(sampleNewSelf);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1431,12 +1431,12 @@ describe('plugin-meetings', () => {
       });
 
       it('should not trigger SELF_ROLES_CHANGED if self roles not changed', () => {
-        locusInfo.self = self;
+        locusInfo.updateSelf(self);
         locusInfo.emitScoped = sinon.stub();
         const sampleNewSelf = cloneDeep(self);
         sampleNewSelf.controls.role.roles = [{type: 'PRESENTER', hasRole: true}];
 
-        locusInfo.updateSelf(sampleNewSelf, []);
+        locusInfo.updateSelf(sampleNewSelf);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -1450,12 +1450,12 @@ describe('plugin-meetings', () => {
       });
 
       it('should trigger SELF_MEETING_INTERPRETATION_CHANGED if self interpretation info changed', () => {
-        locusInfo.self = self;
+        locusInfo.updateSelf(self);
         locusInfo.emitScoped = sinon.stub();
         const sampleNewSelf = cloneDeep(self);
         sampleNewSelf.controls.interpretation.targetLanguage = 'it';
 
-        locusInfo.updateSelf(sampleNewSelf, []);
+        locusInfo.updateSelf(sampleNewSelf);
 
         assert.calledWith(
           locusInfo.emitScoped,
@@ -1472,12 +1472,12 @@ describe('plugin-meetings', () => {
       });
 
       it('should not trigger SELF_MEETING_INTERPRETATION_CHANGED if self interpretation info not changed', () => {
-        locusInfo.self = self;
+        locusInfo.updateSelf(self);
         locusInfo.emitScoped = sinon.stub();
         const sampleNewSelf = cloneDeep(self);
         sampleNewSelf.controls.interpretation.targetLanguage = 'cn'; // same with previous one
 
-        locusInfo.updateSelf(sampleNewSelf, []);
+        locusInfo.updateSelf(sampleNewSelf);
 
         assert.neverCalledWith(
           locusInfo.emitScoped,
@@ -1494,12 +1494,12 @@ describe('plugin-meetings', () => {
       });
 
       it('should not trigger any events if controls is undefined', () => {
-        locusInfo.self = self;
+        locusInfo.updateSelf(self);
         locusInfo.emitScoped = sinon.stub();
         const newSelf = cloneDeep(self);
         newSelf.controls = undefined;
 
-        locusInfo.updateSelf(newSelf, []);
+        locusInfo.updateSelf(newSelf);
 
         const eventsSet = new Set([
           LOCUSINFO.EVENTS.CONTROLS_MEETING_LAYOUT_UPDATED,
@@ -1516,6 +1516,31 @@ describe('plugin-meetings', () => {
           assert.isFalse(eventsSet.has(eventName));
         });
       });
+
+      it('calls getSelves with correct parameters', () => {
+        const getSelvesStub = sinon.stub(SelfUtils, 'getSelves').returns({
+          current: {},
+          previous: {},
+          updates: {},
+        });
+
+        locusInfo.webex.internal.device.url = self.deviceUrl;
+        locusInfo.participants = [{id: '1'}, {id: '2'}];
+        locusInfo.parsedLocus.self = {id: 'fake parsed locus self id'};
+
+        const parsedLocusSelf = locusInfo.parsedLocus.self; // need to store it before it's updated in updateSelf
+        locusInfo.updateSelf(self);
+
+        assert.calledWith(
+          getSelvesStub,
+          parsedLocusSelf,
+          self,
+          locusInfo.webex.internal.device.url,
+          locusInfo.participants
+        );
+
+        getSelvesStub.restore();
+      });
     });
 
     describe('#updateMeetingInfo', () => {
@@ -1782,11 +1807,11 @@ describe('plugin-meetings', () => {
       });
 
       it('should update media shares and emit LOCUS_INFO_UPDATE_MEDIA_SHARES when mediaShares change', () => {
-        const initialMediaShares = { audio: true, video: false };
-        const newMediaShares = { audio: false, video: true };
+        const initialMediaShares = {audio: true, video: false};
+        const newMediaShares = {audio: false, video: true};
 
         locusInfo.mediaShares = initialMediaShares;
-        locusInfo.parsedLocus = { mediaShares: null };
+        locusInfo.parsedLocus = {mediaShares: null};
 
         const parsedMediaShares = {
           current: newMediaShares,
@@ -1823,9 +1848,9 @@ describe('plugin-meetings', () => {
       });
 
       it('should force update media shares and emit LOCUS_INFO_UPDATE_MEDIA_SHARES even if shares are the same', () => {
-        const initialMediaShares = { audio: true, video: false };
+        const initialMediaShares = {audio: true, video: false};
         locusInfo.mediaShares = initialMediaShares;
-        locusInfo.parsedLocus = { mediaShares: null };
+        locusInfo.parsedLocus = {mediaShares: null};
 
         const parsedMediaShares = {
           current: initialMediaShares,
@@ -1857,7 +1882,7 @@ describe('plugin-meetings', () => {
       });
 
       it('should not emit LOCUS_INFO_UPDATE_MEDIA_SHARES if mediaShares do not change and forceUpdate is false', () => {
-        const initialMediaShares = { audio: true, video: false };
+        const initialMediaShares = {audio: true, video: false};
         locusInfo.mediaShares = initialMediaShares;
 
         // Call the function with the same mediaShares and forceUpdate = false
@@ -1871,11 +1896,11 @@ describe('plugin-meetings', () => {
       });
 
       it('should update internal state correctly when mediaShares are updated', () => {
-        const initialMediaShares = { audio: true, video: false };
-        const newMediaShares = { audio: false, video: true };
+        const initialMediaShares = {audio: true, video: false};
+        const newMediaShares = {audio: false, video: true};
 
         locusInfo.mediaShares = initialMediaShares;
-        locusInfo.parsedLocus = { mediaShares: null };
+        locusInfo.parsedLocus = {mediaShares: null};
 
         const parsedMediaShares = {
           current: newMediaShares,
@@ -2414,6 +2439,21 @@ describe('plugin-meetings', () => {
         locusInfo.onDeltaLocus(fakeLocus);
         assert.calledWith(locusInfo.updateParticipants, {}, true);
       });
+
+      it('onDeltaLocus merges delta participants with existing participants', () => {
+        const FAKE_DELTA_PARTICIPANTS = [
+          {id: '1111'}, {id: '2222'}
+        ]
+        fakeLocus.participants = FAKE_DELTA_PARTICIPANTS;
+
+        sinon.spy(locusInfo, 'mergeParticipants');
+        locusInfo.updateParticipants = sinon.stub();
+        const existingParticipants = locusInfo.participants;
+
+        locusInfo.onDeltaLocus(fakeLocus);
+        assert.calledOnceWithExactly(locusInfo.mergeParticipants, existingParticipants, FAKE_DELTA_PARTICIPANTS);
+        assert.calledWith(locusInfo.updateParticipants, FAKE_DELTA_PARTICIPANTS, false);
+      });
     });
 
     describe('#updateLocusCache', () => {