@webex/plugin-meetings 3.8.0-next.3 → 3.8.0-next.31

package/dist/types/reachability/index.d.ts

@@ -4,7 +4,7 @@
 import { Defer } from '@webex/common';
 import { IP_VERSION } from '../constants';
 import ReachabilityRequest, { ClusterList } from './request';
-import { ClusterReachabilityResult, ClientMediaPreferences, ReachabilityMetrics, ReachabilityReportV0, ReachabilityReportV1, ReachabilityResults, ReachabilityResultsForBackend, GetClustersTrigger } from './reachability.types';
+import { ClusterReachabilityResult, ClientMediaPreferences, ReachabilityMetrics, ReachabilityReportV0, ReachabilityReportV1, ReachabilityResults, ReachabilityResultsForBackend, GetClustersTrigger, NatType } from './reachability.types';
 import { ClusterReachability } from './clusterReachability';
 import EventsScope from '../common/events/events-scope';
 /**
@@ -46,6 +46,7 @@ export default class Reachability extends EventsScope {
     };
     startTime: any;
     totalDuration: any;
+    natType: NatType;
     protected lastTrigger?: string;
     /**
      * Creates an instance of Reachability.

package/dist/types/reachability/reachability.types.d.ts

@@ -4,6 +4,10 @@ export type TransportResult = {
     latencyInMilliseconds?: number;
     clientMediaIPs?: string[];
 };
+export declare enum NatType {
+    Unknown = "unknown",
+    SymmetricNat = "symmetric-nat"
+}
 export type ClusterReachabilityResult = {
     udp: TransportResult;
     tcp: TransportResult;
@@ -22,6 +26,7 @@ export type ReachabilityMetrics = {
     reachability_vmn_tcp_failed: number;
     reachability_vmn_xtls_success: number;
     reachability_vmn_xtls_failed: number;
+    natType: NatType;
 };
 /**
  * This is the type that matches what backend expects us to send to them. It is a bit weird, because

package/dist/types/roap/index.d.ts

@@ -1,7 +1,8 @@
 import { StatelessWebexPlugin } from '@webex/webex-core';
-import TurnDiscovery, { TurnDiscoveryResult } from './turnDiscovery';
+import TurnDiscovery from './turnDiscovery';
+import { TurnDiscoveryResult } from './types';
 import Meeting from '../meeting';
-export { type TurnDiscoveryResult, type TurnServerInfo, type TurnDiscoverySkipReason, } from './turnDiscovery';
+export { type TurnDiscoveryResult, type TurnServerInfo, type TurnDiscoverySkipReason } from './types';
 /**
  * Roap options
  * @typedef {Object} RoapOptions

package/dist/types/roap/turnDiscovery.d.ts

@@ -1,21 +1,6 @@
-import { Enum } from '../constants';
 import RoapRequest from './request';
 import Meeting from '../meeting';
-declare const TurnDiscoverySkipReason: {
-    readonly missingHttpResponse: "missing http response";
-    readonly reachability: "reachability";
-    readonly alreadyInProgress: "already in progress";
-};
-export type TurnDiscoverySkipReason = Enum<typeof TurnDiscoverySkipReason> | string | undefined;
-export type TurnServerInfo = {
-    url: string;
-    username: string;
-    password: string;
-};
-export type TurnDiscoveryResult = {
-    turnServerInfo?: TurnServerInfo;
-    turnDiscoverySkippedReason: TurnDiscoverySkipReason;
-};
+import { TurnDiscoverySkipReason, TurnDiscoveryResult } from './types';
 /**
  * Handles the process of finding out TURN server information from Linus.
  * This is achieved by sending a TURN_DISCOVERY_REQUEST.
@@ -152,4 +137,3 @@ export default class TurnDiscovery {
      */
     doTurnDiscovery(meeting: Meeting, isReconnecting?: boolean, isForced?: boolean): Promise<TurnDiscoveryResult>;
 }
-export {};

package/dist/types/roap/types.d.ts

@@ -0,0 +1,16 @@
+import { Enum } from '../constants';
+export declare const TurnDiscoverySkipReason: {
+    readonly missingHttpResponse: "missing http response";
+    readonly reachability: "reachability";
+    readonly alreadyInProgress: "already in progress";
+};
+export type TurnDiscoverySkipReason = Enum<typeof TurnDiscoverySkipReason> | string | undefined;
+export type TurnServerInfo = {
+    urls: string[];
+    username: string;
+    password: string;
+};
+export type TurnDiscoveryResult = {
+    turnServerInfo?: TurnServerInfo;
+    turnDiscoverySkippedReason: TurnDiscoverySkipReason;
+};

package/dist/webinar/index.js

@@ -458,7 +458,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       }, _callee7);
     }))();
   },
-  version: "3.8.0-next.3"
+  version: "3.8.0-next.31"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,13 +43,13 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.8.0-next.3",
-    "@webex/plugin-rooms": "3.7.0-next.25",
-    "@webex/test-helper-chai": "3.7.0-next.18",
-    "@webex/test-helper-mocha": "3.7.0-next.18",
-    "@webex/test-helper-mock-webex": "3.7.0-next.18",
-    "@webex/test-helper-retry": "3.7.0-next.18",
-    "@webex/test-helper-test-users": "3.7.0-next.18",
+    "@webex/plugin-meetings": "3.8.0-next.31",
+    "@webex/plugin-rooms": "3.8.0-next.13",
+    "@webex/test-helper-chai": "3.8.0-next.11",
+    "@webex/test-helper-mocha": "3.8.0-next.11",
+    "@webex/test-helper-mock-webex": "3.8.0-next.11",
+    "@webex/test-helper-retry": "3.8.0-next.11",
+    "@webex/test-helper-test-users": "3.8.0-next.11",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.24.0",
@@ -61,22 +61,22 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.7.0-next.18",
+    "@webex/common": "3.8.0-next.11",
     "@webex/event-dictionary-ts": "^1.0.1688",
-    "@webex/internal-media-core": "2.14.4",
-    "@webex/internal-plugin-conversation": "3.7.0-next.25",
-    "@webex/internal-plugin-device": "3.7.0-next.18",
-    "@webex/internal-plugin-llm": "3.8.0-next.1",
-    "@webex/internal-plugin-mercury": "3.7.0-next.23",
-    "@webex/internal-plugin-metrics": "3.7.0-next.18",
-    "@webex/internal-plugin-support": "3.7.0-next.26",
-    "@webex/internal-plugin-user": "3.7.0-next.18",
-    "@webex/internal-plugin-voicea": "3.8.0-next.3",
-    "@webex/media-helpers": "3.7.0-next.25",
-    "@webex/plugin-people": "3.7.0-next.23",
-    "@webex/plugin-rooms": "3.7.0-next.25",
+    "@webex/internal-media-core": "2.14.7",
+    "@webex/internal-plugin-conversation": "3.8.0-next.13",
+    "@webex/internal-plugin-device": "3.8.0-next.11",
+    "@webex/internal-plugin-llm": "3.8.0-next.14",
+    "@webex/internal-plugin-mercury": "3.8.0-next.13",
+    "@webex/internal-plugin-metrics": "3.8.0-next.11",
+    "@webex/internal-plugin-support": "3.8.0-next.13",
+    "@webex/internal-plugin-user": "3.8.0-next.11",
+    "@webex/internal-plugin-voicea": "3.8.0-next.31",
+    "@webex/media-helpers": "3.8.0-next.12",
+    "@webex/plugin-people": "3.8.0-next.13",
+    "@webex/plugin-rooms": "3.8.0-next.13",
     "@webex/web-capabilities": "^1.4.0",
-    "@webex/webex-core": "3.7.0-next.18",
+    "@webex/webex-core": "3.8.0-next.11",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",
@@ -92,5 +92,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.8.0-next.3"
+  "version": "3.8.0-next.31"
 }

package/src/config.ts

@@ -95,6 +95,7 @@ export default {
     // This only applies to non-multistream meetings
     iceCandidatesGatheringTimeout: undefined,
     backendIpv6NativeSupport: false,
+    enableReachabilityChecks: true,
     reachabilityGetClusterTimeout: 5000,
     logUploadIntervalMultiplicationFactor: 0, // if set to 0 or undefined, logs won't be uploaded periodically, if you want periodic logs, recommended value is 1
   },

package/src/constants.ts

@@ -904,6 +904,7 @@ export enum SELF_POLICY {
   ENFORCE_VIRTUAL_BACKGROUND = 'enforceVirtualBackground',
   SUPPORT_LOCAL_RECORD = 'supportLocalRecord',
   SUPPORT_NETWORK_BASED_RECORD = 'supportNetworkBasedRecord',
+  SUPPORT_PREMISE_RECORD = 'supportPremiseRecord',
   SUPPORT_REALTIME_CLOSE_CAPTION = 'supportRealtimeCloseCaption',
   SUPPORT_CHAT = 'supportChat',
   SUPPORT_DESKTOP_SHARE_REMOTE = 'supportDesktopShareRemote',

package/src/interpretation/index.ts

@@ -35,13 +35,13 @@ const SimultaneousInterpretation = WebexPlugin.extend({
   derived: {
     shouldQuerySupportLanguages: {
       cache: false,
-      deps: ['canManageInterpreters', 'hostSIEnabled'],
+      deps: ['canManageInterpreters', 'hostSIEnabled', 'locusUrl'],
       /**
        * Returns should query support languages or not
        * @returns {boolean}
        */
       fn() {
-        return !!(this.canManageInterpreters && this.hostSIEnabled);
+        return !!(this.canManageInterpreters && this.hostSIEnabled && this.locusUrl);
       },
     },
   },
@@ -51,7 +51,7 @@ const SimultaneousInterpretation = WebexPlugin.extend({
    */
   initialize() {
     this.listenTo(this, 'change:shouldQuerySupportLanguages', () => {
-      if (this.canManageInterpreters && !this.supportLanguages) {
+      if (this.shouldQuerySupportLanguages && !this.supportLanguages) {
         this.querySupportLanguages();
       }
     });

package/src/locus-info/controlsUtils.ts

@@ -206,8 +206,8 @@ ControlsUtils.getControls = (oldControls: any, newControls: any) => {
         ),
 
       hasPracticeSessionEnabledChanged: !isEqual(
-        previous?.practiceSession?.enabled,
-        current?.practiceSession?.enabled
+        !!previous?.practiceSession?.enabled,
+        !!current?.practiceSession?.enabled
       ),
 
       hasStageViewChanged: !isEqual(previous?.videoLayout, current?.videoLayout),

package/src/media/index.ts

@@ -21,6 +21,7 @@ import {MEDIA_TRACK_CONSTRAINT} from '../constants';
 import Config from '../config';
 import StaticConfig from '../common/config';
 import BrowserDetection from '../common/browser-detection';
+import {TurnServerInfo} from '../roap/types';
 
 const {isBrowser} = BrowserDetection();
 
@@ -138,11 +139,7 @@ Media.createMediaConnection = (
     remoteQualityLevel?: 'LOW' | 'MEDIUM' | 'HIGH';
     enableRtx?: boolean;
     enableExtmap?: boolean;
-    turnServerInfo?: {
-      url: string;
-      username: string;
-      password: string;
-    };
+    turnServerInfo?: TurnServerInfo;
     bundlePolicy?: BundlePolicy;
     iceCandidatesTimeout?: number;
   }
@@ -160,24 +157,11 @@ Media.createMediaConnection = (
 
   const iceServers = [];
 
-  // we might not have any TURN server if TURN discovery failed or wasn't done or
-  // we might get an empty TURN url if we land on a video mesh node
-  if (turnServerInfo?.url) {
-    if (!isBrowser('firefox')) {
-      let bareTurnServer = turnServerInfo.url;
-      bareTurnServer = bareTurnServer.replace('turns:', 'turn:');
-      bareTurnServer = bareTurnServer.replace('443', '5004');
-
-      iceServers.push({
-        urls: bareTurnServer,
-        username: turnServerInfo.username || '',
-        credential: turnServerInfo.password || '',
-      });
-    }
-
+  // we might not have any TURN server if TURN discovery failed or wasn't done or we land on a video mesh node
+  if (turnServerInfo?.urls.length > 0) {
     // TURN-TLS server
     iceServers.push({
-      urls: turnServerInfo.url,
+      urls: turnServerInfo.urls,
       username: turnServerInfo.username || '',
       credential: turnServerInfo.password || '',
     });

package/src/meeting/index.ts

@@ -60,11 +60,8 @@ import {
 import LoggerProxy from '../common/logs/logger-proxy';
 import EventsUtil from '../common/events/util';
 import Trigger from '../common/events/trigger-proxy';
-import Roap, {
-  type TurnDiscoveryResult,
-  type TurnServerInfo,
-  type TurnDiscoverySkipReason,
-} from '../roap/index';
+import Roap, {type TurnDiscoveryResult, type TurnDiscoverySkipReason} from '../roap/index';
+import {type TurnServerInfo} from '../roap/types';
 import Media, {type BundlePolicy} from '../media';
 import MediaProperties from '../media/properties';
 import MeetingStateMachine from './state';
@@ -241,6 +238,8 @@ export type CallStateForMetrics = {
   sessionCorrelationId?: string;
   joinTrigger?: string;
   loginType?: string;
+  userNameInput?: string;
+  emailInput?: string;
 };
 
 export const MEDIA_UPDATE_TYPE = {
@@ -1627,6 +1626,38 @@ export default class Meeting extends StatelessWebexPlugin {
     this.callStateForMetrics.correlationId = correlationId;
   }
 
+  /**
+   * Getter - Returns callStateForMetrics.userNameInput
+   * @returns {string}
+   */
+  get userNameInput() {
+    return this.callStateForMetrics?.userNameInput;
+  }
+
+  /**
+   * Setter - sets callStateForMetrics.userNameInput
+   * @param {string} userNameInput
+   */
+  set userNameInput(userNameInput: string) {
+    this.callStateForMetrics.userNameInput = userNameInput;
+  }
+
+  /**
+   * Getter - Returns callStateForMetrics.emailInput
+   * @returns {string}
+   */
+  get emailInput() {
+    return this.callStateForMetrics?.emailInput;
+  }
+
+  /**
+   * Setter - sets callStateForMetrics.emailInput
+   * @param {string} emailInput
+   */
+  set emailInput(emailInput: string) {
+    this.callStateForMetrics.emailInput = emailInput;
+  }
+
   /**
    * Getter - Returns callStateForMetrics.sessionCorrelationId
    * @returns {string}
@@ -1652,6 +1683,33 @@ export default class Meeting extends StatelessWebexPlugin {
     return this.#isoLocalClientMeetingJoinTime;
   }
 
+  /**
+   * Setter - sets isoLocalClientMeetingJoinTime
+   * This will be set once on meeting join, and not updated again
+   * this will always produce an ISO string
+   * If the iso string is invalid, it will fallback to the current system time
+   * @param {string | undefined} time
+   */
+  set isoLocalClientMeetingJoinTime(time: string | undefined) {
+    const fallback = new Date().toISOString();
+    if (!time) {
+      this.#isoLocalClientMeetingJoinTime = fallback;
+    } else {
+      const date = new Date(time);
+
+      // Check if the date is valid
+      if (Number.isNaN(date.getTime())) {
+        LoggerProxy.logger.info(
+          // @ts-ignore
+          `Meeting:index#isoLocalClientMeetingJoinTime --> Invalid date provided: ${time}. Falling back to system clock.`
+        );
+        this.#isoLocalClientMeetingJoinTime = fallback;
+      } else {
+        this.#isoLocalClientMeetingJoinTime = date.toISOString();
+      }
+    }
+  }
+
   /**
    * Set meeting info and trigger `MEETING_INFO_AVAILABLE` event
    * @param {any} info
@@ -5684,8 +5742,6 @@ export default class Meeting extends StatelessWebexPlugin {
         // @ts-ignore
         this.webex.internal.device.meetingStarted();
 
-        this.#isoLocalClientMeetingJoinTime = new Date().toISOString();
-
         LoggerProxy.logger.log('Meeting:index#join --> Success');
 
         Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.JOIN_SUCCESS, {
@@ -6146,10 +6202,7 @@ export default class Meeting extends StatelessWebexPlugin {
         },
         options: {meetingId: this.id, rawError: error},
       });
-    } else if (
-      error instanceof Errors.SdpOfferHandlingError ||
-      error instanceof Errors.SdpAnswerHandlingError
-    ) {
+    } else if (error instanceof Errors.SdpOfferHandlingError) {
       sendBehavioralMetric(BEHAVIORAL_METRICS.PEERCONNECTION_FAILURE, error, this.correlationId);
 
       // @ts-ignore
@@ -6160,6 +6213,24 @@ export default class Meeting extends StatelessWebexPlugin {
         },
         options: {meetingId: this.id, rawError: error},
       });
+    } else if (error instanceof Errors.SdpAnswerHandlingError) {
+      sendBehavioralMetric(BEHAVIORAL_METRICS.PEERCONNECTION_FAILURE, error, this.correlationId);
+
+      // @ts-ignore
+      this.webex.internal.newMetrics.submitClientEvent({
+        name: 'client.media-engine.remote-sdp-received',
+        payload: {
+          canProceed: false,
+        },
+        options: {meetingId: this.id, rawError: error},
+      });
+
+      if (this.deferSDPAnswer) {
+        clearTimeout(this.sdpResponseTimer);
+        this.sdpResponseTimer = undefined;
+
+        this.deferSDPAnswer.reject();
+      }
     } else if (error instanceof Errors.SdpError) {
       // this covers also the case of Errors.IceGatheringError which extends Errors.SdpError
       sendBehavioralMetric(BEHAVIORAL_METRICS.INVALID_ICE_CANDIDATE, error, this.correlationId);
@@ -6796,7 +6867,10 @@ export default class Meeting extends StatelessWebexPlugin {
    * @param {AddMediaOptions} [options] Options for enabling/disabling audio/video
    * @returns {RoapMediaConnection | MultistreamRoapMediaConnection}
    */
-  private async createMediaConnection(turnServerInfo, bundlePolicy?: BundlePolicy) {
+  private async createMediaConnection(
+    turnServerInfo?: TurnServerInfo,
+    bundlePolicy?: BundlePolicy
+  ) {
     this.rtcMetrics = this.isMultistream
       ? // @ts-ignore
         new RtcMetrics(this.webex, {meetingId: this.id}, this.correlationId)
@@ -8681,6 +8755,9 @@ export default class Meeting extends StatelessWebexPlugin {
     LoggerProxy.logger.log(
       `Meeting:index#handleShareVideoStreamMuteStateChange --> Share video stream mute state changed to muted ${muted}`
     );
+
+    const shareVideoStreamSettings = this.mediaProperties?.shareVideoStream?.getSettings();
+
     Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.MEETING_SHARE_VIDEO_MUTE_STATE_CHANGE, {
       correlationId: this.correlationId,
       muted,
@@ -8689,8 +8766,9 @@ export default class Meeting extends StatelessWebexPlugin {
       // SDK to TypeScript 5, which may affect other packages, use bracket notation for now, since
       // all we're doing here is adding metrics.
       // eslint-disable-next-line dot-notation
-      displaySurface: this.mediaProperties?.shareVideoStream?.getSettings()['displaySurface'],
+      displaySurface: shareVideoStreamSettings?.['displaySurface'],
       isMultistream: this.isMultistream,
+      frameRate: shareVideoStreamSettings?.frameRate,
     });
   };
 

package/src/meeting/locusMediaRequest.ts

@@ -1,6 +1,7 @@
 /* eslint-disable valid-jsdoc */
 import {defer} from 'lodash';
-import {Defer} from '@webex/common';
+import {Defer, transferEvents} from '@webex/common';
+import {EventEmitter} from 'events';
 import {WebexPlugin} from '@webex/webex-core';
 import {MEDIA, HTTP_VERBS, ROAP} from '../constants';
 import LoggerProxy from '../common/logs/logger-proxy';
@@ -250,12 +251,19 @@ export class LocusMediaRequest extends WebexPlugin {
       this.confluenceState = 'creation in progress';
     }
 
-    // @ts-ignore
-    return this.request({
+    const upload = new EventEmitter();
+    const download = new EventEmitter();
+
+    const options = {
       method: HTTP_VERBS.PUT,
       uri,
       body,
-    })
+      upload,
+      download,
+    };
+
+    // @ts-ignore
+    const promise = this.request(options)
       .then((result) => {
         if (isRequestAffectingConfluenceState(request)) {
           this.confluenceState = 'created';
@@ -294,6 +302,21 @@ export class LocusMediaRequest extends WebexPlugin {
 
         throw e;
       });
+
+    if (request.type === 'RoapMessage') {
+      const setupProgressListener = (direction: string, eventEmitter: EventEmitter) => {
+        eventEmitter.on('progress', (progressEvent: ProgressEvent) => {
+          LoggerProxy.logger.info(
+            `${request.type}: ${direction} Progress, Timestamp: ${progressEvent.timeStamp}, Progress: ${progressEvent.loaded}/${progressEvent.total}`
+          );
+        });
+      };
+
+      setupProgressListener('Upload', options.upload);
+      setupProgressListener('Download', options.download);
+    }
+
+    return promise;
   }
 
   /**

package/src/meeting/util.ts

@@ -176,11 +176,12 @@ const MeetingUtil = {
         deviceCapabilities: options.deviceCapabilities,
         liveAnnotationSupported: options.liveAnnotationSupported,
         clientMediaPreferences,
+        alias: options.alias,
       })
       .then((res) => {
         const parsed = MeetingUtil.parseLocusJoin(res);
         meeting.setLocus(parsed);
-
+        meeting.isoLocalClientMeetingJoinTime = res?.headers?.date; // read from header if exist, else fall back to system clock : https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-555657
         webex.internal.newMetrics.submitClientEvent({
           name: 'client.locus.join.response',
           payload: {