@webex/plugin-meetings 3.8.0-next.2 → 3.8.0-next.20

package/dist/types/reachability/reachability.types.d.ts

@@ -4,6 +4,10 @@ export type TransportResult = {
     latencyInMilliseconds?: number;
     clientMediaIPs?: string[];
 };
+export declare enum NatType {
+    Unknown = "unknown",
+    SymmetricNat = "symmetric-nat"
+}
 export type ClusterReachabilityResult = {
     udp: TransportResult;
     tcp: TransportResult;
@@ -22,6 +26,7 @@ export type ReachabilityMetrics = {
     reachability_vmn_tcp_failed: number;
     reachability_vmn_xtls_success: number;
     reachability_vmn_xtls_failed: number;
+    natType: NatType;
 };
 /**
  * This is the type that matches what backend expects us to send to them. It is a bit weird, because

package/dist/webinar/index.js

@@ -458,7 +458,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       }, _callee7);
     }))();
   },
-  version: "3.8.0-next.2"
+  version: "3.8.0-next.20"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,13 +43,13 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.8.0-next.2",
-    "@webex/plugin-rooms": "3.7.0-next.25",
-    "@webex/test-helper-chai": "3.7.0-next.18",
-    "@webex/test-helper-mocha": "3.7.0-next.18",
-    "@webex/test-helper-mock-webex": "3.7.0-next.18",
-    "@webex/test-helper-retry": "3.7.0-next.18",
-    "@webex/test-helper-test-users": "3.7.0-next.18",
+    "@webex/plugin-meetings": "3.8.0-next.20",
+    "@webex/plugin-rooms": "3.8.0-next.10",
+    "@webex/test-helper-chai": "3.8.0-next.9",
+    "@webex/test-helper-mocha": "3.8.0-next.9",
+    "@webex/test-helper-mock-webex": "3.8.0-next.9",
+    "@webex/test-helper-retry": "3.8.0-next.9",
+    "@webex/test-helper-test-users": "3.8.0-next.9",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.24.0",
@@ -61,22 +61,22 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.7.0-next.18",
+    "@webex/common": "3.8.0-next.9",
     "@webex/event-dictionary-ts": "^1.0.1688",
-    "@webex/internal-media-core": "2.14.4",
-    "@webex/internal-plugin-conversation": "3.7.0-next.25",
-    "@webex/internal-plugin-device": "3.7.0-next.18",
-    "@webex/internal-plugin-llm": "3.8.0-next.1",
-    "@webex/internal-plugin-mercury": "3.7.0-next.23",
-    "@webex/internal-plugin-metrics": "3.7.0-next.18",
-    "@webex/internal-plugin-support": "3.7.0-next.26",
-    "@webex/internal-plugin-user": "3.7.0-next.18",
-    "@webex/internal-plugin-voicea": "3.8.0-next.2",
-    "@webex/media-helpers": "3.7.0-next.25",
-    "@webex/plugin-people": "3.7.0-next.23",
-    "@webex/plugin-rooms": "3.7.0-next.25",
+    "@webex/internal-media-core": "2.14.6",
+    "@webex/internal-plugin-conversation": "3.8.0-next.10",
+    "@webex/internal-plugin-device": "3.8.0-next.9",
+    "@webex/internal-plugin-llm": "3.8.0-next.11",
+    "@webex/internal-plugin-mercury": "3.8.0-next.10",
+    "@webex/internal-plugin-metrics": "3.8.0-next.9",
+    "@webex/internal-plugin-support": "3.8.0-next.10",
+    "@webex/internal-plugin-user": "3.8.0-next.9",
+    "@webex/internal-plugin-voicea": "3.8.0-next.20",
+    "@webex/media-helpers": "3.8.0-next.10",
+    "@webex/plugin-people": "3.8.0-next.10",
+    "@webex/plugin-rooms": "3.8.0-next.10",
     "@webex/web-capabilities": "^1.4.0",
-    "@webex/webex-core": "3.7.0-next.18",
+    "@webex/webex-core": "3.8.0-next.9",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",
@@ -92,5 +92,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.8.0-next.2"
+  "version": "3.8.0-next.20"
 }

package/src/config.ts

@@ -95,6 +95,7 @@ export default {
     // This only applies to non-multistream meetings
     iceCandidatesGatheringTimeout: undefined,
     backendIpv6NativeSupport: false,
+    enableReachabilityChecks: true,
     reachabilityGetClusterTimeout: 5000,
     logUploadIntervalMultiplicationFactor: 0, // if set to 0 or undefined, logs won't be uploaded periodically, if you want periodic logs, recommended value is 1
   },

package/src/constants.ts

@@ -904,6 +904,7 @@ export enum SELF_POLICY {
   ENFORCE_VIRTUAL_BACKGROUND = 'enforceVirtualBackground',
   SUPPORT_LOCAL_RECORD = 'supportLocalRecord',
   SUPPORT_NETWORK_BASED_RECORD = 'supportNetworkBasedRecord',
+  SUPPORT_PREMISE_RECORD = 'supportPremiseRecord',
   SUPPORT_REALTIME_CLOSE_CAPTION = 'supportRealtimeCloseCaption',
   SUPPORT_CHAT = 'supportChat',
   SUPPORT_DESKTOP_SHARE_REMOTE = 'supportDesktopShareRemote',

package/src/interpretation/index.ts

@@ -35,13 +35,13 @@ const SimultaneousInterpretation = WebexPlugin.extend({
   derived: {
     shouldQuerySupportLanguages: {
       cache: false,
-      deps: ['canManageInterpreters', 'hostSIEnabled'],
+      deps: ['canManageInterpreters', 'hostSIEnabled', 'locusUrl'],
       /**
        * Returns should query support languages or not
        * @returns {boolean}
        */
       fn() {
-        return !!(this.canManageInterpreters && this.hostSIEnabled);
+        return !!(this.canManageInterpreters && this.hostSIEnabled && this.locusUrl);
       },
     },
   },
@@ -51,7 +51,7 @@ const SimultaneousInterpretation = WebexPlugin.extend({
    */
   initialize() {
     this.listenTo(this, 'change:shouldQuerySupportLanguages', () => {
-      if (this.canManageInterpreters && !this.supportLanguages) {
+      if (this.shouldQuerySupportLanguages && !this.supportLanguages) {
         this.querySupportLanguages();
       }
     });

package/src/locus-info/controlsUtils.ts

@@ -206,8 +206,8 @@ ControlsUtils.getControls = (oldControls: any, newControls: any) => {
         ),
 
       hasPracticeSessionEnabledChanged: !isEqual(
-        previous?.practiceSession?.enabled,
-        current?.practiceSession?.enabled
+        !!previous?.practiceSession?.enabled,
+        !!current?.practiceSession?.enabled
       ),
 
       hasStageViewChanged: !isEqual(previous?.videoLayout, current?.videoLayout),

package/src/meeting/index.ts

@@ -241,6 +241,8 @@ export type CallStateForMetrics = {
   sessionCorrelationId?: string;
   joinTrigger?: string;
   loginType?: string;
+  userNameInput?: string;
+  emailInput?: string;
 };
 
 export const MEDIA_UPDATE_TYPE = {
@@ -1627,6 +1629,38 @@ export default class Meeting extends StatelessWebexPlugin {
     this.callStateForMetrics.correlationId = correlationId;
   }
 
+  /**
+   * Getter - Returns callStateForMetrics.userNameInput
+   * @returns {string}
+   */
+  get userNameInput() {
+    return this.callStateForMetrics?.userNameInput;
+  }
+
+  /**
+   * Setter - sets callStateForMetrics.userNameInput
+   * @param {string} userNameInput
+   */
+  set userNameInput(userNameInput: string) {
+    this.callStateForMetrics.userNameInput = userNameInput;
+  }
+
+  /**
+   * Getter - Returns callStateForMetrics.emailInput
+   * @returns {string}
+   */
+  get emailInput() {
+    return this.callStateForMetrics?.emailInput;
+  }
+
+  /**
+   * Setter - sets callStateForMetrics.emailInput
+   * @param {string} emailInput
+   */
+  set emailInput(emailInput: string) {
+    this.callStateForMetrics.emailInput = emailInput;
+  }
+
   /**
    * Getter - Returns callStateForMetrics.sessionCorrelationId
    * @returns {string}
@@ -8681,6 +8715,9 @@ export default class Meeting extends StatelessWebexPlugin {
     LoggerProxy.logger.log(
       `Meeting:index#handleShareVideoStreamMuteStateChange --> Share video stream mute state changed to muted ${muted}`
     );
+
+    const shareVideoStreamSettings = this.mediaProperties?.shareVideoStream?.getSettings();
+
     Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.MEETING_SHARE_VIDEO_MUTE_STATE_CHANGE, {
       correlationId: this.correlationId,
       muted,
@@ -8689,8 +8726,9 @@ export default class Meeting extends StatelessWebexPlugin {
       // SDK to TypeScript 5, which may affect other packages, use bracket notation for now, since
       // all we're doing here is adding metrics.
       // eslint-disable-next-line dot-notation
-      displaySurface: this.mediaProperties?.shareVideoStream?.getSettings()['displaySurface'],
+      displaySurface: shareVideoStreamSettings?.['displaySurface'],
       isMultistream: this.isMultistream,
+      frameRate: shareVideoStreamSettings?.frameRate,
     });
   };
 

package/src/meeting/locusMediaRequest.ts

@@ -1,6 +1,7 @@
 /* eslint-disable valid-jsdoc */
 import {defer} from 'lodash';
-import {Defer} from '@webex/common';
+import {Defer, transferEvents} from '@webex/common';
+import {EventEmitter} from 'events';
 import {WebexPlugin} from '@webex/webex-core';
 import {MEDIA, HTTP_VERBS, ROAP} from '../constants';
 import LoggerProxy from '../common/logs/logger-proxy';
@@ -250,12 +251,19 @@ export class LocusMediaRequest extends WebexPlugin {
       this.confluenceState = 'creation in progress';
     }
 
-    // @ts-ignore
-    return this.request({
+    const upload = new EventEmitter();
+    const download = new EventEmitter();
+
+    const options = {
       method: HTTP_VERBS.PUT,
       uri,
       body,
-    })
+      upload,
+      download,
+    };
+
+    // @ts-ignore
+    const promise = this.request(options)
       .then((result) => {
         if (isRequestAffectingConfluenceState(request)) {
           this.confluenceState = 'created';
@@ -294,6 +302,21 @@ export class LocusMediaRequest extends WebexPlugin {
 
         throw e;
       });
+
+    if (request.type === 'RoapMessage') {
+      const setupProgressListener = (direction: string, eventEmitter: EventEmitter) => {
+        eventEmitter.on('progress', (progressEvent: ProgressEvent) => {
+          LoggerProxy.logger.info(
+            `${request.type}: ${direction} Progress, Timestamp: ${progressEvent.timeStamp}, Progress: ${progressEvent.loaded}/${progressEvent.total}`
+          );
+        });
+      };
+
+      setupProgressListener('Upload', options.upload);
+      setupProgressListener('Download', options.download);
+    }
+
+    return promise;
   }
 
   /**

package/src/meetings/index.ts

@@ -854,7 +854,7 @@ export default class Meetings extends WebexPlugin {
       this.executeRegistrationStep(
         () =>
           this.startReachability('registration').catch((error) => {
-            LoggerProxy.logger.error(`Meetings:index#register --> GDM error, ${error.message}`);
+            LoggerProxy.logger.warn(`Meetings:index#register --> startReachability failed:`, error);
           }),
         'startReachability'
       ),

package/src/multistream/remoteMediaManager.ts

@@ -1054,22 +1054,44 @@ export class RemoteMediaManager extends EventsScope {
     );
   }
 
+  /**
+   * Set multiple remote video CSIs at once
+   * @param remoteMediaCsis The remote medias and CSIs to set them to
+   * @returns {void}
+   */
+  public setRemoteVideoCsis(remoteMediaCsis: {remoteMedia: RemoteMedia; csi?: CSI | null}[]) {
+    if (!remoteMediaCsis.length) {
+      return;
+    }
+
+    // Check all remote medias are known
+    remoteMediaCsis.forEach(({remoteMedia}) => {
+      if (!Object.values(this.media.video.memberPanes).includes(remoteMedia)) {
+        throw new Error(`remoteMedia ${remoteMedia.id} not found`);
+      }
+    });
+
+    // Set remote video CSIs
+    remoteMediaCsis.forEach(({remoteMedia, csi}) => {
+      if (csi) {
+        remoteMedia.sendMediaRequest(csi, false);
+      } else {
+        remoteMedia.cancelMediaRequest(false);
+      }
+    });
+
+    // Commit the changes
+    this.mediaRequestManagers.video.commit();
+  }
+
   /**
    * Sets a new CSI on a given remote media object
    *
    * @param {RemoteMedia} remoteMedia remote Media object to modify
    * @param {CSI} csi new CSI value, can be null if we want to stop receiving media
    */
-  public setRemoteVideoCsi(remoteMedia: RemoteMedia, csi: CSI | null) {
-    if (!Object.values(this.media.video.memberPanes).includes(remoteMedia)) {
-      throw new Error('remoteMedia not found');
-    }
-
-    if (csi) {
-      remoteMedia.sendMediaRequest(csi, true);
-    } else {
-      remoteMedia.cancelMediaRequest(true);
-    }
+  public setRemoteVideoCsi(remoteMedia: RemoteMedia, csi?: CSI | null) {
+    this.setRemoteVideoCsis([{remoteMedia, csi}]);
   }
 
   /**

package/src/reachability/clusterReachability.ts

@@ -6,7 +6,7 @@ import {convertStunUrlToTurn, convertStunUrlToTurnTls} from './util';
 import EventsScope from '../common/events/events-scope';
 
 import {CONNECTION_STATE, Enum, ICE_GATHERING_STATE} from '../constants';
-import {ClusterReachabilityResult} from './reachability.types';
+import {ClusterReachabilityResult, NatType} from './reachability.types';
 
 // data for the Events.resultReady event
 export type ResultEventData = {
@@ -22,9 +22,14 @@ export type ClientMediaIpsUpdatedEventData = {
   clientMediaIPs: string[];
 };
 
+export type NatTypeUpdatedEventData = {
+  natType: NatType;
+};
+
 export const Events = {
   resultReady: 'resultReady', // emitted when a cluster is reached successfully using specific protocol
   clientMediaIpsUpdated: 'clientMediaIpsUpdated', // emitted when more public IPs are found after resultReady was already sent for a given protocol
+  natTypeUpdated: 'natTypeUpdated', // emitted when NAT type is determined
 } as const;
 
 export type Events = Enum<typeof Events>;
@@ -41,6 +46,7 @@ export class ClusterReachability extends EventsScope {
   private pc?: RTCPeerConnection;
   private defer: Defer; // this defer is resolved once reachability checks for this cluster are completed
   private startTimestamp: number;
+  private srflxIceCandidates: RTCIceCandidate[] = [];
   public readonly isVideoMesh: boolean;
   public readonly name;
 
@@ -290,6 +296,44 @@ export class ClusterReachability extends EventsScope {
     }
   }
 
+  /**
+   * Determines NAT Type.
+   *
+   * @param {RTCIceCandidate} candidate
+   * @returns {void}
+   */
+  private determineNatType(candidate: RTCIceCandidate) {
+    this.srflxIceCandidates.push(candidate);
+
+    if (this.srflxIceCandidates.length > 1) {
+      const portsFound: Record<string, Set<number>> = {};
+
+      this.srflxIceCandidates.forEach((c) => {
+        const key = `${c.address}:${c.relatedPort}`;
+        if (!portsFound[key]) {
+          portsFound[key] = new Set();
+        }
+        portsFound[key].add(c.port);
+      });
+
+      Object.entries(portsFound).forEach(([, ports]) => {
+        if (ports.size > 1) {
+          // Found candidates with the same address and relatedPort, but different ports
+          this.emit(
+            {
+              file: 'clusterReachability',
+              function: 'determineNatType',
+            },
+            Events.natTypeUpdated,
+            {
+              natType: NatType.SymmetricNat,
+            }
+          );
+        }
+      });
+    }
+  }
+
   /**
    * Registers a listener for the icecandidate event
    *
@@ -308,6 +352,8 @@ export class ClusterReachability extends EventsScope {
       if (e.candidate) {
         if (e.candidate.type === CANDIDATE_TYPES.SERVER_REFLEXIVE) {
           this.saveResult('udp', latencyInMilliseconds, e.candidate.address);
+
+          this.determineNatType(e.candidate);
         }
 
         if (e.candidate.type === CANDIDATE_TYPES.RELAY) {

package/src/reachability/index.ts

@@ -23,11 +23,13 @@ import {
   ReachabilityResultsForBackend,
   TransportResultForBackend,
   GetClustersTrigger,
+  NatType,
 } from './reachability.types';
 import {
   ClientMediaIpsUpdatedEventData,
   ClusterReachability,
   Events,
+  NatTypeUpdatedEventData,
   ResultEventData,
 } from './clusterReachability';
 import EventsScope from '../common/events/events-scope';
@@ -64,6 +66,7 @@ export default class Reachability extends EventsScope {
   resultsCount = {videoMesh: {udp: 0}, public: {udp: 0, tcp: 0, xtls: 0}};
   startTime = undefined;
   totalDuration = undefined;
+  natType = NatType.Unknown;
 
   protected lastTrigger?: string;
 
@@ -143,6 +146,10 @@ export default class Reachability extends EventsScope {
    * @memberof Reachability
    */
   public async gatherReachability(trigger: string): Promise<ReachabilityResults> {
+    // @ts-ignore
+    if (!this.webex.config.meetings.enableReachabilityChecks) {
+      throw new Error('enableReachabilityChecks is disabled in config');
+    }
     // Fetch clusters and measure latency
     try {
       this.lastTrigger = trigger;
@@ -305,6 +312,7 @@ export default class Reachability extends EventsScope {
       reachability_vmn_tcp_failed: 0,
       reachability_vmn_xtls_success: 0,
       reachability_vmn_xtls_failed: 0,
+      natType: this.natType,
     };
 
     const updateStats = (clusterType: 'public' | 'vmn', result: ClusterReachabilityResult) => {
@@ -963,6 +971,13 @@ export default class Reachability extends EventsScope {
         }
       );
 
+      this.clusterReachability[key].on(
+        Events.natTypeUpdated,
+        async (data: NatTypeUpdatedEventData) => {
+          this.natType = data.natType;
+        }
+      );
+
       this.clusterReachability[key].start(); // not awaiting on purpose
     });
   }

package/src/reachability/reachability.types.ts

@@ -7,6 +7,11 @@ export type TransportResult = {
   clientMediaIPs?: string[];
 };
 
+export enum NatType {
+  Unknown = 'unknown',
+  SymmetricNat = 'symmetric-nat',
+}
+
 // reachability result for a specific media cluster
 export type ClusterReachabilityResult = {
   udp: TransportResult;
@@ -27,6 +32,7 @@ export type ReachabilityMetrics = {
   reachability_vmn_tcp_failed: number;
   reachability_vmn_xtls_success: number;
   reachability_vmn_xtls_failed: number;
+  natType: NatType;
 };
 
 /**

package/src/recording-controller/util.ts

@@ -6,33 +6,37 @@ const canUserStart = (
   displayHints: Array<string>,
   userPolicies: Record<SELF_POLICY, boolean>
 ): boolean =>
-  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_START) ||
-    displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_START)) &&
-  MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies);
+  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_START) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies)) ||
+  (displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_START) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_PREMISE_RECORD, userPolicies));
 
 const canUserPause = (
   displayHints: Array<string>,
   userPolicies: Record<SELF_POLICY, boolean>
 ): boolean =>
-  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_PAUSE) ||
-    displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_PAUSE)) &&
-  MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies);
+  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_PAUSE) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies)) ||
+  (displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_PAUSE) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_PREMISE_RECORD, userPolicies));
 
 const canUserResume = (
   displayHints: Array<string>,
   userPolicies: Record<SELF_POLICY, boolean>
 ): boolean =>
-  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_RESUME) ||
-    displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_RESUME)) &&
-  MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies);
+  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_RESUME) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies)) ||
+  (displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_RESUME) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_PREMISE_RECORD, userPolicies));
 
 const canUserStop = (
   displayHints: Array<string>,
   userPolicies: Record<SELF_POLICY, boolean>
 ): boolean =>
-  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_STOP) ||
-    displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_STOP)) &&
-  MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies);
+  (displayHints.includes(DISPLAY_HINTS.RECORDING_CONTROL_STOP) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies)) ||
+  (displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_STOP) &&
+    MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_PREMISE_RECORD, userPolicies));
 
 const isPremiseRecordingEnabled = (
   displayHints: Array<string>,
@@ -42,7 +46,7 @@ const isPremiseRecordingEnabled = (
     displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_PAUSE) ||
     displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_STOP) ||
     displayHints.includes(DISPLAY_HINTS.PREMISE_RECORDING_CONTROL_RESUME)) &&
-  MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_NETWORK_BASED_RECORD, userPolicies);
+  MeetingUtil.selfSupportsFeature(SELF_POLICY.SUPPORT_PREMISE_RECORD, userPolicies);
 
 const extractLocusId = (url: string) => {
   return url?.split('/').pop();

package/test/unit/spec/interpretation/index.ts

@@ -22,16 +22,54 @@ describe('plugin-meetings', () => {
     });
 
     describe('#initialize', () => {
+      beforeEach(() => {
+        interpretation.querySupportLanguages = sinon.stub();
+        interpretation.set({
+          canManageInterpreters: undefined,
+          hostSIEnabled: undefined,
+          locusUrl: undefined
+        });
+      });
+
+      afterEach(() => {
+        interpretation.querySupportLanguages.reset();
+      });
+
       it('creates SimultaneousInterpretation as expected', () => {
         assert.equal(interpretation.namespace, 'Meetings');
       });
       it('call querySupportLanguages correctly when meet the conditions', () => {
-        interpretation.querySupportLanguages = sinon.stub();
         interpretation.set({
           canManageInterpreters: true,
+          hostSIEnabled: true,
+          locusUrl: "MOCK_LOCUS_URL"
         });
         assert.called(interpretation.querySupportLanguages);
       });
+
+      it('does not call querySupportLanguages when canManageInterpreters is not set', () => {
+        interpretation.set({
+          hostSIEnabled: true,
+          locusUrl: "MOCK_LOCUS_URL"
+        });
+        assert.notCalled(interpretation.querySupportLanguages);
+      });
+
+      it('does not call querySupportLanguages when hostSIEnabled is not set', () => {
+        interpretation.set({
+          canManageInterpreters: true,
+          locusUrl: "MOCK_LOCUS_URL"
+        });
+        assert.notCalled(interpretation.querySupportLanguages);
+      });
+
+      it('does not call querySupportLanguages when locusUrl is not set', () => {
+        interpretation.set({
+          canManageInterpreters: true,
+          hostSIEnabled: true,
+        });
+        assert.notCalled(interpretation.querySupportLanguages);
+      });
     });
 
     describe('#cleanUp', () => {

package/test/unit/spec/locus-info/controlsUtils.js

@@ -269,6 +269,14 @@ describe('plugin-meetings', () => {
         assert.equal(updates.hasPracticeSessionEnabledChanged, true);
       });
 
+      it('returns hasPracticeSessionEnabledChanged = false when enabled is false and previous state is false', () => {
+        const newControls = {practiceSession: {enabled: false}};
+
+        const {updates} = ControlsUtils.getControls(defaultControls, newControls);
+
+        assert.equal(updates.hasPracticeSessionEnabledChanged, false);
+      });
+
       it('returns hasEntryExitToneChanged = true when mode changed', () => {
         const newControls = {
           entryExitTone: {