@webex/plugin-meetings 3.7.0-next.55 → 3.7.0-next.57

package/dist/webinar/index.js

@@ -458,7 +458,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       }, _callee7);
     }))();
   },
-  version: "3.7.0-next.55"
+  version: "3.7.0-next.57"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,13 +43,13 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.7.0-next.55",
-    "@webex/plugin-rooms": "3.7.0-next.21",
-    "@webex/test-helper-chai": "3.7.0-next.15",
-    "@webex/test-helper-mocha": "3.7.0-next.15",
-    "@webex/test-helper-mock-webex": "3.7.0-next.15",
-    "@webex/test-helper-retry": "3.7.0-next.15",
-    "@webex/test-helper-test-users": "3.7.0-next.15",
+    "@webex/plugin-meetings": "3.7.0-next.57",
+    "@webex/plugin-rooms": "3.7.0-next.22",
+    "@webex/test-helper-chai": "3.7.0-next.16",
+    "@webex/test-helper-mocha": "3.7.0-next.16",
+    "@webex/test-helper-mock-webex": "3.7.0-next.16",
+    "@webex/test-helper-retry": "3.7.0-next.16",
+    "@webex/test-helper-test-users": "3.7.0-next.16",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.24.0",
@@ -61,22 +61,22 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.7.0-next.15",
+    "@webex/common": "3.7.0-next.16",
     "@webex/event-dictionary-ts": "^1.0.1643",
     "@webex/internal-media-core": "2.14.3",
-    "@webex/internal-plugin-conversation": "3.7.0-next.21",
-    "@webex/internal-plugin-device": "3.7.0-next.15",
-    "@webex/internal-plugin-llm": "3.7.0-next.19",
-    "@webex/internal-plugin-mercury": "3.7.0-next.19",
-    "@webex/internal-plugin-metrics": "3.7.0-next.15",
-    "@webex/internal-plugin-support": "3.7.0-next.22",
-    "@webex/internal-plugin-user": "3.7.0-next.15",
-    "@webex/internal-plugin-voicea": "3.7.0-next.55",
-    "@webex/media-helpers": "3.7.0-next.21",
-    "@webex/plugin-people": "3.7.0-next.19",
-    "@webex/plugin-rooms": "3.7.0-next.21",
+    "@webex/internal-plugin-conversation": "3.7.0-next.22",
+    "@webex/internal-plugin-device": "3.7.0-next.16",
+    "@webex/internal-plugin-llm": "3.7.0-next.20",
+    "@webex/internal-plugin-mercury": "3.7.0-next.20",
+    "@webex/internal-plugin-metrics": "3.7.0-next.16",
+    "@webex/internal-plugin-support": "3.7.0-next.23",
+    "@webex/internal-plugin-user": "3.7.0-next.16",
+    "@webex/internal-plugin-voicea": "3.7.0-next.57",
+    "@webex/media-helpers": "3.7.0-next.22",
+    "@webex/plugin-people": "3.7.0-next.20",
+    "@webex/plugin-rooms": "3.7.0-next.22",
     "@webex/web-capabilities": "^1.4.0",
-    "@webex/webex-core": "3.7.0-next.15",
+    "@webex/webex-core": "3.7.0-next.16",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",
@@ -92,5 +92,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.7.0-next.55"
+  "version": "3.7.0-next.57"
 }

package/src/meeting/index.ts

@@ -6099,9 +6099,12 @@ export default class Meeting extends StatelessWebexPlugin {
    * @returns {undefined}
    */
   public roapMessageReceived = (roapMessage: RoapMessage) => {
-    const mediaServer = MeetingsUtil.getMediaServer(roapMessage.sdp);
+    const mediaServer =
+      roapMessage.messageType === 'ANSWER'
+        ? MeetingsUtil.getMediaServer(roapMessage.sdp)
+        : undefined;
 
-    if (this.isMultistream && mediaServer !== 'homer') {
+    if (this.isMultistream && mediaServer && mediaServer !== 'homer') {
       throw new MultistreamNotSupportedError(
         `Client asked for multistream backend (Homer), but got ${mediaServer} instead`
       );

package/test/unit/spec/meeting/index.js

@@ -13260,7 +13260,7 @@ describe('plugin-meetings', () => {
 
   describe('#roapMessageReceived', () => {
     it('calls roapMessageReceived on the webrtc media connection', () => {
-      const fakeMessage = {messageType: 'fake', sdp: 'fake sdp'};
+      const fakeMessage = {messageType: 'ANSWER', sdp: 'fake sdp'};
 
       const getMediaServer = sinon.stub(MeetingsUtil, 'getMediaServer').returns('homer');
 
@@ -13298,5 +13298,26 @@ describe('plugin-meetings', () => {
 
       assert.notCalled(meeting.mediaProperties.webrtcMediaConnection.roapMessageReceived);
     });
+
+    it('does not call getMediaServer for a roap message other than ANSWER', async () => {
+      const fakeMessage = {messageType: 'ERROR', sdp: 'fake sdp'};
+
+      meeting.isMultistream = true;
+      meeting.mediaProperties.webrtcMediaConnection = {
+        roapMessageReceived: sinon.stub(),
+      };
+      meeting.mediaProperties.webrtcMediaConnection.mediaServer = 'linus';
+
+      const getMediaServerStub = sinon.stub(MeetingsUtil, 'getMediaServer').returns('something');
+
+      meeting.roapMessageReceived(fakeMessage);
+
+      assert.calledOnceWithExactly(
+        meeting.mediaProperties.webrtcMediaConnection.roapMessageReceived,
+        fakeMessage
+      );
+      assert.notCalled(getMediaServerStub);
+      assert.equal(meeting.mediaProperties.webrtcMediaConnection.mediaServer, 'linus'); // check that it hasn't been overwritten
+    });
   });
 });