@webex/plugin-meetings 3.7.0-next.16 → 3.7.0-next.17

package/dist/webinar/index.js

@@ -425,7 +425,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       }, _callee7);
     }))();
   },
-  version: "3.7.0-next.16"
+  version: "3.7.0-next.17"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,13 +43,13 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.7.0-next.16",
-    "@webex/plugin-rooms": "3.7.0-next.5",
-    "@webex/test-helper-chai": "3.7.0-next.3",
-    "@webex/test-helper-mocha": "3.7.0-next.3",
-    "@webex/test-helper-mock-webex": "3.7.0-next.3",
-    "@webex/test-helper-retry": "3.7.0-next.3",
-    "@webex/test-helper-test-users": "3.7.0-next.3",
+    "@webex/plugin-meetings": "3.7.0-next.17",
+    "@webex/plugin-rooms": "3.7.0-next.6",
+    "@webex/test-helper-chai": "3.7.0-next.4",
+    "@webex/test-helper-mocha": "3.7.0-next.4",
+    "@webex/test-helper-mock-webex": "3.7.0-next.4",
+    "@webex/test-helper-retry": "3.7.0-next.4",
+    "@webex/test-helper-test-users": "3.7.0-next.4",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.24.0",
@@ -61,21 +61,21 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.7.0-next.3",
+    "@webex/common": "3.7.0-next.4",
     "@webex/internal-media-core": "2.12.2",
-    "@webex/internal-plugin-conversation": "3.7.0-next.5",
-    "@webex/internal-plugin-device": "3.7.0-next.3",
-    "@webex/internal-plugin-llm": "3.7.0-next.3",
-    "@webex/internal-plugin-mercury": "3.7.0-next.3",
-    "@webex/internal-plugin-metrics": "3.7.0-next.3",
-    "@webex/internal-plugin-support": "3.7.0-next.6",
-    "@webex/internal-plugin-user": "3.7.0-next.3",
-    "@webex/internal-plugin-voicea": "3.7.0-next.16",
-    "@webex/media-helpers": "3.7.0-next.3",
-    "@webex/plugin-people": "3.7.0-next.3",
-    "@webex/plugin-rooms": "3.7.0-next.5",
+    "@webex/internal-plugin-conversation": "3.7.0-next.6",
+    "@webex/internal-plugin-device": "3.7.0-next.4",
+    "@webex/internal-plugin-llm": "3.7.0-next.4",
+    "@webex/internal-plugin-mercury": "3.7.0-next.4",
+    "@webex/internal-plugin-metrics": "3.7.0-next.4",
+    "@webex/internal-plugin-support": "3.7.0-next.7",
+    "@webex/internal-plugin-user": "3.7.0-next.4",
+    "@webex/internal-plugin-voicea": "3.7.0-next.17",
+    "@webex/media-helpers": "3.7.0-next.4",
+    "@webex/plugin-people": "3.7.0-next.4",
+    "@webex/plugin-rooms": "3.7.0-next.6",
     "@webex/web-capabilities": "^1.4.0",
-    "@webex/webex-core": "3.7.0-next.3",
+    "@webex/webex-core": "3.7.0-next.4",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",
@@ -91,5 +91,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.7.0-next.16"
+  "version": "3.7.0-next.17"
 }

package/src/meeting/index.ts

@@ -5381,16 +5381,19 @@ export default class Meeting extends StatelessWebexPlugin {
       this.meetingFiniteStateMachine.reset();
     }
 
-    // @ts-ignore
-    this.webex.internal.newMetrics.submitClientEvent({
-      name: 'client.call.initiated',
-      payload: {
-        trigger: this.callStateForMetrics.joinTrigger || 'user-interaction',
-        isRoapCallEnabled: true,
-        pstnAudioType: options?.pstnAudioType,
-      },
-      options: {meetingId: this.id},
-    });
+    // send client.call.initiated unless told not to
+    if (options.sendCallInitiated !== false) {
+      // @ts-ignore
+      this.webex.internal.newMetrics.submitClientEvent({
+        name: 'client.call.initiated',
+        payload: {
+          trigger: this.callStateForMetrics.joinTrigger || 'user-interaction',
+          isRoapCallEnabled: true,
+          pstnAudioType: options?.pstnAudioType,
+        },
+        options: {meetingId: this.id},
+      });
+    }
 
     LoggerProxy.logger.log('Meeting:index#join --> Joining a meeting');
 

package/test/unit/spec/meeting/index.js

@@ -1705,6 +1705,12 @@ describe('plugin-meetings', () => {
             sinon.assert.called(setCorrelationIdSpy);
             assert.equal(meeting.correlationId, '123');
           });
+
+          it('should not send client.call.initiated if told not to', async () => {
+            await meeting.join({sendCallInitiated: false});
+
+            sinon.assert.notCalled(webex.internal.newMetrics.submitClientEvent);
+          });
         });
 
         describe('failure', () => {
@@ -2514,7 +2520,7 @@ describe('plugin-meetings', () => {
           meeting.mediaProperties.webrtcMediaConnection = undefined;
           checkLogCounter(60, 6);
 
-          clock.tick(120*1000*60);
+          clock.tick(120 * 1000 * 60);
           assert.equal(logUploadCounter, 6);
 
           clock.restore();
@@ -3741,8 +3747,12 @@ describe('plugin-meetings', () => {
             meeting.setMercuryListener = sinon.stub();
             meeting.locusInfo.onFullLocus = sinon.stub();
             meeting.webex.meetings.geoHintInfo = {regionCode: 'EU', countryCode: 'UK'};
-            meeting.webex.meetings.reachability.getReachabilityReportToAttachToRoap = sinon.stub().resolves({id: 'fake reachability'});
-            meeting.webex.meetings.reachability.getClientMediaPreferences = sinon.stub().resolves({id: 'fake clientMediaPreferences'});
+            meeting.webex.meetings.reachability.getReachabilityReportToAttachToRoap = sinon
+              .stub()
+              .resolves({id: 'fake reachability'});
+            meeting.webex.meetings.reachability.getClientMediaPreferences = sinon
+              .stub()
+              .resolves({id: 'fake clientMediaPreferences'});
             meeting.roap.doTurnDiscovery = sinon.stub().resolves({
               turnServerInfo: {
                 url: 'turns:turn-server-url:443?transport=tcp',
@@ -3928,8 +3938,14 @@ describe('plugin-meetings', () => {
           const checkSdpOfferSent = ({audioMuted, videoMuted}) => {
             const {sdp, seq, tieBreaker} = roapOfferMessage;
 
-            assert.calledWith(meeting.webex.meetings.reachability.getClientMediaPreferences, meeting.isMultistream, 0);
-            assert.calledWith(meeting.webex.meetings.reachability.getReachabilityReportToAttachToRoap);
+            assert.calledWith(
+              meeting.webex.meetings.reachability.getClientMediaPreferences,
+              meeting.isMultistream,
+              0
+            );
+            assert.calledWith(
+              meeting.webex.meetings.reachability.getReachabilityReportToAttachToRoap
+            );
 
             assert.calledWith(locusMediaRequestStub, {
               method: 'PUT',
@@ -7860,7 +7876,9 @@ describe('plugin-meetings', () => {
           });
 
           it('should collect ice candidates', () => {
-            eventListeners[MediaConnectionEventNames.ICE_CANDIDATE]({candidate: {candidate: 'candidate'}});
+            eventListeners[MediaConnectionEventNames.ICE_CANDIDATE]({
+              candidate: {candidate: 'candidate'},
+            });
 
             assert.equal(meeting.iceCandidatesCount, 1);
           });
@@ -8166,10 +8184,10 @@ describe('plugin-meetings', () => {
             meeting.statsAnalyzer.stopAnalyzer = sinon.stub().resolves();
             meeting.reconnectionManager = {
               reconnect: sinon.stub().resolves(),
-              resetReconnectionTimer: () => {}
+              resetReconnectionTimer: () => {},
             };
             meeting.currentMediaStatus = {
-              video: true
+              video: true,
             };
 
             await mockFailedEvent();
@@ -9097,7 +9115,7 @@ describe('plugin-meetings', () => {
             {state}
           );
 
-          assert.calledOnceWithExactly( meeting.webinar.updatePracticeSessionStatus, state);
+          assert.calledOnceWithExactly(meeting.webinar.updatePracticeSessionStatus, state);
           assert.calledWith(
             TriggerProxy.trigger,
             meeting,