@webex/plugin-meetings 3.6.0-next.18 → 3.6.0-next.19

package/dist/webinar/index.js

@@ -75,7 +75,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       isDemoted: isDemoted
     };
   },
-  version: "3.6.0-next.18"
+  version: "3.6.0-next.19"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,7 +43,7 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.6.0-next.18",
+    "@webex/plugin-meetings": "3.6.0-next.19",
     "@webex/plugin-rooms": "3.6.0-next.8",
     "@webex/test-helper-chai": "3.6.0-next.4",
     "@webex/test-helper-mocha": "3.6.0-next.4",
@@ -70,7 +70,7 @@
     "@webex/internal-plugin-metrics": "3.6.0-next.4",
     "@webex/internal-plugin-support": "3.6.0-next.8",
     "@webex/internal-plugin-user": "3.6.0-next.4",
-    "@webex/internal-plugin-voicea": "3.6.0-next.18",
+    "@webex/internal-plugin-voicea": "3.6.0-next.19",
     "@webex/media-helpers": "3.6.0-next.4",
     "@webex/plugin-people": "3.6.0-next.6",
     "@webex/plugin-rooms": "3.6.0-next.8",
@@ -91,5 +91,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.6.0-next.18"
+  "version": "3.6.0-next.19"
 }

package/src/meeting/index.ts

@@ -6323,7 +6323,7 @@ export default class Meeting extends StatelessWebexPlugin {
     this.mediaProperties.webrtcMediaConnection.on(
       MediaConnectionEventNames.ICE_CANDIDATE,
       (event) => {
-        if (event.candidate) {
+        if (event.candidate && event.candidate.candidate && event.candidate.candidate.length > 0) {
           this.iceCandidatesCount += 1;
         }
       }

package/test/unit/spec/meeting/index.js

@@ -90,8 +90,8 @@ import WebExMeetingsErrors from '../../../../src/common/errors/webex-meetings-er
 import ParameterError from '../../../../src/common/errors/parameter';
 import PasswordError from '../../../../src/common/errors/password-error';
 import CaptchaError from '../../../../src/common/errors/captcha-error';
-import PermissionError   from '../../../../src/common/errors/permission';
-import WebinarRegistrationError   from '../../../../src/common/errors/webinar-registration-error';
+import PermissionError from '../../../../src/common/errors/permission';
+import WebinarRegistrationError from '../../../../src/common/errors/webinar-registration-error';
 import IntentToJoinError from '../../../../src/common/errors/intent-to-join';
 import testUtils from '../../../utils/testUtils';
 import {
@@ -6290,14 +6290,22 @@ describe('plugin-meetings', () => {
           meeting.attrs.meetingInfoProvider = {
             fetchMeetingInfo: sinon
               .stub()
-              .throws(new MeetingInfoV2WebinarRegistrationError(403021, FAKE_MEETING_INFO, 'a message')),
+              .throws(
+                new MeetingInfoV2WebinarRegistrationError(403021, FAKE_MEETING_INFO, 'a message')
+              ),
           };
 
-          await assert.isRejected(meeting.fetchMeetingInfo({sendCAevents: true}), WebinarRegistrationError);
+          await assert.isRejected(
+            meeting.fetchMeetingInfo({sendCAevents: true}),
+            WebinarRegistrationError
+          );
 
           assert.deepEqual(meeting.meetingInfo, FAKE_MEETING_INFO);
           assert.equal(meeting.meetingInfoFailureCode, 403021);
-          assert.equal(meeting.meetingInfoFailureReason, MEETING_INFO_FAILURE_REASON.WEBINAR_REGISTRATION);
+          assert.equal(
+            meeting.meetingInfoFailureReason,
+            MEETING_INFO_FAILURE_REASON.WEBINAR_REGISTRATION
+          );
         });
       });
 
@@ -7761,11 +7769,17 @@ describe('plugin-meetings', () => {
           });
 
           it('should collect ice candidates', () => {
-            eventListeners[MediaConnectionEventNames.ICE_CANDIDATE]({candidate: 'candidate'});
+            eventListeners[MediaConnectionEventNames.ICE_CANDIDATE]({candidate: {candidate: 'candidate'}});
 
             assert.equal(meeting.iceCandidatesCount, 1);
           });
 
+          it('should not collect empty ice candidates', () => {
+            eventListeners[MediaConnectionEventNames.ICE_CANDIDATE]({candidate: {candidate: ''}});
+
+            assert.equal(meeting.iceCandidatesCount, 0);
+          });
+
           it('should not collect null ice candidates', () => {
             eventListeners[MediaConnectionEventNames.ICE_CANDIDATE]({candidate: null});
 
@@ -9160,7 +9174,6 @@ describe('plugin-meetings', () => {
               webcastInstance: {
                 url: 'url',
               },
-
             },
           };
 
@@ -9174,10 +9187,7 @@ describe('plugin-meetings', () => {
             newLocusResources
           );
 
-          assert.calledWith(
-            meeting.webinar.updateWebcastUrl,
-            newLocusResources
-          );
+          assert.calledWith(meeting.webinar.updateWebcastUrl, newLocusResources);
 
           done();
         });
@@ -12335,14 +12345,10 @@ describe('plugin-meetings', () => {
         const testEmit = async (unmuteAllowed) => {
           meeting.audio = {
             handleServerLocalUnmuteRequired: sinon.stub(),
-          }
-          await meeting.locusInfo.emitScoped(
-            {},
-            LOCUSINFO.EVENTS.LOCAL_UNMUTE_REQUIRED,
-            {
-              unmuteAllowed,
-            }
-          );
+          };
+          await meeting.locusInfo.emitScoped({}, LOCUSINFO.EVENTS.LOCAL_UNMUTE_REQUIRED, {
+            unmuteAllowed,
+          });
 
           assert.calledWith(
             TriggerProxy.trigger,
@@ -12358,7 +12364,11 @@ describe('plugin-meetings', () => {
               },
             }
           );
-          assert.calledOnceWithExactly(meeting.audio.handleServerLocalUnmuteRequired, meeting, unmuteAllowed)
+          assert.calledOnceWithExactly(
+            meeting.audio.handleServerLocalUnmuteRequired,
+            meeting,
+            unmuteAllowed
+          );
         };
 
         [true, false].forEach((unmuteAllowed) => {