@webex/plugin-meetings 3.4.0 → 3.5.0-next.2

package/src/reachability/index.ts

@@ -93,6 +93,8 @@ export default class Reachability extends EventsScope {
   expectedResultsCount = {videoMesh: {udp: 0}, public: {udp: 0, tcp: 0, xtls: 0}};
   resultsCount = {videoMesh: {udp: 0}, public: {udp: 0, tcp: 0, xtls: 0}};
 
+  protected lastTrigger?: string;
+
   /**
    * Creates an instance of Reachability.
    * @param {object} webex
@@ -114,18 +116,50 @@ export default class Reachability extends EventsScope {
     this.clusterReachability = {};
   }
 
+  /**
+   * Fetches the list of media clusters from the backend
+   * @param {boolean} isRetry
+   * @private
+   * @returns {Promise<{clusters: ClusterList, joinCookie: any}>}
+   */
+  async getClusters(isRetry = false): Promise<{clusters: ClusterList; joinCookie: any}> {
+    try {
+      const {clusters, joinCookie} = await this.reachabilityRequest.getClusters(
+        MeetingUtil.getIpVersion(this.webex)
+      );
+
+      return {clusters, joinCookie};
+    } catch (error) {
+      if (isRetry) {
+        throw error;
+      }
+
+      LoggerProxy.logger.error(
+        `Reachability:index#getClusters --> Failed with error: ${error}, retrying...`
+      );
+
+      return this.getClusters(true);
+    }
+  }
+
   /**
    * Gets a list of media clusters from the backend and performs reachability checks on all the clusters
+   * @param {string} trigger - explains the reason for starting reachability
    * @returns {Promise<ReachabilityResults>} reachability results
    * @public
    * @memberof Reachability
    */
-  public async gatherReachability(): Promise<ReachabilityResults> {
+  public async gatherReachability(trigger: string): Promise<ReachabilityResults> {
     // Fetch clusters and measure latency
     try {
-      const {clusters, joinCookie} = await this.reachabilityRequest.getClusters(
-        MeetingUtil.getIpVersion(this.webex)
-      );
+      this.lastTrigger = trigger;
+
+      // kick off ip version detection. For now we don't await it, as we're doing it
+      // to gather the timings and send them with our reachability metrics
+      // @ts-ignore
+      this.webex.internal.device.ipNetworkDetector.detect();
+
+      const {clusters, joinCookie} = await this.getClusters();
 
       // @ts-ignore
       await this.webex.boundedStorage.put(
@@ -513,6 +547,17 @@ export default class Reachability extends EventsScope {
         tcp: this.getStatistics(results, 'tcp', false),
         xtls: this.getStatistics(results, 'xtls', false),
       },
+      ipver: {
+        // @ts-ignore
+        firstIpV4: this.webex.internal.device.ipNetworkDetector.firstIpV4,
+        // @ts-ignore
+        firstIpV6: this.webex.internal.device.ipNetworkDetector.firstIpV6,
+        // @ts-ignore
+        firstMdns: this.webex.internal.device.ipNetworkDetector.firstMdns,
+        // @ts-ignore
+        totalTime: this.webex.internal.device.ipNetworkDetector.totalTime,
+      },
+      trigger: this.lastTrigger,
     };
     Metrics.sendBehavioralMetric(
       BEHAVIORAL_METRICS.REACHABILITY_COMPLETED,

package/src/reconnection-manager/index.ts

@@ -342,7 +342,7 @@ export default class ReconnectionManager {
       }
 
       try {
-        await this.webex.meetings.startReachability();
+        await this.webex.meetings.startReachability('reconnection');
       } catch (err) {
         LoggerProxy.logger.info(
           'ReconnectionManager:index#reconnect --> Reachability failed, continuing with reconnection attempt, err: ',

package/src/rtcMetrics/index.ts

@@ -34,6 +34,8 @@ export default class RtcMetrics {
 
   connectionId: string;
 
+  shouldSendMetricsOnNextStatsReport: boolean;
+
   /**
    * Initialize the interval.
    *
@@ -47,9 +49,7 @@ export default class RtcMetrics {
     this.meetingId = meetingId;
     this.webex = webex;
     this.correlationId = correlationId;
-    this.setNewConnectionId();
-    // Send the first set of metrics at 5 seconds in the case of a user leaving the call shortly after joining.
-    setTimeout(this.sendMetricsInQueue.bind(this), 5 * 1000);
+    this.resetConnection();
   }
 
   /**
@@ -64,6 +64,18 @@ export default class RtcMetrics {
     }
   }
 
+  /**
+   * Forces sending metrics when we get the next stats-report
+   *
+   * This is useful for cases when something important happens that affects the media connection,
+   * for example when we move from lobby into the meeting.
+   *
+   * @returns {void}
+   */
+  public sendNextMetrics() {
+    this.shouldSendMetricsOnNextStatsReport = true;
+  }
+
   /**
    * Add metrics items to the metrics queue.
    *
@@ -79,6 +91,13 @@ export default class RtcMetrics {
 
       this.metricsQueue.push(data);
 
+      if (this.shouldSendMetricsOnNextStatsReport && data.name === 'stats-report') {
+        // this is the first useful set of data (WCME gives it to us after 5s), send it out immediately
+        // in case the user is unhappy and closes the browser early
+        this.sendMetricsInQueue();
+        this.shouldSendMetricsOnNextStatsReport = false;
+      }
+
       try {
         // If a connection fails, send the rest of the metrics in queue and get a new connection id.
         const parsedPayload = parseJsonPayload(data.payload);
@@ -88,7 +107,7 @@ export default class RtcMetrics {
           parsedPayload.value === 'failed'
         ) {
           this.sendMetricsInQueue();
-          this.setNewConnectionId();
+          this.resetConnection();
         }
       } catch (e) {
         console.error(e);
@@ -130,8 +149,9 @@ export default class RtcMetrics {
    *
    * @returns {void}
    */
-  private setNewConnectionId() {
+  private resetConnection() {
     this.connectionId = uuid.v4();
+    this.shouldSendMetricsOnNextStatsReport = true;
   }
 
   /**

package/test/integration/spec/converged-space-meetings.js

@@ -1,5 +1,5 @@
-import { config } from 'dotenv';
 import 'jsdom-global/register';
+import {config} from 'dotenv';
 import {assert} from '@webex/test-helper-chai';
 import {skipInNode} from '@webex/test-helper-mocha';
 import BrowserDetection from '@webex/plugin-meetings/dist/common/browser-detection';

package/test/unit/spec/breakouts/index.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert, expect} from '@webex/test-helper-chai';
 import Breakouts from '@webex/plugin-meetings/src/breakouts';
 import LoggerProxy from '@webex/plugin-meetings/src/common/logs/logger-proxy';

package/test/unit/spec/interceptors/locusRetry.ts

@@ -3,6 +3,7 @@
  */
 
 /* eslint-disable camelcase */
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import { expect } from "@webex/test-helper-chai";
 import MockWebex from '@webex/test-helper-mock-webex';
@@ -13,7 +14,7 @@ import sinon from 'sinon';
 
 describe('plugin-meetings', () => {
     describe('Interceptors', () => {
-      describe('LocusRetryStatusInterceptor', () => { 
+      describe('LocusRetryStatusInterceptor', () => {
         let interceptor, webex;
         beforeEach(() => {
             webex = new MockWebex({
@@ -24,7 +25,7 @@ describe('plugin-meetings', () => {
             interceptor = Reflect.apply(LocusRetryStatusInterceptor.create, {
                 sessionId: 'mock-webex_uuid',
               }, []);
-          });  
+          });
         describe('#onResponseError', () => {
             const options = {
                 method: 'POST',
@@ -41,7 +42,7 @@ describe('plugin-meetings', () => {
                     headers: {
                         trackingid: 'test',
                         'retry-after': 1000,
-                    },    
+                    },
                     uri: `https://locus-test.webex.com/locus/api/v1/loci/call`,
                     },
                 body: {
@@ -54,7 +55,7 @@ describe('plugin-meetings', () => {
                     headers: {
                         trackingid: 'test',
                         'retry-after': 1000,
-                    },    
+                    },
                     uri: `https://locus-test.webex.com/locus/api/v1/loci/call`,
                     },
                 body: {
@@ -73,7 +74,7 @@ describe('plugin-meetings', () => {
 
                 return interceptor.onResponseError(options, reason2).then(() => {
                     expect(handleRetryStub.calledWith(options, 1000)).to.be.true;
-                    
+
                 });
             });
         });
@@ -92,7 +93,7 @@ describe('plugin-meetings', () => {
             it('returns the correct resolved value when the request is successful', () => {
                 const mockResponse = 'mock response'
                 interceptor.webex.request = sinon.stub().returns(Promise.resolve(mockResponse));
-          
+
                 return interceptor.handleRetryRequestLocusServiceError(options, retryAfterTime)
                   .then((response) => {
                     expect(response).to.equal(mockResponse);
@@ -101,9 +102,9 @@ describe('plugin-meetings', () => {
 
             it('rejects the promise when the request is unsuccessful', () => {
               const rejectionReason = 'Service Unavaialble after retry';
-    
+
               interceptor.webex.request = sinon.stub().returns(Promise.reject(rejectionReason));
-        
+
               return interceptor.handleRetryRequestLocusServiceError(options, retryAfterTime)
                 .catch((error) => {
                   expect(error).to.equal(rejectionReason);
@@ -114,10 +115,10 @@ describe('plugin-meetings', () => {
                 let clock;
                 clock = sinon.useFakeTimers();
                 const mockResponse = 'mock response'
-      
+
                 interceptor.webex.request = sinon.stub().returns(Promise.resolve(mockResponse));
                 const promise = interceptor.handleRetryRequestLocusServiceError(options, retryAfterTime);
-      
+
                 clock.tick(retryAfterTime);
 
                 return promise.then(() => {

package/test/unit/spec/media/MediaConnectionAwaiter.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import {ConnectionState, MediaConnectionEventNames} from '@webex/internal-media-core';

package/test/unit/spec/media/index.ts

@@ -1,16 +1,15 @@
+import 'jsdom-global/register';
 import * as InternalMediaCoreModule from '@webex/internal-media-core';
 import Media from '@webex/plugin-meetings/src/media/index';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import StaticConfig from '@webex/plugin-meetings/src/common/config';
-import MockWebex from '@webex/test-helper-mock-webex';
 
 describe('createMediaConnection', () => {
   let clock;
   beforeEach(() => {
     clock = sinon.useFakeTimers();
   });
-  const webex = MockWebex();
 
   const fakeRoapMediaConnection = {
     id: 'roap media connection',
@@ -61,7 +60,7 @@ describe('createMediaConnection', () => {
     const ENABLE_EXTMAP = false;
     const ENABLE_RTX = true;
 
-    Media.createMediaConnection(false, 'some debug id', webex, 'meetingId', 'correlationId', {
+    Media.createMediaConnection(false, 'some debug id', 'meetingId', {
       mediaProperties: {
         mediaDirection: {
           sendAudio: false,
@@ -139,7 +138,13 @@ describe('createMediaConnection', () => {
       .stub(InternalMediaCoreModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    Media.createMediaConnection(true, 'some debug id', webex, 'meeting id', 'correlationId', {
+    const rtcMetrics = {
+      addMetrics: sinon.stub(),
+      closeMetrics: sinon.stub(),
+      sendMetricsInQueue: sinon.stub(),
+    };
+
+    Media.createMediaConnection(true, 'some debug id', 'meeting id', {
       mediaProperties: {
         mediaDirection: {
           sendAudio: true,
@@ -150,6 +155,7 @@ describe('createMediaConnection', () => {
           receiveShare: true,
         },
       },
+      rtcMetrics,
       turnServerInfo: {
         url: 'turns:turn-server-url:443?transport=tcp',
         username: 'turn username',
@@ -177,6 +183,27 @@ describe('createMediaConnection', () => {
       },
       'meeting id'
     );
+
+    // check if rtcMetrics callbacks are configured correctly
+    const addMetricsCallback = multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[2];
+    const closeMetricsCallback = multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[3];
+    const sendMetricsInQueueCallback = multistreamRoapMediaConnectionConstructorStub.getCalls()[0].args[4];
+
+    assert.isFunction(addMetricsCallback);
+    assert.isFunction(closeMetricsCallback);
+    assert.isFunction(sendMetricsInQueueCallback);
+
+    const fakeMetricsData = {id: 'metrics data'};
+
+    addMetricsCallback(fakeMetricsData);
+    assert.calledOnceWithExactly(rtcMetrics.addMetrics, fakeMetricsData);
+
+    closeMetricsCallback();
+    assert.calledOnce(rtcMetrics.closeMetrics);
+
+    sendMetricsInQueueCallback();
+    assert.calledOnce(rtcMetrics.sendMetricsInQueue);
+
   });
 
   [
@@ -191,7 +218,7 @@ describe('createMediaConnection', () => {
         .stub(InternalMediaCoreModule, 'MultistreamRoapMediaConnection')
         .returns(fakeRoapMediaConnection);
 
-      Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
+      Media.createMediaConnection(true, 'debug string', 'meeting id', {
         mediaProperties: {
           mediaDirection: {
             sendAudio: true,
@@ -220,7 +247,7 @@ describe('createMediaConnection', () => {
       .stub(InternalMediaCoreModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
+    Media.createMediaConnection(true, 'debug string', 'meeting id', {
       mediaProperties: {
         mediaDirection: {
           sendAudio: true,
@@ -260,7 +287,7 @@ describe('createMediaConnection', () => {
       const ENABLE_EXTMAP = false;
       const ENABLE_RTX = true;
 
-      Media.createMediaConnection(false, 'some debug id', webex, 'meeting id', 'correlationId', {
+      Media.createMediaConnection(false, 'some debug id', 'meeting id', {
         mediaProperties: {
           mediaDirection: {
             sendAudio: true,

package/test/unit/spec/media/properties.ts

@@ -1,8 +1,8 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import {ConnectionState} from '@webex/internal-media-core';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
-import testUtils from '../../../utils/testUtils';
 import {Defer} from '@webex/common';
 import MediaConnectionAwaiter from '../../../../src/media/MediaConnectionAwaiter';
 

package/test/unit/spec/meeting/connectionStateHandler.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register'
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
 import {

package/test/unit/spec/meeting/index.js

@@ -5,6 +5,8 @@ import 'jsdom-global/register';
 import {cloneDeep, forEach, isEqual, isUndefined} from 'lodash';
 import sinon from 'sinon';
 import * as InternalMediaCoreModule from '@webex/internal-media-core';
+import * as RtcMetricsModule from '@webex/plugin-meetings/src/rtcMetrics';
+import * as RemoteMediaManagerModule from '@webex/plugin-meetings/src/multistream/remoteMediaManager';
 import StateMachine from 'javascript-state-machine';
 import uuid from 'uuid';
 import {assert, expect} from '@webex/test-helper-chai';
@@ -305,7 +307,7 @@ describe('plugin-meetings', () => {
           assert.equal(meeting.resource, uuid2);
           assert.equal(meeting.deviceUrl, uuid3);
           assert.equal(meeting.correlationId, correlationId);
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           assert.deepEqual(meeting.meetingInfo, {});
           assert.instanceOf(meeting.members, Members);
           assert.calledOnceWithExactly(
@@ -329,6 +331,7 @@ describe('plugin-meetings', () => {
           assert.isNull(meeting.partner);
           assert.isNull(meeting.type);
           assert.isNull(meeting.owner);
+          assert.isUndefined(meeting.isoLocalClientMeetingJoinTime);
           assert.isNull(meeting.hostId);
           assert.isNull(meeting.policy);
           assert.instanceOf(meeting.meetingRequest, MeetingRequest);
@@ -373,7 +376,7 @@ describe('plugin-meetings', () => {
             }
           );
           assert.equal(newMeeting.correlationId, newMeeting.id);
-          assert.deepEqual(newMeeting.callStateForMetrics, {correlationId: newMeeting.id});
+          assert.deepEqual(newMeeting.callStateForMetrics, {correlationId: newMeeting.id, sessionCorrelationId: ''});
         });
 
         it('correlationId can be provided in callStateForMetrics', () => {
@@ -400,6 +403,36 @@ describe('plugin-meetings', () => {
             correlationId: uuid4,
             joinTrigger: 'fake-join-trigger',
             loginType: 'fake-login-type',
+            sessionCorrelationId: '',
+          });
+        });
+
+        it('sessionCorrelationId can be provided in callStateForMetrics', () => {
+          const newMeeting = new Meeting(
+            {
+              userId: uuid1,
+              resource: uuid2,
+              deviceUrl: uuid3,
+              locus: {url: url1},
+              destination: testDestination,
+              destinationType: DESTINATION_TYPE.MEETING_ID,
+              callStateForMetrics: {
+                correlationId: uuid4,
+                sessionCorrelationId: uuid1,
+                joinTrigger: 'fake-join-trigger',
+                loginType: 'fake-login-type',
+              },
+            },
+            {
+              parent: webex,
+            }
+          );
+          assert.exists(newMeeting.sessionCorrelationId);
+          assert.deepEqual(newMeeting.callStateForMetrics, {
+            correlationId: uuid4,
+            sessionCorrelationId: uuid1,
+            joinTrigger: 'fake-join-trigger',
+            loginType: 'fake-login-type',
           });
         });
 
@@ -1585,6 +1618,10 @@ describe('plugin-meetings', () => {
             sandbox.stub(MeetingUtil, 'joinMeeting').returns(Promise.resolve(joinMeetingResult));
           });
 
+          afterEach(() => {
+            assert.exists(meeting.isoLocalClientMeetingJoinTime);
+          });
+
           it('should join the meeting and return promise', async () => {
             const join = meeting.join({pstnAudioType: 'dial-in'});
             meeting.config.enableAutomaticLLM = true;
@@ -1603,6 +1640,7 @@ describe('plugin-meetings', () => {
             const result = await join;
 
             assert.calledOnce(MeetingUtil.joinMeeting);
+            assert.calledOnce(webex.internal.device.meetingStarted);
             assert.calledOnce(meeting.setLocus);
             assert.equal(result, joinMeetingResult);
             assert.calledWith(webex.internal.llm.on, 'online', meeting.handleLLMOnline);
@@ -2405,9 +2443,7 @@ describe('plugin-meetings', () => {
             Media.createMediaConnection,
             false,
             meeting.getMediaConnectionDebugId(),
-            webex,
             meeting.id,
-            meeting.correlationId,
             sinon.match({turnServerInfo: undefined})
           );
           assert.calledOnce(meeting.setMercuryListener);
@@ -2449,6 +2485,44 @@ describe('plugin-meetings', () => {
           checkWorking({allowMediaInLobby: true});
         });
 
+        it('should create rtcMetrics and pass them to Media.createMediaConnection()', async () => {
+          const fakeRtcMetrics = {id: 'fake rtc metrics object'};
+          const rtcMetricsCtor = sinon.stub(RtcMetricsModule, 'default').returns(fakeRtcMetrics);
+
+          // setup the minimum mocks required for multistream connection
+          fakeMediaConnection.createSendSlot = sinon.stub().returns({
+            publishStream: sinon.stub(),
+            unpublishStream: sinon.stub(),
+            setNamedMediaGroups: sinon.stub(),
+          });
+          sinon.stub(RemoteMediaManagerModule, 'RemoteMediaManager').returns({
+            start: sinon.stub().resolves(),
+            on: sinon.stub(),
+            logAllReceiveSlots: sinon.stub(),
+          });
+
+          meeting.meetingState = 'ACTIVE';
+          meeting.isMultistream = true;
+
+          await meeting.addMedia({
+            mediaSettings: {},
+          });
+
+          assert.calledOnceWithExactly(rtcMetricsCtor, webex, meeting.id, meeting.correlationId);
+
+          // check that rtcMetrics was passed to Media.createMediaConnection
+          assert.calledOnce(Media.createMediaConnection);
+          assert.calledWith(
+            Media.createMediaConnection,
+            true,
+            meeting.getMediaConnectionDebugId(),
+            meeting.id,
+            sinon.match({
+              rtcMetrics: fakeRtcMetrics,
+            })
+          );
+        });
+
         it('should pass the turn server info to the peer connection', async () => {
           const FAKE_TURN_URL = 'turns:webex.com:3478';
           const FAKE_TURN_USER = 'some-turn-username';
@@ -2478,9 +2552,7 @@ describe('plugin-meetings', () => {
             Media.createMediaConnection,
             false,
             meeting.getMediaConnectionDebugId(),
-            webex,
             meeting.id,
-            meeting.correlationId,
             sinon.match({
               turnServerInfo: {
                 url: FAKE_TURN_URL,
@@ -3023,6 +3095,8 @@ describe('plugin-meetings', () => {
             }),
           };
           meeting.iceCandidatesCount = 3;
+          meeting.iceCandidateErrors.set('701_error', 3);
+          meeting.iceCandidateErrors.set('701_turn_host_lookup_received_error', 1);
 
           await meeting.addMedia({
             mediaSettings: {},
@@ -3044,6 +3118,8 @@ describe('plugin-meetings', () => {
               someReachabilityMetric1: 'some value1',
               someReachabilityMetric2: 'some value2',
               iceCandidatesCount: 3,
+              '701_error': 3,
+              '701_turn_host_lookup_received_error': 1,
             }
           );
 
@@ -3397,9 +3473,7 @@ describe('plugin-meetings', () => {
             Media.createMediaConnection,
             false,
             meeting.getMediaConnectionDebugId(),
-            webex,
             meeting.id,
-            meeting.correlationId,
             sinon.match({
               turnServerInfo: {
                 url: FAKE_TURN_URL,
@@ -4240,6 +4314,20 @@ describe('plugin-meetings', () => {
             assert.calledTwice(locusMediaRequestStub);
           });
 
+          it('addMedia() works correctly when media is disabled with no streams to publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({audioEnabled: false});
+            //calling handleDeviceLogging with audioEnaled as true adn videoEnabled as false
+            assert.calledWith(handleDeviceLoggingSpy,false,true);
+          });
+
+          it('addMedia() works correctly when video is disabled with no streams to publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({videoEnabled: false});
+            //calling handleDeviceLogging audioEnabled as true videoEnabled as false
+            assert.calledWith(handleDeviceLoggingSpy,true,false);
+          });
+
           it('addMedia() works correctly when video is disabled with no streams to publish', async () => {
             await meeting.addMedia({videoEnabled: false});
             await simulateRoapOffer();
@@ -4306,6 +4394,14 @@ describe('plugin-meetings', () => {
             assert.calledTwice(locusMediaRequestStub);
           });
 
+
+          it('addMedia() works correctly when both shareAudio and shareVideo is disabled with no streams publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({shareAudioEnabled: false, shareVideoEnabled: false});
+            //calling handleDeviceLogging with audioEnabled true and videoEnabled as true
+            assert.calledWith(handleDeviceLoggingSpy,true,true);
+          });
+
           describe('publishStreams()/unpublishStreams() calls', () => {
             [
               {mediaEnabled: true, expected: {direction: 'sendrecv', localMuteSentValue: false}},
@@ -6861,33 +6957,36 @@ describe('plugin-meetings', () => {
       describe('#setCorrelationId', () => {
         it('should set the correlationId and return undefined', () => {
           assert.equal(meeting.correlationId, correlationId);
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           meeting.setCorrelationId(uuid1);
           assert.equal(meeting.correlationId, uuid1);
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId: uuid1});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId: uuid1, sessionCorrelationId: ''});
         });
       });
 
       describe('#updateCallStateForMetrics', () => {
         it('should update the callState, overriding existing values', () => {
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           meeting.updateCallStateForMetrics({
             correlationId: uuid1,
+            sessionCorrelationId: uuid3,
             joinTrigger: 'jt',
             loginType: 'lt',
           });
           assert.deepEqual(meeting.callStateForMetrics, {
             correlationId: uuid1,
+            sessionCorrelationId: uuid3,
             joinTrigger: 'jt',
             loginType: 'lt',
           });
         });
 
         it('should update the callState, keeping non-supplied values', () => {
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           meeting.updateCallStateForMetrics({joinTrigger: 'jt', loginType: 'lt'});
           assert.deepEqual(meeting.callStateForMetrics, {
             correlationId,
+            sessionCorrelationId: '',
             joinTrigger: 'jt',
             loginType: 'lt',
           });
@@ -8450,6 +8549,9 @@ describe('plugin-meetings', () => {
         it('listens to the self admitted guest event', (done) => {
           meeting.stopKeepAlive = sinon.stub();
           meeting.updateLLMConnection = sinon.stub();
+          meeting.rtcMetrics = {
+            sendNextMetrics: sinon.stub(),
+          };
           meeting.locusInfo.emit({function: 'test', file: 'test'}, 'SELF_ADMITTED_GUEST', test1);
           assert.calledOnceWithExactly(meeting.stopKeepAlive);
           assert.calledThrice(TriggerProxy.trigger);
@@ -8461,6 +8563,8 @@ describe('plugin-meetings', () => {
             {payload: test1}
           );
           assert.calledOnce(meeting.updateLLMConnection);
+          assert.calledOnceWithExactly(meeting.rtcMetrics.sendNextMetrics);
+
           done();
         });
 

package/test/unit/spec/meeting/locusMediaRequest.ts

@@ -1,6 +1,7 @@
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
-import { cloneDeep, defer } from 'lodash';
+import { cloneDeep } from 'lodash';
 
 import MockWebex from '@webex/test-helper-mock-webex';
 import Meetings from '@webex/plugin-meetings';
@@ -495,4 +496,4 @@ describe('LocusMediaRequest.send()', () => {
     });
 
   });
-})
+})