@webex/plugin-meetings 3.4.0-next.9 → 3.5.0-next.1

package/package.json

@@ -43,13 +43,13 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.4.0-next.9",
-    "@webex/plugin-rooms": "3.4.0-next.2",
-    "@webex/test-helper-chai": "3.4.0-next.2",
-    "@webex/test-helper-mocha": "3.4.0-next.2",
-    "@webex/test-helper-mock-webex": "3.4.0-next.2",
-    "@webex/test-helper-retry": "3.4.0-next.2",
-    "@webex/test-helper-test-users": "3.4.0-next.2",
+    "@webex/plugin-meetings": "3.5.0-next.1",
+    "@webex/plugin-rooms": "3.5.0-next.1",
+    "@webex/test-helper-chai": "3.5.0-next.1",
+    "@webex/test-helper-mocha": "3.5.0-next.1",
+    "@webex/test-helper-mock-webex": "3.5.0-next.1",
+    "@webex/test-helper-retry": "3.5.0-next.1",
+    "@webex/test-helper-test-users": "3.5.0-next.1",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.24.0",
@@ -61,21 +61,21 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.4.0-next.2",
-    "@webex/internal-media-core": "2.10.2",
-    "@webex/internal-plugin-conversation": "3.4.0-next.2",
-    "@webex/internal-plugin-device": "3.4.0-next.2",
-    "@webex/internal-plugin-llm": "3.4.0-next.2",
-    "@webex/internal-plugin-mercury": "3.4.0-next.2",
-    "@webex/internal-plugin-metrics": "3.4.0-next.2",
-    "@webex/internal-plugin-support": "3.4.0-next.2",
-    "@webex/internal-plugin-user": "3.4.0-next.2",
-    "@webex/internal-plugin-voicea": "3.4.0-next.9",
-    "@webex/media-helpers": "3.4.0-next.3",
-    "@webex/plugin-people": "3.4.0-next.2",
-    "@webex/plugin-rooms": "3.4.0-next.2",
+    "@webex/common": "3.5.0-next.1",
+    "@webex/internal-media-core": "2.11.1",
+    "@webex/internal-plugin-conversation": "3.5.0-next.1",
+    "@webex/internal-plugin-device": "3.5.0-next.1",
+    "@webex/internal-plugin-llm": "3.5.0-next.1",
+    "@webex/internal-plugin-mercury": "3.5.0-next.1",
+    "@webex/internal-plugin-metrics": "3.5.0-next.1",
+    "@webex/internal-plugin-support": "3.5.0-next.1",
+    "@webex/internal-plugin-user": "3.5.0-next.1",
+    "@webex/internal-plugin-voicea": "3.5.0-next.1",
+    "@webex/media-helpers": "3.5.0-next.1",
+    "@webex/plugin-people": "3.5.0-next.1",
+    "@webex/plugin-rooms": "3.5.0-next.1",
     "@webex/web-capabilities": "^1.4.0",
-    "@webex/webex-core": "3.4.0-next.2",
+    "@webex/webex-core": "3.5.0-next.1",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",
@@ -91,5 +91,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.4.0-next.9"
+  "version": "3.5.0-next.1"
 }

package/src/meeting/index.ts

@@ -227,6 +227,7 @@ export type AddMediaOptions = {
 
 export type CallStateForMetrics = {
   correlationId?: string;
+  sessionCorrelationId?: string;
   joinTrigger?: string;
   loginType?: string;
 };
@@ -538,6 +539,7 @@ export default class Meeting extends StatelessWebexPlugin {
   id: string;
   isMultistream: boolean;
   locusUrl: string;
+  #isoLocalClientMeetingJoinTime?: string;
   mediaConnections: any[];
   mediaId?: string;
   meetingFiniteStateMachine: any;
@@ -741,12 +743,29 @@ export default class Meeting extends StatelessWebexPlugin {
      */
     this.callStateForMetrics = attrs.callStateForMetrics || {};
     const correlationId = attrs.correlationId || attrs.callStateForMetrics?.correlationId;
+    const sessionCorrelationId =
+      attrs.sessionCorrelationId || attrs.callStateForMetrics?.sessionCorrelationId;
+    if (sessionCorrelationId) {
+      LoggerProxy.logger.log(
+        `Meetings:index#constructor --> Initializing the meeting object with session correlation id from app ${correlationId}`
+      );
+      this.callStateForMetrics.sessionCorrelationId = sessionCorrelationId;
+    } else {
+      LoggerProxy.logger.log(
+        `Meetings:index#constructor --> No session correlation id supplied. None will be generated and this field will remain blank`
+      );
+      // TODO: supply a session from the meetings instance
+      this.callStateForMetrics.sessionCorrelationId = '';
+    }
     if (correlationId) {
       LoggerProxy.logger.log(
         `Meetings:index#constructor --> Initializing the meeting object with correlation id from app ${correlationId}`
       );
       this.callStateForMetrics.correlationId = correlationId;
     } else {
+      LoggerProxy.logger.log(
+        `Meetings:index#constructor --> Initializing the meeting object with generated correlation id from sdk ${this.id}`
+      );
       this.callStateForMetrics.correlationId = this.id;
     }
     /**
@@ -1521,6 +1540,17 @@ export default class Meeting extends StatelessWebexPlugin {
      * @memberof Meeting
      */
     this.iceCandidatesCount = 0;
+
+    /**
+     * Start time of meeting as an ISO string
+     * based on browser time, so can only be used to compute durations client side
+     * undefined if meeting has not been joined, set once on meeting join, and not updated again
+     * @instance
+     * @type {string}
+     * @private
+     * @memberof Meeting
+     */
+    this.#isoLocalClientMeetingJoinTime = undefined;
   }
 
   /**
@@ -1569,6 +1599,31 @@ export default class Meeting extends StatelessWebexPlugin {
     this.callStateForMetrics.correlationId = correlationId;
   }
 
+  /**
+   * Getter - Returns callStateForMetrics.sessionCorrelationId
+   * @returns {string}
+   */
+  get sessionCorrelationId() {
+    return this.callStateForMetrics.correlationId;
+  }
+
+  /**
+   * Setter - sets callStateForMetrics.sessionCorrelationId
+   * @param {string} sessionCorrelationId
+   */
+  set sessionCorrelationId(sessionCorrelationId: string) {
+    this.callStateForMetrics.sessionCorrelationId = sessionCorrelationId;
+  }
+
+  /**
+   * Getter - Returns isoLocalClientMeetingJoinTime
+   * This will be set once on meeting join, and not updated again
+   * @returns {string | undefined}
+   */
+  get isoLocalClientMeetingJoinTime(): string | undefined {
+    return this.#isoLocalClientMeetingJoinTime;
+  }
+
   /**
    * Set meeting info and trigger `MEETING_INFO_AVAILABLE` event
    * @param {any} info
@@ -5232,6 +5287,11 @@ export default class Meeting extends StatelessWebexPlugin {
         this.meetingFiniteStateMachine.join();
         this.setupLocusMediaRequest();
 
+        // @ts-ignore
+        this.webex.internal.device.meetingStarted();
+
+        this.#isoLocalClientMeetingJoinTime = new Date().toISOString();
+
         LoggerProxy.logger.log('Meeting:index#join --> Success');
 
         Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.JOIN_SUCCESS, {
@@ -6518,12 +6578,21 @@ export default class Meeting extends StatelessWebexPlugin {
    *
    * @private
    * @static
+   * @param {boolean} isAudioEnabled
+   * @param {boolean} isVideoEnabled
    * @returns {Promise<void>}
    */
-  private static async handleDeviceLogging(): Promise<void> {
-    try {
-      const devices = await getDevices();
 
+  private static async handleDeviceLogging(isAudioEnabled, isVideoEnabled): Promise<void> {
+    try {
+      let devices = [];
+      if (isVideoEnabled && isAudioEnabled) {
+        devices = await getDevices();
+      } else if (isVideoEnabled) {
+        devices = await getDevices(Media.DeviceKind.VIDEO_INPUT);
+      } else if (isAudioEnabled) {
+        devices = await getDevices(Media.DeviceKind.AUDIO_INPUT);
+      }
       MeetingUtil.handleDeviceLogging(devices);
     } catch {
       // getDevices may fail if we don't have browser permissions, that's ok, we still can have a media connection
@@ -7016,7 +7085,7 @@ export default class Meeting extends StatelessWebexPlugin {
       );
 
       if (audioEnabled || videoEnabled) {
-        await Meeting.handleDeviceLogging();
+        await Meeting.handleDeviceLogging(audioEnabled, videoEnabled);
       } else {
         LoggerProxy.logger.info(`${LOG_HEADER} device logging not required`);
       }

package/src/meeting/util.ts

@@ -170,6 +170,8 @@ const MeetingUtil = {
   },
 
   cleanUp: (meeting) => {
+    meeting.getWebexObject().internal.device.meetingEnded();
+
     meeting.breakouts.cleanUp();
     meeting.simultaneousInterpretation.cleanUp();
     meeting.locusMediaRequest = undefined;

package/src/meetings/index.ts

@@ -1081,6 +1081,7 @@ export default class Meetings extends WebexPlugin {
    * @param {CallStateForMetrics} callStateForMetrics - information about call state for metrics
    * @param {Object} [meetingInfo] - Pre-fetched complete meeting info
    * @param {String} [meetingLookupUrl] - meeting info prefetch url
+   * @param {string} sessionCorrelationId - the optional specified sessionCorrelationId (callStateForMetrics.sessionCorrelationId) can be provided instead
    * @returns {Promise<Meeting>} A new Meeting.
    * @public
    * @memberof Meetings
@@ -1094,7 +1095,8 @@ export default class Meetings extends WebexPlugin {
     failOnMissingMeetingInfo = false,
     callStateForMetrics: CallStateForMetrics = undefined,
     meetingInfo = undefined,
-    meetingLookupUrl = undefined
+    meetingLookupUrl = undefined,
+    sessionCorrelationId: string = undefined
   ) {
     // Validate meeting information based on the provided destination and
     // type. This must be performed prior to determining if the meeting is
@@ -1105,6 +1107,10 @@ export default class Meetings extends WebexPlugin {
       callStateForMetrics = {...(callStateForMetrics || {}), correlationId};
     }
 
+    if (sessionCorrelationId) {
+      callStateForMetrics = {...(callStateForMetrics || {}), sessionCorrelationId};
+    }
+
     return (
       this.meetingInfo
         .fetchInfoOptions(destination, type)

package/test/integration/spec/converged-space-meetings.js

@@ -1,5 +1,5 @@
-import { config } from 'dotenv';
 import 'jsdom-global/register';
+import {config} from 'dotenv';
 import {assert} from '@webex/test-helper-chai';
 import {skipInNode} from '@webex/test-helper-mocha';
 import BrowserDetection from '@webex/plugin-meetings/dist/common/browser-detection';

package/test/unit/spec/breakouts/index.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert, expect} from '@webex/test-helper-chai';
 import Breakouts from '@webex/plugin-meetings/src/breakouts';
 import LoggerProxy from '@webex/plugin-meetings/src/common/logs/logger-proxy';

package/test/unit/spec/interceptors/locusRetry.ts

@@ -3,6 +3,7 @@
  */
 
 /* eslint-disable camelcase */
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import { expect } from "@webex/test-helper-chai";
 import MockWebex from '@webex/test-helper-mock-webex';
@@ -13,7 +14,7 @@ import sinon from 'sinon';
 
 describe('plugin-meetings', () => {
     describe('Interceptors', () => {
-      describe('LocusRetryStatusInterceptor', () => { 
+      describe('LocusRetryStatusInterceptor', () => {
         let interceptor, webex;
         beforeEach(() => {
             webex = new MockWebex({
@@ -24,7 +25,7 @@ describe('plugin-meetings', () => {
             interceptor = Reflect.apply(LocusRetryStatusInterceptor.create, {
                 sessionId: 'mock-webex_uuid',
               }, []);
-          });  
+          });
         describe('#onResponseError', () => {
             const options = {
                 method: 'POST',
@@ -41,7 +42,7 @@ describe('plugin-meetings', () => {
                     headers: {
                         trackingid: 'test',
                         'retry-after': 1000,
-                    },    
+                    },
                     uri: `https://locus-test.webex.com/locus/api/v1/loci/call`,
                     },
                 body: {
@@ -54,7 +55,7 @@ describe('plugin-meetings', () => {
                     headers: {
                         trackingid: 'test',
                         'retry-after': 1000,
-                    },    
+                    },
                     uri: `https://locus-test.webex.com/locus/api/v1/loci/call`,
                     },
                 body: {
@@ -73,7 +74,7 @@ describe('plugin-meetings', () => {
 
                 return interceptor.onResponseError(options, reason2).then(() => {
                     expect(handleRetryStub.calledWith(options, 1000)).to.be.true;
-                    
+
                 });
             });
         });
@@ -92,7 +93,7 @@ describe('plugin-meetings', () => {
             it('returns the correct resolved value when the request is successful', () => {
                 const mockResponse = 'mock response'
                 interceptor.webex.request = sinon.stub().returns(Promise.resolve(mockResponse));
-          
+
                 return interceptor.handleRetryRequestLocusServiceError(options, retryAfterTime)
                   .then((response) => {
                     expect(response).to.equal(mockResponse);
@@ -101,9 +102,9 @@ describe('plugin-meetings', () => {
 
             it('rejects the promise when the request is unsuccessful', () => {
               const rejectionReason = 'Service Unavaialble after retry';
-    
+
               interceptor.webex.request = sinon.stub().returns(Promise.reject(rejectionReason));
-        
+
               return interceptor.handleRetryRequestLocusServiceError(options, retryAfterTime)
                 .catch((error) => {
                   expect(error).to.equal(rejectionReason);
@@ -114,10 +115,10 @@ describe('plugin-meetings', () => {
                 let clock;
                 clock = sinon.useFakeTimers();
                 const mockResponse = 'mock response'
-      
+
                 interceptor.webex.request = sinon.stub().returns(Promise.resolve(mockResponse));
                 const promise = interceptor.handleRetryRequestLocusServiceError(options, retryAfterTime);
-      
+
                 clock.tick(retryAfterTime);
 
                 return promise.then(() => {

package/test/unit/spec/media/MediaConnectionAwaiter.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import {ConnectionState, MediaConnectionEventNames} from '@webex/internal-media-core';

package/test/unit/spec/media/index.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import * as InternalMediaCoreModule from '@webex/internal-media-core';
 import Media from '@webex/plugin-meetings/src/media/index';
 import {assert} from '@webex/test-helper-chai';

package/test/unit/spec/media/properties.ts

@@ -1,8 +1,8 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import {ConnectionState} from '@webex/internal-media-core';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
-import testUtils from '../../../utils/testUtils';
 import {Defer} from '@webex/common';
 import MediaConnectionAwaiter from '../../../../src/media/MediaConnectionAwaiter';
 

package/test/unit/spec/meeting/connectionStateHandler.ts

@@ -1,3 +1,4 @@
+import 'jsdom-global/register'
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
 import {

package/test/unit/spec/meeting/index.js

@@ -307,7 +307,7 @@ describe('plugin-meetings', () => {
           assert.equal(meeting.resource, uuid2);
           assert.equal(meeting.deviceUrl, uuid3);
           assert.equal(meeting.correlationId, correlationId);
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           assert.deepEqual(meeting.meetingInfo, {});
           assert.instanceOf(meeting.members, Members);
           assert.calledOnceWithExactly(
@@ -331,6 +331,7 @@ describe('plugin-meetings', () => {
           assert.isNull(meeting.partner);
           assert.isNull(meeting.type);
           assert.isNull(meeting.owner);
+          assert.isUndefined(meeting.isoLocalClientMeetingJoinTime);
           assert.isNull(meeting.hostId);
           assert.isNull(meeting.policy);
           assert.instanceOf(meeting.meetingRequest, MeetingRequest);
@@ -375,7 +376,7 @@ describe('plugin-meetings', () => {
             }
           );
           assert.equal(newMeeting.correlationId, newMeeting.id);
-          assert.deepEqual(newMeeting.callStateForMetrics, {correlationId: newMeeting.id});
+          assert.deepEqual(newMeeting.callStateForMetrics, {correlationId: newMeeting.id, sessionCorrelationId: ''});
         });
 
         it('correlationId can be provided in callStateForMetrics', () => {
@@ -402,6 +403,36 @@ describe('plugin-meetings', () => {
             correlationId: uuid4,
             joinTrigger: 'fake-join-trigger',
             loginType: 'fake-login-type',
+            sessionCorrelationId: '',
+          });
+        });
+
+        it('sessionCorrelationId can be provided in callStateForMetrics', () => {
+          const newMeeting = new Meeting(
+            {
+              userId: uuid1,
+              resource: uuid2,
+              deviceUrl: uuid3,
+              locus: {url: url1},
+              destination: testDestination,
+              destinationType: DESTINATION_TYPE.MEETING_ID,
+              callStateForMetrics: {
+                correlationId: uuid4,
+                sessionCorrelationId: uuid1,
+                joinTrigger: 'fake-join-trigger',
+                loginType: 'fake-login-type',
+              },
+            },
+            {
+              parent: webex,
+            }
+          );
+          assert.exists(newMeeting.sessionCorrelationId);
+          assert.deepEqual(newMeeting.callStateForMetrics, {
+            correlationId: uuid4,
+            sessionCorrelationId: uuid1,
+            joinTrigger: 'fake-join-trigger',
+            loginType: 'fake-login-type',
           });
         });
 
@@ -1587,6 +1618,10 @@ describe('plugin-meetings', () => {
             sandbox.stub(MeetingUtil, 'joinMeeting').returns(Promise.resolve(joinMeetingResult));
           });
 
+          afterEach(() => {
+            assert.exists(meeting.isoLocalClientMeetingJoinTime);
+          });
+
           it('should join the meeting and return promise', async () => {
             const join = meeting.join({pstnAudioType: 'dial-in'});
             meeting.config.enableAutomaticLLM = true;
@@ -1605,6 +1640,7 @@ describe('plugin-meetings', () => {
             const result = await join;
 
             assert.calledOnce(MeetingUtil.joinMeeting);
+            assert.calledOnce(webex.internal.device.meetingStarted);
             assert.calledOnce(meeting.setLocus);
             assert.equal(result, joinMeetingResult);
             assert.calledWith(webex.internal.llm.on, 'online', meeting.handleLLMOnline);
@@ -4278,6 +4314,20 @@ describe('plugin-meetings', () => {
             assert.calledTwice(locusMediaRequestStub);
           });
 
+          it('addMedia() works correctly when media is disabled with no streams to publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({audioEnabled: false});
+            //calling handleDeviceLogging with audioEnaled as true adn videoEnabled as false
+            assert.calledWith(handleDeviceLoggingSpy,false,true);
+          });
+
+          it('addMedia() works correctly when video is disabled with no streams to publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({videoEnabled: false});
+            //calling handleDeviceLogging audioEnabled as true videoEnabled as false
+            assert.calledWith(handleDeviceLoggingSpy,true,false);
+          });
+
           it('addMedia() works correctly when video is disabled with no streams to publish', async () => {
             await meeting.addMedia({videoEnabled: false});
             await simulateRoapOffer();
@@ -4344,6 +4394,14 @@ describe('plugin-meetings', () => {
             assert.calledTwice(locusMediaRequestStub);
           });
 
+
+          it('addMedia() works correctly when both shareAudio and shareVideo is disabled with no streams publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({shareAudioEnabled: false, shareVideoEnabled: false});
+            //calling handleDeviceLogging with audioEnabled true and videoEnabled as true
+            assert.calledWith(handleDeviceLoggingSpy,true,true);
+          });
+
           describe('publishStreams()/unpublishStreams() calls', () => {
             [
               {mediaEnabled: true, expected: {direction: 'sendrecv', localMuteSentValue: false}},
@@ -6899,33 +6957,36 @@ describe('plugin-meetings', () => {
       describe('#setCorrelationId', () => {
         it('should set the correlationId and return undefined', () => {
           assert.equal(meeting.correlationId, correlationId);
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           meeting.setCorrelationId(uuid1);
           assert.equal(meeting.correlationId, uuid1);
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId: uuid1});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId: uuid1, sessionCorrelationId: ''});
         });
       });
 
       describe('#updateCallStateForMetrics', () => {
         it('should update the callState, overriding existing values', () => {
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           meeting.updateCallStateForMetrics({
             correlationId: uuid1,
+            sessionCorrelationId: uuid3,
             joinTrigger: 'jt',
             loginType: 'lt',
           });
           assert.deepEqual(meeting.callStateForMetrics, {
             correlationId: uuid1,
+            sessionCorrelationId: uuid3,
             joinTrigger: 'jt',
             loginType: 'lt',
           });
         });
 
         it('should update the callState, keeping non-supplied values', () => {
-          assert.deepEqual(meeting.callStateForMetrics, {correlationId});
+          assert.deepEqual(meeting.callStateForMetrics, {correlationId, sessionCorrelationId: ''});
           meeting.updateCallStateForMetrics({joinTrigger: 'jt', loginType: 'lt'});
           assert.deepEqual(meeting.callStateForMetrics, {
             correlationId,
+            sessionCorrelationId: '',
             joinTrigger: 'jt',
             loginType: 'lt',
           });

package/test/unit/spec/meeting/locusMediaRequest.ts

@@ -1,6 +1,7 @@
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
-import { cloneDeep, defer } from 'lodash';
+import { cloneDeep } from 'lodash';
 
 import MockWebex from '@webex/test-helper-mock-webex';
 import Meetings from '@webex/plugin-meetings';
@@ -495,4 +496,4 @@ describe('LocusMediaRequest.send()', () => {
     });
 
   });
-})
+})

package/test/unit/spec/meeting/request.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
 import MockWebex from '@webex/test-helper-mock-webex';

package/test/unit/spec/meeting/utils.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
 import Meetings from '@webex/plugin-meetings';
@@ -71,6 +72,7 @@ describe('plugin-meetings', () => {
         assert.calledOnce(meeting.updateLLMConnection);
         assert.calledOnce(meeting.breakouts.cleanUp);
         assert.calledOnce(meeting.simultaneousInterpretation.cleanUp);
+        assert.calledOnce(webex.internal.device.meetingEnded);
       });
 
       it('do clean up on meeting object with LLM disabled', async () => {
@@ -87,6 +89,7 @@ describe('plugin-meetings', () => {
         assert.notCalled(meeting.updateLLMConnection);
         assert.calledOnce(meeting.breakouts.cleanUp);
         assert.calledOnce(meeting.simultaneousInterpretation.cleanUp);
+        assert.calledOnce(webex.internal.device.meetingEnded);
       });
 
       it('do clean up on meeting object with no config', async () => {
@@ -102,6 +105,7 @@ describe('plugin-meetings', () => {
         assert.notCalled(meeting.updateLLMConnection);
         assert.calledOnce(meeting.breakouts.cleanUp);
         assert.calledOnce(meeting.simultaneousInterpretation.cleanUp);
+        assert.calledOnce(webex.internal.device.meetingEnded);
       });
     });