@webex/plugin-meetings 3.4.0-next.15 → 3.4.0-next.16

package/dist/types/meeting/index.d.ts

@@ -1295,6 +1295,8 @@ export default class Meeting extends StatelessWebexPlugin {
      *
      * @private
      * @static
+     * @param {boolean} isAudioEnabled
+     * @param {boolean} isVideoEnabled
      * @returns {Promise<void>}
      */
     private static handleDeviceLogging;

package/dist/webinar/index.js

@@ -62,7 +62,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
   updateCanManageWebcast: function updateCanManageWebcast(canManageWebcast) {
     this.set('canManageWebcast', canManageWebcast);
   },
-  version: "3.4.0-next.15"
+  version: "3.4.0-next.16"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,7 +43,7 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.4.0-next.15",
+    "@webex/plugin-meetings": "3.4.0-next.16",
     "@webex/plugin-rooms": "3.4.0-next.6",
     "@webex/test-helper-chai": "3.4.0-next.6",
     "@webex/test-helper-mocha": "3.4.0-next.6",
@@ -70,7 +70,7 @@
     "@webex/internal-plugin-metrics": "3.4.0-next.6",
     "@webex/internal-plugin-support": "3.4.0-next.6",
     "@webex/internal-plugin-user": "3.4.0-next.6",
-    "@webex/internal-plugin-voicea": "3.4.0-next.15",
+    "@webex/internal-plugin-voicea": "3.4.0-next.16",
     "@webex/media-helpers": "3.4.0-next.9",
     "@webex/plugin-people": "3.4.0-next.6",
     "@webex/plugin-rooms": "3.4.0-next.6",
@@ -91,5 +91,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.4.0-next.15"
+  "version": "3.4.0-next.16"
 }

package/src/meeting/index.ts

@@ -6521,12 +6521,21 @@ export default class Meeting extends StatelessWebexPlugin {
    *
    * @private
    * @static
+   * @param {boolean} isAudioEnabled
+   * @param {boolean} isVideoEnabled
    * @returns {Promise<void>}
    */
-  private static async handleDeviceLogging(): Promise<void> {
-    try {
-      const devices = await getDevices();
 
+  private static async handleDeviceLogging(isAudioEnabled, isVideoEnabled): Promise<void> {
+    try {
+      let devices = [];
+      if (isVideoEnabled && isAudioEnabled) {
+        devices = await getDevices();
+      } else if (isVideoEnabled) {
+        devices = await getDevices(Media.DeviceKind.VIDEO_INPUT);
+      } else if (isAudioEnabled) {
+        devices = await getDevices(Media.DeviceKind.AUDIO_INPUT);
+      }
       MeetingUtil.handleDeviceLogging(devices);
     } catch {
       // getDevices may fail if we don't have browser permissions, that's ok, we still can have a media connection
@@ -7019,7 +7028,7 @@ export default class Meeting extends StatelessWebexPlugin {
       );
 
       if (audioEnabled || videoEnabled) {
-        await Meeting.handleDeviceLogging();
+        await Meeting.handleDeviceLogging(audioEnabled, videoEnabled);
       } else {
         LoggerProxy.logger.info(`${LOG_HEADER} device logging not required`);
       }

package/test/unit/spec/meeting/index.js

@@ -4279,6 +4279,20 @@ describe('plugin-meetings', () => {
             assert.calledTwice(locusMediaRequestStub);
           });
 
+          it('addMedia() works correctly when media is disabled with no streams to publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({audioEnabled: false});
+            //calling handleDeviceLogging with audioEnaled as true adn videoEnabled as false
+            assert.calledWith(handleDeviceLoggingSpy,false,true);
+          });
+
+          it('addMedia() works correctly when video is disabled with no streams to publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({videoEnabled: false});
+            //calling handleDeviceLogging audioEnabled as true videoEnabled as false
+            assert.calledWith(handleDeviceLoggingSpy,true,false);
+          });
+
           it('addMedia() works correctly when video is disabled with no streams to publish', async () => {
             await meeting.addMedia({videoEnabled: false});
             await simulateRoapOffer();
@@ -4345,6 +4359,14 @@ describe('plugin-meetings', () => {
             assert.calledTwice(locusMediaRequestStub);
           });
 
+
+          it('addMedia() works correctly when both shareAudio and shareVideo is disabled with no streams publish', async () => {
+            const handleDeviceLoggingSpy = sinon.spy(Meeting, 'handleDeviceLogging');
+            await meeting.addMedia({shareAudioEnabled: false, shareVideoEnabled: false});
+            //calling handleDeviceLogging with audioEnabled true and videoEnabled as true
+            assert.calledWith(handleDeviceLoggingSpy,true,true);
+          });
+
           describe('publishStreams()/unpublishStreams() calls', () => {
             [
               {mediaEnabled: true, expected: {direction: 'sendrecv', localMuteSentValue: false}},