@webex/plugin-meetings 3.3.1-next.21 → 3.3.1-next.23

package/dist/webinar/index.js

@@ -62,7 +62,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
   updateCanManageWebcast: function updateCanManageWebcast(canManageWebcast) {
     this.set('canManageWebcast', canManageWebcast);
   },
-  version: "3.3.1-next.21"
+  version: "3.3.1-next.23"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -43,13 +43,13 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/plugin-meetings": "3.3.1-next.21",
-    "@webex/plugin-rooms": "3.3.1-next.5",
-    "@webex/test-helper-chai": "3.3.1-next.4",
-    "@webex/test-helper-mocha": "3.3.1-next.4",
-    "@webex/test-helper-mock-webex": "3.3.1-next.4",
-    "@webex/test-helper-retry": "3.3.1-next.4",
-    "@webex/test-helper-test-users": "3.3.1-next.4",
+    "@webex/plugin-meetings": "3.3.1-next.23",
+    "@webex/plugin-rooms": "3.3.1-next.6",
+    "@webex/test-helper-chai": "3.3.1-next.5",
+    "@webex/test-helper-mocha": "3.3.1-next.5",
+    "@webex/test-helper-mock-webex": "3.3.1-next.5",
+    "@webex/test-helper-retry": "3.3.1-next.5",
+    "@webex/test-helper-test-users": "3.3.1-next.5",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "eslint": "^8.24.0",
@@ -61,21 +61,21 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.3.1-next.4",
+    "@webex/common": "3.3.1-next.5",
     "@webex/internal-media-core": "2.7.1",
-    "@webex/internal-plugin-conversation": "3.3.1-next.5",
-    "@webex/internal-plugin-device": "3.3.1-next.4",
-    "@webex/internal-plugin-llm": "3.3.1-next.6",
-    "@webex/internal-plugin-mercury": "3.3.1-next.5",
-    "@webex/internal-plugin-metrics": "3.3.1-next.4",
-    "@webex/internal-plugin-support": "3.3.1-next.5",
-    "@webex/internal-plugin-user": "3.3.1-next.4",
-    "@webex/internal-plugin-voicea": "3.3.1-next.21",
-    "@webex/media-helpers": "3.3.1-next.7",
-    "@webex/plugin-people": "3.3.1-next.5",
-    "@webex/plugin-rooms": "3.3.1-next.5",
+    "@webex/internal-plugin-conversation": "3.3.1-next.6",
+    "@webex/internal-plugin-device": "3.3.1-next.5",
+    "@webex/internal-plugin-llm": "3.3.1-next.7",
+    "@webex/internal-plugin-mercury": "3.3.1-next.6",
+    "@webex/internal-plugin-metrics": "3.3.1-next.5",
+    "@webex/internal-plugin-support": "3.3.1-next.6",
+    "@webex/internal-plugin-user": "3.3.1-next.5",
+    "@webex/internal-plugin-voicea": "3.3.1-next.23",
+    "@webex/media-helpers": "3.3.1-next.8",
+    "@webex/plugin-people": "3.3.1-next.6",
+    "@webex/plugin-rooms": "3.3.1-next.6",
     "@webex/web-capabilities": "^1.3.0",
-    "@webex/webex-core": "3.3.1-next.4",
+    "@webex/webex-core": "3.3.1-next.5",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",
@@ -92,5 +92,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.3.1-next.21"
+  "version": "3.3.1-next.23"
 }

package/src/meeting/index.ts

@@ -4647,7 +4647,16 @@ export default class Meeting extends StatelessWebexPlugin {
         }
       );
 
-      if (!isRetry) {
+      // if this was the first attempt, let's do a retry
+      let shouldRetry = !isRetry;
+
+      if (CallDiagnosticUtils.isSdpOfferCreationError(error)) {
+        // errors related to offer creation (for example missing H264 codec) will happen again no matter how many times we try,
+        // so there is no point doing a retry
+        shouldRetry = false;
+      }
+
+      if (shouldRetry) {
         LoggerProxy.logger.warn('Meeting:index#joinWithMedia --> retrying call to joinWithMedia');
         this.joinWithMediaRetryInfo.isRetry = true;
         this.joinWithMediaRetryInfo.prevJoinResponse = joinResponse;

package/test/unit/spec/meeting/index.js

@@ -902,6 +902,38 @@ describe('plugin-meetings', () => {
             }
           );
         });
+
+        it('should not attempt a retry if we fail to create the offer on first atttempt', async () => {
+          const addMediaError = new Error('fake addMedia error');
+          addMediaError.name = 'SdpOfferCreationError';
+
+          meeting.addMedia.rejects(addMediaError)
+
+          await assert.isRejected(meeting.joinWithMedia({
+            joinOptions,
+            mediaOptions,
+          }), addMediaError);
+
+          // check that only 1 attempt was done
+          assert.calledOnce(meeting.join);
+          assert.calledOnce(meeting.addMedia);
+          assert.calledOnce(Metrics.sendBehavioralMetric);
+          assert.calledWith(
+            Metrics.sendBehavioralMetric.firstCall,
+            BEHAVIORAL_METRICS.JOIN_WITH_MEDIA_FAILURE,
+            {
+              correlation_id: meeting.correlationId,
+              locus_id: meeting.locusUrl.split('/').pop(),
+              reason: addMediaError.message,
+              stack: addMediaError.stack,
+              leaveErrorReason: undefined,
+              isRetry: false,
+            },
+            {
+              type: addMediaError.name,
+            }
+          );
+        });
       });
 
       describe('#isTranscriptionSupported', () => {