@webex/plugin-meetings 3.12.0-next.8 → 3.12.0-task-refactor.1

package/test/unit/spec/media/MediaConnectionAwaiter.ts

@@ -5,8 +5,6 @@ import {ConnectionState, MediaConnectionEventNames} from '@webex/internal-media-
 import testUtils from '../../../utils/testUtils';
 import {ICE_AND_DTLS_CONNECTION_TIMEOUT} from '@webex/plugin-meetings/src/constants';
 import MediaConnectionAwaiter from '../../../../src/media/MediaConnectionAwaiter';
-import Metrics from '../../../../src/metrics';
-import BEHAVIORAL_METRICS from '../../../../src/metrics/constants';
 
 describe('MediaConnectionAwaiter', () => {
   let mediaConnectionAwaiter;
@@ -16,34 +14,18 @@ describe('MediaConnectionAwaiter', () => {
   beforeEach(() => {
     clock = sinon.useFakeTimers();
 
-    const mockTransportReport = {
-      type: 'transport',
-      dtlsState: 'connecting',
-      iceState: 'checking',
-      packetsSent: 10,
-      packetsReceived: 5,
-    };
-
     mockMC = {
-      getStats: sinon.stub().resolves({
-        values: () => [mockTransportReport],
-      }),
+      getStats: sinon.stub().resolves([]),
       on: sinon.stub(),
       off: sinon.stub(),
       getConnectionState: sinon.stub().returns(ConnectionState.New),
       getIceGatheringState: sinon.stub().returns('new'),
       getIceConnectionState: sinon.stub().returns('new'),
       getPeerConnectionState: sinon.stub().returns('new'),
-      multistreamConnection: {
-        dataChannel: {
-          readyState: 'open',
-        },
-      },
     };
 
     mediaConnectionAwaiter = new MediaConnectionAwaiter({
       webrtcMediaConnection: mockMC,
-      correlationId: 'test-correlation-id',
     });
   });
 
@@ -62,8 +44,6 @@ describe('MediaConnectionAwaiter', () => {
     });
 
     it('rejects after timeout if ice state is not connected', async () => {
-      const sendMetricSpy = sinon.spy(Metrics, 'sendBehavioralMetric');
-
       mockMC.getConnectionState.returns(ConnectionState.Connecting);
       mockMC.getIceGatheringState.returns('gathering');
 
@@ -103,18 +83,6 @@ describe('MediaConnectionAwaiter', () => {
       assert.equal(promiseRejected, true);
 
       assert.calledThrice(mockMC.off);
-
-      assert.calledOnceWithExactly(sendMetricSpy, BEHAVIORAL_METRICS.MEDIA_STILL_NOT_CONNECTED, {
-        correlation_id: 'test-correlation-id',
-        numTransports: 1,
-        dtlsState: 'connecting',
-        iceState: 'checking',
-        packetsSent: 10,
-        packetsReceived: 5,
-        dataChannelState: 'open',
-      });
-
-      sendMetricSpy.restore();
     });
 
     it('rejects immediately if ice state is FAILED', async () => {
@@ -383,8 +351,6 @@ describe('MediaConnectionAwaiter', () => {
     });
 
     it(`reject with restart timer once if gathering state is not complete`, async () => {
-      const sendMetricSpy = sinon.spy(Metrics, 'sendBehavioralMetric');
-
       mockMC.getConnectionState.returns(ConnectionState.Connecting);
       mockMC.getIceGatheringState.returns('new');
 
@@ -424,12 +390,6 @@ describe('MediaConnectionAwaiter', () => {
 
       assert.calledOnce(clearTimeoutSpy);
       assert.calledTwice(setTimeoutSpy);
-
-      // verify sendMetric was called twice (once for each timeout)
-      assert.calledTwice(sendMetricSpy);
-      assert.calledWith(sendMetricSpy, BEHAVIORAL_METRICS.MEDIA_STILL_NOT_CONNECTED);
-
-      sendMetricSpy.restore();
     });
 
     it(`resolves gathering and connection state complete right after`, async () => {

package/test/unit/spec/media/properties.ts

@@ -41,23 +41,14 @@ describe('MediaProperties', () => {
   describe('waitForMediaConnectionConnected', () => {
     it('resolves if media connection is connected', async () => {
       const waitForMediaConnectionConnectedResult = new Defer();
-      const correlationId = 'aaaa-bbbb-cccc-dddd';
 
-      let capturedInstance;
-      const stub = sinon
+      sinon
         .stub(MediaConnectionAwaiter.prototype, 'waitForMediaConnectionConnected')
-        .callsFake(function () {
-          capturedInstance = this;
-          return waitForMediaConnectionConnectedResult.promise;
-        });
+        .returns(waitForMediaConnectionConnectedResult.promise);
 
       waitForMediaConnectionConnectedResult.resolve();
 
-      await mediaProperties.waitForMediaConnectionConnected(correlationId);
-
-      assert.calledOnce(stub);
-      assert.equal(capturedInstance.correlationId, correlationId);
-      assert.equal(capturedInstance.webrtcMediaConnection, mockMC);
+      await mediaProperties.waitForMediaConnectionConnected();
     });
     it('rejects if media connection is not connected', async () => {
       const waitForMediaConnectionConnectedResult = new Defer();

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -26,7 +26,6 @@ describe('plugin-meetings', () => {
         canLowerAllHands: null,
         canLowerSomeoneElsesHand: null,
         bothLeaveAndEndMeetingAvailable: null,
-        requireHostEndMeetingBeforeLeave: null,
         canEnableClosedCaption: null,
         canStartTranscribing: null,
         canStopTranscribing: null,
@@ -36,8 +35,8 @@ describe('plugin-meetings', () => {
         isLocalRecordingStarted: null,
         isLocalRecordingStopped: null,
         isLocalRecordingPaused: null,
-        isLocalStreamingStarted: null,
-        isLocalStreamingStopped: null,
+        isLocalStreamingStarted:null,
+        isLocalStreamingStopped:null,
         isManualCaptionActive: null,
         isPremiseRecordingEnabled: null,
         isSaveTranscriptsEnabled: null,
@@ -112,8 +111,6 @@ describe('plugin-meetings', () => {
         canMoveToLobby: null,
         canEnablePollingQA: null,
         canDisablePollingQA: null,
-        canAttendeeRequestAiAssistantEnabled: null,
-        isAttendeeRequestAiAssistantDeclinedAll: null,
 
         ...expected,
       };
@@ -152,7 +149,6 @@ describe('plugin-meetings', () => {
       'canLowerAllHands',
       'canLowerSomeoneElsesHand',
       'bothLeaveAndEndMeetingAvailable',
-      'requireHostEndMeetingBeforeLeave',
       'canEnableClosedCaption',
       'canStopTranscribing',
       'isClosedCaptionActive',
@@ -232,8 +228,6 @@ describe('plugin-meetings', () => {
       'canMoveToLobby',
       'canEnablePollingQA',
       'canDisablePollingQA',
-      'canAttendeeRequestAiAssistantEnabled',
-      'isAttendeeRequestAiAssistantDeclinedAll',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();