@webex/plugin-meetings 3.11.0 → 3.12.0

package/test/unit/spec/media/MediaConnectionAwaiter.ts

@@ -5,6 +5,8 @@ import {ConnectionState, MediaConnectionEventNames} from '@webex/internal-media-
 import testUtils from '../../../utils/testUtils';
 import {ICE_AND_DTLS_CONNECTION_TIMEOUT} from '@webex/plugin-meetings/src/constants';
 import MediaConnectionAwaiter from '../../../../src/media/MediaConnectionAwaiter';
+import Metrics from '../../../../src/metrics';
+import BEHAVIORAL_METRICS from '../../../../src/metrics/constants';
 
 describe('MediaConnectionAwaiter', () => {
   let mediaConnectionAwaiter;
@@ -14,18 +16,34 @@ describe('MediaConnectionAwaiter', () => {
   beforeEach(() => {
     clock = sinon.useFakeTimers();
 
+    const mockTransportReport = {
+      type: 'transport',
+      dtlsState: 'connecting',
+      iceState: 'checking',
+      packetsSent: 10,
+      packetsReceived: 5,
+    };
+
     mockMC = {
-      getStats: sinon.stub().resolves([]),
+      getStats: sinon.stub().resolves({
+        values: () => [mockTransportReport],
+      }),
       on: sinon.stub(),
       off: sinon.stub(),
       getConnectionState: sinon.stub().returns(ConnectionState.New),
       getIceGatheringState: sinon.stub().returns('new'),
       getIceConnectionState: sinon.stub().returns('new'),
       getPeerConnectionState: sinon.stub().returns('new'),
+      multistreamConnection: {
+        dataChannel: {
+          readyState: 'open',
+        },
+      },
     };
 
     mediaConnectionAwaiter = new MediaConnectionAwaiter({
       webrtcMediaConnection: mockMC,
+      correlationId: 'test-correlation-id',
     });
   });
 
@@ -44,6 +62,8 @@ describe('MediaConnectionAwaiter', () => {
     });
 
     it('rejects after timeout if ice state is not connected', async () => {
+      const sendMetricSpy = sinon.spy(Metrics, 'sendBehavioralMetric');
+
       mockMC.getConnectionState.returns(ConnectionState.Connecting);
       mockMC.getIceGatheringState.returns('gathering');
 
@@ -83,6 +103,18 @@ describe('MediaConnectionAwaiter', () => {
       assert.equal(promiseRejected, true);
 
       assert.calledThrice(mockMC.off);
+
+      assert.calledOnceWithExactly(sendMetricSpy, BEHAVIORAL_METRICS.MEDIA_STILL_NOT_CONNECTED, {
+        correlation_id: 'test-correlation-id',
+        numTransports: 1,
+        dtlsState: 'connecting',
+        iceState: 'checking',
+        packetsSent: 10,
+        packetsReceived: 5,
+        dataChannelState: 'open',
+      });
+
+      sendMetricSpy.restore();
     });
 
     it('rejects immediately if ice state is FAILED', async () => {
@@ -351,6 +383,8 @@ describe('MediaConnectionAwaiter', () => {
     });
 
     it(`reject with restart timer once if gathering state is not complete`, async () => {
+      const sendMetricSpy = sinon.spy(Metrics, 'sendBehavioralMetric');
+
       mockMC.getConnectionState.returns(ConnectionState.Connecting);
       mockMC.getIceGatheringState.returns('new');
 
@@ -390,6 +424,12 @@ describe('MediaConnectionAwaiter', () => {
 
       assert.calledOnce(clearTimeoutSpy);
       assert.calledTwice(setTimeoutSpy);
+
+      // verify sendMetric was called twice (once for each timeout)
+      assert.calledTwice(sendMetricSpy);
+      assert.calledWith(sendMetricSpy, BEHAVIORAL_METRICS.MEDIA_STILL_NOT_CONNECTED);
+
+      sendMetricSpy.restore();
     });
 
     it(`resolves gathering and connection state complete right after`, async () => {

package/test/unit/spec/media/properties.ts

@@ -41,14 +41,23 @@ describe('MediaProperties', () => {
   describe('waitForMediaConnectionConnected', () => {
     it('resolves if media connection is connected', async () => {
       const waitForMediaConnectionConnectedResult = new Defer();
+      const correlationId = 'aaaa-bbbb-cccc-dddd';
 
-      sinon
+      let capturedInstance;
+      const stub = sinon
         .stub(MediaConnectionAwaiter.prototype, 'waitForMediaConnectionConnected')
-        .returns(waitForMediaConnectionConnectedResult.promise);
+        .callsFake(function () {
+          capturedInstance = this;
+          return waitForMediaConnectionConnectedResult.promise;
+        });
 
       waitForMediaConnectionConnectedResult.resolve();
 
-      await mediaProperties.waitForMediaConnectionConnected();
+      await mediaProperties.waitForMediaConnectionConnected(correlationId);
+
+      assert.calledOnce(stub);
+      assert.equal(capturedInstance.correlationId, correlationId);
+      assert.equal(capturedInstance.webrtcMediaConnection, mockMC);
     });
     it('rejects if media connection is not connected', async () => {
       const waitForMediaConnectionConnectedResult = new Defer();

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -26,6 +26,7 @@ describe('plugin-meetings', () => {
         canLowerAllHands: null,
         canLowerSomeoneElsesHand: null,
         bothLeaveAndEndMeetingAvailable: null,
+        requireHostEndMeetingBeforeLeave: null,
         canEnableClosedCaption: null,
         canStartTranscribing: null,
         canStopTranscribing: null,
@@ -35,8 +36,8 @@ describe('plugin-meetings', () => {
         isLocalRecordingStarted: null,
         isLocalRecordingStopped: null,
         isLocalRecordingPaused: null,
-        isLocalStreamingStarted:null,
-        isLocalStreamingStopped:null,
+        isLocalStreamingStarted: null,
+        isLocalStreamingStopped: null,
         isManualCaptionActive: null,
         isPremiseRecordingEnabled: null,
         isSaveTranscriptsEnabled: null,
@@ -111,6 +112,8 @@ describe('plugin-meetings', () => {
         canMoveToLobby: null,
         canEnablePollingQA: null,
         canDisablePollingQA: null,
+        canAttendeeRequestAiAssistantEnabled: null,
+        isAttendeeRequestAiAssistantDeclinedAll: null,
 
         ...expected,
       };
@@ -149,6 +152,7 @@ describe('plugin-meetings', () => {
       'canLowerAllHands',
       'canLowerSomeoneElsesHand',
       'bothLeaveAndEndMeetingAvailable',
+      'requireHostEndMeetingBeforeLeave',
       'canEnableClosedCaption',
       'canStopTranscribing',
       'isClosedCaptionActive',
@@ -228,6 +232,8 @@ describe('plugin-meetings', () => {
       'canMoveToLobby',
       'canEnablePollingQA',
       'canDisablePollingQA',
+      'canAttendeeRequestAiAssistantEnabled',
+      'isAttendeeRequestAiAssistantDeclinedAll',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();