@webex/plugin-meetings 3.10.0-next.1 → 3.10.0-next.2

package/dist/webinar/index.js

@@ -458,7 +458,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
       }, _callee7);
     }))();
   },
-  version: "3.10.0-next.1"
+  version: "3.10.0-next.2"
 });
 var _default = exports.default = Webinar;
 //# sourceMappingURL=index.js.map

package/package.json

@@ -62,7 +62,7 @@
   "dependencies": {
     "@webex/common": "3.8.1-next.11",
     "@webex/event-dictionary-ts": "^1.0.1930",
-    "@webex/internal-media-core": "2.20.0",
+    "@webex/internal-media-core": "2.20.1",
     "@webex/internal-plugin-conversation": "3.9.0-next.8",
     "@webex/internal-plugin-device": "3.9.0-next.6",
     "@webex/internal-plugin-llm": "3.9.0-next.7",
@@ -71,11 +71,11 @@
     "@webex/internal-plugin-support": "3.9.0-next.9",
     "@webex/internal-plugin-user": "3.9.0-next.6",
     "@webex/internal-plugin-voicea": "3.9.0-next.8",
-    "@webex/media-helpers": "3.9.0-next.2",
+    "@webex/media-helpers": "3.10.0-next.1",
     "@webex/plugin-people": "3.9.0-next.7",
     "@webex/plugin-rooms": "3.9.0-next.8",
     "@webex/ts-sdp": "^1.8.1",
-    "@webex/web-capabilities": "^1.6.0",
+    "@webex/web-capabilities": "^1.7.1",
     "@webex/webex-core": "3.9.0-next.6",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
@@ -92,5 +92,5 @@
   "//": [
     "TODO: upgrade jwt-decode when moving to node 18"
   ],
-  "version": "3.10.0-next.1"
+  "version": "3.10.0-next.2"
 }

package/src/constants.ts

@@ -347,7 +347,7 @@ export const EVENT_TRIGGERS = {
   MEETING_SELF_LEFT: 'meeting:self:left',
   NETWORK_QUALITY: 'network:quality',
   MEDIA_NEGOTIATED: 'media:negotiated',
-  MEDIA_INBOUND_AUDIO_ISSUE_DETECTED: 'media:inboundAudio:issueDetected',
+  MEDIA_INBOUND_AUDIO_ISSUE_DETECTED: 'media:inboundAudio:issueDetected', // event.data: InboundAudioIssueEvent
   // the following events apply only to multistream media connections
   ACTIVE_SPEAKER_CHANGED: 'media:activeSpeakerChanged',
   REMOTE_VIDEO_SOURCE_COUNT_CHANGED: 'media:remoteVideoSourceCountChanged',

package/src/media/index.ts

@@ -194,6 +194,12 @@ Media.createMediaConnection = (
       config.stopIceGatheringAfterFirstRelayCandidate = stopIceGatheringAfterFirstRelayCandidate;
     }
 
+    if (BrowserInfo.isEdge() || BrowserInfo.isChrome()) {
+      // we need this for getting inbound audio metadata
+      // but the audioLevel that we use is only available on Chromium based browsers
+      config.enableInboundAudioLevelMonitoring = true;
+    }
+
     return new MultistreamRoapMediaConnection(
       config,
       meetingId,

package/src/meeting/index.ts

@@ -30,6 +30,7 @@ import {
   NetworkQualityMonitor,
   StatsMonitor,
   StatsMonitorEventNames,
+  InboundAudioIssueSubTypes,
 } from '@webex/internal-media-core';
 
 import {

package/test/unit/spec/media/index.ts

@@ -141,12 +141,12 @@ describe('createMediaConnection', () => {
     const roapMediaConnectionConstructorStub = sinon
       .stub(InternalMediaCoreModule, 'RoapMediaConnection')
       .returns(fakeRoapMediaConnection);
-  
+
     StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
-  
+
     const ENABLE_EXTMAP = false;
     const ENABLE_RTX = true;
-  
+
     Media.createMediaConnection(false, 'sendonly-debug-id', 'meetingId', {
       mediaProperties: {
         mediaDirection: {
@@ -168,7 +168,7 @@ describe('createMediaConnection', () => {
       turnServerInfo: undefined,
       iceCandidatesTimeout: undefined,
     });
-  
+
     assert.calledWith(
       roapMediaConnectionConstructorStub,
       sinon.match.any,
@@ -194,12 +194,12 @@ describe('createMediaConnection', () => {
     const roapMediaConnectionConstructorStub = sinon
       .stub(InternalMediaCoreModule, 'RoapMediaConnection')
       .returns(fakeRoapMediaConnection);
-  
+
     StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
-  
+
     const ENABLE_EXTMAP = true;
     const ENABLE_RTX = false;
-  
+
     Media.createMediaConnection(false, 'recvonly-debug-id', 'meetingId', {
       mediaProperties: {
         mediaDirection: {
@@ -221,7 +221,7 @@ describe('createMediaConnection', () => {
       turnServerInfo: undefined,
       iceCandidatesTimeout: undefined,
     });
-  
+
     assert.calledWith(
       roapMediaConnectionConstructorStub,
       sinon.match.any,
@@ -242,7 +242,6 @@ describe('createMediaConnection', () => {
       'recvonly-debug-id'
     );
   });
-  
 
   it('creates a MultistreamRoapMediaConnection when multistream is enabled', () => {
     const multistreamRoapMediaConnectionConstructorStub = sinon
@@ -511,6 +510,138 @@ describe('createMediaConnection', () => {
     );
   });
 
+  const testEnableInboundAudioLevelMonitoring = (
+    testName: string,
+    browserStubs: {isChrome?: boolean; isEdge?: boolean; isFirefox?: boolean},
+    isMultistream: boolean,
+    expectedConfig: object,
+    additionalOptions = {}
+  ) => {
+    it(testName, () => {
+      const connectionConstructorStub = isMultistream
+        ? sinon.stub(InternalMediaCoreModule, 'MultistreamRoapMediaConnection')
+        : sinon.stub(InternalMediaCoreModule, 'RoapMediaConnection');
+
+      connectionConstructorStub.returns(fakeRoapMediaConnection);
+
+      // Set up browser stubs
+      sinon.stub(BrowserInfo, 'isChrome').returns(browserStubs.isChrome || false);
+      sinon.stub(BrowserInfo, 'isEdge').returns(browserStubs.isEdge || false);
+      sinon.stub(BrowserInfo, 'isFirefox').returns(browserStubs.isFirefox || false);
+
+      const baseOptions = {
+        mediaProperties: {
+          mediaDirection: {
+            sendAudio: true,
+            sendVideo: true,
+            sendShare: false,
+            receiveAudio: true,
+            receiveVideo: true,
+            receiveShare: true,
+          },
+          ...(isMultistream
+            ? {}
+            : {
+                audioStream: fakeAudioStream,
+                videoStream: fakeVideoStream,
+                shareVideoTrack: null,
+                shareAudioTrack: null,
+              }),
+        },
+        ...(isMultistream
+          ? {}
+          : {
+              remoteQualityLevel: 'HIGH',
+              enableRtx: true,
+              enableExtmap: true,
+            }),
+        ...additionalOptions,
+      };
+
+      if (!isMultistream) {
+        StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
+      }
+
+      Media.createMediaConnection(isMultistream, 'debug string', 'meeting id', baseOptions);
+
+      if (isMultistream) {
+        assert.calledOnceWithExactly(
+          connectionConstructorStub,
+          expectedConfig,
+          'meeting id',
+          sinon.match.func,
+          sinon.match.func,
+          sinon.match.func
+        );
+      } else {
+        assert.calledOnceWithExactly(
+          connectionConstructorStub,
+          expectedConfig,
+          sinon.match.object,
+          'debug string'
+        );
+      }
+    });
+  };
+
+  testEnableInboundAudioLevelMonitoring(
+    'enables enableInboundAudioLevelMonitoring for multistream when browser is Chrome',
+    {isChrome: true},
+    true,
+    {
+      iceServers: [],
+      disableAudioTwcc: true,
+      enableInboundAudioLevelMonitoring: true,
+    }
+  );
+
+  testEnableInboundAudioLevelMonitoring(
+    'enables enableInboundAudioLevelMonitoring for multistream when browser is Edge',
+    {isEdge: true},
+    true,
+    {
+      iceServers: [],
+      disableAudioTwcc: true,
+      enableInboundAudioLevelMonitoring: true,
+    }
+  );
+
+  testEnableInboundAudioLevelMonitoring(
+    'does not enable enableInboundAudioLevelMonitoring for multistream when browser is Firefox',
+    {isFirefox: true},
+    true,
+    {
+      iceServers: [],
+      disableAudioTwcc: true,
+      doFullIce: true,
+      stopIceGatheringAfterFirstRelayCandidate: undefined,
+    }
+  );
+
+  testEnableInboundAudioLevelMonitoring(
+    'does not enable enableInboundAudioLevelMonitoring for non-multistream connections even when browser is Chrome',
+    {isChrome: true},
+    false,
+    {
+      iceServers: [],
+      iceCandidatesTimeout: undefined,
+      skipInactiveTransceivers: false,
+      requireH264: true,
+      sdpMunging: {
+        convertPort9to0: false,
+        addContentSlides: true,
+        bandwidthLimits: {
+          audio: 123,
+          video: 456,
+        },
+        startBitrate: 999,
+        periodicKeyframes: 20,
+        disableExtmap: false,
+        disableRtx: false,
+      },
+    }
+  );
+
   [
     {testCase: 'turnServerInfo is undefined', turnServerInfo: undefined},
     {

package/test/unit/spec/meetings/index.js

@@ -690,11 +690,9 @@ describe('plugin-meetings', () => {
           assert.deepEqual(result.options, {
             mode: 'BLUR',
             blurStrength: 'STRONG',
-            generator: 'worker',
             quality: 'LOW',
             authToken: 'fake_token',
             mirror: false,
-            canvasResolutionScaling: 1,
           });
           assert.exists(result.enable);
           assert.exists(result.disable);