@webex/plugin-meetings 3.0.0 → 3.1.0-next.10

package/test/integration/spec/journey.js

@@ -432,11 +432,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.microphone.setMuted(true);
+        localStreams.alice.microphone.setUserMuted(true);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.microphone.muted, true);
+        assert.equal(localStreams.alice.microphone.userMuted, true);
       });
 
       it('alice Audio unMute ', async () => {
@@ -451,11 +451,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.microphone.setMuted(false);
+        localStreams.alice.microphone.setUserMuted(false);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.microphone.muted, false);
+        assert.equal(localStreams.alice.microphone.userMuted, false);
       });
 
       it('alice video mute', async () => {
@@ -470,11 +470,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.camera.setMuted(true);
+        localStreams.alice.camera.setUserMuted(true);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.camera.muted, true);
+        assert.equal(localStreams.alice.camera.userMuted, true);
       });
 
       it('alice video unmute', async () => {
@@ -489,11 +489,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.camera.setMuted(false);
+        localStreams.alice.camera.setUserMuted(false);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.camera.muted, false);
+        assert.equal(localStreams.alice.camera.userMuted, false);
       });
 
       it('alice update Audio', async () => {
@@ -574,11 +574,11 @@ skipInNode(describe)('plugin-meetings', () => {
         ]);
 
         // first bob mutes himself
-        localStreams.bob.microphone.setMuted(true);
+        localStreams.bob.microphone.setUserMuted(true);
 
         await membersUpdate;
 
-        assert.equal(localStreams.bob.microphone.muted, true);
+        assert.equal(localStreams.bob.microphone.userMuted, true);
 
         // now alice tries to unmmute bob
         await testUtils.delayedPromise(alice.meeting.mute(bob.meeting.members.selfId, false))
@@ -593,7 +593,7 @@ skipInNode(describe)('plugin-meetings', () => {
             assert.fail('bob received unexpected meeting:self:unmutedByOthers event');
           })
           .catch(() => {
-            assert.equal(localStreams.bob.microphone.muted, true);
+            assert.equal(localStreams.bob.microphone.userMuted, true);
           });
       });
 
@@ -607,11 +607,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: alice.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.bob.microphone.setMuted(false);
+        localStreams.bob.microphone.setUserMuted(false);
 
         await membersUpdate;
 
-        assert.equal(localStreams.bob.microphone.muted, false);
+        assert.equal(localStreams.bob.microphone.userMuted, false);
       });
 
       it('alice shares the screen with highFrameRate', async () => {
@@ -871,7 +871,7 @@ skipInNode(describe)('plugin-meetings', () => {
           assert.equal(bob.meeting.shareStatus, 'whiteboard_share_active');
         }));
 
-      it('alice adds chris as guest to 1:1 meeting', async() =>
+      it('alice adds chris as guest to 1:1 meeting', () =>
         Promise.all([
           testUtils.delayedPromise(alice.meeting.invite({emailAddress: chris.emailAddress})),
           testUtils.waitForEvents([

package/test/integration/spec/space-meeting.js

@@ -34,7 +34,7 @@ skipInNode(describe)('plugin-meetings', () => {
   describe('space-meeting', () => {
     let space = null;
 
-    before(async () =>
+    before(() =>
       webexTestUsers
         .generateTestUsers({
           count: 4,

package/test/unit/spec/interpretation/index.ts

@@ -1,6 +1,7 @@
 import {assert, expect} from '@webex/test-helper-chai';
 import LoggerProxy from '@webex/plugin-meetings/src/common/logs/logger-proxy';
 import SimultaneousInterpretation from '@webex/plugin-meetings/src/interpretation';
+import SILanguage from '@webex/plugin-meetings/src/interpretation/siLanguage';
 import MockWebex from '@webex/test-helper-mock-webex';
 import sinon from 'sinon';
 
@@ -123,22 +124,57 @@ describe('plugin-meetings', () => {
             receiveLanguage: 'en',
             order: 0,
           }, selfParticipantId: '123'};
-        interpretation.updateSelfInterpretation(sampleData);
+        assert.equal(interpretation.updateSelfInterpretation(sampleData), true);
         assert.equal(interpretation.originalLanguage, 'en');
         assert.equal(interpretation.sourceLanguage, 'en');
         assert.equal(interpretation.targetLanguage, 'zh');
         assert.equal(interpretation.receiveLanguage, 'en');
         assert.equal(interpretation.isActive, true);
         assert.equal(interpretation.order, 0);
+        assert.equal(interpretation.selfIsInterpreter, true);
 
         sampleData.interpretation = {
           originalLanguage: 'en',
+          targetLanguage: 'zh',
           order: 0,
         };
-        interpretation.updateSelfInterpretation(sampleData);
+        assert.equal(interpretation.updateSelfInterpretation(sampleData), false);
         assert.equal(interpretation.sourceLanguage, undefined);
-        assert.equal(interpretation.targetLanguage, undefined);
+        assert.equal(interpretation.targetLanguage, 'zh');
         assert.equal(interpretation.receiveLanguage, undefined);
+        assert.equal(interpretation.selfIsInterpreter, true);
+
+        sampleData.interpretation = {
+          order: 0,
+        };
+        assert.equal(interpretation.updateSelfInterpretation(sampleData), true);
+        assert.equal(interpretation.originalLanguage, undefined);
+        assert.equal(interpretation.targetLanguage, undefined);
+        assert.equal(interpretation.selfIsInterpreter, false);
+      });
+    });
+
+    describe('#getTargetLanguageCode', () => {
+      it('get target language id if self is interpreter', () => {
+        interpretation.siLanguages.set([{
+          languageCode: 24,
+          languageName: "fr"
+        },
+          {
+            languageCode: 20,
+            languageName: "en"
+          }]);
+        interpretation.selfIsInterpreter = true;
+        interpretation.targetLanguage = 'fr';
+
+        assert.equal(interpretation.getTargetLanguageCode(), 24);
+
+        interpretation.targetLanguage = 'en';
+        assert.equal(interpretation.getTargetLanguageCode(), 20);
+
+        interpretation.selfIsInterpreter = false;
+        assert.equal(interpretation.getTargetLanguageCode(), 0);
+
       });
     });
 

package/test/unit/spec/locus-info/controlsUtils.js

@@ -269,6 +269,26 @@ describe('plugin-meetings', () => {
         assert.equal(updates.hasInterpretationChanged, false);
       });
 
+      it('returns hasManualCaptionChanged = true when it has changed', () => {
+        const newControls = {
+          manualCaptionControl: {enabled: false},
+        };
+
+        const {updates} = ControlsUtils.getControls({manualCaptionControl: {enabled: true}}, newControls);
+
+        assert.equal(updates.hasManualCaptionChanged, true);
+      });
+
+      it('returns hasManualCaptionChanged = false when it has not changed', () => {
+        const newControls = {
+          manualCaptionControl: {enabled: true},
+        };
+
+        const {updates} = ControlsUtils.getControls({manualCaptionControl: {enabled: true}}, newControls);
+
+        assert.equal(updates.hasManualCaptionChanged, false);
+      });
+
       describe('videoEnabled', () => {
         const testVideoEnabled = (oldControls, newControls, updatedProperty) => {
           const result = ControlsUtils.getControls(oldControls, newControls);

package/test/unit/spec/locus-info/index.js

@@ -24,7 +24,7 @@ import {
   _MEETING_,
 } from '../../../../src/constants';
 
-import {self, selfWithInactivity} from './lib/selfConstant';
+import {self, selfWithInactivity} from './selfConstant';
 
 describe('plugin-meetings', () => {
   describe('LocusInfo index', () => {
@@ -467,6 +467,27 @@ describe('plugin-meetings', () => {
         );
       });
 
+      it('should update the manual caption state', () => {
+        locusInfo.emitScoped = sinon.stub();
+        locusInfo.controls = {
+          manualCaptionControl: {enabled: false},
+        };
+
+        locusInfo.updateControls({manualCaptionControl: { enabled: true, }});
+
+        assert.calledWith(
+          locusInfo.emitScoped,
+          {
+            file: 'locus-info',
+            function: 'updateControls',
+          },
+          LOCUSINFO.EVENTS.CONTROLS_MEETING_MANUAL_CAPTION_UPDATED,
+          {
+            enabled: true,
+          }
+        );
+      });
+
       it('should update the meetingContainerURL from null', () => {
         locusInfo.controls = {
           meetingContainer: {meetingContainerUrl: null},
@@ -1385,7 +1406,7 @@ describe('plugin-meetings', () => {
             function: 'updateMeetingInfo',
           },
           LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
-          payload
+          payload,
         ];
 
         if (expected) {
@@ -1404,7 +1425,7 @@ describe('plugin-meetings', () => {
             function: 'updateMeetingInfo',
           },
           LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
-          payload
+          payload,
         ];
 
         if (expected) {
@@ -1426,8 +1447,7 @@ describe('plugin-meetings', () => {
         */
         sinon.stub(locusInfo, 'emitScoped').callsFake(() => {
           assert.deepEqual(mockMeeting, expectedMeeting);
-        })
-
+        });
 
         // set the info initially as locusInfo.info starts as undefined
         expectedMeeting = {
@@ -1907,7 +1927,7 @@ describe('plugin-meetings', () => {
         locusInfo.locusParser.workingCopy = {
           syncUrl: 'current sync url',
         };
-  
+
         locusInfo.applyLocusDeltaData(LOCUS_URL_CHANGED, fakeLocus, meeting);
         assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, {url: 'current sync url'});
       });
@@ -1970,8 +1990,12 @@ describe('plugin-meetings', () => {
           }).then(() => {
             assert.calledTwice(meeting.meetingRequest.getLocusDTO);
 
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [{url: 'deltaSyncUrl'}]);
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [{url: 'fullSyncUrl'}]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [
+              {url: 'deltaSyncUrl'},
+            ]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [
+              {url: 'fullSyncUrl'},
+            ]);
 
             assert.calledWith(sendBehavioralMetricStub, 'js_sdk_locus_delta_sync_failed', {
               correlationId: meeting.correlationId,
@@ -1999,8 +2023,12 @@ describe('plugin-meetings', () => {
           }).then(() => {
             assert.calledTwice(meeting.meetingRequest.getLocusDTO);
 
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [{url: 'deltaSyncUrl'}]);
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [{url: 'fullSyncUrl'}]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [
+              {url: 'deltaSyncUrl'},
+            ]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [
+              {url: 'fullSyncUrl'},
+            ]);
 
             assert.calledWith(sendBehavioralMetricStub, 'js_sdk_locus_delta_sync_failed', {
               correlationId: meeting.correlationId,
@@ -2084,7 +2112,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         locusInfo.getTheLocusToUpdate(newLocus);
-        assert.notCalled(locusInfo.clearMainSessionLocusCache)
+        assert.notCalled(locusInfo.clearMainSessionLocusCache);
       });
 
       it('return the new locus if return to main session but no cache and do not clear main session cache', () => {
@@ -2106,7 +2134,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         locusInfo.getTheLocusToUpdate(newLocus);
-        assert.notCalled(locusInfo.clearMainSessionLocusCache)
+        assert.notCalled(locusInfo.clearMainSessionLocusCache);
       });
 
       it('return the new locus if not return to main session and clear main session cache', () => {
@@ -2116,9 +2144,9 @@ describe('plugin-meetings', () => {
               sessionType: 'MAIN',
             },
           },
-          self: {removed: true}
+          self: {removed: true},
         };
-        locusInfo.fullState = {state: 'ACTIVE'}
+        locusInfo.fullState = {state: 'ACTIVE'};
         locusInfo.controls = {
           breakout: {
             sessionType: 'MAIN',
@@ -2134,7 +2162,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         const result = locusInfo.getTheLocusToUpdate(newLocus);
-        assert.calledOnce(locusInfo.clearMainSessionLocusCache)
+        assert.calledOnce(locusInfo.clearMainSessionLocusCache);
 
         assert.deepEqual(result, newLocus);
       });
@@ -2146,9 +2174,9 @@ describe('plugin-meetings', () => {
               sessionType: 'MAIN',
             },
           },
-          self: {removed: undefined}
+          self: {removed: undefined},
         };
-        locusInfo.fullState = {state: 'ACTIVE'}
+        locusInfo.fullState = {state: 'ACTIVE'};
         locusInfo.controls = {
           breakout: {
             sessionType: 'MAIN',
@@ -2164,7 +2192,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         locusInfo.getTheLocusToUpdate(newLocus);
-        assert.notCalled(locusInfo.clearMainSessionLocusCache)
+        assert.notCalled(locusInfo.clearMainSessionLocusCache);
       });
     });
 
@@ -2611,7 +2639,9 @@ describe('plugin-meetings', () => {
         // send an out-of-order delta
         locusInfo.handleLocusDelta(oooDelta, mockMeeting);
 
-        assert.calledOnceWithExactly(sendBehavioralMetricStub, 'js_sdk_locus_delta_ooo', { stack: sinon.match.any})
+        assert.calledOnceWithExactly(sendBehavioralMetricStub, 'js_sdk_locus_delta_ooo', {
+          stack: sinon.match.any,
+        });
 
         await clock.tickAsync(12499);
         await testUtils.flushPromises();

package/test/unit/spec/locus-info/mediaSharesUtils.ts

@@ -20,6 +20,15 @@ describe('getContentUrl', () => {
   });
 });
 
+describe('getContentResourceType', () => {
+  it('getContentResourceType return correct resourceType value', () => {
+    const stub = Sinon.stub(MediaSharesUtils, 'extractContent').returns({resourceType:'resourceType'});
+    const resourceType = MediaSharesUtils.getContentResourceType();
+    assert.equal(resourceType,'resourceType');
+    stub.restore();
+  });
+});
+
 describe('getContentBeneficiaryDeviceUrl', () => {
   it('getContentBeneficiaryDeviceUrl return correct deviceUrl value', () => {
     const mockContentBeneficiaryDeviceUrl = "https://wdm-a.wbx2.com/wdm/api/v1/devices/e9ffd8a1-1fae-42d1-afbe-013e951f93ab"

package/test/unit/spec/locus-info/selfUtils.js

@@ -3,7 +3,7 @@ import Sinon from 'sinon';
 import {cloneDeep} from 'lodash';
 import SelfUtils from '@webex/plugin-meetings/src/locus-info/selfUtils';
 
-import {self} from './lib/selfConstant';
+import {self} from './selfConstant';
 
 describe('plugin-meetings', () => {
   describe('selfUtils', () => {
@@ -150,8 +150,7 @@ describe('plugin-meetings', () => {
 
       it('should return false if no breakouts in current', () => {
         const current = {
-          breakoutSessions: {
-          },
+          breakoutSessions: {},
         };
         const previous = {
           breakoutSessions: {
@@ -293,7 +292,7 @@ describe('plugin-meetings', () => {
           const clonedSelf = cloneDeep(self);
 
           clonedSelf.controls.audio.requestedToUnmute = true;
-          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z'
+          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z';
 
           const {updates} = SelfUtils.getSelves(self, clonedSelf);
 
@@ -345,6 +344,41 @@ describe('plugin-meetings', () => {
     });
   });
 
+  describe('mutedByOthersChanged', () => {
+    it('throws an error if changedSelf is not provided', function() {
+      assert.throws(() => SelfUtils.mutedByOthersChanged({}, null), 'New self must be defined to determine if self was muted by others.');
+    });
+
+    it('return false when oldSelf is not defined', function() {
+      assert.equal(SelfUtils.mutedByOthersChanged(null, { remoteMuted: false }), false);
+    });
+
+    it('should return true when remoteMuted is true on entry', function() {
+      assert.equal(SelfUtils.mutedByOthersChanged(null, { remoteMuted: true }), true);
+    });
+
+    it('should return false when selfIdentity and modifiedBy are the same', function() {
+      assert.equal(SelfUtils.mutedByOthersChanged(
+        { remoteMuted: false },
+        { remoteMuted: true, selfIdentity: 'user1', modifiedBy: 'user1' }
+      ), false);
+    });
+
+    it('should return true when remoteMuted values are different', function() {
+      assert.equal(SelfUtils.mutedByOthersChanged(
+        { remoteMuted: false },
+        { remoteMuted: true, selfIdentity: 'user1', modifiedBy: 'user2' }
+      ), true);
+    });
+
+    it('should return true when remoteMuted is true and unmuteAllowed has changed', function() {
+      assert.equal(SelfUtils.mutedByOthersChanged(
+        { remoteMuted: true, unmuteAllowed: false },
+        { remoteMuted: true, unmuteAllowed: true, selfIdentity: 'user1', modifiedBy: 'user2' }
+      ), true);
+    });
+  });
+
   describe('videoMutedByOthersChanged', () => {
     it('returns true if changed', () => {
       assert.equal(
@@ -371,23 +405,18 @@ describe('plugin-meetings', () => {
     const clonedSelf = cloneDeep(self);
 
     it('get breakoutMoveId works', () => {
-
       assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(self, deviceId), breakoutMoveId);
-
     });
 
     it('replaces is empty', () => {
-
       clonedSelf.devices[0].replaces = undefined;
       assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(clonedSelf, deviceId), null);
-
     });
 
     it('no self or self.devices is not array', () => {
-
       assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(undefined, deviceId), null);
 
-      clonedSelf.devices =     {
+      clonedSelf.devices = {
         url: 'https://wdm-a.wbx2.com/wdm/api/v1/devices/20eabde3-4254-48da-9a24',
         deviceType: 'WEB',
         mediaSessionsExternal: false,
@@ -395,10 +424,11 @@ describe('plugin-meetings', () => {
           {
             breakoutMoveId: 'e5caeb2c-ffcc-4e06-a08a-1122e7710398',
             lastActive: '2023-05-04T07:14:32.068Z',
-            locusUrl: 'https://locus-alpha-apdx.prod.meetapi.webex.com/locus/api/v1/loci/495061ca-7b3c-3b77-85ff-4e1bd58600d1',
+            locusUrl:
+              'https://locus-alpha-apdx.prod.meetapi.webex.com/locus/api/v1/loci/495061ca-7b3c-3b77-85ff-4e1bd58600d1',
             replacedAt: '2023-05-04T07:16:04.905Z',
             sessionId: 'be3147d4-c318-86d8-7611-8d24beaaca8d',
-          }
+          },
         ],
         state: 'JOINED',
       };