@webex/plugin-meetings 3.0.0-stream-classes.4 → 3.0.0

package/test/unit/spec/locus-info/parser.js

@@ -5,6 +5,7 @@
 import sinon from 'sinon';
 import {assert} from '@webex/test-helper-chai';
 import LocusDeltaParser from '@webex/plugin-meetings/src/locus-info/parser';
+import Metrics from '@webex/plugin-meetings/src/metrics';
 
 import basicSequenceComparisons from './lib/BasicSeqCmp.json';
 import sequenceComparisons from './lib/SeqCmp';
@@ -50,9 +51,11 @@ describe('locus-info/parser', () => {
     });
 
     describe('delta sequence comparisons', () => {
-      const {DESYNC, USE_CURRENT, USE_INCOMING} = LocusDeltaParser.loci;
+      const {DESYNC, USE_CURRENT, USE_INCOMING, WAIT, LOCUS_URL_CHANGED} = LocusDeltaParser.loci;
       const {extractComparisonState: extract} = LocusDeltaParser;
 
+      sinon.stub(Metrics, 'sendBehavioralMetric');
+      
       function translate(action) {
         switch (action) {
           case 'ACCEPT_NEW':
@@ -61,6 +64,10 @@ describe('locus-info/parser', () => {
             return USE_CURRENT;
           case 'DESYNC':
             return DESYNC;
+          case 'WAIT':
+            return WAIT;
+          case 'LOCUS_URL_CHANGED':
+            return LOCUS_URL_CHANGED;
           default:
             throw new Error(`${action} not recognized`);
         }
@@ -73,10 +80,12 @@ describe('locus-info/parser', () => {
 
         const current = {
           sequence: sequenceComparisons.sequences[currentKey],
+          url: sequenceComparisons.update_actions[key].currentUrl,
         };
         const incoming = {
           sequence: sequenceComparisons.sequences[incomingKey],
           baseSequence: sequenceComparisons.sequences[baseKey],
+          url: sequenceComparisons.update_actions[key].incomingUrl,
         };
         const comparison = LocusDeltaParser.compare(current, incoming);
         const action = extract(comparison);
@@ -87,6 +96,8 @@ describe('locus-info/parser', () => {
           assert.equal(action, translate(result));
         });
       });
+
+      Metrics.sendBehavioralMetric.restore();
     });
   });
 
@@ -106,7 +117,7 @@ describe('locus-info/parser', () => {
         return burst;
       })();
 
-      parser.onDeltaAction = true;
+      parser.onDeltaAction = sinon.stub();
       parser.processDeltaEvent = function () {
         const fakeLoci = this.queue.dequeue();
 
@@ -133,7 +144,11 @@ describe('locus-info/parser', () => {
   });
 
   describe('Processes delta events correctly', () => {
-    const NEW_LOCI = 'NEW LOCI';
+    const CURRENT_LOCI = {sequence: {entries: [100]}, url: 'CURRENT LOCI', baseSequence: {
+      "entries": [100], "rangeStart": 100, "rangeEnd": 100}};
+    const NEW_LOCI = {sequence: {entries: [200]}, url: 'NEW LOCI', baseSequence: {
+      "entries": [200], "rangeStart": 200, "rangeEnd": 200}};
+
     let sandbox = null;
     let parser;
 
@@ -142,6 +157,7 @@ describe('locus-info/parser', () => {
       parser = new LocusDeltaParser();
       sandbox.stub(parser, 'isValidLocus').returns(true);
       parser.queue.dequeue = sandbox.stub().returns(NEW_LOCI);
+      parser.onDeltaAction = sandbox.stub();
     });
 
     afterEach(() => {
@@ -153,7 +169,7 @@ describe('locus-info/parser', () => {
       const {DESYNC} = LocusDeltaParser.loci;
 
       parser.pause = sandbox.stub();
-      LocusDeltaParser.compare = sandbox.stub().returns(DESYNC);
+      sandbox.stub(LocusDeltaParser, 'compare').returns(DESYNC);
 
       parser.processDeltaEvent();
 
@@ -164,7 +180,7 @@ describe('locus-info/parser', () => {
       const {USE_INCOMING} = LocusDeltaParser.loci;
 
       parser.workingCopy = null;
-      LocusDeltaParser.compare = sandbox.stub().returns(USE_INCOMING);
+      sandbox.stub(LocusDeltaParser, 'compare').returns(USE_INCOMING);
 
       parser.processDeltaEvent();
 
@@ -175,8 +191,7 @@ describe('locus-info/parser', () => {
       const {USE_INCOMING} = LocusDeltaParser.loci;
       const lociComparison = USE_INCOMING;
 
-      LocusDeltaParser.compare = sandbox.stub().returns(lociComparison);
-      parser.onDeltaAction = sandbox.stub();
+      sandbox.stub(LocusDeltaParser, 'compare').returns(lociComparison);
 
       parser.processDeltaEvent();
 
@@ -186,7 +201,7 @@ describe('locus-info/parser', () => {
     it('should call nextEvent()', () => {
       const {USE_INCOMING} = LocusDeltaParser.loci;
 
-      LocusDeltaParser.compare = sandbox.stub().returns(USE_INCOMING);
+      sandbox.stub(LocusDeltaParser, 'compare').returns(USE_INCOMING);
       parser.nextEvent = sandbox.stub();
 
       parser.processDeltaEvent();
@@ -197,7 +212,8 @@ describe('locus-info/parser', () => {
     it('should not call compare() if locus is invalid', () => {
       const {USE_INCOMING} = LocusDeltaParser.loci;
 
-      LocusDeltaParser.compare = sandbox.stub().returns(USE_INCOMING);
+      sandbox.stub(LocusDeltaParser, 'compare').returns(USE_INCOMING);
+
       // restore the original method
       parser.isValidLocus.restore();
       parser.isValidLocus.bind(parser);
@@ -208,9 +224,8 @@ describe('locus-info/parser', () => {
     });
 
     it('processDeltaEvent() should take next item in queue', () => {
-      // restore the original method
-      parser.queue.dequeue = sandbox.stub();
-
+      parser.workingCopy = CURRENT_LOCI;
+      
       parser.processDeltaEvent();
 
       assert.calledOnce(parser.queue.dequeue);
@@ -228,7 +243,7 @@ describe('locus-info/parser', () => {
       assert.equal(comparisonResults, expectedResults);
     });
 
-    it('shoud be able to unpack comparison results', () => {
+    it('should be able to unpack comparison results', () => {
       const {extractComparisonState: extract} = LocusDeltaParser;
 
       const comparisonResults = 'value04:value03:value:02:value01';
@@ -236,6 +251,32 @@ describe('locus-info/parser', () => {
 
       assert.equal(lastResult, 'value04');
     });
+    
+    it('replaces current loci when the locus URL changes and incoming sequence is later, even when baseSequence doesn\'t match', () => {
+      const {USE_INCOMING} = LocusDeltaParser.loci;
+
+      parser.queue.dequeue = sandbox.stub().returns(NEW_LOCI);
+      parser.onDeltaAction = sandbox.stub();
+      parser.workingCopy = CURRENT_LOCI;
+      parser.triggerSync = sandbox.stub();
+
+      parser.processDeltaEvent();
+
+      assert.equal(parser.workingCopy, NEW_LOCI);
+    });
+
+    it('does not replace current loci when the locus URL changes but incoming sequence is not later', () => {
+      const {USE_INCOMING} = LocusDeltaParser.loci;
+      const laterLoci = {...CURRENT_LOCI, sequence: {entries: [300]}};
+
+      parser.queue.dequeue = sandbox.stub().returns(NEW_LOCI);
+      parser.onDeltaAction = sandbox.stub();
+      parser.workingCopy = laterLoci;
+
+      parser.processDeltaEvent();
+
+      assert.equal(parser.workingCopy, laterLoci);
+    });
   });
 
   describe('Full Locus handling', () => {

package/test/unit/spec/locus-info/selfUtils.js

@@ -3,7 +3,7 @@ import Sinon from 'sinon';
 import {cloneDeep} from 'lodash';
 import SelfUtils from '@webex/plugin-meetings/src/locus-info/selfUtils';
 
-import {self} from './selfConstant';
+import {self} from './lib/selfConstant';
 
 describe('plugin-meetings', () => {
   describe('selfUtils', () => {

package/test/unit/spec/media/index.ts

@@ -7,6 +7,10 @@ import {forEach} from 'lodash';
 import MockWebex from '@webex/test-helper-mock-webex';
 
 describe('createMediaConnection', () => {
+  let clock;
+  beforeEach(() => {
+    clock = sinon.useFakeTimers();
+  });
   const webex = MockWebex();
 
   const fakeRoapMediaConnection = {
@@ -16,19 +20,36 @@ describe('createMediaConnection', () => {
     id: 'any fake track'
   }
   const fakeAudioStream = {
-    outputTrack: fakeTrack,
+    outputStream: {
+      getTracks: () => {
+        return [fakeTrack];
+      }
+    }
   };
   const fakeVideoStream = {
-    outputTrack: fakeTrack,
+    outputStream: {
+      getTracks: () => {
+        return [fakeTrack];
+      }
+    }
   };
   const fakeShareVideoStream = {
-    outputTrack: fakeTrack,
+    outputStream: {
+      getTracks: () => {
+        return [fakeTrack];
+      }
+    }
   };
   const fakeShareAudioStream = {
-    outputTrack: fakeTrack,
+    outputStream: {
+      getTracks: () => {
+        return [fakeTrack];
+      }
+    }
   };
   afterEach(() => {
     sinon.restore();
+    clock.uninstall()
   });
 
   it('creates a RoapMediaConnection when multistream is disabled', () => {

package/test/unit/spec/media/properties.ts

@@ -4,7 +4,7 @@ import {ConnectionState, Event} from '@webex/internal-media-core';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
 import MediaUtil from '@webex/plugin-meetings/src/media/util';
 import testUtils from '../../../utils/testUtils';
-import {PC_BAIL_TIMEOUT} from '@webex/plugin-meetings/src/constants';
+import {ICE_AND_DTLS_CONNECTION_TIMEOUT} from '@webex/plugin-meetings/src/constants';
 import {Defer} from '@webex/common';
 
 describe('MediaProperties', () => {
@@ -52,7 +52,7 @@ describe('MediaProperties', () => {
       assert.equal(promiseResolved, false);
       assert.equal(promiseRejected, false);
 
-      await clock.tickAsync(PC_BAIL_TIMEOUT);
+      await clock.tickAsync(ICE_AND_DTLS_CONNECTION_TIMEOUT);
       await testUtils.flushPromises();
 
       assert.equal(promiseResolved, false);

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -67,12 +67,14 @@ describe('plugin-meetings', () => {
         canShareDesktop: null,
         canShareContent: null,
         canTransferFile: null,
+        canChat: null,
         canDoVideo: null,
         canAnnotate: null,
         canUseVoip: null,
         supportHQV: null,
         supportHDV: null,
         canShareWhiteBoard: null,
+        enforceVirtualBackground: null,
         ...expected,
       };
 
@@ -145,12 +147,14 @@ describe('plugin-meetings', () => {
       'canShareDesktop',
       'canShareContent',
       'canTransferFile',
+      'canChat',
       'canDoVideo',
       'canAnnotate',
       'canUseVoip',
       'supportHQV',
       'supportHDV',
       'canShareWhiteBoard',
+      'enforceVirtualBackground',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();