@webex/plugin-meetings 3.0.0-next.2 → 3.0.0-next.21

package/test/integration/spec/journey.js

@@ -432,11 +432,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.microphone.setMuted(true);
+        localStreams.alice.microphone.setUserMuted(true);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.microphone.muted, true);
+        assert.equal(localStreams.alice.microphone.userMuted, true);
       });
 
       it('alice Audio unMute ', async () => {
@@ -451,11 +451,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.microphone.setMuted(false);
+        localStreams.alice.microphone.setUserMuted(false);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.microphone.muted, false);
+        assert.equal(localStreams.alice.microphone.userMuted, false);
       });
 
       it('alice video mute', async () => {
@@ -470,11 +470,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.camera.setMuted(true);
+        localStreams.alice.camera.setUserMuted(true);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.camera.muted, true);
+        assert.equal(localStreams.alice.camera.userMuted, true);
       });
 
       it('alice video unmute', async () => {
@@ -489,11 +489,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: bob.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.alice.camera.setMuted(false);
+        localStreams.alice.camera.setUserMuted(false);
 
         await membersUpdate;
 
-        assert.equal(localStreams.alice.camera.muted, false);
+        assert.equal(localStreams.alice.camera.userMuted, false);
       });
 
       it('alice update Audio', async () => {
@@ -574,11 +574,11 @@ skipInNode(describe)('plugin-meetings', () => {
         ]);
 
         // first bob mutes himself
-        localStreams.bob.microphone.setMuted(true);
+        localStreams.bob.microphone.setUserMuted(true);
 
         await membersUpdate;
 
-        assert.equal(localStreams.bob.microphone.muted, true);
+        assert.equal(localStreams.bob.microphone.userMuted, true);
 
         // now alice tries to unmmute bob
         await testUtils.delayedPromise(alice.meeting.mute(bob.meeting.members.selfId, false))
@@ -593,7 +593,7 @@ skipInNode(describe)('plugin-meetings', () => {
             assert.fail('bob received unexpected meeting:self:unmutedByOthers event');
           })
           .catch(() => {
-            assert.equal(localStreams.bob.microphone.muted, true);
+            assert.equal(localStreams.bob.microphone.userMuted, true);
           });
       });
 
@@ -607,11 +607,11 @@ skipInNode(describe)('plugin-meetings', () => {
           {scope: alice.meeting.members, event: 'members:update', match: checkEvent},
         ]);
 
-        localStreams.bob.microphone.setMuted(false);
+        localStreams.bob.microphone.setUserMuted(false);
 
         await membersUpdate;
 
-        assert.equal(localStreams.bob.microphone.muted, false);
+        assert.equal(localStreams.bob.microphone.userMuted, false);
       });
 
       it('alice shares the screen with highFrameRate', async () => {
@@ -871,7 +871,7 @@ skipInNode(describe)('plugin-meetings', () => {
           assert.equal(bob.meeting.shareStatus, 'whiteboard_share_active');
         }));
 
-      it('alice adds chris as guest to 1:1 meeting', async() =>
+      it('alice adds chris as guest to 1:1 meeting', () =>
         Promise.all([
           testUtils.delayedPromise(alice.meeting.invite({emailAddress: chris.emailAddress})),
           testUtils.waitForEvents([

package/test/integration/spec/space-meeting.js

@@ -34,7 +34,7 @@ skipInNode(describe)('plugin-meetings', () => {
   describe('space-meeting', () => {
     let space = null;
 
-    before(async () =>
+    before(() =>
       webexTestUsers
         .generateTestUsers({
           count: 4,

package/test/unit/spec/interpretation/index.ts

@@ -131,6 +131,7 @@ describe('plugin-meetings', () => {
         assert.equal(interpretation.receiveLanguage, 'en');
         assert.equal(interpretation.isActive, true);
         assert.equal(interpretation.order, 0);
+        assert.equal(interpretation.selfIsInterpreter, true);
 
         sampleData.interpretation = {
           originalLanguage: 'en',
@@ -141,13 +142,15 @@ describe('plugin-meetings', () => {
         assert.equal(interpretation.sourceLanguage, undefined);
         assert.equal(interpretation.targetLanguage, 'zh');
         assert.equal(interpretation.receiveLanguage, undefined);
+        assert.equal(interpretation.selfIsInterpreter, true);
 
         sampleData.interpretation = {
           order: 0,
         };
-        assert.equal(interpretation.updateSelfInterpretation(sampleData), false);
+        assert.equal(interpretation.updateSelfInterpretation(sampleData), true);
         assert.equal(interpretation.originalLanguage, undefined);
         assert.equal(interpretation.targetLanguage, undefined);
+        assert.equal(interpretation.selfIsInterpreter, false);
       });
     });
 

package/test/unit/spec/locus-info/mediaSharesUtils.ts

@@ -20,6 +20,15 @@ describe('getContentUrl', () => {
   });
 });
 
+describe('getContentResourceType', () => {
+  it('getContentResourceType return correct resourceType value', () => {
+    const stub = Sinon.stub(MediaSharesUtils, 'extractContent').returns({resourceType:'resourceType'});
+    const resourceType = MediaSharesUtils.getContentResourceType();
+    assert.equal(resourceType,'resourceType');
+    stub.restore();
+  });
+});
+
 describe('getContentBeneficiaryDeviceUrl', () => {
   it('getContentBeneficiaryDeviceUrl return correct deviceUrl value', () => {
     const mockContentBeneficiaryDeviceUrl = "https://wdm-a.wbx2.com/wdm/api/v1/devices/e9ffd8a1-1fae-42d1-afbe-013e951f93ab"

package/test/unit/spec/media/index.ts

@@ -170,37 +170,15 @@ describe('createMediaConnection', () => {
     );
   });
 
-  it('passes empty ICE servers array to MultistreamRoapMediaConnection if turnServerInfo is undefined (multistream enabled)', () => {
-    const multistreamRoapMediaConnectionConstructorStub = sinon
-      .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
-      .returns(fakeRoapMediaConnection);
-
-    Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
-      mediaProperties: {
-        mediaDirection: {
-          sendAudio: true,
-          sendVideo: true,
-          sendShare: false,
-          receiveAudio: true,
-          receiveVideo: true,
-          receiveShare: true,
-        },
-      },
-    });
-    assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
-    assert.calledWith(
-      multistreamRoapMediaConnectionConstructorStub,
-      {
-        iceServers: [],
-      },
-      'meeting id'
-    );
-
-    it('does not pass bundlePolicy to MultistreamRoapMediaConnection if bundlePolicy is undefined', () => {
+  [
+    {testCase: 'turnServerInfo is undefined', turnServerInfo: undefined},
+    {testCase: 'turnServerInfo.url is empty string', turnServerInfo: {url: '', username: 'turn username', password: 'turn password'}},
+  ].forEach(({testCase, turnServerInfo}) => {
+    it(`passes empty ICE servers array to MultistreamRoapMediaConnection if ${testCase} (multistream enabled)`, () => {
       const multistreamRoapMediaConnectionConstructorStub = sinon
         .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
         .returns(fakeRoapMediaConnection);
-
+  
       Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
         mediaProperties: {
           mediaDirection: {
@@ -212,7 +190,7 @@ describe('createMediaConnection', () => {
             receiveShare: true,
           },
         },
-        bundlePolicy: undefined,
+        turnServerInfo,
       });
       assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
       assert.calledWith(
@@ -221,75 +199,108 @@ describe('createMediaConnection', () => {
           iceServers: [],
         },
         'meeting id'
-      );
+        );
     });
   });
-
-  it('passes empty ICE servers array to RoapMediaConnection if turnServerInfo is undefined (multistream disabled)', () => {
-    const roapMediaConnectionConstructorStub = sinon
-      .stub(internalMediaModule, 'RoapMediaConnection')
+      
+  it('does not pass bundlePolicy to MultistreamRoapMediaConnection if bundlePolicy is undefined', () => {
+    const multistreamRoapMediaConnectionConstructorStub = sinon
+      .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
-
-    const ENABLE_EXTMAP = false;
-    const ENABLE_RTX = true;
-
-    Media.createMediaConnection(false, 'some debug id', webex, 'meeting id', 'correlationId', {
+    Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
       mediaProperties: {
         mediaDirection: {
           sendAudio: true,
           sendVideo: true,
-          sendShare: true,
+          sendShare: false,
           receiveAudio: true,
           receiveVideo: true,
           receiveShare: true,
         },
-        audioStream: fakeAudioStream,
-        videoStream: null,
-        shareVideoStream: fakeShareVideoStream,
-        shareAudioStream: fakeShareAudioStream,
       },
-      remoteQualityLevel: 'HIGH',
-      enableRtx: ENABLE_RTX,
-      enableExtmap: ENABLE_EXTMAP,
-      turnServerInfo: undefined,
+      bundlePolicy: undefined,
     });
-    assert.calledOnce(roapMediaConnectionConstructorStub);
+    assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
-      roapMediaConnectionConstructorStub,
+      multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [],
-        skipInactiveTransceivers: false,
-        requireH264: true,
-        sdpMunging: {
-          convertPort9to0: false,
-          addContentSlides: true,
-          bandwidthLimits: {
-            audio: 123,
-            video: 456,
+      },
+      'meeting id'
+    );
+  });
+
+  [
+    {testCase: 'turnServerInfo is undefined', turnServerInfo: undefined},
+    {testCase: 'turnServerInfo.url is empty string', turnServerInfo: {url: '', username: 'turn username', password: 'turn password'}},
+  ].forEach(({testCase, turnServerInfo}) => {
+    it(`passes empty ICE servers array to RoapMediaConnection if ${testCase} (multistream disabled)`, () => {
+      const roapMediaConnectionConstructorStub = sinon
+        .stub(internalMediaModule, 'RoapMediaConnection')
+        .returns(fakeRoapMediaConnection);
+
+      StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
+
+      const ENABLE_EXTMAP = false;
+      const ENABLE_RTX = true;
+
+      Media.createMediaConnection(false, 'some debug id', webex, 'meeting id', 'correlationId', {
+        mediaProperties: {
+          mediaDirection: {
+            sendAudio: true,
+            sendVideo: true,
+            sendShare: true,
+            receiveAudio: true,
+            receiveVideo: true,
+            receiveShare: true,
           },
-          startBitrate: 999,
-          periodicKeyframes: 20,
-          disableExtmap: !ENABLE_EXTMAP,
-          disableRtx: !ENABLE_RTX,
+          audioStream: fakeAudioStream,
+          videoStream: null,
+          shareVideoStream: fakeShareVideoStream,
+          shareAudioStream: fakeShareAudioStream,
         },
-      },
-      {
-        localTracks: {
-          audio: fakeTrack,
-          video: undefined,
-          screenShareVideo: fakeTrack,
-          screenShareAudio: fakeTrack,
+        remoteQualityLevel: 'HIGH',
+        enableRtx: ENABLE_RTX,
+        enableExtmap: ENABLE_EXTMAP,
+        turnServerInfo,
+      });
+      assert.calledOnce(roapMediaConnectionConstructorStub);
+      assert.calledWith(
+        roapMediaConnectionConstructorStub,
+        {
+          iceServers: [],
+          skipInactiveTransceivers: false,
+          requireH264: true,
+          sdpMunging: {
+            convertPort9to0: false,
+            addContentSlides: true,
+            bandwidthLimits: {
+              audio: 123,
+              video: 456,
+            },
+            startBitrate: 999,
+            periodicKeyframes: 20,
+            disableExtmap: !ENABLE_EXTMAP,
+            disableRtx: !ENABLE_RTX,
+          },
         },
-        direction: {
-          audio: 'sendrecv',
-          video: 'sendrecv',
-          screenShareVideo: 'sendrecv',
+        {
+          localTracks: {
+            audio: fakeTrack,
+            video: undefined,
+            screenShareVideo: fakeTrack,
+            screenShareAudio: fakeTrack,
+          },
+          direction: {
+            audio: 'sendrecv',
+            video: 'sendrecv',
+            screenShareVideo: 'sendrecv',
+          },
+          remoteQualityLevel: 'HIGH',
         },
-        remoteQualityLevel: 'HIGH',
-      },
-      'some debug id'
-    );
+        'some debug id'
+      );
+    });
   });
 });