@webex/plugin-meetings 3.0.0-next.1 → 3.0.0-next.11

package/test/unit/spec/locus-info/index.js

@@ -24,7 +24,7 @@ import {
   _MEETING_,
 } from '../../../../src/constants';
 
-import {self, selfWithInactivity} from './lib/selfConstant';
+import {self, selfWithInactivity} from './selfConstant';
 
 describe('plugin-meetings', () => {
   describe('LocusInfo index', () => {
@@ -1385,7 +1385,7 @@ describe('plugin-meetings', () => {
             function: 'updateMeetingInfo',
           },
           LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
-          payload
+          payload,
         ];
 
         if (expected) {
@@ -1404,7 +1404,7 @@ describe('plugin-meetings', () => {
             function: 'updateMeetingInfo',
           },
           LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
-          payload
+          payload,
         ];
 
         if (expected) {
@@ -1426,8 +1426,7 @@ describe('plugin-meetings', () => {
         */
         sinon.stub(locusInfo, 'emitScoped').callsFake(() => {
           assert.deepEqual(mockMeeting, expectedMeeting);
-        })
-
+        });
 
         // set the info initially as locusInfo.info starts as undefined
         expectedMeeting = {
@@ -1907,7 +1906,7 @@ describe('plugin-meetings', () => {
         locusInfo.locusParser.workingCopy = {
           syncUrl: 'current sync url',
         };
-  
+
         locusInfo.applyLocusDeltaData(LOCUS_URL_CHANGED, fakeLocus, meeting);
         assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, {url: 'current sync url'});
       });
@@ -1970,8 +1969,12 @@ describe('plugin-meetings', () => {
           }).then(() => {
             assert.calledTwice(meeting.meetingRequest.getLocusDTO);
 
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [{url: 'deltaSyncUrl'}]);
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [{url: 'fullSyncUrl'}]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [
+              {url: 'deltaSyncUrl'},
+            ]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [
+              {url: 'fullSyncUrl'},
+            ]);
 
             assert.calledWith(sendBehavioralMetricStub, 'js_sdk_locus_delta_sync_failed', {
               correlationId: meeting.correlationId,
@@ -1999,8 +2002,12 @@ describe('plugin-meetings', () => {
           }).then(() => {
             assert.calledTwice(meeting.meetingRequest.getLocusDTO);
 
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [{url: 'deltaSyncUrl'}]);
-            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [{url: 'fullSyncUrl'}]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[0].args, [
+              {url: 'deltaSyncUrl'},
+            ]);
+            assert.deepEqual(meeting.meetingRequest.getLocusDTO.getCalls()[1].args, [
+              {url: 'fullSyncUrl'},
+            ]);
 
             assert.calledWith(sendBehavioralMetricStub, 'js_sdk_locus_delta_sync_failed', {
               correlationId: meeting.correlationId,
@@ -2084,7 +2091,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         locusInfo.getTheLocusToUpdate(newLocus);
-        assert.notCalled(locusInfo.clearMainSessionLocusCache)
+        assert.notCalled(locusInfo.clearMainSessionLocusCache);
       });
 
       it('return the new locus if return to main session but no cache and do not clear main session cache', () => {
@@ -2106,7 +2113,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         locusInfo.getTheLocusToUpdate(newLocus);
-        assert.notCalled(locusInfo.clearMainSessionLocusCache)
+        assert.notCalled(locusInfo.clearMainSessionLocusCache);
       });
 
       it('return the new locus if not return to main session and clear main session cache', () => {
@@ -2116,9 +2123,9 @@ describe('plugin-meetings', () => {
               sessionType: 'MAIN',
             },
           },
-          self: {removed: true}
+          self: {removed: true},
         };
-        locusInfo.fullState = {state: 'ACTIVE'}
+        locusInfo.fullState = {state: 'ACTIVE'};
         locusInfo.controls = {
           breakout: {
             sessionType: 'MAIN',
@@ -2134,7 +2141,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         const result = locusInfo.getTheLocusToUpdate(newLocus);
-        assert.calledOnce(locusInfo.clearMainSessionLocusCache)
+        assert.calledOnce(locusInfo.clearMainSessionLocusCache);
 
         assert.deepEqual(result, newLocus);
       });
@@ -2146,9 +2153,9 @@ describe('plugin-meetings', () => {
               sessionType: 'MAIN',
             },
           },
-          self: {removed: undefined}
+          self: {removed: undefined},
         };
-        locusInfo.fullState = {state: 'ACTIVE'}
+        locusInfo.fullState = {state: 'ACTIVE'};
         locusInfo.controls = {
           breakout: {
             sessionType: 'MAIN',
@@ -2164,7 +2171,7 @@ describe('plugin-meetings', () => {
 
         locusInfo.clearMainSessionLocusCache = sinon.stub();
         locusInfo.getTheLocusToUpdate(newLocus);
-        assert.notCalled(locusInfo.clearMainSessionLocusCache)
+        assert.notCalled(locusInfo.clearMainSessionLocusCache);
       });
     });
 
@@ -2611,7 +2618,9 @@ describe('plugin-meetings', () => {
         // send an out-of-order delta
         locusInfo.handleLocusDelta(oooDelta, mockMeeting);
 
-        assert.calledOnceWithExactly(sendBehavioralMetricStub, 'js_sdk_locus_delta_ooo', { stack: sinon.match.any})
+        assert.calledOnceWithExactly(sendBehavioralMetricStub, 'js_sdk_locus_delta_ooo', {
+          stack: sinon.match.any,
+        });
 
         await clock.tickAsync(12499);
         await testUtils.flushPromises();

package/test/unit/spec/locus-info/mediaSharesUtils.ts

@@ -20,6 +20,15 @@ describe('getContentUrl', () => {
   });
 });
 
+describe('getContentResourceType', () => {
+  it('getContentResourceType return correct resourceType value', () => {
+    const stub = Sinon.stub(MediaSharesUtils, 'extractContent').returns({resourceType:'resourceType'});
+    const resourceType = MediaSharesUtils.getContentResourceType();
+    assert.equal(resourceType,'resourceType');
+    stub.restore();
+  });
+});
+
 describe('getContentBeneficiaryDeviceUrl', () => {
   it('getContentBeneficiaryDeviceUrl return correct deviceUrl value', () => {
     const mockContentBeneficiaryDeviceUrl = "https://wdm-a.wbx2.com/wdm/api/v1/devices/e9ffd8a1-1fae-42d1-afbe-013e951f93ab"

package/test/unit/spec/locus-info/selfUtils.js

@@ -3,7 +3,7 @@ import Sinon from 'sinon';
 import {cloneDeep} from 'lodash';
 import SelfUtils from '@webex/plugin-meetings/src/locus-info/selfUtils';
 
-import {self} from './lib/selfConstant';
+import {self} from './selfConstant';
 
 describe('plugin-meetings', () => {
   describe('selfUtils', () => {
@@ -150,8 +150,7 @@ describe('plugin-meetings', () => {
 
       it('should return false if no breakouts in current', () => {
         const current = {
-          breakoutSessions: {
-          },
+          breakoutSessions: {},
         };
         const previous = {
           breakoutSessions: {
@@ -293,7 +292,7 @@ describe('plugin-meetings', () => {
           const clonedSelf = cloneDeep(self);
 
           clonedSelf.controls.audio.requestedToUnmute = true;
-          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z'
+          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z';
 
           const {updates} = SelfUtils.getSelves(self, clonedSelf);
 
@@ -371,23 +370,18 @@ describe('plugin-meetings', () => {
     const clonedSelf = cloneDeep(self);
 
     it('get breakoutMoveId works', () => {
-
       assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(self, deviceId), breakoutMoveId);
-
     });
 
     it('replaces is empty', () => {
-
       clonedSelf.devices[0].replaces = undefined;
       assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(clonedSelf, deviceId), null);
-
     });
 
     it('no self or self.devices is not array', () => {
-
       assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(undefined, deviceId), null);
 
-      clonedSelf.devices =     {
+      clonedSelf.devices = {
         url: 'https://wdm-a.wbx2.com/wdm/api/v1/devices/20eabde3-4254-48da-9a24',
         deviceType: 'WEB',
         mediaSessionsExternal: false,
@@ -395,10 +389,11 @@ describe('plugin-meetings', () => {
           {
             breakoutMoveId: 'e5caeb2c-ffcc-4e06-a08a-1122e7710398',
             lastActive: '2023-05-04T07:14:32.068Z',
-            locusUrl: 'https://locus-alpha-apdx.prod.meetapi.webex.com/locus/api/v1/loci/495061ca-7b3c-3b77-85ff-4e1bd58600d1',
+            locusUrl:
+              'https://locus-alpha-apdx.prod.meetapi.webex.com/locus/api/v1/loci/495061ca-7b3c-3b77-85ff-4e1bd58600d1',
             replacedAt: '2023-05-04T07:16:04.905Z',
             sessionId: 'be3147d4-c318-86d8-7611-8d24beaaca8d',
-          }
+          },
         ],
         state: 'JOINED',
       };

package/test/unit/spec/media/index.ts

@@ -170,37 +170,15 @@ describe('createMediaConnection', () => {
     );
   });
 
-  it('passes empty ICE servers array to MultistreamRoapMediaConnection if turnServerInfo is undefined (multistream enabled)', () => {
-    const multistreamRoapMediaConnectionConstructorStub = sinon
-      .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
-      .returns(fakeRoapMediaConnection);
-
-    Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
-      mediaProperties: {
-        mediaDirection: {
-          sendAudio: true,
-          sendVideo: true,
-          sendShare: false,
-          receiveAudio: true,
-          receiveVideo: true,
-          receiveShare: true,
-        },
-      },
-    });
-    assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
-    assert.calledWith(
-      multistreamRoapMediaConnectionConstructorStub,
-      {
-        iceServers: [],
-      },
-      'meeting id'
-    );
-
-    it('does not pass bundlePolicy to MultistreamRoapMediaConnection if bundlePolicy is undefined', () => {
+  [
+    {testCase: 'turnServerInfo is undefined', turnServerInfo: undefined},
+    {testCase: 'turnServerInfo.url is empty string', turnServerInfo: {url: '', username: 'turn username', password: 'turn password'}},
+  ].forEach(({testCase, turnServerInfo}) => {
+    it(`passes empty ICE servers array to MultistreamRoapMediaConnection if ${testCase} (multistream enabled)`, () => {
       const multistreamRoapMediaConnectionConstructorStub = sinon
         .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
         .returns(fakeRoapMediaConnection);
-
+  
       Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
         mediaProperties: {
           mediaDirection: {
@@ -212,7 +190,7 @@ describe('createMediaConnection', () => {
             receiveShare: true,
           },
         },
-        bundlePolicy: undefined,
+        turnServerInfo,
       });
       assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
       assert.calledWith(
@@ -221,75 +199,108 @@ describe('createMediaConnection', () => {
           iceServers: [],
         },
         'meeting id'
-      );
+        );
     });
   });
-
-  it('passes empty ICE servers array to RoapMediaConnection if turnServerInfo is undefined (multistream disabled)', () => {
-    const roapMediaConnectionConstructorStub = sinon
-      .stub(internalMediaModule, 'RoapMediaConnection')
+      
+  it('does not pass bundlePolicy to MultistreamRoapMediaConnection if bundlePolicy is undefined', () => {
+    const multistreamRoapMediaConnectionConstructorStub = sinon
+      .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
-
-    const ENABLE_EXTMAP = false;
-    const ENABLE_RTX = true;
-
-    Media.createMediaConnection(false, 'some debug id', webex, 'meeting id', 'correlationId', {
+    Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
       mediaProperties: {
         mediaDirection: {
           sendAudio: true,
           sendVideo: true,
-          sendShare: true,
+          sendShare: false,
           receiveAudio: true,
           receiveVideo: true,
           receiveShare: true,
         },
-        audioStream: fakeAudioStream,
-        videoStream: null,
-        shareVideoStream: fakeShareVideoStream,
-        shareAudioStream: fakeShareAudioStream,
       },
-      remoteQualityLevel: 'HIGH',
-      enableRtx: ENABLE_RTX,
-      enableExtmap: ENABLE_EXTMAP,
-      turnServerInfo: undefined,
+      bundlePolicy: undefined,
     });
-    assert.calledOnce(roapMediaConnectionConstructorStub);
+    assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
-      roapMediaConnectionConstructorStub,
+      multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [],
-        skipInactiveTransceivers: false,
-        requireH264: true,
-        sdpMunging: {
-          convertPort9to0: false,
-          addContentSlides: true,
-          bandwidthLimits: {
-            audio: 123,
-            video: 456,
+      },
+      'meeting id'
+    );
+  });
+
+  [
+    {testCase: 'turnServerInfo is undefined', turnServerInfo: undefined},
+    {testCase: 'turnServerInfo.url is empty string', turnServerInfo: {url: '', username: 'turn username', password: 'turn password'}},
+  ].forEach(({testCase, turnServerInfo}) => {
+    it(`passes empty ICE servers array to RoapMediaConnection if ${testCase} (multistream disabled)`, () => {
+      const roapMediaConnectionConstructorStub = sinon
+        .stub(internalMediaModule, 'RoapMediaConnection')
+        .returns(fakeRoapMediaConnection);
+
+      StaticConfig.set({bandwidth: {audio: 123, video: 456, startBitrate: 999}});
+
+      const ENABLE_EXTMAP = false;
+      const ENABLE_RTX = true;
+
+      Media.createMediaConnection(false, 'some debug id', webex, 'meeting id', 'correlationId', {
+        mediaProperties: {
+          mediaDirection: {
+            sendAudio: true,
+            sendVideo: true,
+            sendShare: true,
+            receiveAudio: true,
+            receiveVideo: true,
+            receiveShare: true,
           },
-          startBitrate: 999,
-          periodicKeyframes: 20,
-          disableExtmap: !ENABLE_EXTMAP,
-          disableRtx: !ENABLE_RTX,
+          audioStream: fakeAudioStream,
+          videoStream: null,
+          shareVideoStream: fakeShareVideoStream,
+          shareAudioStream: fakeShareAudioStream,
         },
-      },
-      {
-        localTracks: {
-          audio: fakeTrack,
-          video: undefined,
-          screenShareVideo: fakeTrack,
-          screenShareAudio: fakeTrack,
+        remoteQualityLevel: 'HIGH',
+        enableRtx: ENABLE_RTX,
+        enableExtmap: ENABLE_EXTMAP,
+        turnServerInfo,
+      });
+      assert.calledOnce(roapMediaConnectionConstructorStub);
+      assert.calledWith(
+        roapMediaConnectionConstructorStub,
+        {
+          iceServers: [],
+          skipInactiveTransceivers: false,
+          requireH264: true,
+          sdpMunging: {
+            convertPort9to0: false,
+            addContentSlides: true,
+            bandwidthLimits: {
+              audio: 123,
+              video: 456,
+            },
+            startBitrate: 999,
+            periodicKeyframes: 20,
+            disableExtmap: !ENABLE_EXTMAP,
+            disableRtx: !ENABLE_RTX,
+          },
         },
-        direction: {
-          audio: 'sendrecv',
-          video: 'sendrecv',
-          screenShareVideo: 'sendrecv',
+        {
+          localTracks: {
+            audio: fakeTrack,
+            video: undefined,
+            screenShareVideo: fakeTrack,
+            screenShareAudio: fakeTrack,
+          },
+          direction: {
+            audio: 'sendrecv',
+            video: 'sendrecv',
+            screenShareVideo: 'sendrecv',
+          },
+          remoteQualityLevel: 'HIGH',
         },
-        remoteQualityLevel: 'HIGH',
-      },
-      'some debug id'
-    );
+        'some debug id'
+      );
+    });
   });
 });