@webex/plugin-meetings 3.0.0-beta.377 → 3.0.0-beta.378

package/dist/types/constants.d.ts

@@ -238,6 +238,7 @@ export declare const EVENT_TRIGGERS: {
     MEETING_UNLOCKED: string;
     MEETING_LOCKED: string;
     MEETING_INFO_AVAILABLE: string;
+    MEETING_INFO_UPDATED: string;
     MEETING_LOG_UPLOAD_SUCCESS: string;
     MEETING_LOG_UPLOAD_FAILURE: string;
     MEETING_ACTIONS_UPDATE: string;

package/dist/webinar/index.js

@@ -62,7 +62,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
   updateCanManageWebcast: function updateCanManageWebcast(canManageWebcast) {
     this.set('canManageWebcast', canManageWebcast);
   },
-  version: "3.0.0-beta.377"
+  version: "3.0.0-beta.378"
 });
 var _default = Webinar;
 exports.default = _default;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/plugin-meetings",
-  "version": "3.0.0-beta.377",
+  "version": "3.0.0-beta.378",
   "description": "",
   "license": "Cisco EULA (https://www.cisco.com/c/en/us/products/end-user-license-agreement.html)",
   "contributors": [
@@ -33,12 +33,12 @@
   },
   "devDependencies": {
     "@peculiar/webcrypto": "^1.4.3",
-    "@webex/plugin-meetings": "3.0.0-beta.377",
-    "@webex/test-helper-chai": "3.0.0-beta.377",
-    "@webex/test-helper-mocha": "3.0.0-beta.377",
-    "@webex/test-helper-mock-webex": "3.0.0-beta.377",
-    "@webex/test-helper-retry": "3.0.0-beta.377",
-    "@webex/test-helper-test-users": "3.0.0-beta.377",
+    "@webex/plugin-meetings": "3.0.0-beta.378",
+    "@webex/test-helper-chai": "3.0.0-beta.378",
+    "@webex/test-helper-mocha": "3.0.0-beta.378",
+    "@webex/test-helper-mock-webex": "3.0.0-beta.378",
+    "@webex/test-helper-retry": "3.0.0-beta.378",
+    "@webex/test-helper-test-users": "3.0.0-beta.378",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "jsdom-global": "3.0.2",
@@ -47,19 +47,19 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.0.0-beta.377",
+    "@webex/common": "3.0.0-beta.378",
     "@webex/internal-media-core": "2.2.7",
-    "@webex/internal-plugin-conversation": "3.0.0-beta.377",
-    "@webex/internal-plugin-device": "3.0.0-beta.377",
-    "@webex/internal-plugin-llm": "3.0.0-beta.377",
-    "@webex/internal-plugin-mercury": "3.0.0-beta.377",
-    "@webex/internal-plugin-metrics": "3.0.0-beta.377",
-    "@webex/internal-plugin-support": "3.0.0-beta.377",
-    "@webex/internal-plugin-user": "3.0.0-beta.377",
-    "@webex/media-helpers": "3.0.0-beta.377",
-    "@webex/plugin-people": "3.0.0-beta.377",
-    "@webex/plugin-rooms": "3.0.0-beta.377",
-    "@webex/webex-core": "3.0.0-beta.377",
+    "@webex/internal-plugin-conversation": "3.0.0-beta.378",
+    "@webex/internal-plugin-device": "3.0.0-beta.378",
+    "@webex/internal-plugin-llm": "3.0.0-beta.378",
+    "@webex/internal-plugin-mercury": "3.0.0-beta.378",
+    "@webex/internal-plugin-metrics": "3.0.0-beta.378",
+    "@webex/internal-plugin-support": "3.0.0-beta.378",
+    "@webex/internal-plugin-user": "3.0.0-beta.378",
+    "@webex/media-helpers": "3.0.0-beta.378",
+    "@webex/plugin-people": "3.0.0-beta.378",
+    "@webex/plugin-rooms": "3.0.0-beta.378",
+    "@webex/webex-core": "3.0.0-beta.378",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",

package/src/constants.ts

@@ -341,6 +341,7 @@ export const EVENT_TRIGGERS = {
   MEETING_UNLOCKED: 'meeting:unlocked',
   MEETING_LOCKED: 'meeting:locked',
   MEETING_INFO_AVAILABLE: 'meeting:meetingInfoAvailable',
+  MEETING_INFO_UPDATED: 'meeting:meetingInfoUpdated',
   MEETING_LOG_UPLOAD_SUCCESS: 'meeting:logUpload:success',
   MEETING_LOG_UPLOAD_FAILURE: 'meeting:logUpload:failure',
   MEETING_ACTIONS_UPDATE: 'meeting:actionsUpdate',

package/src/locus-info/index.ts

@@ -1169,7 +1169,10 @@ export default class LocusInfo extends EventsScope {
           file: 'locus-info',
           function: 'updateMeetingInfo',
         },
-        LOCUSINFO.EVENTS.MEETING_INFO_UPDATED
+        LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
+        {
+          isInitializing: !self, // if self is undefined, then the update is caused by locus init
+        }
       );
     }
     this.roles = roles;

package/src/meeting/index.ts

@@ -2758,12 +2758,24 @@ export default class Meeting extends StatelessWebexPlugin {
         );
       }
     });
-    this.locusInfo.on(LOCUSINFO.EVENTS.MEETING_INFO_UPDATED, () => {
+    this.locusInfo.on(LOCUSINFO.EVENTS.MEETING_INFO_UPDATED, ({isInitializing}) => {
       this.updateMeetingActions();
       this.recordingController.setDisplayHints(this.userDisplayHints);
       this.recordingController.setUserPolicy(this.selfUserPolicies);
       this.controlsOptionsManager.setDisplayHints(this.userDisplayHints);
       this.handleDataChannelUrlChange(this.datachannelUrl);
+
+      if (!isInitializing) {
+        // send updated trigger only if locus is not initializing the meeting
+        Trigger.trigger(
+          this,
+          {
+            file: 'meetings',
+            function: 'setUpLocusInfoMeetingInfoListener',
+          },
+          EVENT_TRIGGERS.MEETING_INFO_UPDATED
+        );
+      }
     });
   }
 

package/test/unit/spec/locus-info/index.js

@@ -1377,7 +1377,7 @@ describe('plugin-meetings', () => {
         );
       });
 
-      const checkMeetingInfoUpdatedCalled = (expected) => {
+      const checkMeetingInfoUpdatedCalled = (expected, payload) => {
         const expectedArgs = [
           locusInfo.emitScoped,
           {
@@ -1385,6 +1385,7 @@ describe('plugin-meetings', () => {
             function: 'updateMeetingInfo',
           },
           LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
+          payload
         ];
 
         if (expected) {
@@ -1395,7 +1396,7 @@ describe('plugin-meetings', () => {
         locusInfo.emitScoped.resetHistory();
       };
 
-      const checkMeetingInfoUpdatedCalledForRoles = (expected) => {
+      const checkMeetingInfoUpdatedCalledForRoles = (expected, payload) => {
         const expectedArgs = [
           locusInfo.emitScoped,
           {
@@ -1403,6 +1404,7 @@ describe('plugin-meetings', () => {
             function: 'updateMeetingInfo',
           },
           LOCUSINFO.EVENTS.MEETING_INFO_UPDATED,
+          payload
         ];
 
         if (expected) {
@@ -1447,7 +1449,7 @@ describe('plugin-meetings', () => {
 
         // since it was initially undefined, this should trigger the event
 
-        checkMeetingInfoUpdatedCalled(true);
+        checkMeetingInfoUpdatedCalled(true, {isInitializing: false});
 
         const newInfo = cloneDeep(meetingInfo);
 
@@ -1472,7 +1474,7 @@ describe('plugin-meetings', () => {
         };
         locusInfo.updateMeetingInfo(newInfo, self);
 
-        checkMeetingInfoUpdatedCalled(true);
+        checkMeetingInfoUpdatedCalled(true, {isInitializing: false});
 
         // update it with the same info
         expectedMeeting = {
@@ -1494,7 +1496,7 @@ describe('plugin-meetings', () => {
         locusInfo.updateMeetingInfo(newInfo, self);
 
         // since the info is the same it should not call trigger the event
-        checkMeetingInfoUpdatedCalled(false);
+        checkMeetingInfoUpdatedCalled(false, {isInitializing: false});
 
         // update it with the same info, but roles changed
         const updateSelf = cloneDeep(self);
@@ -1525,7 +1527,7 @@ describe('plugin-meetings', () => {
         };
         locusInfo.updateMeetingInfo(newInfo, updateSelf);
         // since the info is the same but roles changed, it should call trigger the event
-        checkMeetingInfoUpdatedCalledForRoles(true);
+        checkMeetingInfoUpdatedCalledForRoles(true, {isInitializing: false});
       });
 
       it('gets roles from self if available', () => {
@@ -1546,12 +1548,17 @@ describe('plugin-meetings', () => {
           roles: ['MODERATOR', 'COHOST'],
         };
 
+        sinon.stub(locusInfo, 'emitScoped');
+
         const parsedLocusInfo = cloneDeep(locusInfo.parsedLocus.info);
 
         locusInfo.updateMeetingInfo(initialInfo);
         assert.calledWith(isJoinedSpy, locusInfo.parsedLocus.self);
         assert.neverCalledWith(getRolesSpy, self);
         assert.calledWith(getInfosSpy, parsedLocusInfo, initialInfo, ['MODERATOR', 'COHOST']);
+
+        // since self is not passed to updateMeetingInfo, MEETING_INFO_UPDATED should be triggered with isIntializing: true
+        checkMeetingInfoUpdatedCalledForRoles(true, {isInitializing: true});
       });
     });
 

package/test/unit/spec/meeting/index.js

@@ -2512,6 +2512,7 @@ describe('plugin-meetings', () => {
               clientErrorCode: ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE,
               expectedErrorPayload: {
                 errorDescription: ERROR_DESCRIPTIONS.ICE_FAILED_WITH_TURN_TLS,
+                category: 'network',
               },
             },
           ].forEach(({clientErrorCode, expectedErrorPayload}) => {
@@ -8155,13 +8156,41 @@ describe('plugin-meetings', () => {
           assert.equal(locusInfoOnSpy.thirdCall.args[0], 'MEETING_INFO_UPDATED');
           const callback = locusInfoOnSpy.thirdCall.args[1];
 
-          callback();
+          callback({isInitializing: true});
 
           assert.calledWith(updateMeetingActionsSpy);
           assert.calledWith(setRecordingDisplayHintsSpy, userDisplayHints);
           assert.calledWith(setUserPolicySpy, userDisplayPolicy);
           assert.calledWith(setControlsDisplayHintsSpy, userDisplayHints);
           assert.calledWith(handleDataChannelUrlChangeSpy, datachannelUrl);
+
+          assert.neverCalledWith(
+            TriggerProxy.trigger,
+            meeting,
+            {
+              file: 'meetings',
+              function: 'setUpLocusInfoMeetingInfoListener',
+            },
+            'meeting:meetingInfoUpdated'
+          )
+
+          callback({isIntialized: false});
+
+          assert.calledWith(updateMeetingActionsSpy);
+          assert.calledWith(setRecordingDisplayHintsSpy, userDisplayHints);
+          assert.calledWith(setUserPolicySpy, userDisplayPolicy);
+          assert.calledWith(setControlsDisplayHintsSpy, userDisplayHints);
+          assert.calledWith(handleDataChannelUrlChangeSpy, datachannelUrl);
+
+          assert.calledWith(
+            TriggerProxy.trigger,
+            meeting,
+            {
+              file: 'meetings',
+              function: 'setUpLocusInfoMeetingInfoListener',
+            },
+            'meeting:meetingInfoUpdated'
+          )
         });
       });