@webex/plugin-meetings 3.0.0-beta.328 → 3.0.0-beta.329

package/dist/types/meeting/index.d.ts

@@ -1697,8 +1697,8 @@ export default class Meeting extends StatelessWebexPlugin {
      * @returns {object} containing timeLeft, expiryTime, currentTime
      */
     getPermissionTokenExpiryInfo(): {
-        timeLeft?: number;
-        expiryTime?: number;
+        timeLeft: number;
+        expiryTime: number;
         currentTime: number;
     };
     /**

package/dist/webinar/index.js

@@ -62,7 +62,7 @@ var Webinar = _webexCore.WebexPlugin.extend({
   updateCanManageWebcast: function updateCanManageWebcast(canManageWebcast) {
     this.set('canManageWebcast', canManageWebcast);
   },
-  version: "3.0.0-beta.328"
+  version: "3.0.0-beta.329"
 });
 var _default = Webinar;
 exports.default = _default;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/plugin-meetings",
-  "version": "3.0.0-beta.328",
+  "version": "3.0.0-beta.329",
   "description": "",
   "license": "Cisco EULA (https://www.cisco.com/c/en/us/products/end-user-license-agreement.html)",
   "contributors": [
@@ -33,12 +33,12 @@
   },
   "devDependencies": {
     "@peculiar/webcrypto": "^1.4.3",
-    "@webex/plugin-meetings": "3.0.0-beta.328",
-    "@webex/test-helper-chai": "3.0.0-beta.328",
-    "@webex/test-helper-mocha": "3.0.0-beta.328",
-    "@webex/test-helper-mock-webex": "3.0.0-beta.328",
-    "@webex/test-helper-retry": "3.0.0-beta.328",
-    "@webex/test-helper-test-users": "3.0.0-beta.328",
+    "@webex/plugin-meetings": "3.0.0-beta.329",
+    "@webex/test-helper-chai": "3.0.0-beta.329",
+    "@webex/test-helper-mocha": "3.0.0-beta.329",
+    "@webex/test-helper-mock-webex": "3.0.0-beta.329",
+    "@webex/test-helper-retry": "3.0.0-beta.329",
+    "@webex/test-helper-test-users": "3.0.0-beta.329",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "jsdom-global": "3.0.2",
@@ -47,19 +47,19 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.0.0-beta.328",
+    "@webex/common": "3.0.0-beta.329",
     "@webex/internal-media-core": "2.2.2",
-    "@webex/internal-plugin-conversation": "3.0.0-beta.328",
-    "@webex/internal-plugin-device": "3.0.0-beta.328",
-    "@webex/internal-plugin-llm": "3.0.0-beta.328",
-    "@webex/internal-plugin-mercury": "3.0.0-beta.328",
-    "@webex/internal-plugin-metrics": "3.0.0-beta.328",
-    "@webex/internal-plugin-support": "3.0.0-beta.328",
-    "@webex/internal-plugin-user": "3.0.0-beta.328",
-    "@webex/media-helpers": "3.0.0-beta.328",
-    "@webex/plugin-people": "3.0.0-beta.328",
-    "@webex/plugin-rooms": "3.0.0-beta.328",
-    "@webex/webex-core": "3.0.0-beta.328",
+    "@webex/internal-plugin-conversation": "3.0.0-beta.329",
+    "@webex/internal-plugin-device": "3.0.0-beta.329",
+    "@webex/internal-plugin-llm": "3.0.0-beta.329",
+    "@webex/internal-plugin-mercury": "3.0.0-beta.329",
+    "@webex/internal-plugin-metrics": "3.0.0-beta.329",
+    "@webex/internal-plugin-support": "3.0.0-beta.329",
+    "@webex/internal-plugin-user": "3.0.0-beta.329",
+    "@webex/media-helpers": "3.0.0-beta.329",
+    "@webex/plugin-people": "3.0.0-beta.329",
+    "@webex/plugin-rooms": "3.0.0-beta.329",
+    "@webex/webex-core": "3.0.0-beta.329",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",

package/src/meeting/index.ts

@@ -1525,7 +1525,11 @@ export default class Meeting extends StatelessWebexPlugin {
       : this.destination;
     const destinationType = isStartingSpaceInstantV2Meeting ? _MEETING_LINK_ : this.destinationType;
 
-    const {timeLeft, expiryTime, currentTime} = this.getPermissionTokenExpiryInfo();
+    const permissionTokenExpiryInfo = this.getPermissionTokenExpiryInfo();
+
+    const timeLeft = permissionTokenExpiryInfo?.timeLeft;
+    const expiryTime = permissionTokenExpiryInfo?.expiryTime;
+    const currentTime = permissionTokenExpiryInfo?.currentTime;
 
     LoggerProxy.logger.info(
       `Meeting:index#refreshPermissionToken --> refreshing permission token, destinationType=${destinationType}, timeLeft=${timeLeft}, permissionTokenExpiry=${expiryTime}, currentTimestamp=${currentTime},reason=${reason}`
@@ -7962,11 +7966,7 @@ export default class Meeting extends StatelessWebexPlugin {
    *
    * @returns {object} containing timeLeft, expiryTime, currentTime
    */
-  public getPermissionTokenExpiryInfo(): {
-    timeLeft?: number;
-    expiryTime?: number;
-    currentTime: number;
-  } {
+  public getPermissionTokenExpiryInfo() {
     if (!this.permissionTokenPayload) {
       return undefined;
     }
@@ -7993,7 +7993,7 @@ export default class Meeting extends StatelessWebexPlugin {
    * @returns {Promise<void>}
    */
   public checkAndRefreshPermissionToken(threshold: number, reason: string): Promise<void> {
-    const {timeLeft} = this.getPermissionTokenExpiryInfo();
+    const timeLeft = this.getPermissionTokenExpiryInfo()?.timeLeft;
 
     if (timeLeft !== undefined && timeLeft <= threshold) {
       return this.refreshPermissionToken(reason);

package/test/unit/spec/meeting/index.js

@@ -4616,7 +4616,7 @@ describe('plugin-meetings', () => {
           meeting.destination = 'meeting-destination';
           meeting.destinationType = 'meeting-destination-type';
           meeting.updateMeetingActions = sinon.stub().returns(undefined);
-          meeting.getPermissionTokenExpiryInfo = sinon.stub().returns(FAKE_TIMESTAMPS);
+          
           meeting.meetingInfoExtraParams = {
             extraParam1: 'value1'
           };
@@ -4637,6 +4637,7 @@ describe('plugin-meetings', () => {
         });
 
         it('calls meetingInfoProvider.fetchMeetingInfo() with the right params', async () => {
+          meeting.getPermissionTokenExpiryInfo = sinon.stub().returns(FAKE_TIMESTAMPS);
           await meeting.refreshPermissionToken('fake reason');
 
           assert.calledOnceWithExactly(
@@ -4678,7 +4679,51 @@ describe('plugin-meetings', () => {
           );
         });
 
+        it('calls meetingInfoProvider.fetchMeetingInfo() with the right params when getPermissionTokenExpiryInfo returns undefined', async () => {
+          meeting.getPermissionTokenExpiryInfo = sinon.stub().returns(undefined);
+          await meeting.refreshPermissionToken('fake reason');
+
+          assert.calledOnceWithExactly(
+            meeting.attrs.meetingInfoProvider.fetchMeetingInfo,
+            'meeting-destination',
+            'meeting-destination-type',
+            null,
+            null,
+            'fake-installed-org-id',
+            'locus-id',
+            {extraParam1: 'value1', permissionToken: FAKE_PERMISSION_TOKEN},
+            {meetingId: meeting.id, sendCAevents: true}
+          );
+          assert.deepEqual(meeting.meetingInfo, {
+            ...FAKE_MEETING_INFO,
+            meetingLookupUrl: FAKE_MEETING_INFO_LOOKUP_URL
+          });
+          assert.equal(meeting.meetingInfoFailureReason, MEETING_INFO_FAILURE_REASON.NONE);
+          assert.equal(meeting.requiredCaptcha, null);
+          assert.equal(meeting.passwordStatus, PASSWORD_STATUS.NOT_REQUIRED);
+
+          assert.calledWith(
+            TriggerProxy.trigger,
+            meeting,
+            {file: 'meetings', function: 'fetchMeetingInfo'},
+            'meeting:meetingInfoAvailable'
+          );
+          assert.calledWith(meeting.updateMeetingActions);
+
+          assert.calledWith(
+            Metrics.sendBehavioralMetric, BEHAVIORAL_METRICS.PERMISSION_TOKEN_REFRESH, {
+              correlationId: meeting.correlationId,
+              timeLeft: undefined,
+              expiryTime: undefined,
+              currentTime: undefined,
+              reason: 'fake reason',
+              destinationType: 'meeting-destination-type',
+            }
+          );
+        });
+
         it('calls meetingInfoProvider.fetchMeetingInfo() with the right params when we are starting an instant space meeting', async () => {
+          meeting.getPermissionTokenExpiryInfo = sinon.stub().returns(FAKE_TIMESTAMPS);
           meeting.destination = 'some-convo-url';
           meeting.destinationType = 'CONVERSATION_URL';
           meeting.config.experimental = {enableAdhocMeetings: true};
@@ -9795,7 +9840,7 @@ describe('plugin-meetings', () => {
 
   describe('#checkAndRefreshPermissionToken', () => {
     it('should not fire refreshPermissionToken if permissionToken is not defined', async() => {
-      meeting.getPermissionTokenExpiryInfo = sinon.stub().returns({timeLeft: undefined, expiryTime: undefined, currentTime: Date.now()})
+      meeting.getPermissionTokenExpiryInfo = sinon.stub().returns(undefined)
       meeting.refreshPermissionToken = sinon.stub().returns(Promise.resolve('test return value'));
 
       const returnValue = await meeting.checkAndRefreshPermissionToken(10, 'ttl-join');