@webex/plugin-meetings 3.0.0-beta.31 → 3.0.0-beta.310

package/test/unit/spec/locus-info/selfUtils.js

@@ -39,7 +39,7 @@ describe('plugin-meetings', () => {
               name: 'Breakout session 2',
               groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
               sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
-              sessionType: 'BREAKOUT'
+              sessionType: 'BREAKOUT',
             },
           ],
           allowed: [
@@ -47,9 +47,9 @@ describe('plugin-meetings', () => {
               name: 'Breakout session 2',
               groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
               sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
-              sessionType: 'BREAKOUT'
+              sessionType: 'BREAKOUT',
             },
-          ]
+          ],
         });
       });
 
@@ -76,9 +76,12 @@ describe('plugin-meetings', () => {
       });
     });
 
-    describe('getBreakouts', () => {
+    describe('getBreakoutSessions', () => {
       it('should return breakout sessions', () => {
-        assert.deepEqual(SelfUtils.getBreakouts({controls: {breakout: {sessions: 'SESSIONS'}}}), 'SESSIONS');
+        assert.deepEqual(
+          SelfUtils.getBreakoutSessions({controls: {breakout: {sessions: 'SESSIONS'}}}),
+          'SESSIONS'
+        );
       });
     });
 
@@ -91,10 +94,11 @@ describe('plugin-meetings', () => {
                 name: 'Breakout session 2',
                 groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
                 sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
-                sessionType: 'BREAKOUT'
+                sessionType: 'BREAKOUT',
               },
-            ]
-          }
+            ],
+          },
+          breakout: {},
         };
         const previous = {
           breakoutSessions: {
@@ -103,10 +107,11 @@ describe('plugin-meetings', () => {
                 name: 'Breakout session 2',
                 groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
                 sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
-                sessionType: 'BREAKOUT'
+                sessionType: 'BREAKOUT',
               },
-            ]
-          }
+            ],
+          },
+          breakout: {},
         };
 
         assert.isTrue(SelfUtils.breakoutsChanged(previous, current));
@@ -120,10 +125,11 @@ describe('plugin-meetings', () => {
                 name: 'Breakout session 2',
                 groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
                 sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
-                sessionType: 'BREAKOUT'
+                sessionType: 'BREAKOUT',
               },
-            ]
-          }
+            ],
+          },
+          breakout: {},
         };
         const previous = {
           breakoutSessions: {
@@ -132,10 +138,33 @@ describe('plugin-meetings', () => {
                 name: 'Breakout session 2',
                 groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
                 sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
-                sessionType: 'BREAKOUT'
+                sessionType: 'BREAKOUT',
               },
-            ]
-          }
+            ],
+          },
+          breakout: {},
+        };
+
+        assert.isFalse(SelfUtils.breakoutsChanged(previous, current));
+      });
+
+      it('should return false if no breakouts in current', () => {
+        const current = {
+          breakoutSessions: {
+          },
+        };
+        const previous = {
+          breakoutSessions: {
+            active: [
+              {
+                name: 'Breakout session 2',
+                groupId: '0e73abb8-5584-49d8-be8d-806d2a8247ca',
+                sessionId: '1cf41ab1-2e57-4d95-b7e9-5613acddfb0f',
+                sessionType: 'BREAKOUT',
+              },
+            ],
+          },
+          breakout: {},
         };
 
         assert.isFalse(SelfUtils.breakoutsChanged(previous, current));
@@ -222,6 +251,55 @@ describe('plugin-meetings', () => {
           assert.equal(updates.canNotViewTheParticipantListChanged, false);
         });
       });
+
+      describe('localAudioUnmuteRequestedByServer', () => {
+        it('should return localAudioUnmuteRequestedByServer = false when requestedToUnmute = false', () => {
+          const clonedSelf = cloneDeep(self);
+
+          const {updates} = SelfUtils.getSelves(self, clonedSelf);
+
+          assert.equal(updates.localAudioUnmuteRequestedByServer, false);
+        });
+
+        it('should return localAudioUnmuteRequestedByServer = true when first request is made with requestedToUnmute = true', () => {
+          const clonedSelf = cloneDeep(self);
+
+          //request to unmute with timestamp
+          clonedSelf.controls.audio.requestedToUnmute = true;
+          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z';
+
+          const {updates} = SelfUtils.getSelves(self, clonedSelf);
+
+          assert.equal(updates.localAudioUnmuteRequestedByServer, true);
+        });
+
+        it('should return localAudioUnmuteRequestedByServer = true when requestedToUnmute = true and new requests lastModifiedRequestedToUnmute timestamp is greater than old one', () => {
+          self.controls.audio.requestedToUnmute = true;
+          self.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z';
+          const clonedSelf = cloneDeep(self);
+
+          //request to unmute with timestamp
+          clonedSelf.controls.audio.requestedToUnmute = true;
+          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T19:25:04.369Z';
+
+          const {updates} = SelfUtils.getSelves(self, clonedSelf);
+
+          assert.equal(updates.localAudioUnmuteRequestedByServer, true);
+        });
+
+        it('should return localAudioUnmuteRequestedByServer = false when requestedToUnmute but lastModifiedRequestedToUnmute timestamps are same', () => {
+          self.controls.audio.requestedToUnmute = true;
+          self.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z';
+          const clonedSelf = cloneDeep(self);
+
+          clonedSelf.controls.audio.requestedToUnmute = true;
+          clonedSelf.controls.audio.lastModifiedRequestedToUnmute = '2023-06-16T18:25:04.369Z'
+
+          const {updates} = SelfUtils.getSelves(self, clonedSelf);
+
+          assert.equal(updates.localAudioUnmuteRequestedByServer, false);
+        });
+      });
     });
 
     describe('isSharingBlocked', () => {
@@ -266,4 +344,117 @@ describe('plugin-meetings', () => {
       assert.deepEqual(SelfUtils.isJoined(customSelf), false);
     });
   });
+
+  describe('videoMutedByOthersChanged', () => {
+    it('returns true if changed', () => {
+      assert.equal(
+        SelfUtils.videoMutedByOthersChanged({remoteVideoMuted: true}, {remoteVideoMuted: false}),
+        true
+      );
+    });
+
+    it('returns true if changed from undefined', () => {
+      assert.equal(SelfUtils.videoMutedByOthersChanged({}, {remoteVideoMuted: false}), true);
+    });
+
+    it('returns false if not changed', () => {
+      assert.equal(
+        SelfUtils.videoMutedByOthersChanged({remoteVideoMuted: false}, {remoteVideoMuted: false}),
+        false
+      );
+    });
+  });
+
+  describe('getReplacedBreakoutMoveId', () => {
+    const deviceId = 'https://wdm-a.wbx2.com/wdm/api/v1/devices/20eabde3-4254-48da-9a24';
+    const breakoutMoveId = 'e5caeb2c-ffcc-4e06-a08a-1122e7710398';
+    const clonedSelf = cloneDeep(self);
+
+    it('get breakoutMoveId works', () => {
+
+      assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(self, deviceId), breakoutMoveId);
+
+    });
+
+    it('replaces is empty', () => {
+
+      clonedSelf.devices[0].replaces = undefined;
+      assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(clonedSelf, deviceId), null);
+
+    });
+
+    it('no self or self.devices is not array', () => {
+
+      assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(undefined, deviceId), null);
+
+      clonedSelf.devices =     {
+        url: 'https://wdm-a.wbx2.com/wdm/api/v1/devices/20eabde3-4254-48da-9a24',
+        deviceType: 'WEB',
+        mediaSessionsExternal: false,
+        replaces: [
+          {
+            breakoutMoveId: 'e5caeb2c-ffcc-4e06-a08a-1122e7710398',
+            lastActive: '2023-05-04T07:14:32.068Z',
+            locusUrl: 'https://locus-alpha-apdx.prod.meetapi.webex.com/locus/api/v1/loci/495061ca-7b3c-3b77-85ff-4e1bd58600d1',
+            replacedAt: '2023-05-04T07:16:04.905Z',
+            sessionId: 'be3147d4-c318-86d8-7611-8d24beaaca8d',
+          }
+        ],
+        state: 'JOINED',
+      };
+      assert.deepEqual(SelfUtils.getReplacedBreakoutMoveId(clonedSelf, deviceId), null);
+    });
+  });
+
+  describe('isRolesChanged', () => {
+    it('should return false if new self is null', () => {
+      const parsedSelf = SelfUtils.parse(self);
+
+      assert.deepEqual(SelfUtils.isRolesChanged(parsedSelf, null), false);
+    });
+
+    it('should return true if self roles has changed', () => {
+      const parsedSelf = SelfUtils.parse(self);
+      const clonedSelf = cloneDeep(parsedSelf);
+
+      clonedSelf.roles = ['COHOST'];
+
+      assert.deepEqual(SelfUtils.isRolesChanged(parsedSelf, clonedSelf), true);
+    });
+
+    it('should return false if self roles has not changed', () => {
+      const parsedSelf = SelfUtils.parse(self);
+      const clonedSelf = cloneDeep(parsedSelf);
+
+      clonedSelf.roles = ['PRESENTER'];
+
+      assert.deepEqual(SelfUtils.isRolesChanged(parsedSelf, clonedSelf), false);
+    });
+  });
+
+  describe('interpretationChanged', () => {
+    it('should return false if new self is null', () => {
+      const parsedSelf = SelfUtils.parse(self);
+
+      assert.deepEqual(SelfUtils.interpretationChanged(parsedSelf, null), false);
+    });
+
+    it('should return true if interpretation info has changed', () => {
+      const parsedSelf = SelfUtils.parse(self);
+      const clonedSelf = cloneDeep(parsedSelf);
+
+      clonedSelf.interpretation.sourceLanguage = 'ja';
+
+      assert.deepEqual(SelfUtils.interpretationChanged(parsedSelf, clonedSelf), true);
+    });
+
+    it('should return false if interpretation info  has not changed', () => {
+      const parsedSelf = SelfUtils.parse(self);
+      const clonedSelf = cloneDeep(parsedSelf);
+
+      clonedSelf.interpretation.sourceLanguage = 'en';
+
+      assert.deepEqual(SelfUtils.interpretationChanged(parsedSelf, clonedSelf), false);
+    });
+  });
 });

package/test/unit/spec/media/index.ts

@@ -3,18 +3,30 @@ import Media from '@webex/plugin-meetings/src/media/index';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import StaticConfig from '@webex/plugin-meetings/src/common/config';
+import {forEach} from 'lodash';
+import MockWebex from '@webex/test-helper-mock-webex';
 
 describe('createMediaConnection', () => {
+  const webex = MockWebex();
+
   const fakeRoapMediaConnection = {
     id: 'roap media connection',
   };
-  const fakeAudioTrack = {
-    id: 'audio track',
+  const fakeTrack = {
+    id: 'any fake track'
+  }
+  const fakeAudioStream = {
+    outputTrack: fakeTrack,
   };
-  const fakeVideoTrack = {
-    id: 'video track',
+  const fakeVideoStream = {
+    outputTrack: fakeTrack,
+  };
+  const fakeShareVideoStream = {
+    outputTrack: fakeTrack,
+  };
+  const fakeShareAudioStream = {
+    outputTrack: fakeTrack,
   };
-
   afterEach(() => {
     sinon.restore();
   });
@@ -29,19 +41,20 @@ describe('createMediaConnection', () => {
     const ENABLE_EXTMAP = false;
     const ENABLE_RTX = true;
 
-    Media.createMediaConnection(false, 'some debug id', {
+    Media.createMediaConnection(false, 'some debug id', webex, 'meetingId', 'correlationId', {
       mediaProperties: {
         mediaDirection: {
-          sendAudio: true,
+          sendAudio: false,
           sendVideo: true,
           sendShare: false,
-          receiveAudio: true,
+          receiveAudio: false,
           receiveVideo: true,
           receiveShare: true,
         },
-        audioTrack: fakeAudioTrack,
-        videoTrack: fakeVideoTrack,
-        shareTrack: null,
+        audioStream: fakeAudioStream,
+        videoStream: fakeVideoStream,
+        shareVideoTrack: null,
+        shareAudioTrack: null,
       },
       remoteQualityLevel: 'HIGH',
       enableRtx: ENABLE_RTX,
@@ -79,17 +92,18 @@ describe('createMediaConnection', () => {
         },
       },
       {
-        send: {
-          audio: fakeAudioTrack,
-          video: fakeVideoTrack,
-          screenShareVideo: null,
+        localTracks: {
+          audio: fakeTrack,
+          video: fakeTrack,
+          screenShareVideo: undefined,
+          screenShareAudio: undefined,
         },
-        receive: {
-          audio: true,
-          video: true,
-          screenShareVideo: true,
-          remoteQualityLevel: 'HIGH',
+        direction: {
+          audio: 'inactive',
+          video: 'sendrecv',
+          screenShareVideo: 'recvonly',
         },
+        remoteQualityLevel: 'HIGH',
       },
       'some debug id'
     );
@@ -100,12 +114,23 @@ describe('createMediaConnection', () => {
       .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    Media.createMediaConnection(true, 'some debug id', {
+    Media.createMediaConnection(true, 'some debug id', webex, 'meeting id', 'correlationId', {
+      mediaProperties: {
+        mediaDirection: {
+          sendAudio: true,
+          sendVideo: true,
+          sendShare: false,
+          receiveAudio: true,
+          receiveVideo: true,
+          receiveShare: true,
+        },
+      },
       turnServerInfo: {
         url: 'turn server url',
         username: 'turn username',
         password: 'turn password',
       },
+      bundlePolicy: 'max-bundle',
     });
     assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
@@ -118,8 +143,9 @@ describe('createMediaConnection', () => {
             credential: 'turn password',
           },
         ],
+        bundlePolicy: 'max-bundle',
       },
-      'some debug id'
+      'meeting id'
     );
   });
 
@@ -128,15 +154,54 @@ describe('createMediaConnection', () => {
       .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    Media.createMediaConnection(true, 'debug string', {});
+    Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
+      mediaProperties: {
+        mediaDirection: {
+          sendAudio: true,
+          sendVideo: true,
+          sendShare: false,
+          receiveAudio: true,
+          receiveVideo: true,
+          receiveShare: true,
+        },
+      },
+    });
     assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
       multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [],
       },
-      'debug string'
+      'meeting id'
     );
+
+    it('does not pass bundlePolicy to MultistreamRoapMediaConnection if bundlePolicy is undefined', () => {
+      const multistreamRoapMediaConnectionConstructorStub = sinon
+        .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
+        .returns(fakeRoapMediaConnection);
+
+      Media.createMediaConnection(true, 'debug string', webex, 'meeting id', 'correlationId', {
+        mediaProperties: {
+          mediaDirection: {
+            sendAudio: true,
+            sendVideo: true,
+            sendShare: false,
+            receiveAudio: true,
+            receiveVideo: true,
+            receiveShare: true,
+          },
+        },
+        bundlePolicy: undefined,
+      });
+      assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
+      assert.calledWith(
+        multistreamRoapMediaConnectionConstructorStub,
+        {
+          iceServers: [],
+        },
+        'meeting id'
+      );
+    });
   });
 
   it('passes empty ICE servers array to RoapMediaConnection if turnServerInfo is undefined (multistream disabled)', () => {
@@ -149,7 +214,7 @@ describe('createMediaConnection', () => {
     const ENABLE_EXTMAP = false;
     const ENABLE_RTX = true;
 
-    Media.createMediaConnection(false, 'some debug id', {
+    Media.createMediaConnection(false, 'some debug id', webex, 'meeting id', 'correlationId', {
       mediaProperties: {
         mediaDirection: {
           sendAudio: true,
@@ -159,9 +224,10 @@ describe('createMediaConnection', () => {
           receiveVideo: true,
           receiveShare: true,
         },
-        audioTrack: fakeAudioTrack,
-        videoTrack: null,
-        shareTrack: fakeVideoTrack,
+        audioStream: fakeAudioStream,
+        videoStream: null,
+        shareVideoStream: fakeShareVideoStream,
+        shareAudioStream: fakeShareAudioStream,
       },
       remoteQualityLevel: 'HIGH',
       enableRtx: ENABLE_RTX,
@@ -189,17 +255,18 @@ describe('createMediaConnection', () => {
         },
       },
       {
-        send: {
-          audio: fakeAudioTrack,
-          video: null,
-          screenShareVideo: fakeVideoTrack,
+        localTracks: {
+          audio: fakeTrack,
+          video: undefined,
+          screenShareVideo: fakeTrack,
+          screenShareAudio: fakeTrack,
         },
-        receive: {
-          audio: true,
-          video: true,
-          screenShareVideo: true,
-          remoteQualityLevel: 'HIGH',
+        direction: {
+          audio: 'sendrecv',
+          video: 'sendrecv',
+          screenShareVideo: 'sendrecv',
         },
+        remoteQualityLevel: 'HIGH',
       },
       'some debug id'
     );

package/test/unit/spec/media/properties.ts

@@ -4,7 +4,7 @@ import {ConnectionState, Event} from '@webex/internal-media-core';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
 import MediaUtil from '@webex/plugin-meetings/src/media/util';
 import testUtils from '../../../utils/testUtils';
-import {PC_BAIL_TIMEOUT} from '@webex/plugin-meetings/src/constants';
+import {ICE_AND_DTLS_CONNECTION_TIMEOUT} from '@webex/plugin-meetings/src/constants';
 import {Defer} from '@webex/common';
 
 describe('MediaProperties', () => {
@@ -52,7 +52,7 @@ describe('MediaProperties', () => {
       assert.equal(promiseResolved, false);
       assert.equal(promiseRejected, false);
 
-      await clock.tickAsync(PC_BAIL_TIMEOUT);
+      await clock.tickAsync(ICE_AND_DTLS_CONNECTION_TIMEOUT);
       await testUtils.flushPromises();
 
       assert.equal(promiseResolved, false);

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -10,6 +10,8 @@ describe('plugin-meetings', () => {
         canLock: null,
         canUnlock: null,
         canAssignHost: null,
+        canSetPresenter: null,
+        canUnsetPresenter: null,
         canStartRecording: null,
         canPauseRecording: null,
         canResumeRecording: null,
@@ -17,6 +19,8 @@ describe('plugin-meetings', () => {
         canUnsetMuteOnEntry: null,
         canSetDisallowUnmute: null,
         canUnsetDisallowUnmute: null,
+        canSetMuted: null,
+        canUnsetMuted: null,
         canStopRecording: null,
         canRaiseHand: null,
         canLowerAllHands: null,
@@ -26,14 +30,50 @@ describe('plugin-meetings', () => {
         canStartTranscribing: null,
         canStopTranscribing: null,
         isClosedCaptionActive: null,
+        isSaveTranscriptsEnabled: null,
         isWebexAssistantActive: null,
         canViewCaptionPanel: null,
         isRealTimeTranslationEnabled: null,
         canSelectSpokenLanguages: null,
         waitingForOthersToJoin: null,
-        canEnableReactions: null,
         canSendReactions: null,
-        ...expected
+        canManageBreakout: null,
+        canBroadcastMessageToBreakout: null,
+        canAdmitLobbyToBreakout: null,
+        canUserAskForHelp: null,
+        canUserRenameSelfAndObserved: null,
+        canUserRenameOthers: null,
+        isBreakoutPreassignmentsEnabled: null,
+        canMuteAll: null,
+        canUnmuteAll: null,
+        canEnableHardMute: null,
+        canDisableHardMute: null,
+        canEnableMuteOnEntry: null,
+        canDisableMuteOnEntry: null,
+        canEnableReactions: null,
+        canDisableReactions: null,
+        canEnableReactionDisplayNames: null,
+        canDisableReactionDisplayNames: null,
+        canUpdateShareControl: null,
+        canEnableViewTheParticipantsList: null,
+        canDisableViewTheParticipantsList: null,
+        canEnableRaiseHand: null,
+        canDisableRaiseHand: null,
+        canEnableVideo: null,
+        canDisableVideo: null,
+        canShareFile: null,
+        canShareApplication: null,
+        canShareCamera: null,
+        canShareDesktop: null,
+        canShareContent: null,
+        canTransferFile: null,
+        canDoVideo: null,
+        canAnnotate: null,
+        canUseVoip: null,
+        supportHQV: null,
+        supportHDV: null,
+        canShareWhiteBoard: null,
+        ...expected,
       };
 
       // Check get retuns all the correct values at once
@@ -51,6 +91,8 @@ describe('plugin-meetings', () => {
       'canLock',
       'canUnlock',
       'canAssignHost',
+      'canSetPresenter',
+      'canUnsetPresenter',
       'canStartRecording',
       'canPauseRecording',
       'canResumeRecording',
@@ -66,13 +108,49 @@ describe('plugin-meetings', () => {
       'canEnableClosedCaption',
       'canStopTranscribing',
       'isClosedCaptionActive',
+      'isSaveTranscriptsEnabled',
       'isWebexAssistantActive',
       'canViewCaptionPanel',
       'isRealTimeTranslationEnabled',
       'canSelectSpokenLanguages',
       'waitingForOthersToJoin',
+      'canSendReactions',
+      'canManageBreakout',
+      'canBroadcastMessageToBreakout',
+      'canAdmitLobbyToBreakout',
+      'canUserAskForHelp',
+      'canUserRenameSelfAndObserved',
+      'canUserRenameOthers',
+      'isBreakoutPreassignmentsEnabled',
+      'canMuteAll',
+      'canUnmuteAll',
+      'canEnableHardMute',
+      'canDisableHardMute',
+      'canEnableMuteOnEntry',
+      'canDisableMuteOnEntry',
       'canEnableReactions',
-      'canSendReactions'
+      'canDisableReactions',
+      'canEnableReactionDisplayNames',
+      'canDisableReactionDisplayNames',
+      'canUpdateShareControl',
+      'canEnableViewTheParticipantsList',
+      'canDisableViewTheParticipantsList',
+      'canEnableRaiseHand',
+      'canDisableRaiseHand',
+      'canEnableVideo',
+      'canDisableVideo',
+      'canShareFile',
+      'canShareApplication',
+      'canShareCamera',
+      'canShareDesktop',
+      'canShareContent',
+      'canTransferFile',
+      'canDoVideo',
+      'canAnnotate',
+      'canUseVoip',
+      'supportHQV',
+      'supportHDV',
+      'canShareWhiteBoard',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();