@webex/plugin-meetings 3.0.0-beta.276 → 3.0.0-beta.277

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/plugin-meetings",
-  "version": "3.0.0-beta.276",
+  "version": "3.0.0-beta.277",
   "description": "",
   "license": "Cisco EULA (https://www.cisco.com/c/en/us/products/end-user-license-agreement.html)",
   "contributors": [
@@ -32,12 +32,12 @@
     "build": "yarn run -T tsc --declaration true --declarationDir ./dist/types"
   },
   "devDependencies": {
-    "@webex/plugin-meetings": "3.0.0-beta.276",
-    "@webex/test-helper-chai": "3.0.0-beta.276",
-    "@webex/test-helper-mocha": "3.0.0-beta.276",
-    "@webex/test-helper-mock-webex": "3.0.0-beta.276",
-    "@webex/test-helper-retry": "3.0.0-beta.276",
-    "@webex/test-helper-test-users": "3.0.0-beta.276",
+    "@webex/plugin-meetings": "3.0.0-beta.277",
+    "@webex/test-helper-chai": "3.0.0-beta.277",
+    "@webex/test-helper-mocha": "3.0.0-beta.277",
+    "@webex/test-helper-mock-webex": "3.0.0-beta.277",
+    "@webex/test-helper-retry": "3.0.0-beta.277",
+    "@webex/test-helper-test-users": "3.0.0-beta.277",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "jsdom-global": "3.0.2",
@@ -46,19 +46,19 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.0.0-beta.276",
+    "@webex/common": "3.0.0-beta.277",
     "@webex/internal-media-core": "2.0.6",
-    "@webex/internal-plugin-conversation": "3.0.0-beta.276",
-    "@webex/internal-plugin-device": "3.0.0-beta.276",
-    "@webex/internal-plugin-llm": "3.0.0-beta.276",
-    "@webex/internal-plugin-mercury": "3.0.0-beta.276",
-    "@webex/internal-plugin-metrics": "3.0.0-beta.276",
-    "@webex/internal-plugin-support": "3.0.0-beta.276",
-    "@webex/internal-plugin-user": "3.0.0-beta.276",
-    "@webex/media-helpers": "3.0.0-beta.276",
-    "@webex/plugin-people": "3.0.0-beta.276",
-    "@webex/plugin-rooms": "3.0.0-beta.276",
-    "@webex/webex-core": "3.0.0-beta.276",
+    "@webex/internal-plugin-conversation": "3.0.0-beta.277",
+    "@webex/internal-plugin-device": "3.0.0-beta.277",
+    "@webex/internal-plugin-llm": "3.0.0-beta.277",
+    "@webex/internal-plugin-mercury": "3.0.0-beta.277",
+    "@webex/internal-plugin-metrics": "3.0.0-beta.277",
+    "@webex/internal-plugin-support": "3.0.0-beta.277",
+    "@webex/internal-plugin-user": "3.0.0-beta.277",
+    "@webex/media-helpers": "3.0.0-beta.277",
+    "@webex/plugin-people": "3.0.0-beta.277",
+    "@webex/plugin-rooms": "3.0.0-beta.277",
+    "@webex/webex-core": "3.0.0-beta.277",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",

package/src/meeting/index.ts

@@ -5542,8 +5542,8 @@ export default class Meeting extends StatelessWebexPlugin {
           this.mediaProperties.mediaDirection.receiveShare,
       ];
 
-      this.sendSlotManager.createSlot(mc, MediaType.VideoMain, audioEnabled);
-      this.sendSlotManager.createSlot(mc, MediaType.AudioMain, videoEnabled);
+      this.sendSlotManager.createSlot(mc, MediaType.VideoMain, videoEnabled);
+      this.sendSlotManager.createSlot(mc, MediaType.AudioMain, audioEnabled);
       this.sendSlotManager.createSlot(mc, MediaType.VideoSlides, shareEnabled);
       this.sendSlotManager.createSlot(mc, MediaType.AudioSlides, shareEnabled);
     }

package/test/unit/spec/meeting/index.js

@@ -2081,6 +2081,11 @@ describe('plugin-meetings', () => {
               iceServers,
             }, meetingId);
 
+            assert.calledWith(fakeMultistreamRoapMediaConnection.createSendSlot, MediaType.AudioMain, direction.audio !== 'inactive');
+            assert.calledWith(fakeMultistreamRoapMediaConnection.createSendSlot, MediaType.VideoMain, direction.video !== 'inactive');
+            assert.calledWith(fakeMultistreamRoapMediaConnection.createSendSlot, MediaType.AudioSlides, direction.screenShare !== 'inactive');
+            assert.calledWith(fakeMultistreamRoapMediaConnection.createSendSlot, MediaType.VideoSlides, direction.screenShare !== 'inactive');
+
             for(let type in localStreams){
               const stream = localStreams[type];
               if(stream !== undefined){
@@ -2109,7 +2114,7 @@ describe('plugin-meetings', () => {
                   screenShareVideo: localStreams.screenShareVideo?.outputTrack,
                   screenShareAudio: localStreams.screenShareAudio?.outputTrack,
                 },
-                direction,
+                direction: {audio: direction.audio, video: direction.video, screenShareVideo: direction.screenShare},
                 remoteQualityLevel,
               },
               expectedDebugId
@@ -2133,7 +2138,7 @@ describe('plugin-meetings', () => {
             direction: {
               audio: 'sendrecv',
               video: 'sendrecv',
-              screenShareVideo: 'recvonly',
+              screenShare: 'recvonly',
             },
             remoteQualityLevel: 'HIGH',
             expectedDebugId,
@@ -2163,7 +2168,7 @@ describe('plugin-meetings', () => {
             direction: {
               audio: 'sendrecv',
               video: 'sendrecv',
-              screenShareVideo: 'recvonly',
+              screenShare: 'recvonly',
             },
             remoteQualityLevel: 'HIGH',
             expectedDebugId,
@@ -2195,7 +2200,7 @@ describe('plugin-meetings', () => {
             direction: {
               audio: 'sendrecv',
               video: 'sendrecv',
-              screenShareVideo: 'recvonly',
+              screenShare: 'recvonly',
             },
             remoteQualityLevel: 'HIGH',
             expectedDebugId,
@@ -2224,7 +2229,7 @@ describe('plugin-meetings', () => {
             direction: {
               audio: 'inactive',
               video: 'sendrecv',
-              screenShareVideo: 'recvonly',
+              screenShare: 'recvonly',
             },
             remoteQualityLevel: 'HIGH',
             expectedDebugId,
@@ -2254,7 +2259,68 @@ describe('plugin-meetings', () => {
             direction: {
               audio: 'inactive',
               video: 'sendrecv',
-              screenShareVideo: 'recvonly',
+              screenShare: 'recvonly',
+            },
+            remoteQualityLevel: 'HIGH',
+            expectedDebugId,
+            meetingId: meeting.id
+          });
+
+          // and SDP offer was sent with the right audioMuted/videoMuted values
+          checkSdpOfferSent({audioMuted: true, videoMuted: true});
+
+          // and no other local mute requests were sent to Locus
+          assert.calledOnce(locusMediaRequestStub);
+        });
+
+
+        it('addMedia() works correctly when video is disabled with no tracks to publish', async () => {
+          await meeting.addMedia({videoEnabled: false});
+          await simulateRoapOffer();
+
+          // check RoapMediaConnection was created correctly
+          checkMediaConnectionCreated({
+            mediaConnectionConfig: expectedMediaConnectionConfig,
+            localStreams: {
+              audio: undefined,
+              video: undefined,
+              screenShareVideo: undefined,
+              screenShareAudio: undefined,
+            },
+            direction: {
+              audio: 'sendrecv',
+              video: 'inactive',
+              screenShare: 'recvonly',
+            },
+            remoteQualityLevel: 'HIGH',
+            expectedDebugId,
+            meetingId: meeting.id
+          });
+
+          // and SDP offer was sent with the right audioMuted/videoMuted values
+          checkSdpOfferSent({audioMuted: true, videoMuted: true});
+
+          // and no other local mute requests were sent to Locus
+          assert.calledOnce(locusMediaRequestStub);
+        });
+
+        it('addMedia() works correctly when screen share is disabled with no tracks to publish', async () => {
+          await meeting.addMedia({shareAudioEnabled: false, shareVideoEnabled: false});
+          await simulateRoapOffer();
+
+          // check RoapMediaConnection was created correctly
+          checkMediaConnectionCreated({
+            mediaConnectionConfig: expectedMediaConnectionConfig,
+            localStreams: {
+              audio: undefined,
+              video: undefined,
+              screenShareVideo: undefined,
+              screenShareAudio: undefined,
+            },
+            direction: {
+              audio: 'sendrecv',
+              video: 'sendrecv',
+              screenShare: 'inactive',
             },
             remoteQualityLevel: 'HIGH',
             expectedDebugId,