@webex/plugin-meetings 3.0.0-beta.240 → 3.0.0-beta.241

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/plugin-meetings",
-  "version": "3.0.0-beta.240",
+  "version": "3.0.0-beta.241",
   "description": "",
   "license": "Cisco EULA (https://www.cisco.com/c/en/us/products/end-user-license-agreement.html)",
   "contributors": [
@@ -32,12 +32,12 @@
     "build": "yarn run -T tsc --declaration true --declarationDir ./dist/types"
   },
   "devDependencies": {
-    "@webex/plugin-meetings": "3.0.0-beta.240",
-    "@webex/test-helper-chai": "3.0.0-beta.240",
-    "@webex/test-helper-mocha": "3.0.0-beta.240",
-    "@webex/test-helper-mock-webex": "3.0.0-beta.240",
-    "@webex/test-helper-retry": "3.0.0-beta.240",
-    "@webex/test-helper-test-users": "3.0.0-beta.240",
+    "@webex/plugin-meetings": "3.0.0-beta.241",
+    "@webex/test-helper-chai": "3.0.0-beta.241",
+    "@webex/test-helper-mocha": "3.0.0-beta.241",
+    "@webex/test-helper-mock-webex": "3.0.0-beta.241",
+    "@webex/test-helper-retry": "3.0.0-beta.241",
+    "@webex/test-helper-test-users": "3.0.0-beta.241",
     "chai": "^4.3.4",
     "chai-as-promised": "^7.1.1",
     "jsdom-global": "3.0.2",
@@ -46,19 +46,19 @@
     "typescript": "^4.7.4"
   },
   "dependencies": {
-    "@webex/common": "3.0.0-beta.240",
+    "@webex/common": "3.0.0-beta.241",
     "@webex/internal-media-core": "1.39.3",
-    "@webex/internal-plugin-conversation": "3.0.0-beta.240",
-    "@webex/internal-plugin-device": "3.0.0-beta.240",
-    "@webex/internal-plugin-llm": "3.0.0-beta.240",
-    "@webex/internal-plugin-mercury": "3.0.0-beta.240",
-    "@webex/internal-plugin-metrics": "3.0.0-beta.240",
-    "@webex/internal-plugin-support": "3.0.0-beta.240",
-    "@webex/internal-plugin-user": "3.0.0-beta.240",
-    "@webex/media-helpers": "3.0.0-beta.240",
-    "@webex/plugin-people": "3.0.0-beta.240",
-    "@webex/plugin-rooms": "3.0.0-beta.240",
-    "@webex/webex-core": "3.0.0-beta.240",
+    "@webex/internal-plugin-conversation": "3.0.0-beta.241",
+    "@webex/internal-plugin-device": "3.0.0-beta.241",
+    "@webex/internal-plugin-llm": "3.0.0-beta.241",
+    "@webex/internal-plugin-mercury": "3.0.0-beta.241",
+    "@webex/internal-plugin-metrics": "3.0.0-beta.241",
+    "@webex/internal-plugin-support": "3.0.0-beta.241",
+    "@webex/internal-plugin-user": "3.0.0-beta.241",
+    "@webex/media-helpers": "3.0.0-beta.241",
+    "@webex/plugin-people": "3.0.0-beta.241",
+    "@webex/plugin-rooms": "3.0.0-beta.241",
+    "@webex/webex-core": "3.0.0-beta.241",
     "ampersand-collection": "^2.0.2",
     "bowser": "^2.11.0",
     "btoa": "^1.2.1",

package/src/meeting/index.ts

@@ -5047,7 +5047,9 @@ export default class Meeting extends StatelessWebexPlugin {
             errors: [
               // @ts-ignore
               this.webex.internal.newMetrics.callDiagnosticMetrics.getErrorPayloadForClientErrorCode(
-                CALL_DIAGNOSTIC_CONFIG.ICE_FAILURE_CLIENT_CODE
+                {
+                  clientErrorCode: CALL_DIAGNOSTIC_CONFIG.ICE_FAILURE_CLIENT_CODE,
+                }
               ),
             ],
           },
@@ -5566,7 +5568,9 @@ export default class Meeting extends StatelessWebexPlugin {
               errors: [
                 // @ts-ignore
                 this.webex.internal.newMetrics.callDiagnosticMetrics.getErrorPayloadForClientErrorCode(
-                  CALL_DIAGNOSTIC_CONFIG.ICE_FAILURE_CLIENT_CODE
+                  {
+                    clientErrorCode: CALL_DIAGNOSTIC_CONFIG.ICE_FAILURE_CLIENT_CODE,
+                  }
                 ),
               ],
             },

package/test/unit/spec/meeting/index.js

@@ -1374,9 +1374,10 @@ describe('plugin-meetings', () => {
         });
 
         it('should reject if waitForMediaConnectionConnected() rejects', async () => {
-          webex.internal.newMetrics.callDiagnosticMetrics.getErrorPayloadForClientErrorCode = sinon
+          const FAKE_ERROR = {fatal: true};
+          const getErrorPayloadForClientErrorCodeStub = webex.internal.newMetrics.callDiagnosticMetrics.getErrorPayloadForClientErrorCode = sinon
             .stub()
-            .returns({});
+            .returns(FAKE_ERROR);
           meeting.meetingState = 'ACTIVE';
           meeting.mediaProperties.waitForMediaConnectionConnected.rejects(new Error('fake error'));
 
@@ -1390,14 +1391,14 @@ describe('plugin-meetings', () => {
               errorThrown = true;
             });
 
+          assert.calledOnceWithExactly(getErrorPayloadForClientErrorCodeStub, {clientErrorCode: 2004});
           assert.calledTwice(webex.internal.newMetrics.submitClientEvent);
-
           assert.calledWithMatch(webex.internal.newMetrics.submitClientEvent, {
             name: 'client.ice.end',
             payload: {
               canProceed: false,
               icePhase: 'JOIN_MEETING_FINAL',
-              errors: [{}],
+              errors: [FAKE_ERROR],
             },
             options: {
               meetingId: meeting.id,
@@ -4488,20 +4489,22 @@ describe('plugin-meetings', () => {
 
         describe('submitClientEvent on connectionFailed', () => {
           it('sends client.ice.end when connectionFailed on CONNECTION_STATE_CHANGED event', () => {
-            webex.internal.newMetrics.callDiagnosticMetrics.getErrorPayloadForClientErrorCode =
-              sinon.stub().returns({});
+            const FAKE_ERROR = {fatal: true};
+            const getErrorPayloadForClientErrorCodeStub = webex.internal.newMetrics.callDiagnosticMetrics.getErrorPayloadForClientErrorCode = sinon
+              .stub()
+              .returns(FAKE_ERROR);
             meeting.setupMediaConnectionListeners();
             eventListeners[Event.CONNECTION_STATE_CHANGED]({
               state: 'Failed',
             });
+            assert.calledOnceWithExactly(getErrorPayloadForClientErrorCodeStub, {clientErrorCode: 2004});
             assert.calledOnce(webex.internal.newMetrics.submitClientEvent);
-
             assert.calledWithMatch(webex.internal.newMetrics.submitClientEvent, {
               name: 'client.ice.end',
               payload: {
                 canProceed: false,
                 icePhase: 'IN_MEETING',
-                errors: [{}],
+                errors: [FAKE_ERROR],
               },
               options: {
                 meetingId: meeting.id,