@webex/plugin-meetings 3.0.0-beta.202 → 3.0.0-beta.204

package/test/unit/spec/locus-info/index.js

@@ -1409,14 +1409,19 @@ describe('plugin-meetings', () => {
       it('emits MEETING_INFO_UPDATED and updates the meeting if the info changes', () => {
         const initialInfo = cloneDeep(meetingInfo);
 
-        locusInfo.emitScoped = sinon.stub();
+        let expectedMeeting;
 
-        // set the info initially as locusInfo.info starts as undefined
-        locusInfo.updateMeetingInfo(initialInfo, self);
+        /*
+        When the event is triggered, it is required that the meeting has already
+        been updated. This is why the meeting is being checked within the stubbed event emitter
+        */
+        sinon.stub(locusInfo, 'emitScoped').callsFake(() => {
+          assert.deepEqual(mockMeeting, expectedMeeting);
+        })
 
-        // since it was initially undefined, this should trigger the event
-        checkMeetingInfoUpdatedCalled(true);
-        assert.deepEqual(mockMeeting, {
+
+        // set the info initially as locusInfo.info starts as undefined
+        expectedMeeting = {
           coHost: {
             LOWER_SOMEONE_ELSES_HAND: true,
           },
@@ -1430,17 +1435,19 @@ describe('plugin-meetings', () => {
             ROSTER_IN_MEETING: true,
           },
           userDisplayHints: ['ROSTER_IN_MEETING', 'LOCK_STATUS_UNLOCKED'],
-        });
+        };
+        locusInfo.updateMeetingInfo(initialInfo, self);
+
+        // since it was initially undefined, this should trigger the event
+
+        checkMeetingInfoUpdatedCalled(true);
 
         const newInfo = cloneDeep(meetingInfo);
 
         newInfo.displayHints.coHost = [DISPLAY_HINTS.LOCK_CONTROL_LOCK];
 
         // Updating with different info should trigger the event
-        locusInfo.updateMeetingInfo(newInfo, self);
-
-        checkMeetingInfoUpdatedCalled(true);
-        assert.deepEqual(mockMeeting, {
+        expectedMeeting = {
           coHost: {
             LOWER_SOMEONE_ELSES_HAND: true,
             LOCK_CONTROL_LOCK: true,
@@ -1455,14 +1462,13 @@ describe('plugin-meetings', () => {
             ROSTER_IN_MEETING: true,
           },
           userDisplayHints: ['ROSTER_IN_MEETING', 'LOCK_STATUS_UNLOCKED'],
-        });
-
-        // update it with the same info
+        };
         locusInfo.updateMeetingInfo(newInfo, self);
 
-        // since the info is the same it should not call trigger the event
-        checkMeetingInfoUpdatedCalled(false);
-        assert.deepEqual(mockMeeting, {
+        checkMeetingInfoUpdatedCalled(true);
+
+        // update it with the same info
+        expectedMeeting = {
           coHost: {
             LOWER_SOMEONE_ELSES_HAND: true,
             LOCK_CONTROL_LOCK: true,
@@ -1477,7 +1483,11 @@ describe('plugin-meetings', () => {
             ROSTER_IN_MEETING: true,
           },
           userDisplayHints: ['ROSTER_IN_MEETING', 'LOCK_STATUS_UNLOCKED'],
-        });
+        };
+        locusInfo.updateMeetingInfo(newInfo, self);
+
+        // since the info is the same it should not call trigger the event
+        checkMeetingInfoUpdatedCalled(false);
 
         // update it with the same info, but roles changed
         const updateSelf = cloneDeep(self);
@@ -1485,10 +1495,7 @@ describe('plugin-meetings', () => {
           type: 'COHOST',
           hasRole: true,
         });
-        locusInfo.updateMeetingInfo(newInfo, updateSelf);
-        // since the info is the same but roles changed, it should call trigger the event
-        checkMeetingInfoUpdatedCalledForRoles(true);
-        assert.deepEqual(mockMeeting, {
+        expectedMeeting = {
           coHost: {
             LOWER_SOMEONE_ELSES_HAND: true,
             LOCK_CONTROL_LOCK: true,
@@ -1508,7 +1515,10 @@ describe('plugin-meetings', () => {
             'LOCK_CONTROL_LOCK',
             'LOWER_SOMEONE_ELSES_HAND',
           ],
-        });
+        };
+        locusInfo.updateMeetingInfo(newInfo, updateSelf);
+        // since the info is the same but roles changed, it should call trigger the event
+        checkMeetingInfoUpdatedCalledForRoles(true);
       });
 
       it('gets roles from self if available', () => {

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -69,6 +69,7 @@ describe('plugin-meetings', () => {
         canTransferFile: null,
         canAnnotate: null,
         canUseVoip: null,
+        canShareWhiteBoard: null,
         ...expected,
       };
 
@@ -143,6 +144,7 @@ describe('plugin-meetings', () => {
       'canTransferFile',
       'canAnnotate',
       'canUseVoip',
+      'canShareWhiteBoard',
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();

package/test/unit/spec/meeting/index.js

@@ -5868,6 +5868,7 @@ describe('plugin-meetings', () => {
         let canSendReactionsSpy;
         let canUserRenameSelfAndObservedSpy;
         let canUserRenameOthersSpy;
+        let canShareWhiteBoardSpy;
         // Due to import tree issues, hasHints must be stubed within the scope of the `it`.
 
         beforeEach(() => {
@@ -5893,6 +5894,7 @@ describe('plugin-meetings', () => {
           canSendReactionsSpy = sinon.spy(MeetingUtil, 'canSendReactions');
           canUserRenameSelfAndObservedSpy = sinon.spy(MeetingUtil, 'canUserRenameSelfAndObserved');
           canUserRenameOthersSpy = sinon.spy(MeetingUtil, 'canUserRenameOthers');
+          canShareWhiteBoardSpy = sinon.spy(MeetingUtil, 'canShareWhiteBoard');
         });
 
         afterEach(() => {
@@ -5947,6 +5949,7 @@ describe('plugin-meetings', () => {
             it(`${actionName} is ${expectedEnabled} when the call type is ${callType}`, () => {
               meeting.type = callType;
               meeting.userDisplayHints = [];
+              meeting.meetingInfo = {some: 'info'};
 
               meeting.updateMeetingActions();
 
@@ -6005,7 +6008,7 @@ describe('plugin-meetings', () => {
               requiredPolicies: [SELF_POLICY.SUPPORT_ANNOTATION],
             },
           ],
-          ({actionName, requiredDisplayHints, requiredPolicies, enableUnifiedMeetings}) => {
+          ({actionName, requiredDisplayHints, requiredPolicies, enableUnifiedMeetings, meetingInfo}) => {
             it(`${actionName} is enabled when the conditions are met`, () => {
               meeting.userDisplayHints = requiredDisplayHints;
               meeting.selfUserPolicies = {};
@@ -6014,6 +6017,8 @@ describe('plugin-meetings', () => {
                 ? true
                 : enableUnifiedMeetings;
 
+              meeting.meetingInfo = isUndefined(meetingInfo) ? {some: 'info'} : meetingInfo;
+
               forEach(requiredPolicies, (policy) => {
                 meeting.selfUserPolicies[policy] = true;
               });
@@ -6028,6 +6033,8 @@ describe('plugin-meetings', () => {
                 meeting.userDisplayHints = [];
                 meeting.selfUserPolicies = {};
 
+                meeting.meetingInfo = isUndefined(meetingInfo) ? {some: 'info'} : meetingInfo;
+
                 forEach(requiredPolicies, (policy) => {
                   meeting.selfUserPolicies[policy] = true;
                 });
@@ -6042,6 +6049,8 @@ describe('plugin-meetings', () => {
               meeting.userDisplayHints = requiredDisplayHints;
               meeting.selfUserPolicies = {};
 
+              meeting.meetingInfo = isUndefined(meetingInfo) ? {some: 'info'} : meetingInfo;
+
               meeting.updateMeetingActions();
 
               assert.isFalse(meeting.inMeetingActions.get()[actionName]);
@@ -6093,6 +6102,24 @@ describe('plugin-meetings', () => {
           assert.isTrue(meeting.inMeetingActions.get()['canUseVoip']);
         });
 
+        it('canUseVoip is enabled when there is no meeting info', () => {
+          meeting.config.experimental.enableUnifiedMeetings = true;
+
+          meeting.updateMeetingActions();
+
+          assert.isTrue(meeting.inMeetingActions.get()['canUseVoip']);
+        });
+
+        it('canUseVoip is enabled when it is a locus call', () => {
+          meeting.config.experimental.enableUnifiedMeetings = true;
+          meeting.meetingInfo = {some: 'info'};
+          meeting.type = 'CALL';
+
+          meeting.updateMeetingActions();
+
+          assert.isTrue(meeting.inMeetingActions.get()['canUseVoip']);
+        });
+
         it('canUseVoip is disabled based on api info when supportVoip is false', () => {
           meeting.userDisplayHints = undefined;
           meeting.selfUserPolicies = {[SELF_POLICY.SUPPORT_VOIP]: true};
@@ -6157,6 +6184,7 @@ describe('plugin-meetings', () => {
           assert.calledWith(canSendReactionsSpy, null, userDisplayHints);
           assert.calledWith(canUserRenameSelfAndObservedSpy, userDisplayHints);
           assert.calledWith(canUserRenameOthersSpy, userDisplayHints);
+          assert.calledWith(canShareWhiteBoardSpy, userDisplayHints);
 
           assert.calledWith(ControlsOptionsUtil.hasHints, {
             requiredHints: [DISPLAY_HINTS.MUTE_ALL],
@@ -6283,13 +6311,9 @@ describe('plugin-meetings', () => {
           updateLLMConnectionSpy = sinon.spy(meeting, 'updateLLMConnection');
         });
 
-        const check = async (url, expectedCalled) => {
+        const check = (url, expectedCalled) => {
           meeting.handleDataChannelUrlChange(url);
 
-          assert.notCalled(updateLLMConnectionSpy);
-
-          await testUtils.waitUntil(0);
-
           if (expectedCalled) {
             assert.calledWith(updateLLMConnectionSpy);
           } else {
@@ -6297,17 +6321,17 @@ describe('plugin-meetings', () => {
           }
         };
 
-        it('calls deferred updateLLMConnection if datachannelURL is set and the enableAutomaticLLM is true', async () => {
+        it('calls deferred updateLLMConnection if datachannelURL is set and the enableAutomaticLLM is true', () => {
           meeting.config.enableAutomaticLLM = true;
           check('some url', true);
         });
 
-        it('does not call updateLLMConnection if datachannelURL is undefined', async () => {
+        it('does not call updateLLMConnection if datachannelURL is undefined', () => {
           meeting.config.enableAutomaticLLM = true;
           check(undefined, false);
         });
 
-        it('does not call updateLLMConnection if enableAutomaticLLM is false', async () => {
+        it('does not call updateLLMConnection if enableAutomaticLLM is false', () => {
           check('some url', false);
         });
       });

package/test/unit/spec/meeting/utils.js

@@ -633,6 +633,13 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('canShareWhiteBoard', () => {
+      it('works as expected', () => {
+        assert.deepEqual(MeetingUtil.canShareWhiteBoard(['SHARE_WHITEBOARD']), true);
+        assert.deepEqual(MeetingUtil.canShareWhiteBoard([]), false);
+      });
+    });
+
     describe('bothLeaveAndEndMeetingAvailable', () => {
       it('works as expected', () => {
         assert.deepEqual(

package/test/unit/spec/meetings/index.js

@@ -1371,7 +1371,7 @@ describe('plugin-meetings', () => {
             );
             assert.calledOnce(webex.meetings.meetingInfo.fetchMeetingInfo);
             assert.calledOnce(MeetingsUtil.getMeetingAddedType);
-            assert.calledTwice(TriggerProxy.trigger);
+            assert.calledThrice(TriggerProxy.trigger);
             assert.calledWith(
               webex.meetings.meetingInfo.fetchMeetingInfo,
               'test destination',