@webex/plugin-meetings 3.0.0-beta.2 → 3.0.0-beta.21

package/test/unit/spec/media/index.ts

@@ -1,4 +1,4 @@
-import * as internalMediaModule from '@webex/plugin-meetings/src/media/internal-media-core-wrapper';
+import * as internalMediaModule from '@webex/internal-media-core';
 import Media from '@webex/plugin-meetings/src/media/index';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
@@ -29,8 +29,8 @@ describe('createMediaConnection', () => {
     const ENABLE_EXTMAP = false;
     const ENABLE_RTX = true;
 
-    Media.createMediaConnection(
-      {
+    Media.createMediaConnection(false, 'some debug id', {
+      mediaProperties: {
         mediaDirection: {
           sendAudio: true,
           sendVideo: true,
@@ -43,18 +43,15 @@ describe('createMediaConnection', () => {
         videoTrack: fakeVideoTrack,
         shareTrack: null,
       },
-      {
-        isMultistream: false,
-        remoteQualityLevel: 'HIGH',
-        enableRtx: ENABLE_RTX,
-        enableExtmap: ENABLE_EXTMAP,
-        turnServerInfo: {
-          url: 'turn server url',
-          username: 'turn username',
-          password: 'turn password',
-        },
-      }
-    );
+      remoteQualityLevel: 'HIGH',
+      enableRtx: ENABLE_RTX,
+      enableExtmap: ENABLE_EXTMAP,
+      turnServerInfo: {
+        url: 'turn server url',
+        username: 'turn username',
+        password: 'turn password',
+      },
+    });
     assert.calledOnce(roapMediaConnectionConstructorStub);
     assert.calledWith(
       roapMediaConnectionConstructorStub,
@@ -94,7 +91,7 @@ describe('createMediaConnection', () => {
           remoteQualityLevel: 'HIGH',
         },
       },
-      'mc'
+      'some debug id'
     );
   });
 
@@ -103,17 +100,13 @@ describe('createMediaConnection', () => {
       .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    Media.createMediaConnection(
-      {},
-      {
-        isMultistream: true,
-        turnServerInfo: {
-          url: 'turn server url',
-          username: 'turn username',
-          password: 'turn password',
-        },
-      }
-    );
+    Media.createMediaConnection(true, 'some debug id', {
+      turnServerInfo: {
+        url: 'turn server url',
+        username: 'turn username',
+        password: 'turn password',
+      },
+    });
     assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
       multistreamRoapMediaConnectionConstructorStub,
@@ -126,7 +119,7 @@ describe('createMediaConnection', () => {
           },
         ],
       },
-      'mc'
+      'some debug id'
     );
   });
 
@@ -135,20 +128,14 @@ describe('createMediaConnection', () => {
       .stub(internalMediaModule, 'MultistreamRoapMediaConnection')
       .returns(fakeRoapMediaConnection);
 
-    Media.createMediaConnection(
-      {},
-      {
-        isMultistream: true,
-        turnServerInfo: undefined,
-      }
-    );
+    Media.createMediaConnection(true, 'debug string', {});
     assert.calledOnce(multistreamRoapMediaConnectionConstructorStub);
     assert.calledWith(
       multistreamRoapMediaConnectionConstructorStub,
       {
         iceServers: [],
       },
-      'mc'
+      'debug string'
     );
   });
 
@@ -162,8 +149,8 @@ describe('createMediaConnection', () => {
     const ENABLE_EXTMAP = false;
     const ENABLE_RTX = true;
 
-    Media.createMediaConnection(
-      {
+    Media.createMediaConnection(false, 'some debug id', {
+      mediaProperties: {
         mediaDirection: {
           sendAudio: true,
           sendVideo: true,
@@ -176,14 +163,11 @@ describe('createMediaConnection', () => {
         videoTrack: null,
         shareTrack: fakeVideoTrack,
       },
-      {
-        isMultistream: false,
-        remoteQualityLevel: 'HIGH',
-        enableRtx: ENABLE_RTX,
-        enableExtmap: ENABLE_EXTMAP,
-        turnServerInfo: undefined,
-      }
-    );
+      remoteQualityLevel: 'HIGH',
+      enableRtx: ENABLE_RTX,
+      enableExtmap: ENABLE_EXTMAP,
+      turnServerInfo: undefined,
+    });
     assert.calledOnce(roapMediaConnectionConstructorStub);
     assert.calledWith(
       roapMediaConnectionConstructorStub,
@@ -217,7 +201,7 @@ describe('createMediaConnection', () => {
           remoteQualityLevel: 'HIGH',
         },
       },
-      'mc'
+      'some debug id'
     );
   });
 });

package/test/unit/spec/media/properties.ts

@@ -1,6 +1,6 @@
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
-import {MediaConnection as MC} from '@webex/internal-media-core';
+import {ConnectionState, Event} from '@webex/internal-media-core';
 import MediaProperties from '@webex/plugin-meetings/src/media/properties';
 import MediaUtil from '@webex/plugin-meetings/src/media/util';
 import testUtils from '../../../utils/testUtils';
@@ -19,7 +19,7 @@ describe('MediaProperties', () => {
       getStats: sinon.stub().resolves([]),
       on: sinon.stub(),
       off: sinon.stub(),
-      getConnectionState: sinon.stub().returns(MC.ConnectionState.Connected),
+      getConnectionState: sinon.stub().returns(ConnectionState.Connected),
     };
 
     mediaProperties = new MediaProperties();
@@ -35,7 +35,7 @@ describe('MediaProperties', () => {
       await mediaProperties.waitForMediaConnectionConnected();
     });
     it('rejects after timeout if ice state does not reach connected/completed', async () => {
-      mockMC.getConnectionState.returns(MC.ConnectionState.Connecting);
+      mockMC.getConnectionState.returns(ConnectionState.Connecting);
 
       let promiseResolved = false;
       let promiseRejected = false;
@@ -60,15 +60,15 @@ describe('MediaProperties', () => {
 
       // check that listener was registered and removed
       assert.calledOnce(mockMC.on);
-      assert.equal(mockMC.on.getCall(0).args[0], MC.Event.CONNECTION_STATE_CHANGED);
+      assert.equal(mockMC.on.getCall(0).args[0], Event.CONNECTION_STATE_CHANGED);
       const listener = mockMC.on.getCall(0).args[1];
 
       assert.calledOnce(mockMC.off);
-      assert.calledWith(mockMC.off, MC.Event.CONNECTION_STATE_CHANGED, listener);
+      assert.calledWith(mockMC.off, Event.CONNECTION_STATE_CHANGED, listener);
     });
 
     it(`resolves when media connection reaches "connected" state`, async () => {
-      mockMC.getConnectionState.returns(MC.ConnectionState.Connecting);
+      mockMC.getConnectionState.returns(ConnectionState.Connecting);
 
       const clearTimeoutSpy = sinon.spy(clock, 'clearTimeout');
 
@@ -89,11 +89,11 @@ describe('MediaProperties', () => {
 
       // check the right listener was registered
       assert.calledOnce(mockMC.on);
-      assert.equal(mockMC.on.getCall(0).args[0], MC.Event.CONNECTION_STATE_CHANGED);
+      assert.equal(mockMC.on.getCall(0).args[0], Event.CONNECTION_STATE_CHANGED);
       const listener = mockMC.on.getCall(0).args[1];
 
       // call the listener and pretend we are now connected
-      mockMC.getConnectionState.returns(MC.ConnectionState.Connected);
+      mockMC.getConnectionState.returns(ConnectionState.Connected);
       listener();
       await testUtils.flushPromises();
 
@@ -102,7 +102,7 @@ describe('MediaProperties', () => {
 
       // check that listener was removed
       assert.calledOnce(mockMC.off);
-      assert.calledWith(mockMC.off, MC.Event.CONNECTION_STATE_CHANGED, listener);
+      assert.calledWith(mockMC.off, Event.CONNECTION_STATE_CHANGED, listener);
 
       assert.calledOnce(clearTimeoutSpy);
     });

package/test/unit/spec/meeting/effectsState.js

@@ -12,6 +12,8 @@ import MeetingUtil from '@webex/plugin-meetings/src/meeting/util';
 import createEffectsState from '@webex/plugin-meetings/src/meeting/effectsState';
 import LoggerProxy from '@webex/plugin-meetings/src/common/logs/logger-proxy';
 import LoggerConfig from '@webex/plugin-meetings/src/common/logs/logger-config';
+import LLM from '@webex/internal-plugin-llm';
+import Mercury from '@webex/internal-plugin-mercury';
 
 describe('plugin-meetings', () => {
   const logger = {
@@ -20,7 +22,7 @@ describe('plugin-meetings', () => {
     error: () => {},
     warn: () => {},
     trace: () => {},
-    debug: () => {}
+    debug: () => {},
   };
 
   beforeEach(() => {
@@ -34,8 +36,8 @@ describe('plugin-meetings', () => {
     writable: true,
     value: {
       getSupportedConstraints: sinon.stub().returns({
-        sampleRate: true
-      })
+        sampleRate: true,
+      }),
     },
   });
   LoggerConfig.set({verboseEvents: true, enable: false});
@@ -51,8 +53,8 @@ describe('plugin-meetings', () => {
     readyState: 'live',
     enabled: true,
     getSettings: () => ({
-      sampleRate: 48000
-    })
+      sampleRate: 48000,
+    }),
   });
 
   class FakeMediaStream {
@@ -85,7 +87,7 @@ describe('plugin-meetings', () => {
         connect: () => undefined,
         mediaStream: {
           getAudioTracks() {
-          // eslint-disable-next-line no-undef
+            // eslint-disable-next-line no-undef
             return [new MediaStreamTrack()];
           },
         },
@@ -96,7 +98,7 @@ describe('plugin-meetings', () => {
       return {
         stream: {
           getAudioTracks() {
-          // eslint-disable-next-line no-undef
+            // eslint-disable-next-line no-undef
             return [new MediaStreamTrack()];
           },
         },
@@ -112,7 +114,7 @@ describe('plugin-meetings', () => {
     }
 
     connect() {
-    /* placeholder method */
+      /* placeholder method */
     }
   }
 
@@ -128,7 +130,7 @@ describe('plugin-meetings', () => {
 
     getSettings() {
       return {
-        sampleRate: 48000
+        sampleRate: 48000,
       };
     }
   }
@@ -157,15 +159,17 @@ describe('plugin-meetings', () => {
   beforeEach(() => {
     webex = new MockWebex({
       children: {
-        meetings: Meetings
+        meetings: Meetings,
+        llm: LLM,
+        mercury: Mercury,
       }
     });
     meeting = new Meeting(
       {
-        userId: uuid1
+        userId: uuid1,
       },
       {
-        parent: webex
+        parent: webex,
       }
     );
 
@@ -179,9 +183,11 @@ describe('plugin-meetings', () => {
     sinon.replace(meeting, 'addMedia', () => {
       sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack());
       sinon.stub(meeting.mediaProperties, 'mediaDirection').value({
-        receiveAudio: true
+        receiveAudio: true,
       });
-      sinon.stub(meeting.mediaProperties, 'webrtcMediaConnection').value({updateSendReceiveOptions: sinon.stub()});
+      sinon
+        .stub(meeting.mediaProperties, 'webrtcMediaConnection')
+        .value({updateSendReceiveOptions: sinon.stub()});
     });
   });
 
@@ -200,10 +206,7 @@ describe('plugin-meetings', () => {
         assert.equal(effects.state.bnr.enabled, BNR_STATUS.ENABLED);
 
         assert(Metrics.sendBehavioralMetric.calledOnce);
-        assert.calledWith(
-          Metrics.sendBehavioralMetric,
-          BEHAVIORAL_METRICS.ENABLE_BNR_SUCCESS,
-        );
+        assert.calledWith(Metrics.sendBehavioralMetric, BEHAVIORAL_METRICS.ENABLE_BNR_SUCCESS);
       });
 
       it('does resolve request if bnr is already enabled', async () => {
@@ -213,12 +216,14 @@ describe('plugin-meetings', () => {
       });
 
       it('if called twice, does bnr effect enable on audio track for the first request and resolves second', async () => {
-        Promise.all([effects.handleClientRequest(true, meeting), effects.handleClientRequest(true, meeting)])
-          .then((resolveFirst, resolveSecond) => {
-            assert.isTrue(resolveFirst);
-            assert.isTrue(resolveSecond);
-            assert.calledOnce(MediaUtil.createMediaStream);
-          });
+        Promise.all([
+          effects.handleClientRequest(true, meeting),
+          effects.handleClientRequest(true, meeting),
+        ]).then((resolveFirst, resolveSecond) => {
+          assert.isTrue(resolveFirst);
+          assert.isTrue(resolveSecond);
+          assert.calledOnce(MediaUtil.createMediaStream);
+        });
       });
 
       it('should throw error for inappropriate sample rate and send error metrics', async () => {
@@ -227,8 +232,8 @@ describe('plugin-meetings', () => {
           stop: () => {},
           readyState: 'live',
           getSettings: () => ({
-            sampleRate: 49000
-          })
+            sampleRate: 49000,
+          }),
         });
 
         sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack1());
@@ -237,16 +242,12 @@ describe('plugin-meetings', () => {
         MediaUtil.createMediaStream = sinon.stub().returns(new MediaStream([fakeMediaTrack1()]));
         try {
           await effects.handleClientRequest(true, meeting);
-        }
-        catch (err) {
+        } catch (err) {
           assert(Metrics.sendBehavioralMetric.calledOnce);
-          assert.calledWith(
-            Metrics.sendBehavioralMetric,
-            BEHAVIORAL_METRICS.ENABLE_BNR_FAILURE, {
-              reason: err.message,
-              stack: err.stack
-            }
-          );
+          assert.calledWith(Metrics.sendBehavioralMetric, BEHAVIORAL_METRICS.ENABLE_BNR_FAILURE, {
+            reason: err.message,
+            stack: err.stack,
+          });
           assert.equal(err.message, 'Sample rate of 49000 is not supported.');
         }
       });
@@ -265,25 +266,18 @@ describe('plugin-meetings', () => {
         assert.equal(effects.state.bnr.enabled, BNR_STATUS.NOT_ENABLED);
 
         assert(Metrics.sendBehavioralMetric.calledOnce);
-        assert.calledWith(
-          Metrics.sendBehavioralMetric,
-          BEHAVIORAL_METRICS.DISABLE_BNR_SUCCESS,
-        );
+        assert.calledWith(Metrics.sendBehavioralMetric, BEHAVIORAL_METRICS.DISABLE_BNR_SUCCESS);
       });
 
       it('reject request for disable bnr if not enabled', async () => {
         try {
           await effects.handleClientRequest(false, meeting);
-        }
-        catch (e) {
+        } catch (e) {
           assert.equal(e.message, 'Can not disable as BNR is not enabled');
           assert.equal(effects.state.bnr.enabled, BNR_STATUS.ENABLED);
 
           assert(Metrics.sendBehavioralMetric.calledOnce);
-          assert.calledWith(
-            Metrics.sendBehavioralMetric,
-            BEHAVIORAL_METRICS.DISABLE_BNR_FAILURE,
-          );
+          assert.calledWith(Metrics.sendBehavioralMetric, BEHAVIORAL_METRICS.DISABLE_BNR_FAILURE);
         }
       });
     });

package/test/unit/spec/meeting/in-meeting-actions.ts

@@ -1,7 +1,6 @@
 import {assert} from '@webex/test-helper-chai';
 import InMeetingActions from '@webex/plugin-meetings/src/meeting/in-meeting-actions';
 
-
 describe('plugin-meetings', () => {
   describe('in-meeting-actions', () => {
     const checkValues = (actions, expected?) => {
@@ -28,6 +27,8 @@ describe('plugin-meetings', () => {
         isRealTimeTranslationEnabled: null,
         canSelectSpokenLanguages: null,
         waitingForOthersToJoin: null,
+        canEnableReactions: null,
+        canSendReactions: null,
         ...expected
       };
 
@@ -61,7 +62,9 @@ describe('plugin-meetings', () => {
       'canViewCaptionPanel',
       'isRealTimeTranslationEnabled',
       'canSelectSpokenLanguages',
-      'waitingForOthersToJoin'
+      'waitingForOthersToJoin',
+      'canEnableReactions',
+      'canSendReactions'
     ].forEach((key) => {
       it(`get and set for ${key} work as expected`, () => {
         const inMeetingActions = new InMeetingActions();