@webex/plugin-meetings 3.0.0-beta.184 → 3.0.0-beta.186

package/test/unit/spec/locus-info/index.js

@@ -1547,6 +1547,7 @@ describe('plugin-meetings', () => {
           meeting: true,
           participants: true,
           url: 'newLocusUrl',
+          syncUrl: 'newSyncUrl',
         };
       });
 
@@ -1707,39 +1708,83 @@ describe('plugin-meetings', () => {
         assert.calledWith(meeting.locusInfo.onDeltaLocus, fakeLocus);
       });
 
-      it('applyLocusDeltaData gets full locus on DESYNC action', () => {
+      it('applyLocusDeltaData gets delta locus on DESYNC action if we have a syncUrl', () => {
         const {DESYNC} = LocusDeltaParser.loci;
+        const fakeDeltaLocus = {id: 'fake delta locus'};
         const meeting = {
           meetingRequest: {
-            getFullLocus: sandbox.stub().resolves(true),
+            getLocusDTO: sandbox.stub().resolves({body: fakeDeltaLocus}),
           },
           locusInfo: {
+            onDeltaLocus: sandbox.stub(),
+          },
+          locusUrl: 'oldLocusUrl',
+        };
+
+        locusInfo.locusParser.workingCopy = {
+          syncUrl: 'oldSyncUrl',
+        };
+
+        // Since we have a promise inside a function we want to test that's not returned,
+        // we will wait and stub it's last function to resolve this waiting promise.
+        // Also ensures .onDeltaLocus() is called before .resume()
+        return new Promise((resolve) => {
+          locusInfo.locusParser.resume = sandbox.stub().callsFake(() => resolve());
+          locusInfo.applyLocusDeltaData(DESYNC, fakeLocus, meeting);
+        }).then(() => {
+          assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, { url: 'oldSyncUrl' });
+
+          assert.calledOnceWithExactly(meeting.locusInfo.onDeltaLocus, fakeDeltaLocus);
+          assert.calledOnce(locusInfo.locusParser.resume);
+        });
+      });
+
+      it('applyLocusDeltaData gets delta locus on DESYNC action if we have a syncUrl (empty response body)', () => {
+        const {DESYNC} = LocusDeltaParser.loci;
+        const meeting = {
+          meetingRequest: {
+            getLocusDTO: sandbox.stub().resolves({body: {}}),
+          },
+          locusInfo: {
+            onDeltaLocus: sandbox.stub(),
             onFullLocus: sandbox.stub(),
           },
           locusUrl: 'oldLocusUrl',
         };
 
-        locusInfo.locusParser.resume = sandbox.stub();
-        locusInfo.applyLocusDeltaData(DESYNC, fakeLocus, meeting);
+        locusInfo.locusParser.workingCopy = {
+          syncUrl: 'oldSyncUrl',
+        };
 
-        assert.calledOnceWithExactly(meeting.meetingRequest.getFullLocus,
-          {
-            desync: true,
-            locusUrl: 'newLocusUrl',
-          }
-          );
+        // Since we have a promise inside a function we want to test that's not returned,
+        // we will wait and stub it's last function to resolve this waiting promise.
+        // Also ensures .onDeltaLocus() is called before .resume()
+        return new Promise((resolve) => {
+          locusInfo.locusParser.resume = sandbox.stub().callsFake(() => resolve());
+          locusInfo.applyLocusDeltaData(DESYNC, fakeLocus, meeting);
+        }).then(() => {
+          assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, { url: 'oldSyncUrl' });
+
+          assert.notCalled(meeting.locusInfo.onDeltaLocus);
+          assert.notCalled(meeting.locusInfo.onFullLocus);
+          assert.calledOnce(locusInfo.locusParser.resume);
+        });
       });
 
-      it('getFullLocus handles DESYNC action correctly', () => {
+      it('applyLocusDeltaData gets full locus on DESYNC action if we do not have a syncUrl', () => {
         const {DESYNC} = LocusDeltaParser.loci;
+        const fakeFullLocusDto = {id: 'fake full locus dto'};
         const meeting = {
           meetingRequest: {
-            getFullLocus: sandbox.stub().resolves({body: true}),
+            getLocusDTO: sandbox.stub().resolves({body: fakeFullLocusDto}),
           },
-          locusInfo,
+          locusInfo: {
+            onFullLocus: sandbox.stub(),
+          },
+          locusUrl: 'oldLocusUrl',
         };
 
-        locusInfo.onFullLocus = sandbox.stub();
+        locusInfo.locusParser.workingCopy = {}; // no syncUrl
 
         // Since we have a promise inside a function we want to test that's not returned,
         // we will wait and stub it's last function to resolve this waiting promise.
@@ -1748,7 +1793,9 @@ describe('plugin-meetings', () => {
           locusInfo.locusParser.resume = sandbox.stub().callsFake(() => resolve());
           locusInfo.applyLocusDeltaData(DESYNC, fakeLocus, meeting);
         }).then(() => {
-          assert.calledOnce(meeting.locusInfo.onFullLocus);
+          assert.calledOnceWithExactly(meeting.meetingRequest.getLocusDTO, { url: 'oldLocusUrl' });
+
+          assert.calledOnceWithExactly(meeting.locusInfo.onFullLocus, fakeFullLocusDto);
           assert.calledOnce(locusInfo.locusParser.resume);
         });
       });

package/test/unit/spec/meeting/index.js

@@ -226,7 +226,7 @@ describe('plugin-meetings', () => {
     membersSpy = sinon.spy(MembersImport, 'default');
     meetingRequestSpy = sinon.spy(MeetingRequestImport, 'default');
 
-    TriggerProxy.trigger = sinon.stub().returns(true);
+    sinon.stub(TriggerProxy, 'trigger').returns(true);
     Metrics.initialSetup(webex);
     MediaUtil.createMediaStream = sinon.stub().callsFake((tracks) => {
       return {

package/test/unit/spec/meeting/muteState.js

@@ -37,7 +37,7 @@ describe('plugin-meetings', () => {
       unmuteVideoAllowed: true,
 
       locusInfo: {
-        onDeltaLocus: sinon.stub(),
+        handleLocusDelta: sinon.stub(),
       },
       members: {
         selfId: 'fake self id',

package/test/unit/spec/meeting/utils.js

@@ -21,6 +21,7 @@ describe('plugin-meetings', () => {
         log: sandbox.stub(),
         error: sandbox.stub(),
         warn: sandbox.stub(),
+        debug: sandbox.stub(),
       };
 
       LoggerConfig.set({
@@ -42,6 +43,7 @@ describe('plugin-meetings', () => {
       meeting.annotaion = {cleanUp: sinon.stub()};
       meeting.getWebexObject = sinon.stub().returns(webex);
       meeting.simultaneousInterpretation = {cleanUp: sinon.stub()};
+      meeting.trigger = sinon.stub();
     });
 
     afterEach(() => {
@@ -177,10 +179,10 @@ describe('plugin-meetings', () => {
     });
 
     describe('updateLocusWithDelta', () => {
-      it('should call onDeltaLocus with the new delta locus', () => {
+      it('should call handleLocusDelta with the new delta locus', () => {
         const meeting = {
           locusInfo: {
-            onDeltaLocus: sinon.stub()
+            handleLocusDelta: sinon.stub()
           },
         };
 
@@ -193,13 +195,13 @@ describe('plugin-meetings', () => {
         const response = MeetingUtil.updateLocusWithDelta(meeting, originalResponse);
 
         assert.deepEqual(response, originalResponse);
-        assert.calledOnceWithExactly(meeting.locusInfo.onDeltaLocus, 'locus');
+        assert.calledOnceWithExactly(meeting.locusInfo.handleLocusDelta, 'locus', meeting);
       });
 
       it('should handle locus being missing from the response', () => {
         const meeting = {
           locusInfo: {
-            onDeltaLocus: sinon.stub(),
+            handleLocusDelta: sinon.stub(),
           },
         };
 
@@ -210,7 +212,7 @@ describe('plugin-meetings', () => {
         const response = MeetingUtil.updateLocusWithDelta(meeting, originalResponse);
 
         assert.deepEqual(response, originalResponse);
-        assert.notCalled(meeting.locusInfo.onDeltaLocus);
+        assert.notCalled(meeting.locusInfo.handleLocusDelta);
       });
 
       it('should work with an undefined meeting', () => {

package/test/unit/spec/meetings/index.js

@@ -57,7 +57,7 @@ describe('plugin-meetings', () => {
       verboseEvents: true,
       enable: false,
     });
-    TriggerProxy.trigger = sinon.stub().returns(true);
+    sinon.stub(TriggerProxy, 'trigger').returns(true);
   });
 
   let webex;

package/test/unit/spec/members/index.js

@@ -232,7 +232,7 @@ describe('plugin-meetings', () => {
       it('should send clear event if clear members', () => {
         const members = createMembers({url: url1});
         members.membersCollection.setAll(fakeMembersCollection);
-        Trigger.trigger = sinon.stub();
+        sinon.stub(Trigger, 'trigger');
         members.clearMembers();
         assert.deepEqual(members.membersCollection.members, {});
         assert.calledWith(
@@ -250,7 +250,6 @@ describe('plugin-meetings', () => {
     describe('#locusParticipantsUpdate', () => {
       it('should send member update event with session info', () => {
         const members = createMembers({url: url1});
-        Trigger.trigger = sinon.stub();
         const fakePayload = {
           participants: {
             forEach: sinon.stub(),