@webex/plugin-meetings 3.0.0-beta.181 → 3.0.0-beta.183

package/src/meeting/util.ts

@@ -11,6 +11,7 @@ import {
   DISPLAY_HINTS,
   FULL_STATE,
   SELF_POLICY,
+  EVENT_TRIGGERS,
 } from '../constants';
 import IntentToJoinError from '../common/errors/intent-to-join';
 import JoinMeetingError from '../common/errors/join-meeting';
@@ -18,6 +19,7 @@ import ParameterError from '../common/errors/parameter';
 import PermissionError from '../common/errors/permission';
 import PasswordError from '../common/errors/password-error';
 import CaptchaError from '../common/errors/captcha-error';
+import Trigger from '../common/events/trigger-proxy';
 
 const MeetingUtil = {
   parseLocusJoin: (response) => {
@@ -566,6 +568,47 @@ const MeetingUtil = {
 
     return userPolicies[feature];
   },
+
+  parseInterpretationInfo: (meeting, meetingInfo) => {
+    if (!meeting || !meetingInfo) {
+      return;
+    }
+    const siInfo = meetingInfo.simultaneousInterpretation;
+    meeting.simultaneousInterpretation.updateMeetingSIEnabled(
+      !!meetingInfo.turnOnSimultaneousInterpretation,
+      !!siInfo?.currentSIInterpreter
+    );
+    const hostSIEnabled = !!(
+      meetingInfo.turnOnSimultaneousInterpretation &&
+      meetingInfo?.meetingSiteSetting?.enableHostInterpreterControlSI
+    );
+    meeting.simultaneousInterpretation.updateHostSIEnabled(hostSIEnabled);
+
+    function renameKey(obj, oldKey, newKey) {
+      if (oldKey in obj) {
+        obj[newKey] = obj[oldKey];
+        delete obj[oldKey];
+      }
+    }
+    if (siInfo) {
+      const lanuagesInfo = cloneDeep(siInfo.siLanguages);
+      for (const language of lanuagesInfo) {
+        renameKey(language, 'languageCode', 'languageName');
+        renameKey(language, 'languageGroupId', 'languageCode');
+      }
+      if (!meeting.simultaneousInterpretation?.siLanguages?.length) {
+        meeting.simultaneousInterpretation.updateInterpretation(lanuagesInfo);
+      }
+    }
+    Trigger.trigger(
+      this,
+      {
+        file: 'meeting/util',
+        function: 'parseInterpretationInfo',
+      },
+      EVENT_TRIGGERS.MEETING_INTERPRETATION_UPDATE
+    );
+  },
 };
 
 export default MeetingUtil;

package/src/member/util.ts

@@ -364,8 +364,8 @@ MemberUtil.extractMediaStatus = (participant: any): IMediaStatus => {
   }
 
   return {
-    audio: participant.status.audioStatus,
-    video: participant.status.videoStatus,
+    audio: participant.status?.audioStatus,
+    video: participant.status?.videoStatus,
   };
 };
 

package/test/unit/spec/interpretation/index.ts

@@ -83,6 +83,25 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('#updateMeetingSIEnabled', () => {
+      it('update meeting SI feature is on or off, and self is scheduled interpreter or not', () => {
+        interpretation.updateMeetingSIEnabled(true, false);
+
+        assert.equal(interpretation.meetingSIEnabled, true);
+        assert.equal(interpretation.selfIsInterpreter, false);
+
+        interpretation.updateMeetingSIEnabled(true, true);
+
+        assert.equal(interpretation.meetingSIEnabled, true);
+        assert.equal(interpretation.selfIsInterpreter, true);
+
+        interpretation.updateMeetingSIEnabled(false, false);
+
+        assert.equal(interpretation.meetingSIEnabled, false);
+        assert.equal(interpretation.selfIsInterpreter, false);
+      });
+    });
+
     describe('#updateInterpretation', () => {
       const checkSILanguage = (siLanguage, expectResult) => {
         return siLanguage?.languageCode === expectResult.languageCode && siLanguage?.languageName === expectResult.languageName

package/test/unit/spec/locus-info/index.js

@@ -1648,12 +1648,39 @@ describe('plugin-meetings', () => {
         sandbox.stub(locusInfo, 'updateParticipants');
         sandbox.stub(locusInfo, 'isMeetingActive');
         sandbox.stub(locusInfo, 'handleOneOnOneEvent');
+        sandbox.stub(locusParser, 'isNewFullLocus').returns(true);
 
         locusInfo.onFullLocus(fakeLocus, eventType);
 
         assert.equal(fakeLocus, locusParser.workingCopy);
       });
 
+      it('onFullLocus() does not do anything if the incoming full locus DTO is old', () => {
+        const eventType = 'fakeEvent';
+
+        locusParser.workingCopy = {};
+
+        const oldWorkingCopy = locusParser.workingCopy;
+
+        const spies = [
+          sandbox.stub(locusInfo, 'updateParticipantDeltas'),
+          sandbox.stub(locusInfo, 'updateLocusInfo'),
+          sandbox.stub(locusInfo, 'updateParticipants'),
+          sandbox.stub(locusInfo, 'isMeetingActive'),
+          sandbox.stub(locusInfo, 'handleOneOnOneEvent'),
+        ];
+
+        sandbox.stub(locusParser, 'isNewFullLocus').returns(false);
+
+        locusInfo.onFullLocus(fakeLocus, eventType);
+
+        spies.forEach((spy) => {
+          assert.notCalled(spy);
+        })
+
+        assert.equal(oldWorkingCopy, locusParser.workingCopy);
+      });
+
       it('onDeltaAction applies locus delta data to meeting', () => {
         const action = 'fake action';
         const parsedLoci = 'fake loci';

package/test/unit/spec/locus-info/parser.js

@@ -238,6 +238,68 @@ describe('locus-info/parser', () => {
     });
   });
 
+  describe('Full Locus handling', () => {
+    describe('isNewFullLocus', () => {
+      let parser;
+
+      beforeEach(() => {
+        parser = new LocusDeltaParser();
+      })
+      it('returns false if incoming Locus is not valid', () => {
+        const fakeInvalidIncomingLocus = {};
+
+        parser.workingCopy = { sequence: {rangeStart: 0, rangeEnd: 0, entries: [1]}};
+
+        assert.isFalse(parser.isNewFullLocus(fakeInvalidIncomingLocus));
+      });
+
+      const runCheck = (incomingSequence, currentSequence, expectedResult) => {
+        parser.workingCopy = { sequence: {rangeStart: 0, rangeEnd: 0, entries: [1, 2, currentSequence]}};
+
+        const fakeIncomingLocus = { sequence: {rangeStart: 0, rangeEnd: 0, entries: [1, 10, incomingSequence]}};
+
+        assert.strictEqual(parser.isNewFullLocus(fakeIncomingLocus), expectedResult);
+      }
+      it('returns true if there is no working copy', () => {
+        const fakeIncomingLocus = { sequence: {rangeStart: 0, rangeEnd: 0, entries: [10]}};
+
+        // sanity check that we initially have no working copy 
+        assert.isNull(parser.workingCopy);
+
+        assert.isTrue(parser.isNewFullLocus(fakeIncomingLocus));
+      });
+
+      it('returns true if new sequence is higher than existing one', () => {
+        runCheck(101, 100, true);
+      });
+
+      it('returns false if new sequence is same than existing one', () => {
+        runCheck(100, 100, false);
+      });
+
+      it('returns false if new sequence is older than existing one', () => {
+        runCheck(99, 100, false);
+      });
+
+      it('returns true if incoming Locus has empty sequence', () => {
+        parser.workingCopy = { sequence: {rangeStart: 0, rangeEnd: 0, entries: [1, 2, 3]}};
+
+        const fakeIncomingLocus = { sequence: {rangeStart: 0, rangeEnd: 0, entries: []}};
+
+        assert.isTrue(parser.isNewFullLocus(fakeIncomingLocus));
+      });
+
+      it('returns true if working copy has empty sequence', () => {
+        parser.workingCopy = { sequence: {rangeStart: 0, rangeEnd: 0, entries: []}};
+
+        const fakeIncomingLocus = { sequence: {rangeStart: 0, rangeEnd: 0, entries: [1,2,3]}};
+
+        assert.isTrue(parser.isNewFullLocus(fakeIncomingLocus));
+      });
+
+    })
+  });
+
   describe('Invalid Locus objects', () => {
     let sandbox = null;
     let parser;

package/test/unit/spec/meeting/index.js

@@ -5531,25 +5531,27 @@ describe('plugin-meetings', () => {
 
           checkParseMeetingInfo(expectedInfoToParse);
         });
-        it('should set hostSIEnabled correctly depend on the toggle statue in site setting', () => {
-          const updateHostSIEnabledSpy = sinon.spy(meeting.simultaneousInterpretation, 'updateHostSIEnabled');
+        it('should parse interpretation info correctly', () => {
+          const parseInterpretationInfo = sinon.spy(MeetingUtil, 'parseInterpretationInfo');
           const mockToggleOnData = {
             body: {
               meetingSiteSetting: {
                 enableHostInterpreterControlSI: true,
+              },
+              turnOnSimultaneousInterpretation: true,
+              simultaneousInterpretation: {
+                currentSIInterpreter: false,
+                siLanguages: [
+                  {
+                    languageCode: "ar",
+                    languageGroupId: 4,
+                  },
+                ]
               }
             }
           };
           meeting.parseMeetingInfo(mockToggleOnData);
-          assert.calledWith(updateHostSIEnabledSpy, true);
-
-          const mockToggleOffData = {
-            body: {
-              meetingSiteSetting: {}
-            }
-          };
-          meeting.parseMeetingInfo(mockToggleOffData);
-          assert.calledWith(updateHostSIEnabledSpy, false);
+          assert.calledOnceWithExactly(parseInterpretationInfo, meeting, mockToggleOnData.body);
         });
       });
 

package/test/unit/spec/meeting/utils.js

@@ -740,5 +740,67 @@ describe('plugin-meetings', () => {
         assert.deepEqual(MeetingUtil.isBreakoutPreassignmentsEnabled([]), true);
       });
     });
+
+
+    describe('parseInterpretationInfo', () => {
+      let meetingInfo = {};
+      beforeEach(() => {
+        meeting.simultaneousInterpretation = {
+          updateMeetingSIEnabled: sinon.stub(),
+          updateHostSIEnabled: sinon.stub(),
+          updateInterpretation: sinon.stub(),
+          siLanguages: [],
+        };
+      });
+      it('should update simultaneous interpretation settings with SI and host enabled', () => {
+        meetingInfo.turnOnSimultaneousInterpretation = true;
+        meetingInfo.meetingSiteSetting = {
+          enableHostInterpreterControlSI: true,
+        };
+        meetingInfo.simultaneousInterpretation = {
+          currentSIInterpreter: true,
+          siLanguages: [
+            { languageCode: 'en', languageGroupId: 1 },
+            { languageCode: 'es', languageGroupId: 2 },
+          ],
+        };
+
+        MeetingUtil.parseInterpretationInfo(meeting, meetingInfo);
+        assert.calledWith(meeting.simultaneousInterpretation.updateMeetingSIEnabled, true, true);
+        assert.calledWith(meeting.simultaneousInterpretation.updateHostSIEnabled, true);
+        assert.calledWith(meeting.simultaneousInterpretation.updateInterpretation, [
+          { languageName: 'en', languageCode: 1 },
+          { languageName: 'es', languageCode: 2 },
+        ]);
+      });
+
+      it('should update simultaneous interpretation settings with host SI disabled', () => {
+        meetingInfo.meetingSiteSetting.enableHostInterpreterControlSI = false;
+        meetingInfo.simultaneousInterpretation.currentSIInterpreter = false;
+        MeetingUtil.parseInterpretationInfo(meeting, meetingInfo);
+        assert.calledWith(meeting.simultaneousInterpretation.updateMeetingSIEnabled, true, false);
+        assert.calledWith(meeting.simultaneousInterpretation.updateHostSIEnabled, false);
+        assert.calledWith(meeting.simultaneousInterpretation.updateInterpretation, [
+          { languageName: 'en', languageCode: 1 },
+          { languageName: 'es', languageCode: 2 },
+        ]);
+      });
+      it('should update simultaneous interpretation settings with SI disabled', () => {
+        meetingInfo.turnOnSimultaneousInterpretation = false;
+        MeetingUtil.parseInterpretationInfo(meeting, meetingInfo);
+        assert.calledWith(meeting.simultaneousInterpretation.updateMeetingSIEnabled, false, false);
+        assert.calledWith(meeting.simultaneousInterpretation.updateHostSIEnabled, false);
+      });
+
+      it('should not update simultaneous interpretation settings for invalid input', () => {
+        // Call the function with invalid inputs
+        MeetingUtil.parseInterpretationInfo(null, null);
+
+        // Ensure that the update functions are not called
+        assert.notCalled(meeting.simultaneousInterpretation.updateMeetingSIEnabled);
+        assert.notCalled(meeting.simultaneousInterpretation.updateHostSIEnabled);
+        assert.notCalled(meeting.simultaneousInterpretation.updateInterpretation);
+      });
+    });
   });
 });

package/test/unit/spec/meetings/index.js

@@ -1085,7 +1085,7 @@ describe('plugin-meetings', () => {
             assert.calledOnce(webex.meetings.meetingInfo.fetchMeetingInfo);
             assert.calledOnce(MeetingsUtil.getMeetingAddedType);
             assert.notCalled(setTimeoutSpy);
-            assert.calledThrice(TriggerProxy.trigger);
+            assert.callCount(TriggerProxy.trigger, 4);
             assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, destination, type, null, null, undefined, undefined, extraParams, {meetingId: meeting.id});
             assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test type');