@webex/plugin-meetings 3.0.0-beta.133 → 3.0.0-beta.134

package/src/controls-options-manager/util.ts

@@ -153,17 +153,22 @@ class Utils {
   ) {
     const requiredHints = [];
 
-    if (control.properties.enabled === true) {
-      requiredHints.push(DISPLAY_HINTS.ENABLE_REACTIONS);
-    }
-    if (control.properties.enabled === false) {
-      requiredHints.push(DISPLAY_HINTS.DISABLE_REACTIONS);
-    }
-    if (control.properties.showDisplayNameWithReactions === true) {
-      requiredHints.push(DISPLAY_HINTS.ENABLE_SHOW_DISPLAY_NAME);
-    }
-    if (control.properties.showDisplayNameWithReactions === false) {
-      requiredHints.push(DISPLAY_HINTS.DISABLE_SHOW_DISPLAY_NAME);
+    // This additional if statement avoids the display hint discrepency due to
+    // the service blocking partial requests with this property only.
+    if (control.properties.showDisplayNameWithReactions !== undefined) {
+      if (control.properties.showDisplayNameWithReactions === true) {
+        requiredHints.push(DISPLAY_HINTS.ENABLE_SHOW_DISPLAY_NAME);
+      }
+      if (control.properties.showDisplayNameWithReactions === false) {
+        requiredHints.push(DISPLAY_HINTS.DISABLE_SHOW_DISPLAY_NAME);
+      }
+    } else {
+      if (control.properties.enabled === true) {
+        requiredHints.push(DISPLAY_HINTS.ENABLE_REACTIONS);
+      }
+      if (control.properties.enabled === false) {
+        requiredHints.push(DISPLAY_HINTS.DISABLE_REACTIONS);
+      }
     }
 
     return Utils.hasHints({requiredHints, displayHints});

package/src/locus-info/index.ts

@@ -1,4 +1,4 @@
-import {isArray, isEqual, assignWith, cloneDeep} from 'lodash';
+import {isEqual, assignWith, cloneDeep} from 'lodash';
 
 import LoggerProxy from '../common/logs/logger-proxy';
 import EventsScope from '../common/events/events-scope';

package/src/locus-info/parser.ts

@@ -478,7 +478,7 @@ export default class Parser {
    * @param {Types~Locus} locus Locus delta
    * @returns {undefined}
    */
-  // eslint-disable-next-line no-unused-vars
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   onDeltaAction(action: string, locus) {}
 
   /**

package/src/meeting/index.ts

@@ -2,7 +2,6 @@ import uuid from 'uuid';
 import {cloneDeep, isEqual, pick, isString, defer, isEmpty} from 'lodash';
 // @ts-ignore - Fix this
 import {StatelessWebexPlugin} from '@webex/webex-core';
-import {base64} from '@webex/common';
 import {
   ConnectionState,
   Errors,

package/src/meetings/index.ts

@@ -43,7 +43,6 @@ import {
   _CONVERSATION_URL_,
   CONVERSATION_URL,
   MEETINGNUMBER,
-  BREAKOUTS,
   _JOINED_,
   _MOVED_,
 } from '../constants';

package/src/multistream/remoteMediaManager.ts

@@ -96,6 +96,7 @@ const OnePlusFiveLayout: VideoLayout = {
 };
 
 // A layout with 2 big panes for 2 main active speakers and a strip of 6 small panes for other active speakers:
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const TwoMainPlusSixSmallLayout: VideoLayout = {
   activeSpeakerVideoPaneGroups: [
     {

package/src/reconnection-manager/index.ts

@@ -19,7 +19,6 @@ import BEHAVIORAL_METRICS from '../metrics/constants';
 import ReconnectionError from '../common/errors/reconnection';
 import ReconnectInProgress from '../common/errors/reconnection-in-progress';
 import {eventType, reconnection, errorObjects} from '../metrics/config';
-import Media from '../media';
 import Metrics from '../metrics';
 import Meeting from '../meeting';
 import {MediaRequestManager} from '../multistream/mediaRequestManager';

package/src/roap/request.ts

@@ -1,4 +1,3 @@
-/* global window */
 // @ts-ignore
 import {StatelessWebexPlugin} from '@webex/webex-core';
 

package/test/unit/spec/controls-options-manager/util.js

@@ -203,10 +203,9 @@ describe('plugin-meetings', () => {
                 });
               });
 
-              it('should call hasHints() with all properties after negotiating hints', () => {
+              it('should call hasHints() with only enabled hints when respective property is provided', () => {
                 const properties = {
                   enabled: true,
-                  showDisplayNameWithReactions: true,
                 };
 
                 ControlsOptionsUtil.canUpdateReactions({properties}, []);
@@ -214,6 +213,21 @@ describe('plugin-meetings', () => {
                 assert.calledWith(ControlsOptionsUtil.hasHints, {
                   requiredHints: [
                     DISPLAY_HINTS.ENABLE_REACTIONS,
+                  ],
+                  displayHints: [],
+                });
+              });
+
+              it('should call hasHints() with only display name hints when respective property is provided', () => {
+                const properties = {
+                  enabled: true,
+                  showDisplayNameWithReactions: true,
+                };
+
+                ControlsOptionsUtil.canUpdateReactions({properties}, []);
+
+                assert.calledWith(ControlsOptionsUtil.hasHints, {
+                  requiredHints: [
                     DISPLAY_HINTS.ENABLE_SHOW_DISPLAY_NAME,
                   ],
                   displayHints: [],