@webex/plugin-meetings 3.0.0-beta.13 → 3.0.0-beta.131

package/src/networkQualityMonitor/index.ts

@@ -1,16 +1,15 @@
 import EventsScope from '../common/events/events-scope';
-import {EVENT_TRIGGERS, STATS} from '../constants';
-
+import {EVENT_TRIGGERS} from '../constants';
 
 /**
-  * Meeting - network quality event
-  * Emitted on each interval of retrieving stats Analyzer data
-  * @event network:quality
-  * @type {Object}
-  * @property {string} mediaType {video|audio}
-  * @property {number} networkQualityScore - value determined in determineUplinkNetworkQuality
-  * @memberof NetworkQualityMonitor
-  */
+ * Meeting - network quality event
+ * Emitted on each interval of retrieving stats Analyzer data
+ * @event network:quality
+ * @type {Object}
+ * @property {string} mediaType {video|audio}
+ * @property {number} networkQualityScore - value determined in determineUplinkNetworkQuality
+ * @memberof NetworkQualityMonitor
+ */
 /**
  * NetworkQualityMonitor class that will emit events based on detected quality
  *
@@ -42,19 +41,15 @@ export default class NetworkQualityMonitor extends EventsScope {
     this.indicatorTypes = Object.freeze({
       PACKETLOSS: 'packetLoss',
       LATENCY: 'latency',
-      JITTER: 'jitter'
+      JITTER: 'jitter',
     });
     this.frequencyTypes = Object.freeze({
       UPLINK: 'uplink',
-      DOWNLINK: 'downlink'
+      DOWNLINK: 'downlink',
     });
     this.networkQualityScore = 1;
     this.networkQualityStatus = {
-      [this.frequencyTypes.UPLINK]: {
-        [STATS.VIDEO_CORRELATE]: {},
-        [STATS.AUDIO_CORRELATE]: {},
-        [STATS.SHARE_CORRELATE]: {}
-      }
+      [this.frequencyTypes.UPLINK]: {},
     };
     this.mediaType = null;
   }
@@ -69,12 +64,12 @@ export default class NetworkQualityMonitor extends EventsScope {
     this.emit(
       {
         file: 'networkQualityMonitor',
-        function: 'emitNetworkQuality'
+        function: 'emitNetworkQuality',
       },
       EVENT_TRIGGERS.NETWORK_QUALITY,
       {
         mediaType: this.mediaType,
-        networkQualityScore: this.networkQualityScore
+        networkQualityScore: this.networkQualityScore,
       }
     );
   }
@@ -92,7 +87,6 @@ export default class NetworkQualityMonitor extends EventsScope {
     this.mediaType = null;
   }
 
-
   /**
    * filter data to determine uplink network quality, invoked on same interval as stats analyzer remote-inbout-rtp
    * @param {Object} configObj
@@ -127,8 +121,7 @@ export default class NetworkQualityMonitor extends EventsScope {
      * @returns {boolean}
      */
     const determinePacketLoss = () => {
-      if (currentPacketLossRatio >
-        this.config.videoPacketLossRatioThreshold) {
+      if (currentPacketLossRatio > this.config.videoPacketLossRatioThreshold) {
         this.networkQualityScore = 0;
 
         return false;
@@ -172,7 +165,12 @@ export default class NetworkQualityMonitor extends EventsScope {
      * @param {(number|undefined)} value
      * @returns {(number|null)}
      */
-    const determineIfUndefined = (value: number | undefined) => (typeof value === 'undefined' ? null : value);
+    const determineIfUndefined = (value: number | undefined) =>
+      typeof value === 'undefined' ? null : value;
+
+    if (!this.networkQualityStatus[UPLINK][mediaType]) {
+      this.networkQualityStatus[UPLINK][mediaType] = {};
+    }
 
     /**
      * Values for some browsers specifically Safari will be undefined we explicitly set to null
@@ -182,20 +180,19 @@ export default class NetworkQualityMonitor extends EventsScope {
     // PACKET LOSS
     this.networkQualityStatus[UPLINK][mediaType][PACKETLOSS] = {
       acceptable: determinePacketLoss(),
-      value: determineIfUndefined(currentPacketLossRatio)
+      value: determineIfUndefined(currentPacketLossRatio),
     };
 
-
     // LATENCY measured in Round trip time
     this.networkQualityStatus[UPLINK][mediaType][LATENCY] = {
       acceptable: determineLatency(),
-      value: determineIfUndefined(remoteRtpResults.roundTripTime)
+      value: determineIfUndefined(remoteRtpResults.roundTripTime),
     };
 
     // JITTER
     this.networkQualityStatus[UPLINK][mediaType][JITTER] = {
       acceptable: deterMineJitter(),
-      value: determineIfUndefined(remoteRtpResults.jitter)
+      value: determineIfUndefined(remoteRtpResults.jitter),
     };
 
     this.updateNetworkQualityStatus();

package/src/personal-meeting-room/index.ts

@@ -6,7 +6,6 @@ import ParameterError from '../common/errors/parameter';
 
 import PersonalMeetingRoomRequest from './request';
 
-
 /**
  * @class PersonalMeetingRoom
  */
@@ -36,7 +35,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {Object}
      * @public
      * @memberof PersonalMeetingRoom
-    */
+     */
     this.pmr = null;
     /**
      * The pmr sip Uri
@@ -44,7 +43,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {String}
      * @public
      * @memberof PersonalMeetingRoom
-    */
+     */
     this.sipUri = null;
     /**
      * The pmr link
@@ -52,7 +51,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {String}
      * @public
      * @memberof PersonalMeetingRoom
-    */
+     */
     this.link = null;
     /**
      * The pmr server object
@@ -60,7 +59,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {Object}
      * @public
      * @memberof PersonalMeetingRoom
-    */
+     */
     this.userId = null;
     /**
      * The pmr name
@@ -68,7 +67,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {String}
      * @public
      * @memberof PersonalMeetingRoom
-    */
+     */
     this.name = null;
     /**
      * The meeting info request server interface
@@ -76,7 +75,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {MeetingInfo}
      * @private
      * @memberof PersonalMeetingRoom
-    */
+     */
     this.meetingInfo = attrs.meetingInfo;
     /**
      * The pmr server request interface
@@ -84,7 +83,7 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
      * @type {Object}
      * @private
      * @memberof PersonalMeetingRoom
-    */
+     */
     // @ts-ignore
     this.personalMeetingRoomRequest = new PersonalMeetingRoomRequest({}, options);
   }
@@ -98,20 +97,19 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
    * @public
    * @memberof PersonalMeetingRoom
    */
-  public claim(link: string, pin: string, preferred: boolean = true) {
+  public claim(link: string, pin: string, preferred = true) {
     const options = {
       // @ts-ignore
       userId: this.webex.internal.device.userId,
       passcode: pin,
       meetingAddress: link,
-      preferred
+      preferred,
     };
 
     return this.personalMeetingRoomRequest.claimPmr(options).then((pmr) => {
       if (pmr && pmr.body) {
         this.set(pmr.body);
-      }
-      else {
+      } else {
         return Promise.reject(new ParameterError('No PMR body provided. PMR values not updated.'));
       }
 
@@ -143,15 +141,13 @@ export default class PersonalMeetingRoom extends StatelessWebexPlugin {
    */
   public get() {
     const options = {
-      type: _PERSONAL_ROOM_
-
+      type: _PERSONAL_ROOM_,
     };
 
     return this.meetingInfo.fetchMeetingInfo(options).then((pmr) => {
       if (pmr && pmr.body && pmr.body.isPmr) {
         this.set(pmr.body);
-      }
-      else {
+      } else {
         return Promise.reject(new TypeError('The PMR requested is NOT a PMR. PMR values not set.'));
       }
 

package/src/personal-meeting-room/request.ts

@@ -6,7 +6,6 @@ import ParameterError from '../common/errors/parameter';
 
 import PersonalMeetingRoomUtil from './util';
 
-
 /**
  * @class MeetingInfoRequest
  */
@@ -20,8 +19,16 @@ export default class PersonalMeetingRoomRequest extends StatelessWebexPlugin {
    * @memberof PersonalMeetingRoomRequest
    */
   claimPmr(options: any) {
-    if (!options || !options.userId || !options.passcode || !options.meetingAddress || !options.preferred) {
-      throw new ParameterError('Claiming a PMR should be done with userId, passcode, preferred, and meetingAddress in options.');
+    if (
+      !options ||
+      !options.userId ||
+      !options.passcode ||
+      !options.meetingAddress ||
+      !options.preferred
+    ) {
+      throw new ParameterError(
+        'Claiming a PMR should be done with userId, passcode, preferred, and meetingAddress in options.'
+      );
     }
     const validPin = PersonalMeetingRoomUtil.getClaimPmrPin(options.passcode);
 

package/src/personal-meeting-room/util.ts

@@ -6,7 +6,7 @@ import {
   CMR_MEETINGS,
   CLAIM,
   HECATE,
-  WEBEX_DOT_COM
+  WEBEX_DOT_COM,
 } from '../constants';
 
 const PersonalMeetingRoomUtil: any = {};
@@ -42,8 +42,8 @@ PersonalMeetingRoomUtil.getClaimedRequestParams = (link, pin, options) => ({
     userId: options.userId,
     passcode: pin,
     preferred: options.preferred,
-    meetingAddress: link
-  }
+    meetingAddress: link,
+  },
 });
 
 export default PersonalMeetingRoomUtil;