@webex/plugin-meetings 3.0.0-beta.1 → 3.0.0-beta.2

package/test/unit/spec/meeting/muteState.js

@@ -12,6 +12,7 @@ describe('plugin-meetings', () => {
   let meeting;
   let audio;
   let video;
+  let originalRemoteUpdateAudioVideo;
 
   const fakeLocus = {info: 'this is a fake locus'};
 
@@ -34,10 +35,16 @@ describe('plugin-meetings', () => {
     audio = createMuteState(AUDIO, meeting, {sendAudio: true});
     video = createMuteState(VIDEO, meeting, {sendVideo: true});
 
+    originalRemoteUpdateAudioVideo = MeetingUtil.remoteUpdateAudioVideo;
+
     MeetingUtil.remoteUpdateAudioVideo = sinon.stub().resolves(fakeLocus);
     Media.setLocalTrack = sinon.stub();
   });
 
+  afterEach(() => {
+    MeetingUtil.remoteUpdateAudioVideo = originalRemoteUpdateAudioVideo;
+  });
+
   describe('mute state library', () => {
     it('does not create an audio instance if we are not sending audio', async () => {
       assert.isNull(createMuteState(AUDIO, meeting, {sendAudio: false}));

package/test/unit/spec/meeting/utils.js

@@ -41,7 +41,6 @@ describe('plugin-meetings', () => {
       meeting.unsetRemoteTracks = sinon.stub();
       meeting.unsetPeerConnections = sinon.stub();
       meeting.reconnectionManager = {cleanUp: sinon.stub()};
-      meeting.roap = {stop: sinon.stub()};
       meeting.stopKeepAlive = sinon.stub();
     });
 
@@ -63,7 +62,6 @@ describe('plugin-meetings', () => {
         assert.calledOnce(meeting.unsetRemoteTracks);
         assert.calledOnce(meeting.unsetPeerConnections);
         assert.calledOnce(meeting.reconnectionManager.cleanUp);
-        assert.calledOnce(meeting.roap.stop);
         assert.calledOnce(meeting.stopKeepAlive);
       });
     });
@@ -136,6 +134,48 @@ describe('plugin-meetings', () => {
       });
     });
 
+    describe('remoteUpdateAudioVideo', () => {
+      it('#Should call meetingRequest.remoteAudioVideoToggle with correct parameters (multistream)', async () => {
+        const meeting = {
+          correlationId: 'correlation id',
+          isMultistream: true,
+          mediaId: '12345',
+          meetingJoinUrl: 'meetingJoinUrl',
+          locusUrl: 'locusUrl',
+          deviceUrl: 'some device url',
+          selfId: 'self id',
+          meetingRequest: {remoteAudioVideoToggle: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}
+        };
+
+        await MeetingUtil.remoteUpdateAudioVideo(true, false, meeting);
+
+        assert.calledOnce(meeting.meetingRequest.remoteAudioVideoToggle);
+        const parameter = meeting.meetingRequest.remoteAudioVideoToggle.getCall(0).args[0];
+
+        assert.equal(parameter.locusUrl, 'locusUrl');
+        assert.equal(parameter.selfId, 'self id');
+        assert.equal(parameter.correlationId, 'correlation id');
+        assert.equal(parameter.deviceUrl, 'some device url');
+        assert.deepEqual(parameter.localMedias, [{localSdp: '{"audioMuted":true,"videoMuted":false}', mediaId: '12345'}]);
+        assert.equal(parameter.preferTranscoding, false);
+      });
+
+      it('#Should call meetingRequest.remoteAudioVideoToggle with preferTranscoding:true for non multistream connections', async () => {
+        const meeting = {
+          isMultistream: false,
+          mediaId: '12345',
+          meetingRequest: {remoteAudioVideoToggle: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}
+        };
+
+        await MeetingUtil.remoteUpdateAudioVideo(true, false, meeting);
+
+        assert.calledOnce(meeting.meetingRequest.remoteAudioVideoToggle);
+        const parameter = meeting.meetingRequest.remoteAudioVideoToggle.getCall(0).args[0];
+
+        assert.equal(parameter.preferTranscoding, true);
+      });
+    });
+
     describe('joinMeeting', () => {
       it('#Should call `meetingRequest.joinMeeting', async () => {
         const meeting = {meetingJoinUrl: 'meetingJoinUrl', locusUrl: 'locusUrl', meetingRequest: {joinMeeting: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}};
@@ -147,6 +187,25 @@ describe('plugin-meetings', () => {
         const parameter = meeting.meetingRequest.joinMeeting.getCall(0).args[0];
 
         assert.equal(parameter.inviteeAddress, 'meetingJoinUrl');
+        assert.equal(parameter.preferTranscoding, true);
+      });
+
+      it('#Should call meetingRequest.joinMeeting with preferTranscoding=false when multistream is enabled', async () => {
+        const meeting = {
+          isMultistream: true,
+          meetingJoinUrl: 'meetingJoinUrl',
+          locusUrl: 'locusUrl',
+          meetingRequest: {joinMeeting: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}
+        };
+
+        MeetingUtil.parseLocusJoin = sinon.stub();
+        await MeetingUtil.joinMeeting(meeting, {});
+
+        assert.calledOnce(meeting.meetingRequest.joinMeeting);
+        const parameter = meeting.meetingRequest.joinMeeting.getCall(0).args[0];
+
+        assert.equal(parameter.inviteeAddress, 'meetingJoinUrl');
+        assert.equal(parameter.preferTranscoding, false);
       });
 
       it('#Should fallback sipUrl if meetingJoinUrl does not exists', async () => {

package/test/unit/spec/meetings/index.js

@@ -12,7 +12,6 @@ import uuid from 'uuid';
 import StaticConfig from '@webex/plugin-meetings/src/common/config';
 import TriggerProxy from '@webex/plugin-meetings/src/common/events/trigger-proxy';
 import LoggerConfig from '@webex/plugin-meetings/src/common/logs/logger-config';
-import MediaUtil from '@webex/plugin-meetings/src/media/util';
 import Meeting from '@webex/plugin-meetings/src/meeting';
 import MeetingUtil from '@webex/plugin-meetings/src/meeting/util';
 import Meetings from '@webex/plugin-meetings/src/meetings';
@@ -787,7 +786,6 @@ describe('plugin-meetings', () => {
       });
       describe('#createMeeting', () => {
         beforeEach(() => {
-          MediaUtil.createPeerConnection = sinon.stub().returns(true);
           webex.internal.device.userId = uuid1;
           webex.internal.device.url = url1;
           MeetingCollection.set = sinon.stub().returns(true);
@@ -1024,7 +1022,6 @@ describe('plugin-meetings', () => {
     describe('Public Event Triggers', () => {
       describe('#destroy', () => {
         beforeEach(() => {
-          MediaUtil.createPeerConnection = sinon.stub().returns(true);
           MeetingUtil.cleanUp = sinon.stub();
         });
         it('should have #destroy', () => {
@@ -1116,7 +1113,6 @@ describe('plugin-meetings', () => {
       let meeting;
 
       beforeEach(async () => {
-        MediaUtil.createPeerConnection = sinon.stub().returns(true);
         webex.internal.device.userId = uuid1;
         webex.internal.device.url = url1;
         MeetingCollection.set = sinon.stub().returns(true);

package/test/unit/spec/members/index.js

@@ -10,9 +10,8 @@ import chaiAsPromised from 'chai-as-promised';
 import {Credentials} from '@webex/webex-core';
 import Support from '@webex/internal-plugin-support';
 import MockWebex from '@webex/test-helper-mock-webex';
-
-import Meetings from '@webex/plugin-meetings';
 import ParameterError from '@webex/plugin-meetings/src/common/errors/parameter';
+import Meetings from '@webex/plugin-meetings';
 import Members from '@webex/plugin-meetings/src/members';
 import MembersUtil from '@webex/plugin-meetings/src/members/util';
 
@@ -311,5 +310,168 @@ describe('plugin-meetings', () => {
         await checkValid(resultPromise, spies, requestingMemberId, url1);
       });
     });
+
+    describe('findMemberByCsi()', () => {
+      let members;
+
+      // fake collection that contains all combinations of members data structure (with respect to CSIs)
+      const fakeCollection = {
+        oneWithoutDevices: {
+          participant: {
+          }
+        },
+        oneWithEmptyDevices: {
+          participant: {
+            devices: [],
+          }
+        },
+        oneWithDevicesWithoutCsis: {
+          participant: {
+            devices: [
+              {
+                url: 'https://fakeURL1.com',
+                deviceType: 'SIP',
+                state: 'JOINED',
+                csis: [],
+              },
+              {
+                url: 'dialout:///fakeagain',
+                deviceType: 'PROVISIONAL',
+                state: 'JOINED',
+              }
+            ],
+          },
+          id: 'abc-123-abc-123',
+          status: 'IN_MEETING',
+        },
+        oneWithSomeCsis: {
+          participant: {
+            devices: [
+              {
+                url: 'https://fakeURL2.com',
+                deviceType: 'SIP',
+                state: 'JOINED',
+                csis: [1000, 1001, 1002],
+              },
+              {
+                url: 'https://fakeURL3.com',
+                deviceType: 'SIP',
+                state: 'JOINED',
+                csis: [2000, 2001, 2002],
+              }
+            ]
+          }
+        }
+      };
+
+      beforeEach(() => {
+        members = createMembers({url: url1});
+        members.membersCollection.setAll(fakeCollection);
+      });
+
+      it('returns undefined if member not found', () => {
+        assert.strictEqual(members.findMemberByCsi(123), undefined);
+      });
+
+      it('returns correct member when CSI matches the first device', () => {
+        assert.strictEqual(members.findMemberByCsi(1001), fakeCollection.oneWithSomeCsis);
+      });
+
+      it('returns correct member when CSI matches the second device', () => {
+        assert.strictEqual(members.findMemberByCsi(2001), fakeCollection.oneWithSomeCsis);
+      });
+    });
+
+    describe('getCsisForMember()', () => {
+      let members;
+
+      // fake collection that contains all combinations of members data structure (with respect to CSIs)
+      const fakeCollection = {
+        oneWithoutParticipant: {
+          id: 'oneWithoutParticipant',
+        },
+        oneWithoutDevices: {
+          id: 'oneWithoutDevices',
+          participant: {
+          }
+        },
+        oneWithEmptyDevices: {
+          id: 'oneWithEmptyDevices',
+          participant: {
+            devices: [],
+          }
+        },
+        oneWithDevicesWithoutCsis: {
+          id: 'oneWithDevicesWithoutCsis',
+          participant: {
+            devices: [
+              {
+                url: 'https://fakeURL1.com',
+                deviceType: 'SIP',
+                state: 'JOINED',
+                mediaSessions: [],
+              },
+              {
+                url: 'dialout:///fakeagain',
+                deviceType: 'PROVISIONAL',
+                state: 'JOINED',
+              }
+            ],
+          },
+          status: 'IN_MEETING',
+        },
+        oneWithSomeCsis: {
+          id: 'oneWithSomeCsis',
+          participant: {
+            devices: [
+              {
+                url: 'https://fakeURL2.com',
+                deviceType: 'SIP',
+                state: 'JOINED',
+                mediaSessions: [
+                  {mediaType: 'audio', mediaContent: 'main', csi: 1000},
+                  {mediaType: 'video', mediaContent: 'main', csi: 1001},
+                  {mediaType: 'video', mediaContent: 'content', csi: 1002}
+                ],
+              },
+              {
+                url: 'https://fakeURL3.com',
+                deviceType: 'SIP',
+                state: 'JOINED',
+                mediaSessions: [
+                  {mediaType: 'audio', mediaContent: 'main', csi: 2000},
+                  {mediaType: 'video', mediaContent: 'main', csi: 2001},
+                  {mediaType: 'video', mediaContent: 'content', csi: 2002}
+                ],
+              }
+            ]
+          }
+        }
+      };
+
+      beforeEach(() => {
+        members = createMembers({url: url1});
+        members.membersCollection.setAll(fakeCollection);
+      });
+
+      it('returns empty array if member not found', () => {
+        assert.deepEqual(members.getCsisForMember('wrong id'), []);
+      });
+
+      it('returns empty array if member does not have CSIs', () => {
+        assert.deepEqual(members.getCsisForMember('oneWithoutParticipant'), []);
+        assert.deepEqual(members.getCsisForMember('oneWithoutDevices'), []);
+        assert.deepEqual(members.getCsisForMember('oneWithEmptyDevices'), []);
+        assert.deepEqual(members.getCsisForMember('oneWithDevicesWithoutCsis'), []);
+      });
+
+      it('returns empty array if mediaType and mediaContent do not match', () => {
+        assert.deepEqual(members.getCsisForMember('oneWithSomeCsis', 'audio', 'content'), []);
+      });
+
+      it('returns correct CSI values when there is a match', () => {
+        assert.deepEqual(members.getCsisForMember('oneWithSomeCsis', 'video', 'main'), [1001, 2001]);
+      });
+    });
   });
 });