@webex/plugin-meetings 2.60.1-next.16 → 2.60.1-next.18

package/test/unit/spec/meeting/index.js

@@ -2717,6 +2717,7 @@ describe('plugin-meetings', () => {
               clientErrorCode: ICE_FAILED_WITH_TURN_TLS_CLIENT_CODE,
               expectedErrorPayload: {
                 errorDescription: ERROR_DESCRIPTIONS.ICE_FAILED_WITH_TURN_TLS,
+                category: 'network',
               },
             },
           ].forEach(({clientErrorCode, expectedErrorPayload}) => {
@@ -5986,6 +5987,7 @@ describe('plugin-meetings', () => {
           meeting.mediaProperties.webrtcMediaConnection = {};
           meeting.audio = {handleLocalStreamChange: sinon.stub()};
           meeting.video = {handleLocalStreamChange: sinon.stub()};
+          meeting.statsAnalyzer = {updateMediaStatus: sinon.stub()};
           fakeMultistreamRoapMediaConnection = {
             createSendSlot: () => {
               return {
@@ -6052,6 +6054,10 @@ describe('plugin-meetings', () => {
               options: {meetingId: meeting.id},
             });
             assert.equal(meeting.mediaProperties.mediaDirection.sendShare, true);
+
+            assert.calledWith(meeting.statsAnalyzer.updateMediaStatus, {
+              expected: {sendShare: true},
+            });
           };
 
           const checkScreenShareAudioPublished = (stream) => {
@@ -6068,6 +6074,10 @@ describe('plugin-meetings', () => {
             );
             assert.equal(meeting.mediaProperties.shareAudioStream, stream);
             assert.equal(meeting.mediaProperties.mediaDirection.sendShare, true);
+
+            assert.calledWith(meeting.statsAnalyzer.updateMediaStatus, {
+              expected: {sendShare: true},
+            });
           };
 
           it('requests screen share floor and publishes the screen share video stream', async () => {
@@ -6162,6 +6172,11 @@ describe('plugin-meetings', () => {
 
             assert.equal(meeting.mediaProperties.shareVideoStream, null);
             assert.equal(meeting.mediaProperties.mediaDirection.sendShare, shareDirection);
+            if (!shareDirection) {
+              assert.calledWith(meeting.statsAnalyzer.updateMediaStatus, {
+                expected: {sendShare: false},
+              });
+            }
           };
 
           // share direction will remain true if only one of the two share streams are unpublished
@@ -6174,6 +6189,11 @@ describe('plugin-meetings', () => {
 
             assert.equal(meeting.mediaProperties.shareAudioStream, null);
             assert.equal(meeting.mediaProperties.mediaDirection.sendShare, shareDirection);
+            if (!shareDirection) {
+              assert.calledWith(meeting.statsAnalyzer.updateMediaStatus, {
+                expected: {sendShare: false},
+              });
+            }
           };
 
           it('fails if there is no media connection', async () => {
@@ -8382,13 +8402,41 @@ describe('plugin-meetings', () => {
           assert.equal(locusInfoOnSpy.thirdCall.args[0], 'MEETING_INFO_UPDATED');
           const callback = locusInfoOnSpy.thirdCall.args[1];
 
-          callback();
+          callback({isInitializing: true});
 
           assert.calledWith(updateMeetingActionsSpy);
           assert.calledWith(setRecordingDisplayHintsSpy, userDisplayHints);
           assert.calledWith(setUserPolicySpy, userDisplayPolicy);
           assert.calledWith(setControlsDisplayHintsSpy, userDisplayHints);
           assert.calledWith(handleDataChannelUrlChangeSpy, datachannelUrl);
+
+          assert.neverCalledWith(
+            TriggerProxy.trigger,
+            meeting,
+            {
+              file: 'meetings',
+              function: 'setUpLocusInfoMeetingInfoListener',
+            },
+            'meeting:meetingInfoUpdated'
+          );
+
+          callback({isIntialized: false});
+
+          assert.calledWith(updateMeetingActionsSpy);
+          assert.calledWith(setRecordingDisplayHintsSpy, userDisplayHints);
+          assert.calledWith(setUserPolicySpy, userDisplayPolicy);
+          assert.calledWith(setControlsDisplayHintsSpy, userDisplayHints);
+          assert.calledWith(handleDataChannelUrlChangeSpy, datachannelUrl);
+
+          assert.calledWith(
+            TriggerProxy.trigger,
+            meeting,
+            {
+              file: 'meetings',
+              function: 'setUpLocusInfoMeetingInfoListener',
+            },
+            'meeting:meetingInfoUpdated'
+          );
         });
       });
 

package/test/unit/spec/meetings/index.js

@@ -511,6 +511,27 @@ describe('plugin-meetings', () => {
         it('should have #syncMeetings', () => {
           assert.exists(webex.meetings.syncMeetings);
         });
+        it('should do nothing and return a resolved promise if unverified guest', async () => {
+          webex.meetings.request.getActiveMeetings = sinon.stub().returns(
+            Promise.resolve({
+              loci: [
+                {
+                  url: url1,
+                },
+              ],
+            })
+          );
+          webex.credentials.isUnverifiedGuest = true;
+          LoggerProxy.logger.info = sinon.stub();
+
+          await webex.meetings.syncMeetings();
+
+          assert.notCalled(webex.meetings.request.getActiveMeetings);
+          assert.calledWith(
+            LoggerProxy.logger.info,
+            'Meetings:index#syncMeetings --> skipping meeting sync as unverified guest'
+          );
+        });
         describe('succesful requests', () => {
           beforeEach(() => {
             webex.meetings.request.getActiveMeetings = sinon.stub().returns(

package/test/unit/spec/metrics/index.js

@@ -5,7 +5,6 @@ import 'jsdom-global/register';
 import sinon from 'sinon';
 import Metrics from '@webex/internal-plugin-metrics';
 import MockWebex from '@webex/test-helper-mock-webex';
-import {browserOnly} from '@webex/test-helper-mocha';
 import {assert} from '@webex/test-helper-chai';
 
 import metrics from '@webex/plugin-meetings/src/metrics';
@@ -14,7 +13,7 @@ import metrics from '@webex/plugin-meetings/src/metrics';
  * Meeting can only run in a browser, so we can only send metrics for
  * browser usage.
  */
-browserOnly(describe)('Meeting metrics', () => {
+describe('Meeting metrics', () => {
   let webex, mockSubmitMetric, sandbox;
 
   beforeEach(() => {

package/test/unit/spec/reconnection-manager/index.js

@@ -90,7 +90,7 @@ describe('plugin-meetings', () => {
       sandbox.reset();
     });
 
-    it('syncs meetings if it is not an unverified guest', async () => {
+    it('calls syncMeetings', async () => {
       const rm = new ReconnectionManager(fakeMeeting);
 
       await rm.reconnect();
@@ -99,16 +99,6 @@ describe('plugin-meetings', () => {
       assert.calledWith(rm.webex.meetings.syncMeetings, {keepOnlyLocusMeetings: false});
     });
 
-    it('does not sync meetings if it is an unverified guest', async () => {
-      const rm = new ReconnectionManager(fakeMeeting);
-
-      rm.webex.credentials.isUnverifiedGuest = true;
-
-      await rm.reconnect();
-
-      assert.notCalled(rm.webex.meetings.syncMeetings);
-    });
-
     it('calls startReachability on reconnect', async () => {
       const rm = new ReconnectionManager(fakeMeeting);