@webex/plugin-meetings 2.59.6-next.1 → 2.59.6-next.2

package/package.json

@@ -43,7 +43,7 @@
     "@webex/eslint-config-legacy": "^0.0.0",
     "@webex/jest-config-legacy": "^0.0.0",
     "@webex/legacy-tools": "^0.0.0",
-    "@webex/plugin-meetings": "^2.59.6-next.1",
+    "@webex/plugin-meetings": "^2.59.6-next.2",
     "@webex/plugin-rooms": "^2.59.4-next.1",
     "@webex/test-helper-chai": "^2.59.4-next.1",
     "@webex/test-helper-mocha": "^2.59.4-next.1",
@@ -80,5 +80,5 @@
     "uuid": "^3.3.2",
     "webrtc-adapter": "^7.7.0"
   },
-  "version": "2.59.6-next.1"
+  "version": "2.59.6-next.2"
 }

package/src/meeting/index.ts

@@ -462,6 +462,7 @@ export default class Meeting extends StatelessWebexPlugin {
   shareStatus: string;
   statsAnalyzer: StatsAnalyzer;
   transcription: Transcription;
+  receiveTranscription: boolean;
   updateMediaConnections: (mediaConnections: any[]) => void;
   endCallInitiateJoinReq: any;
   endJoinReqResp: any;
@@ -1761,8 +1762,8 @@ export default class Meeting extends StatelessWebexPlugin {
       LOCUSINFO.EVENTS.CONTROLS_MEETING_TRANSCRIBE_UPDATED,
       ({caption, transcribing}) => {
         // @ts-ignore - config coming from registerPlugin
-        if (transcribing && this.transcription && this.config.receiveTranscription) {
-          this.receiveTranscription();
+        if (transcribing && !this.transcription && this.config.receiveTranscription) {
+          this.startTranscription();
         } else if (!transcribing && this.transcription) {
           Trigger.trigger(
             this,
@@ -2261,8 +2262,17 @@ export default class Meeting extends StatelessWebexPlugin {
         });
       }
     });
-    this.locusInfo.on(LOCUSINFO.EVENTS.SELF_ADMITTED_GUEST, (payload) => {
+    this.locusInfo.on(LOCUSINFO.EVENTS.SELF_ADMITTED_GUEST, async (payload) => {
       this.stopKeepAlive();
+      // @ts-ignore
+      if (!this.transcription && (this.config.receiveTranscription || this.receiveTranscription)) {
+        if (this.isTranscriptionSupported()) {
+          await this.startTranscription();
+          LoggerProxy.logger.info(
+            'Meeting:index#setUpLocusInfoSelfListener --> enabled to receive transcription for guest user!'
+          );
+        }
+      }
 
       if (payload) {
         Trigger.trigger(
@@ -3725,9 +3735,9 @@ export default class Meeting extends StatelessWebexPlugin {
    * @private
    * @returns {Promise<void>} a promise to open the WebSocket connection
    */
-  private async receiveTranscription() {
+  private async startTranscription() {
     LoggerProxy.logger.info(
-      `Meeting:index#receiveTranscription -->
+      `Meeting:index#startTranscription -->
       Attempting to generate a web socket url.`
     );
 
@@ -3744,7 +3754,7 @@ export default class Meeting extends StatelessWebexPlugin {
       });
 
       LoggerProxy.logger.info(
-        `Meeting:index#receiveTranscription -->
+        `Meeting:index#startTranscription -->
         Generated web socket url succesfully.`
       );
 
@@ -3756,7 +3766,7 @@ export default class Meeting extends StatelessWebexPlugin {
       );
 
       LoggerProxy.logger.info(
-        `Meeting:index#receiveTranscription -->
+        `Meeting:index#startTranscription -->
         opened LLM web socket connection successfully.`
       );
 
@@ -3777,7 +3787,7 @@ export default class Meeting extends StatelessWebexPlugin {
       // @ts-ignore - fix type
       this.transcription.connect(this.webex.credentials.supertoken.access_token);
     } catch (error) {
-      LoggerProxy.logger.error(`Meeting:index#receiveTranscription --> ${error}`);
+      LoggerProxy.logger.error(`Meeting:index#startTranscription --> ${error}`);
       Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.RECEIVE_TRANSCRIPTION_FAILURE, {
         correlation_id: this.correlationId,
         reason: error.message,
@@ -3950,6 +3960,7 @@ export default class Meeting extends StatelessWebexPlugin {
       .then((join) => {
         joinSuccess(join);
         this.deferJoin = undefined;
+        this.receiveTranscription = !!options.receiveTranscription;
         Metrics.sendBehavioralMetric(BEHAVIORAL_METRICS.JOIN_SUCCESS, {
           correlation_id: this.correlationId,
         });
@@ -3959,10 +3970,10 @@ export default class Meeting extends StatelessWebexPlugin {
       .then(async (join) => {
         if (isBrowser) {
           // @ts-ignore - config coming from registerPlugin
-          if (this.config.receiveTranscription || options.receiveTranscription) {
+          if (this.config.receiveTranscription || this.receiveTranscription) {
             if (this.isTranscriptionSupported()) {
-              await this.receiveTranscription();
-              LoggerProxy.logger.info('Meeting:index#join --> enabled to recieve transcription!');
+              await this.startTranscription();
+              LoggerProxy.logger.info('Meeting:index#join --> enabled to receive transcription!');
             }
           }
         } else {
@@ -5698,7 +5709,7 @@ export default class Meeting extends StatelessWebexPlugin {
     if (layoutType) {
       if (!LAYOUT_TYPES.includes(layoutType)) {
         return this.rejectWithErrorLog(
-          'Meeting:index#changeVideoLayout --> cannot change video layout, invalid layoutType recieved.'
+          'Meeting:index#changeVideoLayout --> cannot change video layout, invalid layoutType received.'
         );
       }
 

package/test/unit/spec/meeting/index.js

@@ -770,12 +770,12 @@ describe('plugin-meetings', () => {
           assert.equal(meeting.isTranscriptionSupported(), true);
         });
       });
-      describe('#receiveTranscription', () => {
+      describe('#startTranscription', () => {
         it('should invoke subscribe method to invoke the callback', () => {
           meeting.monitorTranscriptionSocketConnection = sinon.stub();
           meeting.initializeTranscription = sinon.stub();
 
-          meeting.receiveTranscription().then(() => {
+          meeting.startTranscription().then(() => {
             assert.equal(true, false);
             assert.calledOnce(meeting.initializeTranscription);
             assert.calledOnce(meeting.monitorTranscriptionSocketConnection);
@@ -786,7 +786,7 @@ describe('plugin-meetings', () => {
           meeting.request = sinon.stub().returns(Promise.reject());
 
           try {
-            await meeting.receiveTranscription();
+            await meeting.startTranscription();
           } catch (err) {
             assert(err, {});
           }
@@ -840,12 +840,12 @@ describe('plugin-meetings', () => {
             assert.calledOnce(MeetingUtil.joinMeeting);
             assert.calledOnce(meeting.setLocus);
           });
-          it('should invoke `receiveTranscription()` if receiveTranscription is set to true', async () => {
+          it('should invoke `startTranscription()` if receiveTranscription is set to true', async () => {
             meeting.isTranscriptionSupported = sinon.stub().returns(true);
-            meeting.receiveTranscription = sinon.stub().returns(Promise.resolve());
+            meeting.startTranscription = sinon.stub().returns(Promise.resolve());
 
             await meeting.join({receiveTranscription: true});
-            assert.calledOnce(meeting.receiveTranscription);
+            assert.calledOnce(meeting.startTranscription);
           });
 
           it('should not create new correlation ID on join immediately after create', async () => {
@@ -3578,8 +3578,49 @@ describe('plugin-meetings', () => {
           );
           done();
         });
+        it('transcription should start when configured when guest admitted', (done) => {
+          meeting.isTranscriptionSupported = sinon.stub().returns(true);
+          meeting.receiveTranscription = sinon.stub().returns(true);
+          meeting.startTranscription = sinon.stub();
+
+          meeting.locusInfo.emit({function: 'test', file: 'test'}, 'SELF_ADMITTED_GUEST', test1);
+          assert.calledOnce(meeting.startTranscription);
+          done();
+        });
       });
 
+      describe('#setupLocusControlsListener', () => {
+        it('transcription should start when meeting transcribe state is updated with active transcribing', (done) => {
+          const payload = {caption: true, transcribing: true};
+          meeting.startTranscription = sinon.stub();
+          meeting.config.receiveTranscription = true;
+          meeting.transcription = null;
+
+          meeting.locusInfo.emit({function: 'meeting/index', file: 'setupLocusControlsListener'}, 'CONTROLS_MEETING_TRANSCRIBE_UPDATED', payload);
+          assert.calledOnce(meeting.startTranscription);
+          done();
+        })
+
+        it('transcription should stop when meeting transcribe state is updated with inactive transcribing', (done) => {
+          const payload = {caption: false, transcribing: false};
+          meeting.startTranscription = sinon.stub();
+          meeting.config.receiveTranscription = true;
+          meeting.transcription = {};
+
+          meeting.locusInfo.emit({function: 'meeting/index', file: 'setupLocusControlsListener'}, 'CONTROLS_MEETING_TRANSCRIBE_UPDATED', payload);
+          assert.notCalled(meeting.startTranscription);
+          assert.calledTwice(TriggerProxy.trigger);
+          assert.calledWith(
+            TriggerProxy.trigger,
+            sinon.match.instanceOf(Meeting),
+            {file: 'meeting/index', function: 'setupLocusControlsListener'},
+            'meeting:receiveTranscription:stopped',
+            payload
+          );
+          done();
+        })
+      })
+
       describe('#setUpLocusUrlListener', () => {
         it('listens to the locus url update event', (done) => {
           const newLocusUrl = 'newLocusUrl/12345';