@webex/plugin-meetings 2.59.1 → 2.59.3-next.1

package/test/unit/spec/recording-controller/util.js

@@ -1,102 +1,102 @@
-import RecordingUtil from '@webex/plugin-meetings/src/recording-controller/util';
-import RecordingAction from '@webex/plugin-meetings/src/recording-controller/enums';
-import { assert } from 'chai';
-
-describe('plugin-meetings', () => {
-    describe('recording-controller tests', () => {
-        describe('recording util tests', () => {
-
-            let locusInfo;
-        
-            beforeEach(() => {
-              locusInfo = {
-                parsedLocus: {
-                  info: {
-                    userDisplayHints: [],
-                  },
-                },
-              };
-            });
-        
-            describe('canUserStart', () => {
-              it('can start recording when the correct display hint is present', () => {
-                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_START');
-
-                assert.equal(RecordingUtil.canUserStart(locusInfo.parsedLocus.info.userDisplayHints), true);
-              });
-        
-              it('rejects when correct display hint is not present', () => {
-                assert.equal(RecordingUtil.canUserStart(locusInfo.parsedLocus.info.userDisplayHints), false);
-              });
-            });
-
-            describe('canUserPause', () => {
-              it('can pause recording when the correct display hint is present', () => {
-                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_PAUSE');
-
-                assert.equal(RecordingUtil.canUserPause(locusInfo.parsedLocus.info.userDisplayHints), true);
-              });
-        
-              it('rejects when correct display hint is not present', () => {
-                assert.equal(RecordingUtil.canUserPause(locusInfo.parsedLocus.info.userDisplayHints), false);
-              });
-            });
-
-            describe('canUserStop', () => {
-              it('can stop recording when the correct display hint is present', () => {
-                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_STOP');
-
-                assert.equal(RecordingUtil.canUserStop(locusInfo.parsedLocus.info.userDisplayHints), true);
-              });
-        
-              it('rejects when correct display hint is not present', () => {
-                assert.equal(RecordingUtil.canUserStop(locusInfo.parsedLocus.info.userDisplayHints), false);
-              });
-            });
-
-            describe('canUserResume', () => {
-              it('can start recording when the correct display hint is present', () => {
-                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_RESUME');
-
-                assert.equal(RecordingUtil.canUserResume(locusInfo.parsedLocus.info.userDisplayHints), true);
-              });
-        
-              it('rejects when correct display hint is not present', () => {
-                assert.equal(RecordingUtil.canUserResume(locusInfo.parsedLocus.info.userDisplayHints), false);
-              });
-            });
-
-            describe('deriveRecordingStates', () => {
-              it('gets the correct values for a start recording action', () => {
-                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Start), {recording: true, paused: false});
-              });
-
-              it('gets the correct values for a stop recording action', () => {
-                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Stop), {recording: false, paused: false});
-              });
-
-              it('gets the correct values for a resume recording action', () => {
-                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Resume), {recording: true, paused: false});
-              });
-
-              it('gets the correct values for a paused recording action', () => {
-                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Pause), {recording: true, paused: true});
-              });
-            });
-
-            describe('extractLocusId', () => {
-              it('gets the correct id from the url param', () => {
-                assert.equal(RecordingUtil.extractLocusId('test/id'), 'id');
-              });
-
-              it('works with empty string parameters passed', () => {
-                assert.equal(RecordingUtil.extractLocusId(''), '');
-              });
-
-              it('works with no parameters passed', () => {
-                assert.isUndefined(RecordingUtil.extractLocusId(undefined));
-              });
-            });
-        });
-    });
+import RecordingUtil from '@webex/plugin-meetings/src/recording-controller/util';
+import RecordingAction from '@webex/plugin-meetings/src/recording-controller/enums';
+import { assert } from 'chai';
+
+describe('plugin-meetings', () => {
+    describe('recording-controller tests', () => {
+        describe('recording util tests', () => {
+
+            let locusInfo;
+        
+            beforeEach(() => {
+              locusInfo = {
+                parsedLocus: {
+                  info: {
+                    userDisplayHints: [],
+                  },
+                },
+              };
+            });
+        
+            describe('canUserStart', () => {
+              it('can start recording when the correct display hint is present', () => {
+                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_START');
+
+                assert.equal(RecordingUtil.canUserStart(locusInfo.parsedLocus.info.userDisplayHints), true);
+              });
+        
+              it('rejects when correct display hint is not present', () => {
+                assert.equal(RecordingUtil.canUserStart(locusInfo.parsedLocus.info.userDisplayHints), false);
+              });
+            });
+
+            describe('canUserPause', () => {
+              it('can pause recording when the correct display hint is present', () => {
+                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_PAUSE');
+
+                assert.equal(RecordingUtil.canUserPause(locusInfo.parsedLocus.info.userDisplayHints), true);
+              });
+        
+              it('rejects when correct display hint is not present', () => {
+                assert.equal(RecordingUtil.canUserPause(locusInfo.parsedLocus.info.userDisplayHints), false);
+              });
+            });
+
+            describe('canUserStop', () => {
+              it('can stop recording when the correct display hint is present', () => {
+                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_STOP');
+
+                assert.equal(RecordingUtil.canUserStop(locusInfo.parsedLocus.info.userDisplayHints), true);
+              });
+        
+              it('rejects when correct display hint is not present', () => {
+                assert.equal(RecordingUtil.canUserStop(locusInfo.parsedLocus.info.userDisplayHints), false);
+              });
+            });
+
+            describe('canUserResume', () => {
+              it('can start recording when the correct display hint is present', () => {
+                locusInfo.parsedLocus.info.userDisplayHints.push('RECORDING_CONTROL_RESUME');
+
+                assert.equal(RecordingUtil.canUserResume(locusInfo.parsedLocus.info.userDisplayHints), true);
+              });
+        
+              it('rejects when correct display hint is not present', () => {
+                assert.equal(RecordingUtil.canUserResume(locusInfo.parsedLocus.info.userDisplayHints), false);
+              });
+            });
+
+            describe('deriveRecordingStates', () => {
+              it('gets the correct values for a start recording action', () => {
+                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Start), {recording: true, paused: false});
+              });
+
+              it('gets the correct values for a stop recording action', () => {
+                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Stop), {recording: false, paused: false});
+              });
+
+              it('gets the correct values for a resume recording action', () => {
+                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Resume), {recording: true, paused: false});
+              });
+
+              it('gets the correct values for a paused recording action', () => {
+                assert.deepEqual(RecordingUtil.deriveRecordingStates(RecordingAction.Pause), {recording: true, paused: true});
+              });
+            });
+
+            describe('extractLocusId', () => {
+              it('gets the correct id from the url param', () => {
+                assert.equal(RecordingUtil.extractLocusId('test/id'), 'id');
+              });
+
+              it('works with empty string parameters passed', () => {
+                assert.equal(RecordingUtil.extractLocusId(''), '');
+              });
+
+              it('works with no parameters passed', () => {
+                assert.isUndefined(RecordingUtil.extractLocusId(undefined));
+              });
+            });
+        });
+    });
 });

package/test/unit/spec/roap/index.ts

@@ -1,128 +1,128 @@
-import {assert} from '@webex/test-helper-chai';
-import sinon from 'sinon';
-import TurnDiscovery from '@webex/plugin-meetings/src/roap/turnDiscovery';
-import {ROAP} from '@webex/plugin-meetings/src/constants';
-
-import RoapRequest from '@webex/plugin-meetings/src/roap/request';
-import RoapHandler from '@webex/plugin-meetings/src/roap/handler';
-import Roap from '@webex/plugin-meetings/src/roap/';
-import Meeting from '@webex/plugin-meetings/src/meeting';
-
-describe('Roap', () => {
-  describe('doTurnDiscovery', () => {
-    it('calls this.turnDiscovery.doTurnDiscovery() and forwards all the arguments', async () => {
-      const RESULT = {something: 'some value'};
-      const meeting = {id: 'some meeting id'} as Meeting;
-
-      const doTurnDiscoveryStub = sinon
-        .stub(TurnDiscovery.prototype, 'doTurnDiscovery')
-        .resolves(RESULT);
-
-      const roap = new Roap({}, {parent: 'fake'});
-
-      // call with isReconnecting: true
-      const result = await roap.doTurnDiscovery(meeting, true);
-
-      assert.calledOnceWithExactly(doTurnDiscoveryStub, meeting, true);
-      assert.deepEqual(result, RESULT);
-
-      doTurnDiscoveryStub.resetHistory();
-
-      // and with isReconnecting: false
-      const result2 = await roap.doTurnDiscovery(meeting, false);
-
-      assert.calledOnceWithExactly(doTurnDiscoveryStub, meeting, false);
-      assert.deepEqual(result2, RESULT);
-
-      sinon.restore();
-    });
-  });
-
-  describe('sendRoapMediaRequest', () => {
-    let sendRoapStub;
-    let roapHandlerSubmitStub;
-
-    const meeting = {
-      id: 'some meeting id',
-      correlationId: 'correlation id',
-      selfUrl: 'self url',
-      mediaId: 'media id',
-      audio:{
-        isLocallyMuted: () => true,
-      },
-      video:{
-        isLocallyMuted: () => false,
-      },
-      setRoapSeq: sinon.stub(),
-      config: {experimental: {enableTurnDiscovery: false}},
-    };
-
-    beforeEach(() => {
-      sendRoapStub = sinon.stub(RoapRequest.prototype, 'sendRoap').resolves({});
-      roapHandlerSubmitStub = sinon.stub(RoapHandler.prototype, 'submit');
-      meeting.setRoapSeq.resetHistory();
-    });
-
-    afterEach(() => {
-      sinon.restore();
-    });
-
-    [
-      {reconnect: true, enableTurnDiscovery: true, expectEmptyMediaId: false},
-      {reconnect: true, enableTurnDiscovery: false, expectEmptyMediaId: true},
-      {reconnect: false, enableTurnDiscovery: true, expectEmptyMediaId: false},
-      {reconnect: false, enableTurnDiscovery: false, expectEmptyMediaId: false},
-    ].forEach(({reconnect, enableTurnDiscovery, expectEmptyMediaId}) =>
-      it(`sends roap OFFER with ${expectEmptyMediaId ? 'empty ' : ''}mediaId when ${
-        reconnect ? '' : 'not '
-      }reconnecting and TURN discovery is ${
-        enableTurnDiscovery ? 'enabled' : 'disabled'
-      }`, async () => {
-        meeting.config.experimental.enableTurnDiscovery = enableTurnDiscovery;
-
-        const roap = new Roap({}, {parent: 'fake'});
-
-        await roap.sendRoapMediaRequest({
-          meeting,
-          sdp: 'sdp',
-          reconnect,
-          roapSeq: 1,
-        });
-
-        const expectedRoapMessage = {
-          messageType: 'OFFER',
-          sdps: ['sdp'],
-          version: '2',
-          seq: 2,
-          tieBreaker: 4294967294,
-        };
-
-        assert.calledOnce(sendRoapStub);
-        assert.calledWith(sendRoapStub, {
-          roapMessage: expectedRoapMessage,
-          correlationId: meeting.correlationId,
-          locusSelfUrl: meeting.selfUrl,
-          mediaId: expectEmptyMediaId ? '' : meeting.mediaId,
-          audioMuted: meeting.audio?.isLocallyMuted(),
-          videoMuted: meeting.video?.isLocallyMuted(),
-          meetingId: meeting.id,
-        });
-
-        assert.calledTwice(roapHandlerSubmitStub);
-        assert.calledWith(roapHandlerSubmitStub, {
-          type: ROAP.SEND_ROAP_MSG,
-          msg: expectedRoapMessage,
-          correlationId: meeting.correlationId,
-        });
-        assert.calledWith(roapHandlerSubmitStub, {
-          type: ROAP.SEND_ROAP_MSG_SUCCESS,
-          seq: 2,
-          correlationId: meeting.correlationId,
-        });
-
-        assert.calledOnce(meeting.setRoapSeq);
-        assert.calledWith(meeting.setRoapSeq, 2);
-      })
-    );
-  });
-});
+import {assert} from '@webex/test-helper-chai';
+import sinon from 'sinon';
+import TurnDiscovery from '@webex/plugin-meetings/src/roap/turnDiscovery';
+import {ROAP} from '@webex/plugin-meetings/src/constants';
+
+import RoapRequest from '@webex/plugin-meetings/src/roap/request';
+import RoapHandler from '@webex/plugin-meetings/src/roap/handler';
+import Roap from '@webex/plugin-meetings/src/roap/';
+import Meeting from '@webex/plugin-meetings/src/meeting';
+
+describe('Roap', () => {
+  describe('doTurnDiscovery', () => {
+    it('calls this.turnDiscovery.doTurnDiscovery() and forwards all the arguments', async () => {
+      const RESULT = {something: 'some value'};
+      const meeting = {id: 'some meeting id'} as Meeting;
+
+      const doTurnDiscoveryStub = sinon
+        .stub(TurnDiscovery.prototype, 'doTurnDiscovery')
+        .resolves(RESULT);
+
+      const roap = new Roap({}, {parent: 'fake'});
+
+      // call with isReconnecting: true
+      const result = await roap.doTurnDiscovery(meeting, true);
+
+      assert.calledOnceWithExactly(doTurnDiscoveryStub, meeting, true);
+      assert.deepEqual(result, RESULT);
+
+      doTurnDiscoveryStub.resetHistory();
+
+      // and with isReconnecting: false
+      const result2 = await roap.doTurnDiscovery(meeting, false);
+
+      assert.calledOnceWithExactly(doTurnDiscoveryStub, meeting, false);
+      assert.deepEqual(result2, RESULT);
+
+      sinon.restore();
+    });
+  });
+
+  describe('sendRoapMediaRequest', () => {
+    let sendRoapStub;
+    let roapHandlerSubmitStub;
+
+    const meeting = {
+      id: 'some meeting id',
+      correlationId: 'correlation id',
+      selfUrl: 'self url',
+      mediaId: 'media id',
+      audio:{
+        isLocallyMuted: () => true,
+      },
+      video:{
+        isLocallyMuted: () => false,
+      },
+      setRoapSeq: sinon.stub(),
+      config: {experimental: {enableTurnDiscovery: false}},
+    };
+
+    beforeEach(() => {
+      sendRoapStub = sinon.stub(RoapRequest.prototype, 'sendRoap').resolves({});
+      roapHandlerSubmitStub = sinon.stub(RoapHandler.prototype, 'submit');
+      meeting.setRoapSeq.resetHistory();
+    });
+
+    afterEach(() => {
+      sinon.restore();
+    });
+
+    [
+      {reconnect: true, enableTurnDiscovery: true, expectEmptyMediaId: false},
+      {reconnect: true, enableTurnDiscovery: false, expectEmptyMediaId: true},
+      {reconnect: false, enableTurnDiscovery: true, expectEmptyMediaId: false},
+      {reconnect: false, enableTurnDiscovery: false, expectEmptyMediaId: false},
+    ].forEach(({reconnect, enableTurnDiscovery, expectEmptyMediaId}) =>
+      it(`sends roap OFFER with ${expectEmptyMediaId ? 'empty ' : ''}mediaId when ${
+        reconnect ? '' : 'not '
+      }reconnecting and TURN discovery is ${
+        enableTurnDiscovery ? 'enabled' : 'disabled'
+      }`, async () => {
+        meeting.config.experimental.enableTurnDiscovery = enableTurnDiscovery;
+
+        const roap = new Roap({}, {parent: 'fake'});
+
+        await roap.sendRoapMediaRequest({
+          meeting,
+          sdp: 'sdp',
+          reconnect,
+          roapSeq: 1,
+        });
+
+        const expectedRoapMessage = {
+          messageType: 'OFFER',
+          sdps: ['sdp'],
+          version: '2',
+          seq: 2,
+          tieBreaker: 4294967294,
+        };
+
+        assert.calledOnce(sendRoapStub);
+        assert.calledWith(sendRoapStub, {
+          roapMessage: expectedRoapMessage,
+          correlationId: meeting.correlationId,
+          locusSelfUrl: meeting.selfUrl,
+          mediaId: expectEmptyMediaId ? '' : meeting.mediaId,
+          audioMuted: meeting.audio?.isLocallyMuted(),
+          videoMuted: meeting.video?.isLocallyMuted(),
+          meetingId: meeting.id,
+        });
+
+        assert.calledTwice(roapHandlerSubmitStub);
+        assert.calledWith(roapHandlerSubmitStub, {
+          type: ROAP.SEND_ROAP_MSG,
+          msg: expectedRoapMessage,
+          correlationId: meeting.correlationId,
+        });
+        assert.calledWith(roapHandlerSubmitStub, {
+          type: ROAP.SEND_ROAP_MSG_SUCCESS,
+          seq: 2,
+          correlationId: meeting.correlationId,
+        });
+
+        assert.calledOnce(meeting.setRoapSeq);
+        assert.calledWith(meeting.setRoapSeq, 2);
+      })
+    );
+  });
+});