@webex/plugin-meetings 2.35.3 → 2.36.0

package/src/roap/turnDiscovery.ts

@@ -1,3 +1,4 @@
+// @ts-ignore - Types not available for @webex/common
 import {Defer} from '@webex/common';
 
 import Metrics from '../metrics';
@@ -6,6 +7,7 @@ import LoggerProxy from '../common/logs/logger-proxy';
 import {ROAP} from '../constants';
 
 import RoapRequest from './request';
+import Meeting from '../meeting';
 
 const TURN_DISCOVERY_TIMEOUT = 10; // in seconds
 
@@ -48,7 +50,7 @@ export default class TurnDiscovery {
    * @private
    * @memberof Roap
    */
-  waitForTurnDiscoveryResponse() {
+  private waitForTurnDiscoveryResponse() {
     if (!this.defer) {
       LoggerProxy.logger.warn('Roap:turnDiscovery#waitForTurnDiscoveryResponse --> TURN discovery is not in progress');
 
@@ -76,7 +78,8 @@ export default class TurnDiscovery {
    * @public
    * @memberof Roap
    */
-  handleTurnDiscoveryResponse(roapMessage) {
+  public handleTurnDiscoveryResponse(roapMessage: object) {
+    // @ts-ignore - Fix missing type
     const {headers} = roapMessage;
 
     if (!this.defer) {
@@ -125,7 +128,7 @@ export default class TurnDiscovery {
    * @private
    * @memberof Roap
    */
-  sendRoapTurnDiscoveryRequest(meeting, isReconnecting) {
+  private sendRoapTurnDiscoveryRequest(meeting: Meeting, isReconnecting: boolean) {
     const seq = meeting.roapSeq + 1;
 
     if (this.defer) {
@@ -148,7 +151,9 @@ export default class TurnDiscovery {
       .sendRoap({
         roapMessage,
         correlationId: meeting.correlationId,
+       // @ts-ignore - Fix missing type
         locusSelfUrl: meeting.selfUrl,
+        // @ts-ignore - Fix missing type
         mediaId: isReconnecting ? '' : meeting.mediaId,
         audioMuted: meeting.isAudioMuted(),
         videoMuted: meeting.isVideoMuted(),
@@ -170,7 +175,7 @@ export default class TurnDiscovery {
    * @param {Meeting} meeting
    * @returns {Promise}
    */
-  sendRoapOK(meeting) {
+  sendRoapOK(meeting: Meeting) {
     LoggerProxy.logger.info('Roap:turnDiscovery#sendRoapOK --> sending OK');
 
     return this.roapRequest.sendRoap({
@@ -179,7 +184,9 @@ export default class TurnDiscovery {
         version: ROAP.ROAP_VERSION,
         seq: meeting.roapSeq
       },
+      // @ts-ignore - fix type
       locusSelfUrl: meeting.selfUrl,
+      // @ts-ignore - fix type
       mediaId: meeting.mediaId,
       correlationId: meeting.correlationId,
       audioMuted: meeting.isAudioMuted(),
@@ -201,7 +208,8 @@ export default class TurnDiscovery {
    *                                 media connection just after a reconnection
    * @returns {Promise}
    */
-  doTurnDiscovery(meeting, isReconnecting) {
+  doTurnDiscovery(meeting: Meeting, isReconnecting: boolean) {
+    // @ts-ignore - fix type
     const isAnyClusterReachable = meeting.webex.meetings.reachability.isAnyClusterReachable();
 
     if (isAnyClusterReachable) {
@@ -209,6 +217,7 @@ export default class TurnDiscovery {
       return Promise.resolve({turnServerInfo: undefined, turnDiscoverySkippedReason: 'reachability'});
     }
 
+    // @ts-ignore - fix type
     if (!meeting.config.experimental.enableTurnDiscovery) {
       LoggerProxy.logger.info('Roap:turnDiscovery#doTurnDiscovery --> TURN discovery disabled in config, skipping it');
 

package/src/roap/{util.js → util.ts}

@@ -1,4 +1,3 @@
-
 import PeerConnectionManager from '../peer-connection-manager';
 import {
   _ANSWER_,
@@ -10,7 +9,7 @@ import {
 import LoggerProxy from '../common/logs/logger-proxy';
 import ParameterError from '../common/errors/parameter';
 
-const RoapUtil = {};
+const RoapUtil: any = {};
 const ROAP_ANSWER = _ANSWER_.toLowerCase();
 
 RoapUtil.shouldHandleMedia = (meeting) => {

package/src/statsAnalyzer/{index.js → index.ts}

@@ -29,6 +29,21 @@ export const EVENTS = {
  * @extends {EventsScope}
  */
 export class StatsAnalyzer extends EventsScope {
+  config: any;
+  correlationId: any;
+  lastEmittedStartStopEvent: any;
+  lastMqaDataSent: any;
+  lastStatsResults: any;
+  localMQEStats: any;
+  meetingMediaStatus: any;
+  mqaInterval: NodeJS.Timeout;
+  mqaSentCount: any;
+  networkQualityMonitor: any;
+  peerConnection: any;
+  statsInterval: NodeJS.Timeout;
+  statsResults: any;
+  statsStarted: any;
+
   /**
    * Creates a new instance of StatsAnalyzer
    * @constructor
@@ -37,7 +52,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {Object} networkQualityMonitor class for assessing network characteristics (jitter, packetLoss, latency)
    * @param {Object} statsResults Default properties for stats
    */
-  constructor(config, networkQualityMonitor = {}, statsResults = defaultStats) {
+  constructor(config: any, networkQualityMonitor: object = {}, statsResults: object = defaultStats) {
     super();
     this.statsStarted = false;
     this.statsResults = statsResults;
@@ -170,7 +185,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  updateMediaStatus(status) {
+  public updateMediaStatus(status: object) {
     this.meetingMediaStatus = status;
   }
 
@@ -181,7 +196,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  sendMqaData() {
+  public sendMqaData() {
     const audioReceiver = mqaData.intervals[0].audioReceive[0];
     const audioSender = mqaData.intervals[0].audioTransmit[0];
     const videoReceiver = mqaData.intervals[0].videoReceive[0];
@@ -236,6 +251,7 @@ export class StatsAnalyzer extends EventsScope {
     mqaData.intervals[0].intervalMetadata.peripherals.push({information: this.peerConnection?.videoTransceiver?.sender?.track?.label || _UNKNOWN_, name: MEDIA_DEVICES.CAMERA});
 
 
+    // @ts-ignore
     mqaData.networkType = this.statsResults.connectionType.local.networkType;
 
     this.mqaSentCount += 1;
@@ -257,6 +273,7 @@ export class StatsAnalyzer extends EventsScope {
       EVENTS.MEDIA_QUALITY,
       {
         data: mqaData.intervals[0],
+        // @ts-ignore
         networkType: mqaData.networkType
       }
     );
@@ -270,7 +287,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {PeerConnection} peerConnection
    * @returns {void}
    */
-  updatePeerconnection(peerConnection) {
+  updatePeerconnection(peerConnection: any) {
     this.peerConnection = peerConnection;
   }
 
@@ -282,7 +299,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {PeerConnection} peerConnection
    * @returns {Promise}
    */
-  startAnalyzer(peerConnection) {
+  public startAnalyzer(peerConnection: any) {
     if (!this.statsStarted) {
       this.statsStarted = true;
       this.peerConnection = peerConnection;
@@ -310,7 +327,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  stopAnalyzer() {
+  public stopAnalyzer() {
     const sendOneLastMqa = this.mqaInterval && this.statsInterval;
 
     if (this.statsInterval) {
@@ -344,7 +361,7 @@ export class StatsAnalyzer extends EventsScope {
    * @returns {void}
    * @memberof StatsAnalyzer
    */
-  parseGetStatsResult(getStatsResult, type, isSender) {
+  private parseGetStatsResult(getStatsResult: any, type: string, isSender: boolean) {
     if (!getStatsResult) {
       return;
     }
@@ -361,6 +378,7 @@ export class StatsAnalyzer extends EventsScope {
         break;
       case 'remote-inbound-rtp':
       case 'remote-outbound-rtp':
+        // @ts-ignore
         this.compareSentAndReceived(getStatsResult, type, isSender);
         break;
       case 'remotecandidate':
@@ -371,6 +389,7 @@ export class StatsAnalyzer extends EventsScope {
         this.parseCandidate(getStatsResult, type, isSender, false);
         break;
       case 'media-source':
+        // @ts-ignore
         this.parseAudioSource(getStatsResult, type);
         break;
       default:
@@ -386,7 +405,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {boolean} isSender
    * @returns {void}
    */
-  filterAndParseGetStatsResults(getStatsResults, type, isSender) {
+  private filterAndParseGetStatsResults(getStatsResults: Array<any>, type: string, isSender: boolean) {
     const {types} = DEFAULT_GET_STATS_FILTER;
 
     getStatsResults.forEach((result) => {
@@ -402,7 +421,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {boolean} type
    * @returns {void}
    */
-  parseAudioSource(result, type) {
+  parseAudioSource(result: any, type: any) {
     if (!result) {
       return;
     }
@@ -427,7 +446,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  emitStartStopEvents = (mediaType, previousValue, currentValue, isLocal) => {
+  emitStartStopEvents = (mediaType: string, previousValue: number, currentValue: number, isLocal: boolean) => {
     if (mediaType !== 'audio' && mediaType !== 'video' && mediaType !== 'share') {
       throw new Error(`Unsupported mediaType: ${mediaType}`);
     }
@@ -475,7 +494,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {void}
    */
-  compareLastStatsResult() {
+  private compareLastStatsResult() {
     if (this.lastStatsResults !== null && this.meetingMediaStatus) {
       // compare audio stats sent
       let mediaType = STATS.AUDIO_CORRELATE;
@@ -633,7 +652,7 @@ export class StatsAnalyzer extends EventsScope {
    * @memberof StatsAnalyzer
    * @returns {Promise}
    */
-  getStatsAndParse() {
+  private getStatsAndParse() {
     if (!this.peerConnection) {
       return Promise.resolve();
     }
@@ -694,7 +713,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {*} type
    * @returns {void}
    */
-  processOutboundRTPResult(result, type) {
+  private processOutboundRTPResult(result: any, type: any) {
     const mediaType = type || STATS.AUDIO_CORRELATE;
     const sendrecvType = STATS.SEND_DIRECTION;
 
@@ -758,7 +777,7 @@ export class StatsAnalyzer extends EventsScope {
    * @param {*} type
    * @returns {void}
    */
-  processInboundRTPResult(result, type) {
+  private processInboundRTPResult(result: any, type: any) {
     const mediaType = type || STATS.AUDIO_CORRELATE;
     const sendrecvType = STATS.RECEIVE_DIRECTION;
 
@@ -860,7 +879,7 @@ export class StatsAnalyzer extends EventsScope {
    *
    * @returns {void}
    */
-  parseCandidate = (result, type, isSender, isRemote) => {
+  parseCandidate = (result: any, type: any, isSender: boolean, isRemote: boolean) => {
     if (!result || !result.id) {
       return;
     }
@@ -935,7 +954,7 @@ export class StatsAnalyzer extends EventsScope {
    * @returns {void}
    * @memberof StatsAnalyzer
    */
-  processTrackResult(result, mediaType) {
+  private processTrackResult(result: any, mediaType: any) {
     if (!result || result.type !== 'track') {
       return;
     }
@@ -979,7 +998,7 @@ export class StatsAnalyzer extends EventsScope {
    * @returns {void}
    * @memberof StatsAnalyzer
    */
-  compareSentAndReceived(result, type) {
+  private compareSentAndReceived(result: any, type: any) {
     if (!type) {
       return;
     }

package/src/statsAnalyzer/{mqaUtil.js → mqaUtil.ts}

@@ -1,4 +1,3 @@
-
 import {mean, max} from 'lodash';
 
 import {STATS} from '../constants';
@@ -17,6 +16,7 @@ export const getAudioReceiverMqa = ({audioReceiver, statsResults, lastMqaDataSen
   audioReceiver.common.mediaHopByHopLost = (statsResults[mediaType][sendrecvType].totalPacketsLost - lastMqaDataSent[mediaType][sendrecvType].totalPacketsLost) || 0;
   audioReceiver.common.rtpHopByHopLost = statsResults[mediaType][sendrecvType].totalPacketsLost - lastMqaDataSent[mediaType][sendrecvType].totalPacketsLost || 0;
 
+  // @ts-ignore
   audioReceiver.streams[0].common.maxRtpJitter = max(statsResults[mediaType][sendrecvType].meanRtpJitter) * 1000 || 0;
   audioReceiver.streams[0].common.meanRtpJitter = mean(statsResults[mediaType][sendrecvType].meanRtpJitter) * 1000 || 0;
   audioReceiver.streams[0].common.rtpJitter = audioReceiver.streams[0].common.maxRtpJitter;
@@ -43,6 +43,7 @@ export const getAudioSenderMqa = ({audioSender, statsResults, lastMqaDataSent})
   audioSender.common.common.direction = statsResults[mediaType].direction;
   audioSender.common.transportType = statsResults.connectionType.local.transport[0];
 
+  // @ts-ignore
   audioSender.common.maxRemoteJitter = max(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
   audioSender.common.meanRemoteJitter = mean(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
 
@@ -56,6 +57,7 @@ export const getAudioSenderMqa = ({audioSender, statsResults, lastMqaDataSent})
 
   audioSender.common.remoteLossRate = totalpacketsLostForaMin > 0 ? (totalpacketsLostForaMin * 100 / audioSender.common.rtpPackets) : 0; // This is the packets sent with in last min || 0;
 
+  // @ts-ignore
   audioSender.common.maxRoundTripTime = max(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   audioSender.common.meanRoundTripTime = mean(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   audioSender.common.roundTripTime = audioSender.common.maxRoundTripTime;
@@ -97,6 +99,7 @@ export const getVideoReceiverMqa = ({
 
   // calculate this values
 
+  // @ts-ignore
   videoReceiver.common.maxRemoteJitter = max(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
   videoReceiver.common.meanRemoteJitter = mean(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
 
@@ -134,6 +137,7 @@ export const getVideoSenderMqa = ({
   videoSender.common.common.direction = statsResults[mediaType].direction;
   videoSender.common.transportType = statsResults.connectionType.local.transport[0];
 
+  // @ts-ignore
   videoSender.common.maxRemoteJitter = max(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
   videoSender.common.meanRemoteJitter = mean(statsResults[mediaType][sendrecvType].meanRemoteJitter) * 1000 || 0;
 
@@ -146,6 +150,7 @@ export const getVideoSenderMqa = ({
 
   videoSender.common.remoteLossRate = totalpacketsLostForaMin > 0 ? (totalpacketsLostForaMin) * 100 / (videoSender.common.rtpPackets + totalpacketsLostForaMin) : 0; // This is the packets sent with in last min || 0;
 
+  // @ts-ignore
   videoSender.common.maxRoundTripTime = max(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   videoSender.common.meanRoundTripTime = mean(statsResults[mediaType][sendrecvType].meanRoundTripTime) * 1000 || 0;
   videoSender.common.roundTripTime = videoSender.common.maxRoundTripTime;

package/src/transcription/{index.js → index.ts}

@@ -6,6 +6,12 @@ import {v4 as uuidv4} from 'uuid';
  * @class Transcription
  */
 export default class Transcription {
+  webSocketUrl: any;
+  sessionID: any;
+  members: any;
+  memberCSIs: any;
+  webSocket: any;
+
   /**
    * @param {string} webSocketUrl
    * @param {sessionID} sessionId
@@ -13,7 +19,7 @@ export default class Transcription {
    * @constructor
    * @memberof Transcription
    */
-  constructor(webSocketUrl, sessionId, members) {
+  constructor(webSocketUrl: string, sessionId: any, members: object) {
     this.webSocketUrl = webSocketUrl;
     this.sessionID = sessionId;
     this.members = members;
@@ -32,7 +38,7 @@ export default class Transcription {
    * @param {string} sessionID
    * @returns {void}
    */
-  connect(token) {
+  connect(token: string) {
     this.webSocket.onopen = () => {
       this.webSocket.send(JSON.stringify({
         id: uuidv4(),
@@ -46,10 +52,10 @@ export default class Transcription {
   /**
    * Sets callback to invoke when the web socket connection is closed.
    *
-   * @param {function} callback
+   * @param {Function} callback
    * @returns {void}
    */
-  onCloseSocket(callback) {
+  onCloseSocket(callback: Function) {
     if (callback) {
       this.webSocket.onclose = (event) => {
         callback(event);
@@ -61,10 +67,10 @@ export default class Transcription {
    * Sets callback to invoke when a web socket connection error occurs.
    * An event parameter will be send to the callback.
    *
-   * @param {function} callback
+   * @param {Function} callback
    * @returns {void}
    */
-  onErrorSocket(callback) {
+  onErrorSocket(callback: Function) {
     if (callback) {
       this.webSocket.onerror = (event) => {
         callback(event);
@@ -79,7 +85,7 @@ export default class Transcription {
    * @param {object} csis
    * @returns {object}
    */
-  getSpeaker(csis) {
+  private getSpeaker(csis: any) {
     for (const csi of csis) {
       const member = this.memberCSIs[csi];
 
@@ -89,7 +95,7 @@ export default class Transcription {
     }
 
     return Object.values(this.members.membersCollection.members)
-      .find((member) => {
+      .find((member: any) => {
         const memberCSIs = member.participant.status.csis;
         let selfIsSpeaking = false;
 
@@ -108,10 +114,10 @@ export default class Transcription {
   /**
    * Sends transcription data to given callback as it arrives.
    *
-   * @param {function} callback
+   * @param {Function} callback
    * @returns {void}
    */
-  subscribe(callback) {
+  subscribe(callback: Function) {
     let data, csis, speaker, transcription;
 
     this.webSocket.onmessage = (event) => {
@@ -144,4 +150,3 @@ export default class Transcription {
     this.webSocket.close();
   }
 }
-

package/test/integration/spec/space-meeting.js

@@ -2,7 +2,6 @@
 import {assert} from '@webex/test-helper-chai';
 import {skipInNode, jenkinsOnly} from '@webex/test-helper-mocha';
 import {patterns} from '@webex/common';
-
 import MeetingInfoUtil from '@webex/plugin-meetings/src/meeting-info/utilv2';
 
 import CMR from '../../utils/cmr';
@@ -10,7 +9,7 @@ import testUtils from '../../utils/testUtils';
 
 require('dotenv').config();
 
-const webexTestUsers = require('../../utils/webex-test-users.js');
+const webexTestUsers = require('../../utils/webex-test-users');
 
 let userSet, alice, bob, chris, guest;
 

package/test/unit/spec/meeting/index.js

@@ -1420,9 +1420,9 @@ describe('plugin-meetings', () => {
           });
         });
       });
-      describe('#share', () => {
-        it('should have #share', () => {
-          assert.exists(meeting.share);
+      describe('#requestScreenShareFloor', () => {
+        it('should have #requestScreenShareFloor', () => {
+          assert.exists(meeting.requestScreenShareFloor);
         });
         beforeEach(() => {
           meeting.locusInfo.mediaShares = [{name: 'content', url: url1}];
@@ -1430,7 +1430,7 @@ describe('plugin-meetings', () => {
           meeting.meetingRequest.changeMeetingFloor = sinon.stub().returns(Promise.resolve());
         });
         it('should send the share', async () => {
-          const share = meeting.share();
+          const share = meeting.requestScreenShareFloor();
 
           assert.exists(share.then);
           await share;
@@ -3457,22 +3457,34 @@ describe('plugin-meetings', () => {
         sandbox = null;
       });
 
-      describe('#stopFloorRequest', () => {
-        it('should have #stopFloorRequest', () => {
-          assert.exists(meeting.stopFloorRequest);
+      describe('#releaseScreenShareFloor', () => {
+        it('should have #releaseScreenShareFloor', () => {
+          assert.exists(meeting.releaseScreenShareFloor);
         });
         beforeEach(() => {
-          meeting.locusInfo.mediaShares = [{name: 'content', url: url1}];
+          meeting.selfId = 'some self id';
+          meeting.locusInfo.mediaShares = [{name: 'content', url: url1, floor: {beneficiary: {id: meeting.selfId}}}];
           meeting.locusInfo.self = {url: url2};
+          meeting.mediaProperties = {mediaDirection: {sendShare: true}};
           meeting.meetingRequest.changeMeetingFloor = sinon.stub().returns(Promise.resolve());
         });
-        it('should call change meeting floor', async () => {
-          const share = meeting.share();
+        it('should call changeMeetingFloor()', async () => {
+          const share = meeting.releaseScreenShareFloor();
 
           assert.exists(share.then);
           await share;
           assert.calledOnce(meeting.meetingRequest.changeMeetingFloor);
         });
+        it('should not call changeMeetingFloor() if someone else already has the floor', async () => {
+          // change selfId so that it doesn't match the beneficiary id from meeting.locusInfo.mediaShares
+          meeting.selfId = 'new self id';
+
+          const share = meeting.releaseScreenShareFloor();
+
+          assert.exists(share.then);
+          await share;
+          assert.notCalled(meeting.meetingRequest.changeMeetingFloor);
+        });
       });
 
       describe('#setSipUri', () => {
@@ -4003,7 +4015,7 @@ describe('plugin-meetings', () => {
                       if (newPayload.previous.content.beneficiaryId === USER_IDS.ME) {
                         eventTrigger.share.push({
                           eventName: EVENT_TRIGGERS.MEETING_STOPPED_SHARING_LOCAL,
-                          functionName: 'stopFloorRequest'
+                          functionName: 'localShare'
                         });
                       }
                       else if (newPayload.current.content.beneficiaryId === USER_IDS.ME) {
@@ -4054,7 +4066,7 @@ describe('plugin-meetings', () => {
                     if (newPayload.current.content.beneficiaryId === USER_IDS.ME) {
                       eventTrigger.share.push({
                         eventName: EVENT_TRIGGERS.MEETING_STOPPED_SHARING_LOCAL,
-                        functionName: 'stopFloorRequest'
+                        functionName: 'localShare'
                       });
                     }
                     else {
@@ -4073,7 +4085,7 @@ describe('plugin-meetings', () => {
                     if (newPayload.previous.content.beneficiaryId === USER_IDS.ME) {
                       eventTrigger.share.push({
                         eventName: EVENT_TRIGGERS.MEETING_STOPPED_SHARING_LOCAL,
-                        functionName: 'stopFloorRequest'
+                        functionName: 'localShare'
                       });
                     }
                     else if (newPayload.current.content.beneficiaryId === USER_IDS.ME) {
@@ -4116,7 +4128,7 @@ describe('plugin-meetings', () => {
                 if (beneficiaryId === USER_IDS.ME) {
                   eventTrigger.share.push({
                     eventName: EVENT_TRIGGERS.MEETING_STOPPED_SHARING_LOCAL,
-                    functionName: 'stopFloorRequest'
+                    functionName: 'localShare'
                   });
                 }
                 else {
@@ -4582,6 +4594,93 @@ describe('plugin-meetings', () => {
           meeting.stopKeepAlive();
         });
       });
+
+      describe('#sendReaction', () => {
+        it('should have #sendReaction', () => {
+          assert.exists(meeting.sendReaction);
+        });
+
+        beforeEach(() => {
+          meeting.meetingRequest.sendReaction = sinon.stub().returns(Promise.resolve());
+        });
+
+        it('should send reaction with the right data and return a promise', async () => {
+          meeting.locusInfo.controls = {reactions: {reactionChannelUrl: 'Fake URL'}};
+
+          const reactionPromise = meeting.sendReaction('thumbs_down', 'light');
+
+          assert.exists(reactionPromise.then);
+          await reactionPromise;
+          assert.calledOnceWithExactly(meeting.meetingRequest.sendReaction, {
+            reactionChannelUrl: 'Fake URL',
+            reaction: {
+              type: 'thumb_down',
+              codepoints: '1F44E',
+              shortcodes: ':thumbsdown:',
+              tone: {
+                type: 'light_skin_tone',
+                codepoints: '1F3FB',
+                shortcodes: ':skin-tone-2:'
+              }
+            },
+            participantId: meeting.members.selfId,
+          });
+        });
+
+        it('should fail sending a reaction if data channel is undefined', async () => {
+          meeting.locusInfo.controls = {reactions: {reactionChannelUrl: undefined}};
+
+          await assert.isRejected(meeting.sendReaction('thumbs_down', 'light'), Error, 'Error sending reaction, service url not found.');
+
+          assert.notCalled(meeting.meetingRequest.sendReaction);
+        });
+
+        it('should fail sending a reaction if reactionType is invalid ', async () => {
+          meeting.locusInfo.controls = {reactions: {reactionChannelUrl: 'Fake URL'}};
+
+          await assert.isRejected(meeting.sendReaction('invalid_reaction', 'light'), Error, 'invalid_reaction is not a valid reaction.');
+
+          assert.notCalled(meeting.meetingRequest.sendReaction);
+        });
+
+        it('should send a reaction with default skin tone if provided skinToneType is invalid ', async () => {
+          meeting.locusInfo.controls = {reactions: {reactionChannelUrl: 'Fake URL'}};
+
+          const reactionPromise = meeting.sendReaction('thumbs_down', 'invalid_skin_tone');
+
+          assert.exists(reactionPromise.then);
+          await reactionPromise;
+          assert.calledOnceWithExactly(meeting.meetingRequest.sendReaction, {
+            reactionChannelUrl: 'Fake URL',
+            reaction: {
+              type: 'thumb_down',
+              codepoints: '1F44E',
+              shortcodes: ':thumbsdown:',
+              tone: {type: 'normal_skin_tone', codepoints: '', shortcodes: ''}
+            },
+            participantId: meeting.members.selfId,
+          });
+        });
+
+        it('should send a reaction with default skin tone if none provided', async () => {
+          meeting.locusInfo.controls = {reactions: {reactionChannelUrl: 'Fake URL'}};
+
+          const reactionPromise = meeting.sendReaction('thumbs_down');
+
+          assert.exists(reactionPromise.then);
+          await reactionPromise;
+          assert.calledOnceWithExactly(meeting.meetingRequest.sendReaction, {
+            reactionChannelUrl: 'Fake URL',
+            reaction: {
+              type: 'thumb_down',
+              codepoints: '1F44E',
+              shortcodes: ':thumbsdown:',
+              tone: {type: 'normal_skin_tone', codepoints: '', shortcodes: ''}
+            },
+            participantId: meeting.members.selfId,
+          });
+        });
+      });
     });
   });
 });