@webex/plugin-meetings 2.29.3 → 2.29.5

package/src/meeting/index.js

@@ -3510,7 +3510,7 @@ export default class Meeting extends StatelessWebexPlugin {
     Metrics.postEvent({
       event: eventType.CALL_INITIATED,
       meeting: this,
-      data: {trigger: trigger.USER_INTERACTION}
+      data: {trigger: trigger.USER_INTERACTION, isRoapCallEnabled: true}
     });
 
     LoggerProxy.logger.log('Meeting:index#join --> Joining a meeting');

package/src/metrics/index.js

@@ -237,6 +237,9 @@ class Metrics {
       if (options.joinTimes) {
         payload.event.joinTimes = options.joinTimes;
       }
+      if (options.isRoapCallEnabled) {
+        payload.event.isRoapCallEnabled = options.isRoapCallEnabled;
+      }
     }
 
     return payload;

package/src/peer-connection-manager/index.js

@@ -121,7 +121,7 @@ const isSdpInvalid = (sdp) => {
 
   for (const mediaLine of parsedSdp.media) {
     if (!mediaLine.candidates || mediaLine.candidates?.length === 0) {
-      LoggerProxy.logger.error('PeerConnectionManager:index#isSdpInvalid --> iceCandidate: Ice candadate never completed');
+      LoggerProxy.logger.error('PeerConnectionManager:index#isSdpInvalid --> iceCandidate: Ice candidate never completed');
 
       return 'iceCandidate: Ice gathering never completed';
     }
@@ -378,7 +378,7 @@ pc.setRemoteSessionDetails = (
 };
 
 /**
- * create offer with a valid paramater
+ * Create offer with a valid parameter
  * @param {Object} peerConnection
  * @param {Object} meetingProperties
  * @param {string} meetingProperties.meetingId
@@ -403,7 +403,7 @@ pc.createOffer = (peerConnection, {
     .createOffer()
     .then((description) => {
       // bug https://bugs.chromium.org/p/chromium/issues/detail?id=1020642
-      // chrome currently generates RTX line irrespective of weither the server side supports it
+      // chrome currently generates RTX line irrespective of whether the server side supports it
       // we are removing apt as well because its associated with rtx line
 
       if (!enableRtx) {

package/test/integration/spec/journey.js

@@ -1,4 +1,6 @@
 /* globals navigator */
+/* eslint prefer-arrow-callback: 0 */
+
 import {assert} from '@webex/test-helper-chai';
 import {skipInNode} from '@webex/test-helper-mocha';
 import sinon from 'sinon';

package/test/integration/spec/space-meeting.js

@@ -1,4 +1,4 @@
-
+/* eslint prefer-arrow-callback: 0 */
 import {assert} from '@webex/test-helper-chai';
 import {skipInNode, jenkinsOnly} from '@webex/test-helper-mocha';
 import {patterns} from '@webex/common';

package/test/unit/spec/meeting/index.js

@@ -41,7 +41,7 @@ import LoggerConfig from '@webex/plugin-meetings/src/common/logs/logger-config';
 import TriggerProxy from '@webex/plugin-meetings/src/common/events/trigger-proxy';
 import BrowserDetection from '@webex/plugin-meetings/src/common/browser-detection';
 import Metrics from '@webex/plugin-meetings/src/metrics';
-import {eventType} from '@webex/plugin-meetings/src/metrics/config';
+import {trigger, eventType} from '@webex/plugin-meetings/src/metrics/config';
 import BEHAVIORAL_METRICS from '@webex/plugin-meetings/src/metrics/constants';
 
 import locus from '../fixture/locus';
@@ -783,6 +783,8 @@ describe('plugin-meetings', () => {
           it('should join the meeting and return promise', async () => {
             const join = meeting.join();
 
+            assert.calledWithMatch(Metrics.postEvent, {event: eventType.CALL_INITIATED, data: {trigger: trigger.USER_INTERACTION, isRoapCallEnabled: true}});
+
             assert.exists(join.then);
             await join;
             assert.calledOnce(MeetingUtil.joinMeeting);

package/test/.eslintrc.json

@@ -1,6 +0,0 @@
-{
-  "rules": {
-    "no-underscore-dangle": "off",
-    "prefer-arrow-callback": "off"
-  }
-}

package/test/unit/spec/reachability/request.ts

@@ -1,84 +0,0 @@
-
-import {assert} from '@webex/test-helper-chai';
-import sinon from 'sinon';
-import ReachabilityRequest from '@webex/plugin-meetings/src/reachability/request';
-
-describe('ReachabilityRequest', () => {
-  let webex;
-  let reachabilityRequest;
-
-  const VIDEO_MESH_NODE_0 = '111-222-333-some-vmn';
-  const VIDEO_MESH_NODE_1 = '444-555-666-some-vmn';
-
-  const CLOUD_NODE_0 = 'some-public-node-1.somewhere';
-  const CLOUD_NODE_1 = 'some-public-node-2.somewhere';
-
-  const vmnClusterUrls = [{
-    tcp: ['some vmn node 0 tcp url', 'another vmn node 0 tcp url'],
-    udp: ['some vmn node 0 udp url', 'another vmn node 0 udp url']
-  }, {
-    tcp: ['some vmn node 1 tcp url', 'another vmn node 1 tcp url'],
-    udp: ['some vmn node 1 udp url', 'another vmn node 1 udp url']
-  }
-  ];
-
-  const cloudClusterUrls = [{
-    tcp: ['some public node 0 tcp url', 'another public node 0 tcp url'],
-    udp: ['some public node 0 udp url', 'another public node 0 udp url']
-  }, {
-    tcp: ['some public node 1 tcp url', 'another public node 1 tcp url'],
-    udp: ['some public node 1 udp url', 'another public node 1 udp url']
-  }
-  ];
-
-  beforeEach(() => {
-    webex = {
-      request: sinon.stub()
-    };
-    reachabilityRequest = new ReachabilityRequest(webex);
-  });
-
-  describe('getClusters', () => {
-    beforeEach(() => {
-      webex.request = sinon.fake.resolves({
-        body: {
-          clusterClasses: {
-            ocpCloud: [],
-            publicCloud: [],
-            hybridMedia: [VIDEO_MESH_NODE_0, VIDEO_MESH_NODE_1]
-          },
-          clusters: {
-            [VIDEO_MESH_NODE_0]: vmnClusterUrls[0],
-            [VIDEO_MESH_NODE_1]: vmnClusterUrls[1],
-            [CLOUD_NODE_0]: cloudClusterUrls[0],
-            [CLOUD_NODE_1]: cloudClusterUrls[1],
-          }
-        }
-      });
-    });
-
-    it('marks video mesh clusters correctly', async () => {
-      const clusters = await reachabilityRequest.getClusters(false);
-
-      assert.deepEqual(clusters, {
-        [VIDEO_MESH_NODE_0]: {
-          ...vmnClusterUrls[0],
-          isVideoMesh: true,
-        },
-        [VIDEO_MESH_NODE_1]: {
-          ...vmnClusterUrls[1],
-          isVideoMesh: true,
-        },
-        [CLOUD_NODE_0]: {
-          ...cloudClusterUrls[0],
-          isVideoMesh: false,
-        },
-        [CLOUD_NODE_1]: {
-          ...cloudClusterUrls[1],
-          isVideoMesh: false,
-        },
-      });
-    });
-  });
-});
-