@webex/plugin-meetings 2.19.0 → 2.19.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/plugin-meetings",
-  "version": "2.19.0",
+  "version": "2.19.1",
   "description": "",
   "license": "MIT",
   "contributors": [
@@ -24,21 +24,21 @@
   },
   "dependencies": {
     "@babel/runtime-corejs2": "^7.14.8",
-    "@webex/webex-core": "2.19.0",
-    "@webex/internal-plugin-mercury": "2.19.0",
-    "@webex/internal-plugin-conversation": "2.19.0",
+    "@webex/webex-core": "2.19.1",
+    "@webex/internal-plugin-mercury": "2.19.1",
+    "@webex/internal-plugin-conversation": "2.19.1",
     "webrtc-adapter": "^7.7.0",
     "lodash": "^4.17.21",
     "uuid": "^3.3.2",
     "global": "^4.4.0",
     "ip-anonymize": "^0.1.0",
-    "@webex/common": "2.19.0",
+    "@webex/common": "2.19.1",
     "bowser": "^2.11.0",
     "sdp-transform": "^2.12.0",
     "readable-stream": "^3.6.0",
-    "@webex/common-timers": "2.19.0",
+    "@webex/common-timers": "2.19.1",
     "btoa": "^1.2.1",
-    "@webex/internal-media-core": "^0.0.6-beta",
+    "@webex/internal-media-core": "^0.0.7-beta",
     "javascript-state-machine": "^3.1.0",
     "envify": "^4.1.0"
   }

package/src/meeting/effectsState.js

@@ -109,8 +109,7 @@ class EffectsState {
       await meeting.updateAudio({
         sendAudio: true,
         receiveAudio: meeting.mediaProperties.mediaDirection.receiveAudio,
-        stream: audioStream,
-        bnrEnabled: bnr.enabled
+        stream: audioStream
       });
 
       LoggerProxy.logger.info('Meeting:effectState#enableBNR. Updated meeting audio with bnr enabled track');

package/src/meeting/index.js

@@ -4575,8 +4575,9 @@ export default class Meeting extends StatelessWebexPlugin {
       return this.enqueueMediaUpdate(MEDIA_UPDATE_TYPE.AUDIO, options);
     }
     const {
-      sendAudio, receiveAudio, stream, bnrEnabled
+      sendAudio, receiveAudio, stream
     } = options;
+
     const {audioTransceiver} = this.mediaProperties.peerConnection;
     let track = MeetingUtil.getTrack(stream).audioTrack;
 
@@ -4584,10 +4585,14 @@ export default class Meeting extends StatelessWebexPlugin {
       return Promise.reject(new ParameterError('Pass sendAudio and receiveAudio parameter'));
     }
 
-    if (sendAudio && !this.isAudioMuted() && (bnrEnabled === BNR_STATUS.ENABLED || bnrEnabled === BNR_STATUS.SHOULD_ENABLE)) {
-      LoggerProxy.logger.info('Meeting:index#updateAudio. Calling WebRTC enable bnr method');
-      track = await this.internal_enableBNR(track);
-      LoggerProxy.logger.info('Meeting:index#updateAudio. WebRTC enable bnr request completed');
+    if (this.effects && this.effects.state) {
+      const bnrEnabled = this.effects.state.bnr.enabled;
+
+      if (sendAudio && !this.isAudioMuted() && (bnrEnabled === BNR_STATUS.ENABLED || bnrEnabled === BNR_STATUS.SHOULD_ENABLE)) {
+        LoggerProxy.logger.info('Meeting:index#updateAudio. Calling WebRTC enable bnr method');
+        track = await this.internal_enableBNR(track);
+        LoggerProxy.logger.info('Meeting:index#updateAudio. WebRTC enable bnr request completed');
+      }
     }
 
     return MeetingUtil.validateOptions({sendAudio, localStream: stream})

package/test/unit/spec/meeting/effectsState.js

@@ -2,9 +2,9 @@
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import MockWebex from '@webex/test-helper-mock-webex';
+import {BNR_STATUS} from '@webex/plugin-meetings/src/constants';
 
 import BEHAVIORAL_METRICS from '@webex/plugin-meetings/src/metrics/constants';
-import {BNR_STATUS} from '@webex/plugin-meetings/src/constants';
 import Meeting from '@webex/plugin-meetings/src/meeting';
 import Meetings from '@webex/plugin-meetings';
 import Metrics from '@webex/plugin-meetings/src/metrics';
@@ -178,6 +178,7 @@ describe('plugin-meetings', () => {
 
     meeting.addMedia = sinon.stub().returns(Promise.resolve());
     meeting.getMediaStreams = sinon.stub().returns(Promise.resolve());
+    sinon.stub(meeting, 'effects').value(effects);
     sinon.replace(meeting, 'addMedia', () => {
       sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack());
       sinon.stub(meeting.mediaProperties, 'mediaDirection').value({