@webex/plugin-meetings 2.18.0 → 2.19.2

package/src/constants.ts

@@ -207,103 +207,6 @@ export const DIALER_REGEX = {
 // eslint-disable-next-line max-len
 export const IPV4_REGEX = /^(?:[0-9]{1,3}\.){3}[0-9]{1,3}|.local/g;
 
-export const DEFAULT_TRANSFORM_REGEX = {
-  rtpOutVideo: {
-    regex: new RegExp('^(?:RTC)?[Oo]utbound_?[Rr][Tt][Pp]_?[Vv]ideo')
-  },
-  rtpOutAudio: {
-    regex: new RegExp('^(?:RTC)?[Oo]utbound_?[Rr][Tt][Pp]_?[Aa]udio')
-  },
-  rtpInVideo: {
-    regex: new RegExp('^(?:RTC)?[Ii]nbound_?[Rr][Tt][Pp]_?[Vv]ideo')
-  },
-  rtpInAudio: {
-    regex: new RegExp('^(?:RTC)?[Ii]nbound_?[Rr][Tt][Pp]_?[Aa]udio')
-  },
-  rtpRemoteInboundAudio: {
-    regex: new RegExp('^(?:RTC)?[Rr]emote[Ii]nbound_?[Rr][Tt][Pp]_?[Aa]udio[sS]tream_?.*')
-  },
-  rtpRemoteOutboundAudio: {
-    regex: new RegExp('^(?:RTC)?[Rr]emote[Oo]utbound_?[Rr][Tt][Pp]_?[Aa]udio[sS]tream_?.*')
-  },
-  rtpRemoteInboundVideo: {
-    regex: new RegExp('^(?:RTC)?[Rr]emote[Ii]nbound_?[Rr][Tt][Pp]_?[Vv]ideo[sS]tream_?.*')
-  },
-  rtpRemoteOutboundVideo: {
-    regex: new RegExp('^(?:RTC)?[Rr]emote[Oo]utbound_?[Rr][Tt][Pp]_?[Vv]ideo[sS]tream_?.*')
-  },
-  rtcOutAudio: {
-    regex: new RegExp('^RTCMediaStreamTrack_(?:local|sender)_'),
-    profiler: {
-      type: 'kind',
-      value: 'audio'
-    }
-  },
-  rtcOutVideo: {
-    regex: new RegExp('^RTCMediaStreamTrack_(?:local|sender)_'),
-    profiler: {
-      type: 'kind',
-      value: 'video'
-    }
-  },
-  rtcInAudio: {
-    regex: new RegExp('^RTCMediaStreamTrack_(?:remote|receiver)_'),
-    profiler: {
-      type: 'kind',
-      value: 'audio'
-    }
-  },
-  rtcInVideo: {
-    regex: new RegExp('^RTCMediaStreamTrack_(?:remote|receiver)_'),
-    profiler: {
-      type: 'kind',
-      value: 'video'
-    }
-  },
-  rtcTransAudio: {
-    regex: new RegExp('^RTCTransport_[Aa]udio')
-  },
-  rtcTransVideo: {
-    regex: new RegExp('^RTCTransport_[Vv]ideo')
-  },
-  rtcCandidatePair: {
-    regex: new RegExp('^RTCIceCandidatePair_'),
-    decider: 'nominated',
-    selector: true,
-    profiler: {
-      type: 'type',
-      value: 'candidate-pair'
-    }
-  }
-};
-
-// we need a specific firefox transform regular expression map
-// to convert firefox values to a consistent getStats type mapping
-// as with chrome/edge/safari
-export const DEFAULT_FF_TRANSFORM_REGEX = {
-  rtpOutVideo: {
-    regex: new RegExp('^outbound-rtp_video_.*')
-  },
-  rtpOutAudio: {
-    regex: new RegExp('^outbound-rtp_audio_.*')
-  },
-  rtpInVideo: {
-    regex: new RegExp('^inbound-rtp_video_.*')
-  },
-  rtpInAudio: {
-    regex: new RegExp('^inbound-rtp_audio_.*')
-  },
-  rtcCandidatePair: {
-    regex: new RegExp('^candidate-pair.*'),
-    decider: 'nominated',
-    selector: true,
-    profiler: {
-      type: 'type',
-      value: 'candidate-pair'
-    }
-  }
-};
-
 export const VALID_EMAIL_ADDRESS = /^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
 export const VALID_PMR_ADDRESS = /([a-z0-9][-a-z0-9, '.']{0,62})@([a-z0-9][-a-z0-9, '.']{0,62})\.webex\.com/i;
 export const VALID_PMR_LINK = /(https:\/\/)?([a-z0-9][-a-z0-9, '.']{0,62})\.webex\.com\/(meet|join)\/([a-z0-9][-a-z0-9, '.']{0,62})\/?/i;
@@ -320,16 +223,6 @@ export const API = {
   LOCUS: 'locus'
 };
 
-export const ANALYSIS_CHECKS = {
-  INCREASING: 'increasing',
-  DECREASING: 'decreasing',
-  CONSTANT: 'constant'
-};
-
-export const ANALYSIS_STATS = {
-  DEFAULT_KEYS: [{key: 'bytesSent', check: 'increasing', prop: 'rtpOutAudio'}, {key: 'bytesReceived', check: 'increasing', prop: 'rtpInAudio'}]
-};
-
 export const CALENDAR_EVENTS = {
   CREATE: 'event:calendar.meeting.create',
   UPDATE: 'event:calendar.meeting.update',
@@ -341,46 +234,7 @@ export const CALENDAR_EVENTS = {
 export const DEFAULT_GET_STATS_FILTER = {
   types: ['track', 'transport', 'candidate-pair', 'outbound-rtp', 'outboundrtp', 'inbound-rtp', 'inboundrtp', 'remote-inbound-rtp', 'remote-outbound-rtp', 'remote-candidate', 'local-candidate', 'media-source']
 };
-export const DEFAULT_EVENT_VIDEO_SEND_KEYS = ['rtpOutVideo', 'rtcOutVideo', 'rtcTransVideo'];
-export const DEFAULT_EVENT_AUDIO_SEND_KEYS = ['rtpOutAudio', 'rtcOutAudio', 'rtcTransAudio'];
-export const DEFAULT_EVENT_VIDEO_RECEIVE_KEYS = ['rtpInVideo', 'rtcInVideo', 'rtcTransVideo'];
-export const DEFAULT_EVENT_AUDIO_RECEIVE_KEYS = ['rtpInAudio', 'rtcInAudio', 'rtcTransAudio'];
-export const DEFAULT_TRANSFORM_KEYS = [
-  'rtpOutVideo',
-  'rtpOutAudio',
-  'rtpInVideo',
-  'rtpInAudio',
-  'rtcOutAudio',
-  'rtcOutVideo',
-  'rtcInAudio',
-  'rtcInVideo',
-  'rtcTransAudio',
-  'rtcTransVideo',
-  'rtcCandidatePairAudio',
-  'rtcCandidatePairVideo'
-];
-// remove unneccessary data that stays constant during a call
-export const DEFAULT_OMISSION_DATA_KEYS = [
-  'id',
-  'timestamp',
-  'type',
-  'ssrc',
-  'isRemote',
-  'mediaType',
-  'kind',
-  'trackId',
-  'transportId',
-  'codecId',
-  'mediaSourceId',
-  'trackIdentifier'
-];
-
-export const DELTAEVENT = {
-  GT: 'GT',
-  CF: 'CF',
-  EQ: 'EQ',
-  LT: 'LT'
-};
+
 
 export const RECORDING_STATE = {
   RECORDING: 'recording',
@@ -444,7 +298,6 @@ export const EVENT_TRIGGERS = {
   MEETING_LOG_UPLOAD_FAILURE: 'meeting:logUpload:failure',
   MEETING_ACTIONS_UPDATE: 'meeting:actionsUpdate',
   MEETING_STATE_CHANGE: 'meeting:stateChange',
-  MEETING_HIGH_PACKETLOSS: 'meeting:highPacketLoss',
   MEETING_MEETING_CONTAINER_UPDATE: 'meeting:meetingContainer:update',
   MEDIA_QUALITY: 'media:quality',
   MEETINGS_NETWORK_DISCONNECTED: 'network:disconnected',
@@ -519,10 +372,6 @@ export const MEDIA_STATE = {
   inactive: 'inactive'
 };
 
-export const EVENT_STATS_MAP = {
-  BYTES_SENT: 'bytesSent',
-  BYTES_RECEIVED: 'bytesReceived'
-};
 export const ERROR_DICTIONARY = {
   PARAMETER: {
     NAME: 'ParameterError',
@@ -1007,78 +856,16 @@ export const STATS = {
   AUDIO_CORRELATE: 'audio',
   VIDEO_CORRELATE: 'video',
   SHARE_CORRELATE: 'share',
-  AUDIO_SENDER_ID: 'audioSender',
-  AUDIO_RECEIVER_ID: 'audioReceiver',
-  VIDEO_SENDER_ID: 'videoSender',
-  VIDEO_RECEIVER_ID: 'videoReceiver',
-  SHARE_SENDER_ID: 'shareSender',
-  SHARE_RECEIVER_ID: 'shareReceiver',
   SEND_DIRECTION: 'send',
   RECEIVE_DIRECTION: 'recv',
-  END: 'end',
   REMOTE: 'remote',
   LOCAL: 'local',
-  DATA: 'data',
-  CLOSED: 'closed',
-  SENDER: 'sender',
-  RECEIVER: 'receiver',
-  SENDERS: 'senders',
-  RECEIVERS: 'receivers',
-  CONFIG: {
-    senders: {
-      audio: {
-        transceiver: 'audioTransceiver',
-        child: 'sender',
-        parent: 'mediaProperties',
-        peerConnection: 'peerConnection',
-        name: 'audioSender'
-      },
-      video: {
-        transceiver: 'videoTransceiver',
-        child: 'sender',
-        parent: 'mediaProperties',
-        peerConnection: 'peerConnection',
-        name: 'videoSender'
-      },
-      share: {
-        transceiver: 'shareTransceiver',
-        child: 'sender',
-        parent: 'mediaProperties',
-        peerConnection: 'peerConnection',
-        name: 'shareSender'
-      }
-    },
-    receivers: {
-      audio: {
-        transceiver: 'audioTransceiver',
-        child: 'receiver',
-        parent: 'mediaProperties',
-        peerConnection: 'peerConnection',
-        name: 'audioReceiver'
-      },
-      video: {
-        transceiver: 'videoTransceiver',
-        child: 'receiver',
-        parent: 'mediaProperties',
-        peerConnection: 'peerConnection',
-        name: 'videoReceiver'
-      },
-      share: {
-        transceiver: 'shareTransceiver',
-        child: 'receiver',
-        parent: 'mediaProperties',
-        peerConnection: 'peerConnection',
-        name: 'shareReceiver'
-      }
-    }
-  }
 };
 
 export const MQA_STATS = {
   MQA_SIZE: 120, // MQA is done on 60 second intervals by server def, add a buffer for missed events
   CA_TYPE: 'MQA',
   DEFAULT_IP: '0.0.0.0',
-  DATA_PLACEMENTS: [STATS.AUDIO_SENDER_ID, STATS.AUDIO_RECEIVER_ID, STATS.VIDEO_SENDER_ID, STATS.VIDEO_RECEIVER_ID, STATS.SHARE_SENDER_ID, STATS.SHARE_RECEIVER_ID],
   DEFAULT_SHARE_SENDER_STATS: {
     common: {
       common: {

package/src/meeting/effectsState.js

@@ -109,8 +109,7 @@ class EffectsState {
       await meeting.updateAudio({
         sendAudio: true,
         receiveAudio: meeting.mediaProperties.mediaDirection.receiveAudio,
-        stream: audioStream,
-        bnrEnabled: bnr.enabled
+        stream: audioStream
       });
 
       LoggerProxy.logger.info('Meeting:effectState#enableBNR. Updated meeting audio with bnr enabled track');

package/src/meeting/index.js

@@ -7,7 +7,7 @@ import {
   MeetingNotActiveError, createMeetingsError, UserInLobbyError,
   NoMediaEstablishedYetError, UserNotJoinedError, InvalidSdpError
 } from '../common/errors/webex-errors';
-import StatsAnalyzer from '../statsAnalyzer';
+import {StatsAnalyzer, EVENTS as StatsAnalyzerEvents} from '../statsAnalyzer';
 import NetworkQualityMonitor from '../networkQualityMonitor';
 import LoggerProxy from '../common/logs/logger-proxy';
 import Trigger from '../common/events/trigger-proxy';
@@ -26,9 +26,6 @@ import MeetingRequest from '../meeting/request';
 import Members from '../members/index';
 import MeetingUtil from '../meeting/util';
 import MediaUtil from '../media/util';
-import WebRTCStats from '../stats/index';
-import StatsMetrics from '../stats/metrics';
-import StatsUtil from '../stats/util';
 import Transcription from '../transcription';
 import PasswordError from '../common/errors/password-error';
 import CaptchaError from '../common/errors/captcha-error';
@@ -70,7 +67,6 @@ import {
   SENDRECV,
   SHARE_STATUS,
   SHARE_STOPPED_REASON,
-  STATS,
   VIDEO_RESOLUTIONS,
   VIDEO,
   BNR_STATUS,
@@ -80,7 +76,6 @@ import BEHAVIORAL_METRICS from '../metrics/constants';
 import ParameterError from '../common/errors/parameter';
 import MediaError from '../common/errors/media';
 import {MeetingInfoV2PasswordError, MeetingInfoV2CaptchaError} from '../meeting-info/meeting-info-v2';
-import MQAProcessor from '../metrics/mqa-processor';
 import BrowserDetection from '../common/browser-detection';
 import RoapCollection from '../roap/collection';
 
@@ -548,21 +543,6 @@ export default class Meeting extends StatelessWebexPlugin {
      * @memberof Meeting
      */
     this.meetingFiniteStateMachine = MeetingStateMachine.create(this);
-    /**
-     * @instance
-     * @type {WebRTCStats}
-     * @public
-     * @memberof Meeting
-     */
-    this.stats = null;
-    /**
-     * @instance
-     * @type {WebRTCStats}
-     * @readonly
-     * @private
-     * @memberof Meeting
-     */
-    this.internalStats = null;
     /**
      * @instance
      * @type {String}
@@ -789,14 +769,6 @@ export default class Meeting extends StatelessWebexPlugin {
      * @memberof Meeting
      */
     this.dialOutUrl = '';
-    /**
-     * @instance
-     * @type {MediaMetrics}
-     * @readonly
-     * @private
-     * @memberof Meeting
-     */
-    this.mediaQualityMetrics = null;
     /**
      * @instance
      * @type {StatsAnalyzer}
@@ -811,14 +783,6 @@ export default class Meeting extends StatelessWebexPlugin {
      * @memberof Meeting
      */
     this.networkQualityMonitor = null;
-    /**
-     * @instance
-     * @type {MQAProcessor}
-     * @readonly
-     * @private
-     * @memberof Meeting
-     */
-    this.mqaProcessor = null;
     /**
      * @instance
      * @type {String}
@@ -2231,129 +2195,6 @@ export default class Meeting extends StatelessWebexPlugin {
     return this.members;
   }
 
-  /**
-   * If this gets turned off mid meeting after attaching media, it will shut down the MQA metrics and they will
-   * not restart unless the start function is called again
-   * @returns {undefined}
-   * @public
-   * @memberof Meeting
-   */
-  cleanMQAInterval() {
-    if (this.mqaInterval) {
-      clearInterval(this.mqaInterval);
-    }
-  }
-
-  /**
-   * Automatically publishes media metrics data and on a config interval
-   * uses the existing getStats data filter, so no new streams are created
-   * but it is separate than history, so history will not be available
-   * @returns {MediaMetrics}
-   * @public
-   * @memberof Meeting
-   */
-  startMediaQualityMetrics() {
-    const automaticMetrics = new StatsMetrics({config: this.config});
-
-    const stats = this.getStats(automaticMetrics.initialize(), true);
-
-    this.mediaQualityMetrics = automaticMetrics;
-
-    this.mediaQualityMetrics.setStats(stats);
-
-    this.mqaInterval = setInterval(() => this.processMQAData(), this.config.metrics.mqaMetricsInterval);
-
-    return automaticMetrics;
-  }
-
-  /**
-   * @private
-   * @returns {undefined}
-   * @memberof Meeting
-   */
-  processMQAData() {
-    if (!this.mqaProcessor) {
-      this.mqaProcessor = new MQAProcessor();
-    }
-
-    MQA_STATS.DATA_PLACEMENTS.forEach((key) => {
-      if (this.mediaQualityMetrics && this.mediaQualityMetrics.stats) {
-        let sendRecvData;
-
-        if (key.toLowerCase().endsWith(STATS.SENDER)) {
-          sendRecvData = this.mediaQualityMetrics.stats.getSender(key);
-        }
-        else if (key.toLowerCase().endsWith(STATS.RECEIVER)) {
-          sendRecvData = this.mediaQualityMetrics.stats.getReceiver(key);
-        }
-        let mqa;
-
-        if (sendRecvData) {
-          mqa = sendRecvData.getMQA();
-        }
-        if (mqa) {
-          const interval = mqa.getSlice(this.config.metrics.mqaMetricsInterval / 1000); // milliseconds -> second based intervals
-
-          this.mqaProcessor.process(key, interval);
-        }
-      }
-    });
-  }
-
-  /**
-   * Reference to the stats builder object
-   * @param {Object} options - see #createStats
-   * @param {Boolean} override - override the previous getStats
-   * @returns {WebRTCStats}
-   * @public
-   * @memberof Meeting
-   */
-  getStats(options, override) {
-    if (!this.stats) {
-      return this.createStats(options);
-    }
-    if (override) {
-      if (this.stats) {
-        LoggerProxy.logger.log('Meeting:index#getStats --> Overriding the previous stats object without destroying first can result in memory leaks.');
-      }
-
-      return this.createStats(options);
-    }
-
-    return this.stats;
-  }
-
-  /**
-   * write the stats builder object and assign to meeting property
-   * @param {Object} options
-   * @returns {WebRTCStats}
-   * @public
-   * @memberof Meeting
-   */
-  createStats(options = {}) {
-    StatsUtil.generateOptions(options, STATS.CONFIG, this);
-
-    options.config = STATS.CONFIG;
-
-    this.stats = new WebRTCStats(this.attrs, this.options, options);
-
-    return this.stats;
-  }
-
-  /**
-   * if you have started a stats instance, here's how you can stop it
-   * @returns {undefined}
-   * @public
-   * @memberof Meeting
-   */
-  stopStats() {
-    if (this.stats) {
-      this.stats.destroySenders();
-      this.stats.destroyReceivers();
-      this.stats = null;
-    }
-  }
-
   /**
    * Truthy when a meeting has an audio connection established
    * @returns {Boolean}  true if meeting audio is connected otherwise false
@@ -4160,6 +4001,75 @@ export default class Meeting extends StatelessWebexPlugin {
    */
   getDevices = () => Media.getDevices();
 
+  /**
+   * Registers for all required StatsAnalyzer events
+   * @private
+   * @returns {void}
+   * @memberof Meetings
+   */
+  setupStatsAnalyzerEventHandlers = () => {
+    this.statsAnalyzer.on(StatsAnalyzerEvents.MEDIA_QUALITY, (options) => {
+      // TODO:  might have to send the same event to the developer
+      // Add ip address info if geo hint is present
+      options.data.intervalMetadata.peerReflexiveIP = this.webex.meetings.geoHintInfo?.clientAddress || options.data.intervalMetadata.peerReflexiveIP || MQA_STATS.DEFAULT_IP;
+      Metrics.postEvent({event: eventType.MEDIA_QUALITY, meeting: this, data: {intervalData: options.data, networkType: options.networkType}});
+    });
+    this.statsAnalyzer.on(StatsAnalyzerEvents.LOCAL_MEDIA_STARTED, (data) => {
+      Trigger.trigger(
+        this,
+        {
+          file: 'meeting/index',
+          function: 'addMedia'
+        },
+        EVENT_TRIGGERS.MEETING_MEDIA_LOCAL_STARTED,
+        data
+      );
+      Metrics.postEvent({
+        event: eventType.SENDING_MEDIA_START,
+        meeting: this,
+        data: {
+          mediaType: data.type
+        }
+      });
+    });
+    this.statsAnalyzer.on(StatsAnalyzerEvents.LOCAL_MEDIA_STOPPED, (data) => {
+      Metrics.postEvent({
+        event: eventType.SENDING_MEDIA_STOP,
+        meeting: this,
+        data: {
+          mediaType: data.type
+        }
+      });
+    });
+    this.statsAnalyzer.on(StatsAnalyzerEvents.REMOTE_MEDIA_STARTED, (data) => {
+      Trigger.trigger(
+        this,
+        {
+          file: 'meeting/index',
+          function: 'addMedia'
+        },
+        EVENT_TRIGGERS.MEETING_MEDIA_REMOTE_STARTED,
+        data
+      );
+      Metrics.postEvent({
+        event: eventType.RECEIVING_MEDIA_START,
+        meeting: this,
+        data: {
+          mediaType: data.type
+        }
+      });
+    });
+    this.statsAnalyzer.on(StatsAnalyzerEvents.REMOTE_MEDIA_STOPPED, (data) => {
+      Metrics.postEvent({
+        event: eventType.RECEIVING_MEDIA_STOP,
+        meeting: this,
+        data: {
+          mediaType: data.type
+        }
+      });
+    });
+  };
+
   /**
    * Specify joining via audio (option: pstn), video, screenshare
    * @param {Object} options A configurable options object for joining a meeting
@@ -4238,22 +4148,11 @@ export default class Meeting extends StatelessWebexPlugin {
           LoggerProxy.logger.info(`${LOG_HEADER} PeerConnection Received from attachMedia `);
 
           this.setRemoteStream(peerConnection);
-          MeetingUtil.startInternalStats(this);
-
-          if (this.config.metrics.autoSendMQA) {
-            this.startMediaQualityMetrics();
-          }
-
           if (this.config.stats.enableStatsAnalyzer) {
             // TODO: ** Dont re create StatsAnalyzer on reconnect or rejoin
             this.networkQualityMonitor = new NetworkQualityMonitor(this.config.stats);
             this.statsAnalyzer = new StatsAnalyzer(this.config.stats, this.networkQualityMonitor);
-            this.statsAnalyzer.on(EVENT_TRIGGERS.MEDIA_QUALITY, (options) => {
-              // TODO:  might have to send the same event to the developer
-              // Add ip address info if geo hint is present
-              options.data.intervalMetadata.peerReflexiveIP = this.webex.meetings.geoHintInfo?.clientAddress || options.data.intervalMetadata.peerReflexiveIP || MQA_STATS.DEFAULT_IP;
-              Metrics.postEvent({event: eventType.MEDIA_QUALITY, meeting: this, data: {intervalData: options.data, networkType: options.networkType}});
-            });
+            this.setupStatsAnalyzerEventHandlers();
             this.networkQualityMonitor.on(EVENT_TRIGGERS.NETWORK_QUALITY, this.sendNetworkQualityEvent.bind(this));
           }
         })
@@ -4356,47 +4255,50 @@ export default class Meeting extends StatelessWebexPlugin {
         }))
       .catch((error) => {
         // Clean up stats analyzer, peer connection, and turn off listeners
-        if (this.statsAnalyzer) {
-          this.statsAnalyzer.stopAnalyzer();
-          this.statsAnalyzer = null;
-        }
-        if (this.mediaProperties.peerConnection) {
-          this.closePeerConnections();
-          this.unsetPeerConnections();
-        }
+        const stopStatsAnalyzer = (this.statsAnalyzer) ? this.statsAnalyzer.stopAnalyzer() : Promise.resolve();
 
-        LoggerProxy.logger.error(`${LOG_HEADER} Error adding media failed to initiate PC and send request, `, error);
+        stopStatsAnalyzer
+          .then(() => {
+            this.statsAnalyzer = null;
 
-        Metrics.sendBehavioralMetric(
-          BEHAVIORAL_METRICS.ADD_MEDIA_FAILURE,
-          {
-            correlation_id: this.correlationId,
-            locus_id: this.locusUrl.split('/').pop(),
-            reason: error.message,
-            stack: error.stack,
-            code: error.code
-          }
-        );
+            if (this.mediaProperties.peerConnection) {
+              this.closePeerConnections();
+              this.unsetPeerConnections();
+            }
 
-        // Upload logs on error while adding media
-        Trigger.trigger(
-          this,
-          {
-            file: 'meeting/index',
-            function: 'addMedia'
-          },
-          EVENTS.REQUEST_UPLOAD_LOGS,
-          this
-        );
+            LoggerProxy.logger.error(`${LOG_HEADER} Error adding media failed to initiate PC and send request, `, error);
 
-        // If addMedia failes for not establishing connection then
-        // leave the meeting with reson connection failed as meeting anyways will end
-        // and cannot be connected unless network condition is checked for firewall
-        if (error.code === InvalidSdpError.CODE) {
-          this.leave({reason: MEETING_REMOVED_REASON.MEETING_CONNECTION_FAILED});
-        }
+            Metrics.sendBehavioralMetric(
+              BEHAVIORAL_METRICS.ADD_MEDIA_FAILURE,
+              {
+                correlation_id: this.correlationId,
+                locus_id: this.locusUrl.split('/').pop(),
+                reason: error.message,
+                stack: error.stack,
+                code: error.code
+              }
+            );
 
-        throw error;
+            // Upload logs on error while adding media
+            Trigger.trigger(
+              this,
+              {
+                file: 'meeting/index',
+                function: 'addMedia'
+              },
+              EVENTS.REQUEST_UPLOAD_LOGS,
+              this
+            );
+
+            // If addMedia failes for not establishing connection then
+            // leave the meeting with reson connection failed as meeting anyways will end
+            // and cannot be connected unless network condition is checked for firewall
+            if (error.code === InvalidSdpError.CODE) {
+              this.leave({reason: MEETING_REMOVED_REASON.MEETING_CONNECTION_FAILED});
+            }
+
+            throw error;
+          });
       });
   }
 
@@ -4575,8 +4477,9 @@ export default class Meeting extends StatelessWebexPlugin {
       return this.enqueueMediaUpdate(MEDIA_UPDATE_TYPE.AUDIO, options);
     }
     const {
-      sendAudio, receiveAudio, stream, bnrEnabled
+      sendAudio, receiveAudio, stream
     } = options;
+
     const {audioTransceiver} = this.mediaProperties.peerConnection;
     let track = MeetingUtil.getTrack(stream).audioTrack;
 
@@ -4584,10 +4487,14 @@ export default class Meeting extends StatelessWebexPlugin {
       return Promise.reject(new ParameterError('Pass sendAudio and receiveAudio parameter'));
     }
 
-    if (sendAudio && !this.isAudioMuted() && (bnrEnabled === BNR_STATUS.ENABLED || bnrEnabled === BNR_STATUS.SHOULD_ENABLE)) {
-      LoggerProxy.logger.info('Meeting:index#updateAudio. Calling WebRTC enable bnr method');
-      track = await this.internal_enableBNR(track);
-      LoggerProxy.logger.info('Meeting:index#updateAudio. WebRTC enable bnr request completed');
+    if (this.effects && this.effects.state) {
+      const bnrEnabled = this.effects.state.bnr.enabled;
+
+      if (sendAudio && !this.isAudioMuted() && (bnrEnabled === BNR_STATUS.ENABLED || bnrEnabled === BNR_STATUS.SHOULD_ENABLE)) {
+        LoggerProxy.logger.info('Meeting:index#updateAudio. Calling WebRTC enable bnr method');
+        track = await this.internal_enableBNR(track);
+        LoggerProxy.logger.info('Meeting:index#updateAudio. WebRTC enable bnr request completed');
+      }
     }
 
     return MeetingUtil.validateOptions({sendAudio, localStream: stream})