@webex/plugin-meetings 2.12.1 → 2.14.1

package/test/unit/spec/meeting/effectsState.js

@@ -0,0 +1,292 @@
+/* eslint-disable camelcase */
+import {assert} from '@webex/test-helper-chai';
+import sinon from 'sinon';
+import MockWebex from '@webex/test-helper-mock-webex';
+
+import BEHAVIORAL_METRICS from '@webex/plugin-meetings/src/metrics/constants';
+import {BNR_STATUS} from '@webex/plugin-meetings/src/constants';
+import Meeting from '@webex/plugin-meetings/src/meeting';
+import Meetings from '@webex/plugin-meetings';
+import Metrics from '@webex/plugin-meetings/src/metrics';
+import MediaUtil from '@webex/plugin-meetings/src/media/util';
+import MeetingUtil from '@webex/plugin-meetings/src/meeting/util';
+import createEffectsState from '@webex/plugin-meetings/src/meeting/effectsState';
+import LoggerProxy from '@webex/plugin-meetings/src/common/logs/logger-proxy';
+import LoggerConfig from '@webex/plugin-meetings/src/common/logs/logger-config';
+
+describe('plugin-meetings', () => {
+  const logger = {
+    info: () => {},
+    log: () => {},
+    error: () => {},
+    warn: () => {},
+    trace: () => {},
+    debug: () => {}
+  };
+
+  beforeEach(() => {
+    sinon.stub(Metrics, 'sendBehavioralMetric');
+  });
+  afterEach(() => {
+    sinon.restore();
+  });
+
+  Object.defineProperty(global.window.navigator, 'mediaDevices', {
+    writable: true,
+    value: {
+      getSupportedConstraints: sinon.stub().returns({
+        sampleRate: true
+      })
+    },
+  });
+  LoggerConfig.set({verboseEvents: true, enable: false});
+  LoggerProxy.set(logger);
+
+  let webex;
+  let meeting;
+  let uuid1;
+
+  const fakeMediaTrack = () => ({
+    id: Date.now().toString(),
+    stop: () => {},
+    readyState: 'live',
+    enabled: true,
+    getSettings: () => ({
+      sampleRate: 48000
+    })
+  });
+
+  class FakeMediaStream {
+    constructor(tracks) {
+      this.active = false;
+      this.id = '5146425f-c240-48cc-b86b-27d422988fb7';
+      this.tracks = tracks;
+    }
+
+    addTrack = () => undefined;
+
+    getAudioTracks = () => this.tracks;
+  }
+
+  class FakeAudioContext {
+    constructor() {
+      this.state = 'running';
+      this.baseLatency = 0.005333333333333333;
+      this.currentTime = 2.7946666666666666;
+      this.sampleRate = 48000;
+      this.audioWorklet = {
+        addModule: async () => undefined,
+      };
+    }
+
+    onstatechange = null;
+
+    createMediaStreamSource() {
+      return {
+        connect: () => undefined,
+        mediaStream: {
+          getAudioTracks() {
+          // eslint-disable-next-line no-undef
+            return [new MediaStreamTrack()];
+          },
+        },
+      };
+    }
+
+    createMediaStreamDestination() {
+      return {
+        stream: {
+          getAudioTracks() {
+          // eslint-disable-next-line no-undef
+            return [new MediaStreamTrack()];
+          },
+        },
+      };
+    }
+  }
+
+  class FakeAudioWorkletNode {
+    constructor() {
+      this.port = {
+        postMessage: () => undefined,
+      };
+    }
+
+    connect() {
+    /* placeholder method */
+    }
+  }
+
+  class FakeMediaStreamTrack {
+    constructor() {
+      this.kind = 'audio';
+      this.enabled = true;
+      this.label = 'Default - MacBook Pro Microphone (Built-in)';
+      this.muted = false;
+      this.readyState = 'live';
+      this.contentHint = '';
+    }
+
+    getSettings() {
+      return {
+        sampleRate: 48000
+      };
+    }
+  }
+  Object.defineProperty(global, 'MediaStream', {
+    writable: true,
+    value: FakeMediaStream,
+  });
+
+  Object.defineProperty(global, 'AudioContext', {
+    writable: true,
+    value: FakeAudioContext,
+  });
+
+  Object.defineProperty(global, 'AudioWorkletNode', {
+    writable: true,
+    value: FakeAudioWorkletNode,
+  });
+
+  Object.defineProperty(global, 'MediaStreamTrack', {
+    writable: true,
+    value: FakeMediaStreamTrack,
+  });
+
+  let effects;
+
+  beforeEach(() => {
+    webex = new MockWebex({
+      children: {
+        meetings: Meetings
+      }
+    });
+    MediaUtil.createPeerConnection = sinon.stub().returns({});
+    meeting = new Meeting(
+      {
+        userId: uuid1
+      },
+      {
+        parent: webex
+      }
+    );
+
+    effects = createEffectsState('BNR');
+    meeting.canUpdateMedia = sinon.stub().returns(true);
+    MeetingUtil.validateOptions = sinon.stub().returns(Promise.resolve());
+    MeetingUtil.updateTransceiver = sinon.stub();
+
+    meeting.addMedia = sinon.stub().returns(Promise.resolve());
+    meeting.getMediaStreams = sinon.stub().returns(Promise.resolve());
+    sinon.replace(meeting, 'addMedia', () => {
+      sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack());
+      sinon.stub(meeting.mediaProperties, 'mediaDirection').value({
+        receiveAudio: true
+      });
+    });
+  });
+
+  describe('bnr effect library', () => {
+    beforeEach(async () => {
+      await meeting.getMediaStreams();
+      await meeting.addMedia();
+    });
+    describe('#enableBNR', () => {
+      it('should have #enableBnr', () => {
+        assert.exists(effects.enableBNR);
+      });
+
+      it('does bnr effect enable on audio track', async () => {
+        assert.isTrue(await effects.handleClientRequest(true, meeting));
+        assert.equal(effects.state.bnr.enabled, BNR_STATUS.ENABLED);
+
+        assert(Metrics.sendBehavioralMetric.calledOnce);
+        assert.calledWith(
+          Metrics.sendBehavioralMetric,
+          BEHAVIORAL_METRICS.ENABLE_BNR_SUCCESS,
+        );
+      });
+
+      it('does resolve request if bnr is already enabled', async () => {
+        effects.state.bnr.enabled = BNR_STATUS.ENABLED;
+        assert.isTrue(await effects.handleClientRequest(true, meeting));
+        assert.equal(effects.state.bnr.enabled, BNR_STATUS.ENABLED);
+      });
+
+      it('if called twice, does bnr effect enable on audio track for the first request and resolves second', async () => {
+        Promise.all([effects.handleClientRequest(true, meeting), effects.handleClientRequest(true, meeting)])
+          .then((resolveFirst, resolveSecond) => {
+            assert.isTrue(resolveFirst);
+            assert.isTrue(resolveSecond);
+            assert.calledOnce(MediaUtil.createMediaStream);
+          });
+      });
+
+      it('should throw error for inappropriate sample rate and send error metrics', async () => {
+        const fakeMediaTrack1 = () => ({
+          id: Date.now().toString(),
+          stop: () => {},
+          readyState: 'live',
+          getSettings: () => ({
+            sampleRate: 49000
+          })
+        });
+
+        sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack1());
+
+        // eslint-disable-next-line no-undef
+        MediaUtil.createMediaStream = sinon.stub().returns(new MediaStream([fakeMediaTrack1()]));
+        try {
+          await effects.handleClientRequest(true, meeting);
+        }
+        catch (err) {
+          assert(Metrics.sendBehavioralMetric.calledOnce);
+          assert.calledWith(
+            Metrics.sendBehavioralMetric,
+            BEHAVIORAL_METRICS.ENABLE_BNR_FAILURE, {
+              reason: err.message,
+              stack: err.stack
+            }
+          );
+          assert.equal(err.message, 'Sample rate of 49000 is not supported.');
+        }
+      });
+    });
+
+    describe('#disableBNR', () => {
+      beforeEach(() => {
+        effects.state.bnr.enabled = BNR_STATUS.ENABLED;
+      });
+      it('should have #disableBnr', () => {
+        assert.exists(effects.disableBNR);
+      });
+
+      it('does bnr disable on audio track', async () => {
+        assert.isTrue(await effects.handleClientRequest(false, meeting));
+        assert.equal(effects.state.bnr.enabled, BNR_STATUS.NOT_ENABLED);
+
+        assert(Metrics.sendBehavioralMetric.calledOnce);
+        assert.calledWith(
+          Metrics.sendBehavioralMetric,
+          BEHAVIORAL_METRICS.DISABLE_BNR_SUCCESS,
+        );
+      });
+
+      it('reject request for disable bnr if not enabled', async () => {
+        try {
+          await effects.handleClientRequest(false, meeting);
+        }
+        catch (e) {
+          assert.equal(e.message, 'Can not disable as BNR is not enabled');
+          assert.equal(effects.state.bnr.enabled, BNR_STATUS.ENABLED);
+
+          assert(Metrics.sendBehavioralMetric.calledOnce);
+          assert.calledWith(
+            Metrics.sendBehavioralMetric,
+            BEHAVIORAL_METRICS.DISABLE_BNR_FAILURE,
+          );
+        }
+      });
+    });
+  });
+});

package/test/unit/spec/meeting/index.js

@@ -456,114 +456,25 @@ describe('plugin-meetings', () => {
         });
       });
       describe('BNR', () => {
-        class FakeMediaStream {
-          constructor() {
-            this.active = false;
-            this.id = '5146425f-c240-48cc-b86b-27d422988fb7';
-          }
-
-          addTrack = () => undefined;
-        }
-
-        class FakeAudioContext {
-          constructor() {
-            this.state = 'running';
-            this.baseLatency = 0.005333333333333333;
-            this.currentTime = 2.7946666666666666;
-            this.sampleRate = 48000;
-            this.audioWorklet = {
-              addModule: async () => undefined,
-            };
-          }
-
-          onstatechange = null;
-
-          createMediaStreamSource() {
-            return {
-              connect: () => undefined,
-              mediaStream: {
-                getAudioTracks() {
-                  // eslint-disable-next-line no-undef
-                  return [new MediaStreamTrack()];
-                },
-              },
-            };
-          }
-
-          createMediaStreamDestination() {
-            return {
-              stream: {
-                getAudioTracks() {
-                  // eslint-disable-next-line no-undef
-                  return [new MediaStreamTrack()];
-                },
-              },
-            };
-          }
-        }
-
-        class FakeAudioWorkletNode {
-          constructor() {
-            this.port = {
-              postMessage: () => undefined,
-            };
-          }
-
-          connect() {
-            /* placeholder method */
-          }
-        }
-
-        class FakeMediaStreamTrack {
-          constructor() {
-            this.kind = 'audio';
-            this.enabled = true;
-            this.label = 'Default - MacBook Pro Microphone (Built-in)';
-            this.muted = false;
-            this.readyState = 'live';
-            this.contentHint = '';
-          }
-        }
-        Object.defineProperty(global, 'MediaStream', {
-          writable: true,
-          value: FakeMediaStream,
-        });
-
-        Object.defineProperty(global, 'AudioContext', {
-          writable: true,
-          value: FakeAudioContext,
-        });
-
-        Object.defineProperty(global, 'AudioWorkletNode', {
-          writable: true,
-          value: FakeAudioWorkletNode,
-        });
-
-        Object.defineProperty(global, 'MediaStreamTrack', {
-          writable: true,
-          value: FakeMediaStreamTrack,
+        const fakeMediaTrack = () => ({
+          id: Date.now().toString(),
+          stop: () => {},
+          readyState: 'live',
+          enabled: true,
+          getSettings: () => ({
+            sampleRate: 48000
+          })
         });
 
-        beforeEach(async () => {
-          meeting.canUpdateMedia = sinon.stub().returns(true);
-          MeetingUtil.validateOptions = sinon.stub().returns(Promise.resolve());
-          MeetingUtil.updateTransceiver = sinon.stub();
-          const fakeMediaTrack = () => ({
-            stop: () => {},
-            readyState: 'live',
-            getSettings: () => ({
-              sampleRate: 48000
-            })
-          });
-
+        beforeEach(() => {
           meeting.getMediaStreams = sinon.stub().returns(Promise.resolve());
           sinon.replace(meeting, 'addMedia', () => {
             sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack());
+            sinon.stub(meeting.mediaProperties, 'mediaDirection').value({
+              receiveAudio: true
+            });
           });
-          await meeting.getMediaStreams();
-          await meeting.addMedia();
         });
-
         describe('#enableBNR', () => {
           it('should have #enableBnr', () => {
             assert.exists(meeting.enableBNR);
@@ -578,67 +489,68 @@ describe('plugin-meetings', () => {
           });
 
           describe('after audio attached to meeting', () => {
-            it('should return true for appropriate sample rate', async () => {
-              const response = await meeting.enableBNR();
+            let handleClientRequest;
 
-              assert.equal(response, true);
+            beforeEach(async () => {
+              await meeting.getMediaStreams();
+              await meeting.addMedia();
             });
 
-            it('should throw error for inappropriate sample rate and send error metrics', async () => {
-              const fakeMediaTrack = () => ({
-                stop: () => {},
-                readyState: 'live',
-                getSettings: () => ({
-                  sampleRate: 49000
-                })
-              });
+            it('should throw error if meeting audio is muted', async () => {
+              const handleClientRequest = (meeting, mute) => {
+                meeting.mediaProperties.audioTrack.enabled = !mute;
+
+                return Promise.resolve();
+              };
+              const isMuted = () => !meeting.mediaProperties.audioTrack.enabled;
 
-              sinon.stub(meeting.mediaProperties, 'audioTrack').value(fakeMediaTrack());
+              meeting.locusInfo.parsedLocus = {self: {state: 'JOINED'}};
+              meeting.mediaId = 'mediaId';
+              meeting.audio = {handleClientRequest, isMuted};
+              await meeting.muteAudio();
               await meeting.enableBNR().catch((err) => {
-                assert(Metrics.sendBehavioralMetric.calledOnce);
-                assert.calledWith(
-                  Metrics.sendBehavioralMetric,
-                  BEHAVIORAL_METRICS.ENABLE_BNR_FAILURE, {
-                    reason: err.message,
-                    stack: err.stack
-                  }
-                );
-                assert.equal(err.message, 'Sample rate of 49000 is not supported.');
+                assert.equal(err.message, 'Cannot enable BNR while meeting is muted');
               });
             });
 
-            it('should send metrics for enable bnr success', async () => {
+            it('should return true on enable bnr success', async () => {
+              handleClientRequest = sinon.stub().returns(Promise.resolve(true));
+              meeting.effects = {handleClientRequest};
               const response = await meeting.enableBNR();
 
-              assert(Metrics.sendBehavioralMetric.calledOnce);
-              assert.calledWith(
-                Metrics.sendBehavioralMetric,
-                BEHAVIORAL_METRICS.ENABLE_BNR_SUCCESS,
-              );
               assert.equal(response, true);
             });
           });
         });
 
         describe('#disableBNR', () => {
-          it('should have #disableBnr', () => {
-            assert.exists(meeting.disableBNR);
+          describe('before audio attached to meeting', () => {
+            it('should have #disableBnr', () => {
+              assert.exists(meeting.disableBNR);
+            });
+
+            it('should throw no audio error', async () => {
+              await meeting.disableBNR().catch((err) => {
+                assert.equal(err.toString(), 'Error: Meeting doesn\'t have an audioTrack attached');
+              });
+            });
           });
+          describe('after audio attached to meeting', () => {
+            beforeEach(async () => {
+              await meeting.getMediaStreams();
+              await meeting.addMedia();
+            });
 
-          it('should return true if bnr is disabled on bnr enabled track', async () => {
-            const response = await meeting.disableBNR();
+            let handleClientRequest;
+            let isBnrEnabled;
 
-            assert.equal(response, true);
-          });
+            it('should return true on disable bnr success', async () => {
+              handleClientRequest = sinon.stub().returns(Promise.resolve(true));
+              isBnrEnabled = sinon.stub().returns(Promise.resolve(true));
+              meeting.effects = {handleClientRequest, isBnrEnabled};
+              const response = await meeting.disableBNR();
 
-          it('should throw error if bnr is not enabled before disabling and send error metrics', async () => {
-            await meeting.disableBNR().catch((err) => {
-              assert(Metrics.sendBehavioralMetric.calledOnce);
-              assert.calledWith(
-                Metrics.sendBehavioralMetric,
-                BEHAVIORAL_METRICS.DISABLE_BNR_FAILURE,
-              );
-              assert.equal(err.message, 'Can not disable as BNR is not enabled');
+              assert.equal(response, true);
             });
           });
         });
@@ -1420,7 +1332,7 @@ describe('plugin-meetings', () => {
 
             sandbox.stub(meeting.mediaProperties, 'peerConnection').value({shareTransceiver: true});
             sandbox.stub(MeetingUtil, 'getTrack').returns({videoTrack: true});
-            sandbox.stub(MeetingUtil, 'validateOptions').resolves(true);
+            MeetingUtil.validateOptions = sinon.stub().returns(Promise.resolve(true));
             sandbox.stub(meeting, 'canUpdateMedia').returns(true);
             sandbox.stub(meeting, 'setLocalShareTrack');
 
@@ -1489,13 +1401,14 @@ describe('plugin-meetings', () => {
             const SENDRECV = 'sendrecv';
             const delay = 1e3;
 
+            MeetingUtil.validateOptions = sinon.stub().returns(Promise.resolve(true));
+            MeetingUtil.updateTransceiver = sinon.stub().returns(Promise.resolve(true));
             sandbox.stub(meeting, 'canUpdateMedia').returns(true);
             sandbox.stub(MeetingUtil, 'getTrack').returns({videoTrack: null});
             sandbox.stub(meeting, 'setLocalShareTrack');
             sandbox.stub(meeting, 'unsetLocalShareTrack');
-            sandbox.stub(MeetingUtil, 'validateOptions').resolves(true);
             sandbox.stub(meeting, 'checkForStopShare').returns(false);
-            sandbox.stub(MeetingUtil, 'updateTransceiver').resolves(true);
+
             sandbox.stub(meeting, 'isLocalShareLive').value(false);
             sandbox.stub(meeting, 'handleShareTrackEnded');
             sandbox.stub(meeting.mediaProperties, 'peerConnection').value({
@@ -2366,11 +2279,6 @@ describe('plugin-meetings', () => {
           assert.equal(meeting.requiredCaptcha, null);
           assert.calledTwice(TriggerProxy.trigger);
           assert.calledWith(TriggerProxy.trigger, meeting, {file: 'meetings', function: 'fetchMeetingInfo'}, 'meeting:meetingInfoAvailable');
-          assert(Metrics.sendBehavioralMetric.calledOnce);
-          assert.calledWith(
-            Metrics.sendBehavioralMetric,
-            BEHAVIORAL_METRICS.VERIFY_PASSWORD_SUCCESS,
-          );
         });
 
         it('calls meetingInfoProvider with all the right parameters and parses the result when random delay is applied', async () => {
@@ -2442,11 +2350,6 @@ describe('plugin-meetings', () => {
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, null, null);
 
-          assert(Metrics.sendBehavioralMetric.calledOnce);
-          assert.calledWith(
-            Metrics.sendBehavioralMetric,
-            BEHAVIORAL_METRICS.VERIFY_PASSWORD_ERROR,
-          );
           assert.deepEqual(meeting.meetingInfo, FAKE_MEETING_INFO);
           assert.equal(meeting.meetingInfoFailureReason, MEETING_INFO_FAILURE_REASON.WRONG_PASSWORD);
           assert.equal(meeting.requiredCaptcha, null);
@@ -2467,11 +2370,7 @@ describe('plugin-meetings', () => {
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, 'aaa', null);
 
-          assert(Metrics.sendBehavioralMetric.calledOnce);
-          assert.calledWith(
-            Metrics.sendBehavioralMetric,
-            BEHAVIORAL_METRICS.VERIFY_CAPTCHA_ERROR,
-          );
+
           assert.deepEqual(meeting.meetingInfo, {});
           assert.equal(meeting.meetingInfoFailureReason, MEETING_INFO_FAILURE_REASON.WRONG_PASSWORD);
           assert.equal(meeting.passwordStatus, PASSWORD_STATUS.REQUIRED);
@@ -2625,6 +2524,11 @@ describe('plugin-meetings', () => {
           meeting.fetchMeetingInfo = sinon.stub().resolves();
           const result = await meeting.verifyPassword('password', 'captcha id');
 
+          assert(Metrics.sendBehavioralMetric.calledOnce);
+          assert.calledWith(
+            Metrics.sendBehavioralMetric,
+            BEHAVIORAL_METRICS.VERIFY_PASSWORD_SUCCESS,
+          );
           assert.equal(result.isPasswordValid, true);
           assert.equal(result.requiredCaptcha, null);
           assert.equal(result.failureReason, MEETING_INFO_FAILURE_REASON.NONE);

package/test/unit/spec/meeting-info/meetinginfov2.js

@@ -177,16 +177,17 @@ describe('plugin-meetings', () => {
         meetingInfo.createAdhocSpaceMeeting.restore();
       });
 
+
       it('should throw an error MeetingInfoV2AdhocMeetingError if not able to start adhoc meeting for a conversation', async () => {
         webex.config.meetings.experimental.enableAdhocMeetings = true;
 
-        webex.request = sinon.stub().rejects({statusCode: 403, body: {code: 400000, message: 'Input is invalid'}});
+        webex.request = sinon.stub().rejects({statusCode: 403, body: {code: 400000}});
         try {
           await meetingInfo.createAdhocSpaceMeeting('conversationUrl');
         }
         catch (err) {
           assert.instanceOf(err, MeetingInfoV2AdhocMeetingError);
-          assert.deepEqual(err.message, 'Input is invalid, code=400000');
+          assert.deepEqual(err.message, 'Failed starting the adhoc meeting, Please contact support team , code=400000');
           assert.equal(err.wbxAppApiCode, 400000);
         }
       });
@@ -201,6 +202,11 @@ describe('plugin-meetings', () => {
           assert.fail('fetchMeetingInfo should have thrown, but has not done that');
         }
         catch (err) {
+          assert(Metrics.sendBehavioralMetric.calledOnce);
+          assert.calledWith(
+            Metrics.sendBehavioralMetric,
+            BEHAVIORAL_METRICS.VERIFY_PASSWORD_ERROR,
+          );
           assert.instanceOf(err, MeetingInfoV2PasswordError);
           assert.deepEqual(err.meetingInfo, FAKE_MEETING_INFO);
           assert.equal(err.wbxAppApiCode, 403000);
@@ -226,6 +232,11 @@ describe('plugin-meetings', () => {
             assert.fail('fetchMeetingInfo should have thrown, but has not done that');
           }
           catch (err) {
+            assert(Metrics.sendBehavioralMetric.calledOnce);
+            assert.calledWith(
+              Metrics.sendBehavioralMetric,
+              BEHAVIORAL_METRICS.VERIFY_CAPTCHA_ERROR,
+            );
             assert.instanceOf(err, MeetingInfoV2CaptchaError);
             assert.deepEqual(err.captchaInfo, {
               captchaId: 'fake_captcha_id',