@webex/plugin-meetings 1.159.1 → 1.159.2

package/test/unit/spec/meeting/index.js

@@ -36,7 +36,8 @@ import {
   PASSWORD_STATUS,
   EVENTS,
   EVENT_TRIGGERS,
-  _SIP_URI_
+  _SIP_URI_,
+  _MEETING_ID_,
 } from '@webex/plugin-meetings/src/constants';
 import BEHAVIORAL_METRICS from '@webex/plugin-meetings/src/metrics/constants';
 
@@ -126,6 +127,7 @@ describe('plugin-meetings', () => {
   let test2;
   let test3;
   let test4;
+  let testDestination;
 
   beforeEach(() => {
     webex = new MockWebex({
@@ -175,13 +177,16 @@ describe('plugin-meetings', () => {
     test2 = `test2-${uuid.v4()}`;
     test3 = `test3-${uuid.v4()}`;
     test4 = `test4-${uuid.v4()}`;
+    testDestination = `testDestination-${uuid.v4()}`;
 
     meeting = new Meeting(
       {
         userId: uuid1,
         resource: uuid2,
         deviceUrl: uuid3,
-        locus: {url: url1}
+        locus: {url: url1},
+        destination: testDestination,
+        destinationType: _MEETING_ID_,
       },
       {
         parent: webex
@@ -227,6 +232,8 @@ describe('plugin-meetings', () => {
           assert.equal(meeting.passwordStatus, PASSWORD_STATUS.UNKNOWN);
           assert.equal(meeting.requiredCaptcha, null);
           assert.equal(meeting.meetingInfoFailureReason, undefined);
+          assert.equal(meeting.destination, testDestination);
+          assert.equal(meeting.destinationType, _MEETING_ID_);
         });
       });
       describe('#invite', () => {
@@ -2141,8 +2148,11 @@ describe('plugin-meetings', () => {
         it('calls meetingInfoProvider with all the right parameters and parses the result', async () => {
           meeting.attrs.meetingInfoProvider = {fetchMeetingInfo: sinon.stub().resolves({body: FAKE_MEETING_INFO})};
           meeting.requiredCaptcha = FAKE_SDK_CAPTCHA_INFO;
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
+
           await meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, password: FAKE_PASSWORD, captchaCode: FAKE_CAPTCHA_CODE
+            password: FAKE_PASSWORD, captchaCode: FAKE_CAPTCHA_CODE
           });
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, FAKE_PASSWORD, {code: FAKE_CAPTCHA_CODE, id: FAKE_CAPTCHA_ID});
@@ -2156,9 +2166,11 @@ describe('plugin-meetings', () => {
         it('fails if captchaCode is provided when captcha not needed', async () => {
           meeting.attrs.meetingInfoProvider = {fetchMeetingInfo: sinon.stub().resolves({body: FAKE_MEETING_INFO})};
           meeting.requiredCaptcha = null;
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
 
           await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, captchaCode: FAKE_CAPTCHA_CODE
+            captchaCode: FAKE_CAPTCHA_CODE
           }), Error, 'fetchMeetingInfo() called with captchaCode when captcha was not required');
 
           assert.notCalled(meeting.attrs.meetingInfoProvider.fetchMeetingInfo);
@@ -2167,22 +2179,24 @@ describe('plugin-meetings', () => {
         it('fails if password is provided when not required', async () => {
           meeting.attrs.meetingInfoProvider = {fetchMeetingInfo: sinon.stub().resolves({body: FAKE_MEETING_INFO})};
           meeting.passwordStatus = PASSWORD_STATUS.NOT_REQUIRED;
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
 
           await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, password: FAKE_PASSWORD
+            password: FAKE_PASSWORD
           }), Error, 'fetchMeetingInfo() called with password when password was not required');
 
           assert.notCalled(meeting.attrs.meetingInfoProvider.fetchMeetingInfo);
         });
 
         it('handles meetingInfoProvider requiring password', async () => {
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
           meeting.attrs.meetingInfoProvider = {
             fetchMeetingInfo: sinon.stub().throws(new MeetingInfoV2PasswordError(403004, FAKE_MEETING_INFO))
           };
 
-          await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE
-          }), PasswordError);
+          await assert.isRejected(meeting.fetchMeetingInfo({}), PasswordError);
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, null, null);
 
@@ -2193,13 +2207,15 @@ describe('plugin-meetings', () => {
         });
 
         it('handles meetingInfoProvider requiring captcha because of wrong password', async () => {
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
           meeting.attrs.meetingInfoProvider = {
             fetchMeetingInfo: sinon.stub().throws(new MeetingInfoV2CaptchaError(423005, FAKE_SDK_CAPTCHA_INFO))
           };
           meeting.requiredCaptcha = null;
 
           await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, password: 'aaa'
+            password: 'aaa'
           }), CaptchaError);
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, 'aaa', null);
@@ -2216,13 +2232,15 @@ describe('plugin-meetings', () => {
         });
 
         it('handles meetingInfoProvider requiring captcha because of wrong captcha', async () => {
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
           meeting.attrs.meetingInfoProvider = {
             fetchMeetingInfo: sinon.stub().throws(new MeetingInfoV2CaptchaError(423005, FAKE_SDK_CAPTCHA_INFO))
           };
           meeting.requiredCaptcha = FAKE_SDK_CAPTCHA_INFO;
 
           await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, password: 'aaa', captchaCode: 'bbb'
+            password: 'aaa', captchaCode: 'bbb'
           }), CaptchaError);
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, 'aaa', {code: 'bbb', id: FAKE_CAPTCHA_ID});
@@ -2234,6 +2252,8 @@ describe('plugin-meetings', () => {
         });
 
         it('handles successful response when good password is passed', async () => {
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
           meeting.attrs.meetingInfoProvider = {
             fetchMeetingInfo: sinon.stub().resolves(
               {
@@ -2245,7 +2265,7 @@ describe('plugin-meetings', () => {
           meeting.passwordStatus = PASSWORD_STATUS.REQUIRED;
 
           await meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, password: 'aaa'
+            password: 'aaa'
           });
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, 'aaa', null);
@@ -2257,6 +2277,8 @@ describe('plugin-meetings', () => {
         });
 
         it('refreshes captcha when captcha was required and we received 403 error code', async () => {
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
           const refreshedCaptcha = {
             captchaID: FAKE_WBXAPPAPI_CAPTCHA_INFO.captchaID,
             verificationImageURL: FAKE_WBXAPPAPI_CAPTCHA_INFO.verificationImageURL,
@@ -2273,9 +2295,11 @@ describe('plugin-meetings', () => {
           ));
           meeting.passwordStatus = PASSWORD_STATUS.REQUIRED;
           meeting.requiredCaptcha = FAKE_SDK_CAPTCHA_INFO;
+          meeting.destination = FAKE_DESTINATION;
+          meeting.destinationType = FAKE_TYPE;
 
           await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: FAKE_DESTINATION, type: FAKE_TYPE, password: 'aaa', captchaCode: 'bbb'
+            password: 'aaa', captchaCode: 'bbb'
           }));
 
           assert.calledWith(meeting.attrs.meetingInfoProvider.fetchMeetingInfo, FAKE_DESTINATION, FAKE_TYPE, 'aaa', {code: 'bbb', id: FAKE_CAPTCHA_ID});
@@ -2319,7 +2343,7 @@ describe('plugin-meetings', () => {
           };
 
           await assert.isRejected(meeting.fetchMeetingInfo({
-            destination: 'something@somecompany.com', type: _SIP_URI_, password: ''
+            password: ''
           }), CaptchaError);
 
           assert.deepEqual(meeting.requiredCaptcha, FAKE_SDK_CAPTCHA_INFO);
@@ -2352,6 +2376,10 @@ describe('plugin-meetings', () => {
           assert.equal(result.isPasswordValid, true);
           assert.equal(result.requiredCaptcha, null);
           assert.equal(result.failureReason, MEETING_INFO_FAILURE_REASON.NONE);
+          assert.calledWith(meeting.fetchMeetingInfo, {
+            password: 'password',
+            captchaCode: 'captcha id',
+          });
         });
         it('handles PasswordError returned by fetchMeetingInfo', async () => {
           meeting.fetchMeetingInfo = sinon.stub().callsFake(() => {

package/test/unit/spec/meetings/index.js

@@ -675,7 +675,7 @@ describe('plugin-meetings', () => {
           webex.internal.device.userId = uuid1;
           webex.internal.device.url = url1;
           MeetingCollection.set = sinon.stub().returns(true);
-          MeetingsUtil.getMeetingAddedType = sinon.stub().returns('test');
+          MeetingsUtil.getMeetingAddedType = sinon.stub().returns('test meeting added type');
           TriggerProxy.trigger.reset();
         });
         describe('successful MeetingInfo.#fetchMeetingInfo', () => {
@@ -687,30 +687,32 @@ describe('plugin-meetings', () => {
             }));
           });
           it('creates the meeting from a successful meeting info fetch promise testing', async () => {
-            const meeting = await webex.meetings.createMeeting('test', 'test');
+            const meeting = await webex.meetings.createMeeting('test destination', 'test type');
 
             assert.calledOnce(webex.meetings.meetingInfo.fetchMeetingInfo);
             assert.calledOnce(MeetingsUtil.getMeetingAddedType);
             assert.calledTwice(TriggerProxy.trigger);
-            assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test');
-            assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test');
+            assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test destination', 'test type');
+            assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test type');
             assert.equal(meeting.permissionToken, 'PT');
             assert.equal(meeting.meetingJoinUrl, 'meetingJoinUrl');
+            assert.equal(meeting.destination, 'test destination');
+            assert.equal(meeting.destinationType, 'test type');
           });
 
           it('creates the meeting from a successful meeting info fetch meeting resolve testing', async () => {
-            const meeting = await webex.meetings.createMeeting('test', 'test');
+            const meeting = await webex.meetings.createMeeting('test destination', 'test type');
 
             assert.instanceOf(meeting, Meeting, 'createMeeting should eventually resolve to a Meeting Object');
             assert.calledOnce(webex.meetings.meetingInfo.fetchMeetingInfo);
             assert.calledOnce(MeetingsUtil.getMeetingAddedType);
             assert.calledTwice(TriggerProxy.trigger);
-            assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test');
-            assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test');
+            assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test destination', 'test type');
+            assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test type');
             assert.calledWith(TriggerProxy.trigger, sinon.match.instanceOf(Meetings), {
               file: 'meetings', function: 'createMeeting'
             }, 'meeting:added', {
-              meeting: sinon.match.instanceOf(Meeting), type: 'test'
+              meeting: sinon.match.instanceOf(Meeting), type: 'test meeting added type'
             });
           });
         });
@@ -721,18 +723,18 @@ describe('plugin-meetings', () => {
             webex.meetings.meetingInfo.fetchMeetingInfo = sinon.stub().returns(Promise.reject(new Error('test')));
           });
           it('creates the meeting from a rejected meeting info fetch', async () => {
-            const meeting = await webex.meetings.createMeeting('test', 'test');
+            const meeting = await webex.meetings.createMeeting('test destination', 'test type');
 
             assert.instanceOf(meeting, Meeting, 'createMeeting should eventually resolve to a Meeting Object');
             assert.calledOnce(webex.meetings.meetingInfo.fetchMeetingInfo);
             assert.calledOnce(MeetingsUtil.getMeetingAddedType);
             assert.calledTwice(TriggerProxy.trigger);
-            assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test');
-            assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test');
+            assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test destination', 'test type');
+            assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test type');
             assert.calledWith(TriggerProxy.trigger, sinon.match.instanceOf(Meetings), {
               file: 'meetings', function: 'createMeeting'
             }, 'meeting:added', {
-              meeting: sinon.match.instanceOf(Meeting), type: 'test'
+              meeting: sinon.match.instanceOf(Meeting), type: 'test meeting added type'
             });
           });
         });