@webex/plugin-meetings 1.157.0 → 1.157.1

package/README.md

@@ -30,8 +30,8 @@ This is a plugin for the Cisco Webex JS SDK . Please see our [developer portal](
 
 ## API Docs and Sample App
 API Docs: https://webex.github.io/webex-js-sdk/api/
-Hosted Sample App: https://js.samples.s4d.io/browser-plugin-meetings/
-See https://github.com/webex/webex-js-sdk/tree/master/packages/node_modules/samples/browser-plugin-meetings for the sample app code vs the readme
+Hosted Sample App: https://webex.github.io/webex-js-sdk/samples/browser-plugin-meetings/
+See https://github.com/webex/webex-js-sdk/tree/master/docs/samples/browser-plugin-meetings for the sample app code vs the readme
 
 #### Device Registration
 
@@ -1386,7 +1386,7 @@ There are several events submitted by this package that you can subscribe to.
 
 To use `webpack-dev-server` to load this package, run `npm run samples:serve`.
 
-Files placed in the `packages/node_modules/samples/browser-plugin-meetings` folder will be served statically.
+Files placed in the `docs/samples/browser-plugin-meetings` folder will be served statically.
 
 Files in the `src` folder will be compiled, bundled, and served as a static asset at `bundle.js` inside that directory.
 

package/browsers.js

@@ -7,7 +7,7 @@
 
 /* eslint camelcase: [0] */
 module.exports = function createBrowsers() {
-  if (process.env.SC_TUNNEL_IDENTIFIER || process.env.CI || process.env.CIRCLECI || process.env.SAUCE) {
+  if (process.env.SC_TUNNEL_IDENTIFIER || process.env.SAUCE) {
     return {
       sl_chrome_latest_macOS_Catalina: {
         base: 'SauceLabs',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@webex/plugin-meetings",
-  "version": "1.157.0",
+  "version": "1.157.1",
   "description": "",
   "license": "MIT",
   "contributors": [
@@ -24,18 +24,18 @@
   },
   "dependencies": {
     "@babel/runtime-corejs2": "^7.14.8",
-    "@webex/webex-core": "1.157.0",
-    "@webex/internal-plugin-mercury": "1.157.0",
+    "@webex/webex-core": "1.157.1",
+    "@webex/internal-plugin-mercury": "1.157.1",
     "webrtc-adapter": "^7.7.0",
     "lodash": "^4.17.21",
     "uuid": "^3.3.2",
     "global": "^4.4.0",
     "ip-anonymize": "^0.1.0",
-    "@webex/common": "1.157.0",
+    "@webex/common": "1.157.1",
     "bowser": "^2.11.0",
     "sdp-transform": "^2.12.0",
     "readable-stream": "^3.6.0",
-    "@webex/common-timers": "1.157.0",
+    "@webex/common-timers": "1.157.1",
     "btoa": "^1.2.1",
     "javascript-state-machine": "^3.1.0",
     "envify": "^4.1.0"

package/test/unit/spec/common/browser-detection.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import BrowserDetection from
   '@webex/plugin-meetings/src/common/browser-detection';

package/test/unit/spec/locus-info/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import {cloneDeep} from 'lodash';
 import {assert} from '@webex/test-helper-chai';
@@ -16,7 +17,6 @@ import {
 
 import {self, selfWithInactivity} from './selfConstant';
 
-
 describe('plugin-meetings', () => {
   describe('LocusInfo index', () => {
     const updateMeeting = () => {};

package/test/unit/spec/meeting/index.js

@@ -1,6 +1,7 @@
 /*!
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
+import 'jsdom-global/register';
 import {cloneDeep, isEqual} from 'lodash';
 import sinon from 'sinon';
 import StateMachine from 'javascript-state-machine';
@@ -37,7 +38,7 @@ import {
   EVENT_TRIGGERS,
   _SIP_URI_
 } from '@webex/plugin-meetings/src/constants';
-import {BEHAVIORAL_METRICS} from '@webex/plugin-meetings/src/metrics/constants';
+import BEHAVIORAL_METRICS from '@webex/plugin-meetings/src/metrics/constants';
 
 import {
   UserNotJoinedError,
@@ -72,6 +73,23 @@ describe('plugin-meetings', () => {
   };
 
   before(() => {
+    const MediaStream = {
+      getVideoTracks: () => [{
+        applyConstraints: () => { }
+      }]
+    };
+
+    Object.defineProperty(global.window.navigator, 'mediaDevices', {
+      writable: true,
+      value: {
+        getDisplayMedia: sinon.stub().returns(Promise.resolve(MediaStream))
+      }
+    });
+
+    Object.defineProperty(global.window, 'MediaStream', {
+      writable: true,
+      value: MediaStream
+    });
     LoggerConfig.set({verboseEvents: true, enable: false});
     LoggerProxy.set(logger);
   });
@@ -108,6 +126,9 @@ describe('plugin-meetings', () => {
           metrics: {},
           stats: {},
           experimental: {enableUnifiedMeetings: true}
+        },
+        metrics: {
+          type: ['behavioral']
         }
       }
     });

package/test/unit/spec/meetings/index.js

@@ -1,7 +1,7 @@
 /*!
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
-
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import MockWebex from '@webex/test-helper-mock-webex';

package/test/unit/spec/members/index.js

@@ -2,6 +2,7 @@
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
 
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import uuid from 'uuid';
 import chai from 'chai';

package/test/unit/spec/metrics/index.js

@@ -1,21 +1,15 @@
 /*!
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
-/* globals window */
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import Metrics from '@webex/internal-plugin-metrics';
-import metrics from '@webex/plugin-meetings/src/metrics';
-import BrowserDetection from '@webex/plugin-meetings/src/common/browser-detection';
 import MockWebex from '@webex/test-helper-mock-webex';
 import {browserOnly} from '@webex/test-helper-mocha';
 import {assert} from '@webex/test-helper-chai';
 
-const {
-  getBrowserName,
-  getBrowserVersion,
-  getOSName,
-  getOSVersion
-} = BrowserDetection();
+import metrics from '@webex/plugin-meetings/src/metrics';
+
 
 /**
  * Meeting can only run in a browser, so we can only send metrics for
@@ -48,6 +42,7 @@ browserOnly(describe)('Meeting metrics', () => {
         clientId: 'mock-client-id'
       }
     };
+    webex.config.metrics.type = ['behavioral'];
     webex.internal.metrics.submitClientMetrics = mockSubmitMetric;
     metrics.initialSetup({}, webex);
   });
@@ -98,10 +93,10 @@ browserOnly(describe)('Meeting metrics', () => {
     });
 
     it('adds environment information to metric', () => {
-      const data = {value: 567};
-      const metadata = {test: true};
+      const fields = {value: 567};
+      const metricTags = {test: true};
 
-      metrics.sendBehavioralMetric('myMetric', data, metadata);
+      metrics.sendBehavioralMetric('myMetric', fields, metricTags);
 
       assert.calledWithMatch(
         mockSubmitMetric,
@@ -109,27 +104,13 @@ browserOnly(describe)('Meeting metrics', () => {
         {
           type: ['behavioral'],
           fields: {
-            browser_version: getBrowserVersion(),
-            os_version: getOSVersion(),
-            sdk_version: '1.2.3',
             value: 567
           },
           tags: {
-            org_id: '7890',
-            os: getOSName(),
-            browser: getBrowserName(),
-            domain: window.location.hostname,
             test: true
           }
         }
       );
     });
-
-    it('throws error if no metric name is given', () => {
-      assert.throws(
-        () => metrics.sendBehavioralMetric(),
-        'Missing behavioral metric name. Please provide one'
-      );
-    });
   });
 });

package/test/unit/spec/networkQualityMonitor/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';

package/test/unit/spec/peerconnection-manager/index.js

@@ -1,4 +1,4 @@
-
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import PeerConnectionManager from '@webex/plugin-meetings/src/peer-connection-manager/index';

package/test/unit/spec/personal-meeting-room/personal-meeting-room.js

@@ -2,6 +2,7 @@
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
 
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import {

package/test/unit/spec/reconnection-manager/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';

package/test/unit/spec/roap/util.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import RoapUtil from '@webex/plugin-meetings/src/roap/util';
 import PeerConnectionManager from '@webex/plugin-meetings/src/peer-connection-manager/index.js';

package/test/unit/spec/stats-analyzer/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';

package/test/unit/spec/transcription/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import Transcription from '@webex/plugin-meetings/src/transcription';