@webex/plugin-meetings 1.156.3 → 1.157.1

package/test/unit/spec/meeting/index.js

@@ -1,6 +1,7 @@
 /*!
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
+import 'jsdom-global/register';
 import {cloneDeep, isEqual} from 'lodash';
 import sinon from 'sinon';
 import StateMachine from 'javascript-state-machine';
@@ -27,6 +28,7 @@ import LoggerConfig from '@webex/plugin-meetings/src/common/logs/logger-config';
 import TriggerProxy from '@webex/plugin-meetings/src/common/events/trigger-proxy';
 import BrowserDetection from '@webex/plugin-meetings/src/common/browser-detection';
 import Metrics from '@webex/plugin-meetings/src/metrics';
+import {eventType} from '@webex/plugin-meetings/src/metrics/config';
 import {
   FLOOR_ACTION,
   SHARE_STATUS,
@@ -36,7 +38,7 @@ import {
   EVENT_TRIGGERS,
   _SIP_URI_
 } from '@webex/plugin-meetings/src/constants';
-import {BEHAVIORAL_METRICS} from '@webex/plugin-meetings/src/metrics/constants';
+import BEHAVIORAL_METRICS from '@webex/plugin-meetings/src/metrics/constants';
 
 import {
   UserNotJoinedError,
@@ -71,6 +73,23 @@ describe('plugin-meetings', () => {
   };
 
   before(() => {
+    const MediaStream = {
+      getVideoTracks: () => [{
+        applyConstraints: () => { }
+      }]
+    };
+
+    Object.defineProperty(global.window.navigator, 'mediaDevices', {
+      writable: true,
+      value: {
+        getDisplayMedia: sinon.stub().returns(Promise.resolve(MediaStream))
+      }
+    });
+
+    Object.defineProperty(global.window, 'MediaStream', {
+      writable: true,
+      value: MediaStream
+    });
     LoggerConfig.set({verboseEvents: true, enable: false});
     LoggerProxy.set(logger);
   });
@@ -107,6 +126,9 @@ describe('plugin-meetings', () => {
           metrics: {},
           stats: {},
           experimental: {enableUnifiedMeetings: true}
+        },
+        metrics: {
+          type: ['behavioral']
         }
       }
     });
@@ -695,6 +717,11 @@ describe('plugin-meetings', () => {
               assert.calledWith(MeetingUtil.joinMeeting, meeting, {moderator: false, pin: '1234'});
             });
           });
+          it('should post error event if failed', async () => {
+            await meeting.join().catch(() => {
+              assert.calledWithMatch(Metrics.postEvent, {event: eventType.LOCUS_JOIN_RESPONSE});
+            });
+          });
           it('should fail if password is required', async () => {
             meeting.passwordStatus = PASSWORD_STATUS.REQUIRED;
             await assert.isRejected(meeting.join(), PasswordError);

package/test/unit/spec/meetings/index.js

@@ -1,7 +1,7 @@
 /*!
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
-
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import MockWebex from '@webex/test-helper-mock-webex';
@@ -448,6 +448,13 @@ skipInBrowser(describe)('plugin-meetings', () => {
             assert.calledOnce(initialSetup);
             assert.calledWith(initialSetup, {id: uuid1, replaces: [{locusUrl: 'http:locusUrl'}], self: {callBackInfo: {callbackAddress: uri1}}});
           });
+          it('should setup the meeting by difference event without replaces', async () => {
+            await webex.meetings.handleLocusEvent({locus: {id: uuid1, self: {callBackInfo: {callbackAddress: uri1}}}, eventType: 'locus.difference', locusUrl: url1});
+            assert.callCount(webex.meetings.meetingCollection.getByKey, 4);
+            assert.calledWith(webex.meetings.meetingCollection.getByKey, 'locusUrl', url1);
+            assert.calledOnce(initialSetup);
+            assert.calledWith(initialSetup, {id: uuid1, self: {callBackInfo: {callbackAddress: uri1}}});
+          });
           it('should setup the meeting by a not difference event', async () => {
             await webex.meetings.handleLocusEvent({locus: {id: uuid1, self: {callBackInfo: {callbackAddress: uri1}}}, eventType: test1, locusUrl: url1});
             assert.callCount(webex.meetings.meetingCollection.getByKey, 4);

package/test/unit/spec/members/index.js

@@ -2,6 +2,7 @@
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
 
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import uuid from 'uuid';
 import chai from 'chai';

package/test/unit/spec/metrics/index.js

@@ -1,21 +1,15 @@
 /*!
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
-/* globals window */
+import 'jsdom-global/register';
 import sinon from 'sinon';
 import Metrics from '@webex/internal-plugin-metrics';
-import metrics from '@webex/plugin-meetings/src/metrics';
-import BrowserDetection from '@webex/plugin-meetings/src/common/browser-detection';
 import MockWebex from '@webex/test-helper-mock-webex';
 import {browserOnly} from '@webex/test-helper-mocha';
 import {assert} from '@webex/test-helper-chai';
 
-const {
-  getBrowserName,
-  getBrowserVersion,
-  getOSName,
-  getOSVersion
-} = BrowserDetection();
+import metrics from '@webex/plugin-meetings/src/metrics';
+
 
 /**
  * Meeting can only run in a browser, so we can only send metrics for
@@ -48,6 +42,7 @@ browserOnly(describe)('Meeting metrics', () => {
         clientId: 'mock-client-id'
       }
     };
+    webex.config.metrics.type = ['behavioral'];
     webex.internal.metrics.submitClientMetrics = mockSubmitMetric;
     metrics.initialSetup({}, webex);
   });
@@ -98,10 +93,10 @@ browserOnly(describe)('Meeting metrics', () => {
     });
 
     it('adds environment information to metric', () => {
-      const data = {value: 567};
-      const metadata = {test: true};
+      const fields = {value: 567};
+      const metricTags = {test: true};
 
-      metrics.sendBehavioralMetric('myMetric', data, metadata);
+      metrics.sendBehavioralMetric('myMetric', fields, metricTags);
 
       assert.calledWithMatch(
         mockSubmitMetric,
@@ -109,27 +104,13 @@ browserOnly(describe)('Meeting metrics', () => {
         {
           type: ['behavioral'],
           fields: {
-            browser_version: getBrowserVersion(),
-            os_version: getOSVersion(),
-            sdk_version: '1.2.3',
             value: 567
           },
           tags: {
-            org_id: '7890',
-            os: getOSName(),
-            browser: getBrowserName(),
-            domain: window.location.hostname,
             test: true
           }
         }
       );
     });
-
-    it('throws error if no metric name is given', () => {
-      assert.throws(
-        () => metrics.sendBehavioralMetric(),
-        'Missing behavioral metric name. Please provide one'
-      );
-    });
   });
 });

package/test/unit/spec/networkQualityMonitor/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';

package/test/unit/spec/peerconnection-manager/index.js

@@ -1,4 +1,4 @@
-
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import PeerConnectionManager from '@webex/plugin-meetings/src/peer-connection-manager/index';

package/test/unit/spec/personal-meeting-room/personal-meeting-room.js

@@ -2,6 +2,7 @@
  * Copyright (c) 2015-2020 Cisco Systems, Inc. See LICENSE file.
  */
 
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import {

package/test/unit/spec/reconnection-manager/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';

package/test/unit/spec/roap/util.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import RoapUtil from '@webex/plugin-meetings/src/roap/util';
 import PeerConnectionManager from '@webex/plugin-meetings/src/peer-connection-manager/index.js';

package/test/unit/spec/stats-analyzer/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import chai from 'chai';
 import chaiAsPromised from 'chai-as-promised';
 import sinon from 'sinon';

package/test/unit/spec/transcription/index.js

@@ -1,3 +1,4 @@
+import 'jsdom-global/register';
 import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import Transcription from '@webex/plugin-meetings/src/transcription';