@webex/plugin-meetings 1.153.0 → 1.153.4

package/src/peer-connection-manager/index.js

@@ -10,9 +10,8 @@ import Metrics from '../metrics';
 import LoggerProxy from '../common/logs/logger-proxy';
 import StaticConfig from '../common/config';
 import {
-  RETRY_TIMEOUT,
-  ICE_TIMEOUT,
-  HOST,
+  COMPLETE,
+  GATHERING,
   AUDIO,
   SDP,
   ICE_STATE,
@@ -22,15 +21,16 @@ import {
   OFFER,
   QUALITY_LEVELS,
   MAX_FRAMESIZES,
-  METRICS_OPERATIONAL_MEASURES,
-  IPV4_REGEX
+  METRICS_OPERATIONAL_MEASURES
 } from '../constants';
 import {error, eventType} from '../metrics/config';
 import MediaError from '../common/errors/media';
 import ParameterError from '../common/errors/parameter';
-import {InvalidSdpError} from '../common/errors/webex-errors';
+import {InvalidSdpError, IceGatheringFailed} from '../common/errors/webex-errors';
 import BrowserDetection from '../common/browser-detection';
 
+import PeerConnectionUtils from './util';
+
 const {isBrowser} = BrowserDetection();
 
 /**
@@ -120,18 +120,10 @@ const isSdpInvalid = (sdp) => {
   const parsedSdp = sdpTransform.parse(sdp);
 
   for (const mediaLine of parsedSdp.media) {
-    if (mediaLine.candidates && mediaLine.candidates.length === 0) {
+    if (!mediaLine.candidates || mediaLine.candidates?.length === 0) {
       LoggerProxy.logger.error('PeerConnectionManager:index#isSdpInvalid --> iceCandidate: Ice candadate never completed');
 
-      return 'iceCandidate: Ice candadate never completed';
-    }
-    // Sometimes the candidates might be there but only IPV6 we need to makes sure we have IPV4
-    const hostCandidate = mediaLine.candidates.filter((candidate) => !!(candidate.type === HOST && candidate.ip.match(IPV4_REGEX)));
-
-    if (hostCandidate.length === 0) {
-      LoggerProxy.logger.error('PeerConnectionManager:index#isSdpInvalid --> iceCandidate: no IPV4 candidate present');
-
-      return 'iceCandidate: no IPV4 candidate present';
+      return 'iceCandidate: Ice gathering never completed';
     }
 
     if (SDP.BAD_MEDIA_PORTS.includes(mediaLine.port)) {
@@ -191,43 +183,52 @@ pc.setContentSlides = (screenPc) => {
  */
 pc.iceCandidate = (peerConnection, {remoteQualityLevel}) =>
   new Promise((resolve, reject) => {
-    // TODO: we dont need timeout as we can check the api state and validate.
-    const timeout = setTimeout(() => {
+    const now = Date.now();
+    const doneGatheringIceCandidate = () => {
+      const miliseconds = parseInt(Math.abs(Date.now() - now), 4);
+
       peerConnection.sdp = limitBandwidth(peerConnection.localDescription.sdp);
       peerConnection.sdp = setMaxFs(peerConnection.sdp, remoteQualityLevel);
+      peerConnection.sdp = PeerConnectionUtils.convertCLineToIpv4(peerConnection.sdp);
 
-      if (isSdpInvalid(peerConnection.sdp)) {
-        setTimeout(() => {
-          // peerconnection does gather ice candidate IP but in some cases due to firewall
-          // or proxy the ice candidate does not get gathered so we need to wait and then retry
-          // if still not valid then throw an error saying missing ice candidate
-          // if ice candidate still not present after retry
-          const invalidSdpPresent = isSdpInvalid(peerConnection.sdp);
+      const invalidSdpPresent = isSdpInvalid(peerConnection.sdp);
 
-          if (!invalidSdpPresent) {
-            resolve(peerConnection);
-          }
-          else {
-            LoggerProxy.logger.error('PeerConnectionManager:index#iceCandidate --> SDP not valid after waiting.');
-            reject(new InvalidSdpError(invalidSdpPresent));
-          }
-        }, RETRY_TIMEOUT);
+      if (invalidSdpPresent) {
+        LoggerProxy.logger.error('PeerConnectionManager:index#iceCandidate --> SDP not valid after waiting.');
+        reject(new InvalidSdpError(invalidSdpPresent));
       }
-      else {
-        resolve(peerConnection);
+      LoggerProxy.logger.log(`PeerConnectionManager:index#iceCandidate --> Time to gather ice candidate ${miliseconds} miliseconds`);
+
+
+      resolve();
+    };
+
+    // If ice has already been gathered
+    if (peerConnection.iceGatheringState === COMPLETE) {
+      doneGatheringIceCandidate();
+    }
+
+    peerConnection.onIceGatheringStateChange = () => {
+      if (peerConnection.iceGatheringState === COMPLETE) {
+        doneGatheringIceCandidate(peerConnection);
+      }
+      if (peerConnection.iceGatheringState === GATHERING) {
+        LoggerProxy.logger.log('PeerConnectionManager:index#onIceGatheringStateChange --> Ice state changed to gathering');
       }
-    }, ICE_TIMEOUT);
+    };
 
     peerConnection.onicecandidate = (evt) => {
-      if (!evt.candidate && !peerConnection.sdp) {
-        peerConnection.sdp = limitBandwidth(peerConnection.localDescription.sdp);
-        peerConnection.sdp = setMaxFs(peerConnection.sdp, remoteQualityLevel);
-
-        if (evt.candidate === null && !isSdpInvalid(peerConnection.sdp)) {
-          clearTimeout(timeout);
-          resolve(peerConnection);
-        }
+      if (evt.candidate === null) {
+        doneGatheringIceCandidate(peerConnection);
       }
+      else {
+        LoggerProxy.logger.log(`PeerConnectionManager:index#onicecandidate --> Candidate ${evt.candidate?.type} ${evt.candidate?.protocol} ${evt.candidate?.address}:${evt.candidate?.port}`);
+      }
+    };
+
+    peerConnection.onicecandidateerror = (event) => {
+      LoggerProxy.logger.error('PeerConnectionManager:index#onicecandidateerror --> Failed to gather ice candidate.', event);
+      reject(new IceGatheringFailed());
     };
   });
 
@@ -402,8 +403,6 @@ pc.createOffer = (peerConnection, {
     })
     .then(() => pc.iceCandidate(peerConnection, {remoteQualityLevel}))
     .then(() => {
-      peerConnection.sdp = limitBandwidth(peerConnection.localDescription.sdp);
-      peerConnection.sdp = setMaxFs(peerConnection.sdp, remoteQualityLevel);
       if (!checkH264Support(peerConnection.sdp)) {
         throw new MediaError('openH264 is downloading please Wait. Upload logs if not working on second try');
       }
@@ -530,6 +529,7 @@ pc.createAnswer = (params, {meetingId, remoteQualityLevel}) => {
     .then(() => {
       peerConnection.sdp = limitBandwidth(peerConnection.localDescription.sdp);
       peerConnection.sdp = setMaxFs(peerConnection.sdp, remoteQualityLevel);
+      peerConnection.sdp = PeerConnectionUtils.convertCLineToIpv4(peerConnection.sdp);
       if (!checkH264Support(peerConnection.sdp)) {
         throw new MediaError('openH264 is downloading please Wait. Upload logs if not working on second try');
       }

package/src/peer-connection-manager/util.js

@@ -0,0 +1,19 @@
+
+const PeerConnectionUtils = {};
+
+/**
+ * Convert C line to IPv4
+ * @param {String} sdp
+ * @returns {String}
+ */
+PeerConnectionUtils.convertCLineToIpv4 = (sdp) => {
+  let replaceSdp = sdp;
+
+  // TODO: remove this once linus supports Ipv6 c line.currently linus rejects SDP with c line having ipv6 candidates we are
+  // mocking ipv6 to ipv4 candidates
+  // https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-299232
+  replaceSdp = replaceSdp.replace(/c=IN IP6 .*/gi, 'c=IN IP4 0.0.0.0');
+
+  return replaceSdp;
+};
+export default PeerConnectionUtils;

package/test/unit/spec/meeting/index.js

@@ -48,6 +48,7 @@ import WebExMeetingsErrors from '../../../../src/common/errors/webex-meetings-er
 import ParameterError from '../../../../src/common/errors/parameter';
 import PasswordError from '../../../../src/common/errors/password-error';
 import CaptchaError from '../../../../src/common/errors/captcha-error';
+import IntentToJoinError from '../../../../src/common/errors/intent-to-join';
 import DefaultSDKConfig from '../../../../src/config';
 import testUtils from '../../../utils/testUtils';
 import {MeetingInfoV2CaptchaError, MeetingInfoV2PasswordError} from '../../../../src/meeting-info/meeting-info-v2';
@@ -609,6 +610,17 @@ describe('plugin-meetings', () => {
         });
       });
       describe('#join', () => {
+        let sandbox = null;
+
+        beforeEach(() => {
+          sandbox = sinon.createSandbox();
+        });
+
+        afterEach(() => {
+          sandbox.restore();
+          sandbox = null;
+        });
+
         it('should have #join', () => {
           assert.exists(meeting.join);
         });
@@ -618,8 +630,9 @@ describe('plugin-meetings', () => {
         });
         describe('successful', () => {
           beforeEach(() => {
-            MeetingUtil.joinMeeting = sinon.stub().returns(Promise.resolve());
+            sandbox.stub(MeetingUtil, 'joinMeeting').returns(Promise.resolve());
           });
+
           it('should join the meeting and return promise', async () => {
             const join = meeting.join();
 
@@ -642,16 +655,17 @@ describe('plugin-meetings', () => {
           });
 
           it('should create new correlation ID when already joined', async () => {
-            meeting.isCreated = false;
+            meeting.hasJoinedOnce = true;
             await meeting.join();
             sinon.assert.called(meeting.setCorrelationId);
           });
         });
         describe('failure', () => {
           beforeEach(() => {
-            MeetingUtil.joinMeeting = sinon.stub().returns(Promise.reject());
+            sandbox.stub(MeetingUtil, 'joinMeeting').returns(Promise.reject());
             meeting.logger.log = sinon.stub().returns(true);
           });
+
           describe('guest join', () => {
             beforeEach(() => {
               MeetingUtil.isPinOrGuest = sinon.stub().returns(true);
@@ -662,6 +676,24 @@ describe('plugin-meetings', () => {
                 assert.calledOnce(MeetingUtil.joinMeeting);
               });
             });
+            it('should succeed when called again after IntentToJoinError error', async () => {
+              let joinSucceeded = false;
+
+              try {
+                await meeting.join();
+                joinSucceeded = true;
+              }
+              catch (e) {
+                assert.instanceOf(e, IntentToJoinError);
+              }
+              assert.isFalse(joinSucceeded);
+
+              // IntentToJoinError means that client should call join() again
+              // with moderator and pin explicitly set
+              MeetingUtil.joinMeeting = sinon.stub().returns(Promise.resolve());
+              await meeting.join({pin: '1234', moderator: false});
+              assert.calledWith(MeetingUtil.joinMeeting, meeting, {moderator: false, pin: '1234'});
+            });
           });
           it('should fail if password is required', async () => {
             meeting.passwordStatus = PASSWORD_STATUS.REQUIRED;

package/test/unit/spec/meeting/request.js

@@ -19,10 +19,18 @@ describe('plugin-meetings', () => {
       regionCode: 'WEST-COAST'
     };
 
+    webex.internal = {
+      services: {
+        get: sinon.mock().returns('locusUrl'),
+        waitForCatalog: sinon.mock().returns(Promise.resolve({}))
+      }
+    };
+
     meetingsRequest = new MeetingRequest({}, {
       parent: webex
     });
 
+
     meetingsRequest.request = sinon.mock().returns(Promise.resolve({}));
   });
 
@@ -112,12 +120,15 @@ describe('plugin-meetings', () => {
         const deviceUrl = 'deviceUrl';
         const correlationId = 'random-uuid';
         const roapMessage = 'roap-message';
+        const permissionToken = 'permission-token';
 
         await meetingsRequest.joinMeeting({
           locusUrl,
           deviceUrl,
           correlationId,
-          roapMessage
+          roapMessage,
+          permissionToken
+
         });
         const requestParams = meetingsRequest.request.getCall(0).args[0];
 
@@ -125,8 +136,49 @@ describe('plugin-meetings', () => {
         assert.equal(requestParams.uri, `${locusUrl}/participant?alternateRedirect=true`);
         assert.equal(requestParams.body.device.url, deviceUrl);
         assert.equal(requestParams.body.device.countryCode, 'US');
+        assert.equal(requestParams.body.permissionToken, 'permission-token');
         assert.equal(requestParams.body.device.regionCode, 'WEST-COAST');
       });
+
+      it('sends /call with meetingNumber if inviteeAddress does not exist', async () => {
+        const deviceUrl = 'deviceUrl';
+        const correlationId = 'random-uuid';
+        const roapMessage = 'roap-message';
+        const meetingNumber = 'meetingNumber';
+
+        await meetingsRequest.joinMeeting({
+          deviceUrl,
+          correlationId,
+          roapMessage,
+          meetingNumber
+        });
+        const requestParams = meetingsRequest.request.getCall(0).args[0];
+
+        assert.equal(requestParams.method, 'POST');
+        assert.equal(requestParams.uri, 'locusUrl/loci/call?alternateRedirect=true');
+        assert.equal(requestParams.body.invitee.address, 'wbxmn:meetingNumber');
+      });
+
+      it('sends /call with inviteeAddress over meetingNumber as preference', async () => {
+        const deviceUrl = 'deviceUrl';
+        const correlationId = 'random-uuid';
+        const roapMessage = 'roap-message';
+        const meetingNumber = 'meetingNumber';
+        const inviteeAddress = 'sipUrl';
+
+        await meetingsRequest.joinMeeting({
+          deviceUrl,
+          correlationId,
+          roapMessage,
+          meetingNumber,
+          inviteeAddress
+        });
+        const requestParams = meetingsRequest.request.getCall(0).args[0];
+
+        assert.equal(requestParams.method, 'POST');
+        assert.equal(requestParams.uri, 'locusUrl/loci/call?alternateRedirect=true');
+        assert.equal(requestParams.body.invitee.address, 'sipUrl');
+      });
     });
 
     describe('#pstn', () => {

package/test/unit/spec/meeting/utils.js

@@ -4,6 +4,7 @@ import MeetingUtil from '@webex/plugin-meetings/src/meeting/util';
 import LoggerProxy from '@webex/plugin-meetings/src/common/logs/logger-proxy';
 import LoggerConfig
   from '@webex/plugin-meetings/src/common/logs/logger-config';
+import Metrics from '@webex/plugin-meetings/src/metrics/index';
 
 describe('plugin-meetings', () => {
   describe('Meeting utils function', () => {
@@ -11,6 +12,7 @@ describe('plugin-meetings', () => {
     const meeting = {};
 
     beforeEach(() => {
+      Metrics.postEvent = sinon.stub();
       const logger = {
         info: sandbox.stub(),
         log: sandbox.stub(),
@@ -132,6 +134,45 @@ describe('plugin-meetings', () => {
         });
       });
     });
+
+    describe('joinMeeting', () => {
+      it('#Should call `meetingRequest.joinMeeting', async () => {
+        const meeting = {meetingJoinUrl: 'meetingJoinUrl', locusUrl: 'locusUrl', meetingRequest: {joinMeeting: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}};
+
+        MeetingUtil.parseLocusJoin = sinon.stub();
+        await MeetingUtil.joinMeeting(meeting, {});
+
+        assert.calledOnce(meeting.meetingRequest.joinMeeting);
+        const parameter = meeting.meetingRequest.joinMeeting.getCall(0).args[0];
+
+        assert.equal(parameter.inviteeAddress, 'meetingJoinUrl');
+      });
+
+      it('#Should fallback sipUrl if meetingJoinUrl does not exists', async () => {
+        const meeting = {sipUri: 'sipUri', locusUrl: 'locusUrl', meetingRequest: {joinMeeting: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}};
+
+        MeetingUtil.parseLocusJoin = sinon.stub();
+        await MeetingUtil.joinMeeting(meeting, {});
+
+        assert.calledOnce(meeting.meetingRequest.joinMeeting);
+        const parameter = meeting.meetingRequest.joinMeeting.getCall(0).args[0];
+
+        assert.equal(parameter.inviteeAddress, 'sipUri');
+      });
+
+      it('#Should fallback to meetingNumber if meetingJoinUrl/sipUrl  does not exists', async () => {
+        const meeting = {meetingNumber: 'meetingNumber', locusUrl: 'locusUrl', meetingRequest: {joinMeeting: sinon.stub().returns(Promise.resolve({body: {}, headers: {}}))}};
+
+        MeetingUtil.parseLocusJoin = sinon.stub();
+        await MeetingUtil.joinMeeting(meeting, {});
+
+        assert.calledOnce(meeting.meetingRequest.joinMeeting);
+        const parameter = meeting.meetingRequest.joinMeeting.getCall(0).args[0];
+
+        assert.isUndefined(parameter.inviteeAddress);
+        assert.equal(parameter.meetingNumber, 'meetingNumber');
+      });
+    });
   });
 });
 

package/test/unit/spec/meetings/index.js

@@ -468,7 +468,7 @@ skipInBrowser(describe)('plugin-meetings', () => {
         });
         describe('successful MeetingInfo.#fetchMeetingInfo', () => {
           beforeEach(() => {
-            webex.meetings.meetingInfo.fetchMeetingInfo = sinon.stub().returns(Promise.resolve(true));
+            webex.meetings.meetingInfo.fetchMeetingInfo = sinon.stub().returns(Promise.resolve({body: {permissionToken: 'PT', meetingJoinUrl: 'meetingJoinUrl'}}));
           });
           it('creates the meeting from a successful meeting info fetch promise testing', async () => {
             const meeting = webex.meetings.createMeeting('test', 'test');
@@ -482,6 +482,8 @@ skipInBrowser(describe)('plugin-meetings', () => {
             assert.calledWith(webex.meetings.meetingInfo.fetchMeetingInfo, 'test');
             assert.calledWith(MeetingsUtil.extractDestination, 'test', 'test');
             assert.calledWith(MeetingsUtil.getMeetingAddedType, 'test');
+            assert.equal(meeting.permissionToken, 'PT');
+            assert.equal(meeting.meetingJoinUrl, 'meetingJoinUrl');
           });
 
           it('creates the meeting from a successful meeting info fetch meeting resolve testing', async () => {

package/test/unit/spec/peerconnection-manager/index.js

@@ -3,9 +3,23 @@ import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import PeerConnectionManager from '@webex/plugin-meetings/src/peer-connection-manager/index';
 import StaticConfig from '@webex/plugin-meetings/src/common/config';
+import {IceGatheringFailed, InvalidSdpError} from '@webex/plugin-meetings/src/common/errors/webex-errors';
 
 describe('Peerconnection Manager', () => {
   describe('Methods', () => {
+    let peerConnection = null;
+    let sdp = null;
+
+    beforeEach(() => {
+      sdp = 'v=0\r\no=- 1026633665396855335 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE 0 1 2\r\nr\na=msid-semantic: WMS\r\nm=audio 40903 UDP/TLS/RTP/SAVPF 111 63 103 104 9 0 8 106 105 13 110 112 113 126\r\nb=TIAS:64000\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:602151403 1 udp 2122262783 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 47974 typ host generation 0 network-id 2 network-cost 900\r\na=candidate:675071982 1 udp 2122197247 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 41234 typ host generation 0 network-id 3 network-cost 900\r\na=candidate:1835525403 1 tcp 1518283007 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 9 typ host tcptype active generation 0 network-id 2 network-cost 900\r\na=candidate:1723808542 1 tcp 1518217471 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 9 typ host tcptype active generation 0 network-id 3 network-cost 900\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\nm=video 43875 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:602151403 1 udp 2122262783 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 41619 typ host generation 0 network-id 2 network-cost 900\r\na=candidate:675071982 1 udp 2122197247 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 47098 typ host generation 0 network-id 3 network-cost 900\r\na=candidate:1835525403 1 tcp 1518283007 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 9 typ host tcptype active generation 0 network-id 2 network-cost 900\r\na=candidate:1723808542 1 tcp 1518217471 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 9 typ host tcptype active generation 0 network-id 3 network-cost 900\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\nm=video 49298 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:602151403 1 udp 2122262783 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 37670 typ host generation 0 network-id 2 network-cost 900\r\na=candidate:675071982 1 udp 2122197247 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 37790 typ host generation 0 network-id 3 network-cost 900\r\na=candidate:1835525403 1 tcp 1518283007 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 9 typ host tcptype active generation 0 network-id 2 network-cost 900\r\na=candidate:1723808542 1 tcp 1518217471 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 9 typ host tcptype active generation 0 network-id 3 network-cost 900\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f;\r\na=content:slides\r\n';
+
+      peerConnection = {
+        iceGatheringState: 'new',
+        onicecandidate: null,
+        onicecandidateerror: null,
+        localDescription: {sdp}
+      };
+    });
     describe('setRemoteSessionDetails', () => {
       it('change the start bitrate on remoteSDP', async () => {
         StaticConfig.set({bandwidth: {audio: 50, video: 500, startBitrate: 2000}});
@@ -62,5 +76,60 @@ describe('Peerconnection Manager', () => {
         assert.equal(result.sdp, remoteSdp);
       });
     });
+
+    describe('iceCandidate', () => {
+      beforeEach(() => {
+        StaticConfig.set({bandwidth: {audio: 50, video: 500, startBitrate: 0}});
+        peerConnection.sdp = null;
+      });
+      it('ice gathering already completed', async () => {
+        peerConnection.iceGatheringState = 'complete';
+
+        await PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'});
+        console.error('Came her with sdp resolved');
+        assert(peerConnection.sdp.search('max-fs:8192'), true);
+      });
+
+      it('listen onIceCandidate,onicecandidateerror and onIceGatheringStateChange', async () => {
+        peerConnection.iceGatheringState = 'none';
+        setTimeout(() => {
+          peerConnection.onicecandidate({candidate: null});
+        }, 1000);
+        await PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'});
+        assert.isFunction(peerConnection.onIceGatheringStateChange);
+        assert.isFunction(peerConnection.onicecandidate);
+        assert.isFunction(peerConnection.onicecandidateerror);
+      });
+
+      it('generate sdp with iceGatheringstate is `complet`', async () => {
+        peerConnection.iceGatheringState = 'none';
+        setTimeout(() => {
+          peerConnection.iceGatheringState = 'complete';
+          peerConnection.onIceGatheringStateChange();
+        }, 1000);
+        await PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'})
+          .then(() => {
+            assert(peerConnection.sdp.search('max-fs:8192'), true);
+          });
+      });
+
+      it('should not generate sdp if onicecandidateerror errors out ', async () => {
+        peerConnection.iceGatheringState = 'none';
+        setTimeout(() => {
+          peerConnection.onicecandidateerror();
+        }, 1000);
+        await assert.isRejected(PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'}), IceGatheringFailed);
+        assert.equal(peerConnection.sdp, null);
+      });
+
+      it('should throw generated SDP does not have candidates ', async () => {
+        peerConnection.iceGatheringState = 'none';
+        peerConnection.localDescription.sdp = 'v=0\r\no=- 1026633665396855335 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE 0 1 2\r\nr\na=msid-semantic: WMS\r\nm=audio 40903 UDP/TLS/RTP/SAVPF 111 63 103 104 9 0 8 106 105 13 110 112 113 126\r\nb=TIAS:64000\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\nm=video 43875 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\nm=video 49298 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f;\r\na=content:slides\r\n';
+        setTimeout(() => {
+          peerConnection.onicecandidate({candidate: null});
+        }, 1000);
+        await assert.isRejected(PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'}), InvalidSdpError);
+      });
+    });
   });
 });

package/test/unit/spec/peerconnection-manager/utils.js

@@ -0,0 +1,25 @@
+
+import {assert} from '@webex/test-helper-chai';
+import PeerConnectionUtils from '@webex/plugin-meetings/src/peer-connection-manager/util';
+
+describe('Peerconnection Manager', () => {
+  describe('Utils', () => {
+    describe('convertCLineToIpv4', () => {
+      it('changes ipv6 to ipv4 default', () => {
+        const localSdp = 'v=0\r\n' +
+        'm=video 5004 UDP/TLS/RTP/SAVPF 102 127 97 99\r\n' +
+        'c=IN IP6 2607:fb90:d27c:b314:211a:32dd:c47f:ffe\r\n' +
+        'a=rtpmap:127 H264/90000\r\n';
+        const resultSdp = 'v=0\r\n' +
+        'm=video 5004 UDP/TLS/RTP/SAVPF 102 127 97 99\r\n' +
+        'c=IN IP4 0.0.0.0\r\n' +
+        'a=rtpmap:127 H264/90000\r\n';
+
+
+        const temp = PeerConnectionUtils.convertCLineToIpv4(localSdp);
+
+        assert.equal(temp, resultSdp);
+      });
+    });
+  });
+});