@webex/plugin-meetings 1.152.1 → 1.153.3

package/test/unit/spec/meeting/index.js

@@ -48,6 +48,7 @@ import WebExMeetingsErrors from '../../../../src/common/errors/webex-meetings-er
 import ParameterError from '../../../../src/common/errors/parameter';
 import PasswordError from '../../../../src/common/errors/password-error';
 import CaptchaError from '../../../../src/common/errors/captcha-error';
+import IntentToJoinError from '../../../../src/common/errors/intent-to-join';
 import DefaultSDKConfig from '../../../../src/config';
 import testUtils from '../../../utils/testUtils';
 import {MeetingInfoV2CaptchaError, MeetingInfoV2PasswordError} from '../../../../src/meeting-info/meeting-info-v2';
@@ -642,7 +643,7 @@ describe('plugin-meetings', () => {
           });
 
           it('should create new correlation ID when already joined', async () => {
-            meeting.isCreated = false;
+            meeting.hasJoinedOnce = true;
             await meeting.join();
             sinon.assert.called(meeting.setCorrelationId);
           });
@@ -662,6 +663,24 @@ describe('plugin-meetings', () => {
                 assert.calledOnce(MeetingUtil.joinMeeting);
               });
             });
+            it('should succeed when called again after IntentToJoinError error', async () => {
+              let joinSucceeded = false;
+
+              try {
+                await meeting.join();
+                joinSucceeded = true;
+              }
+              catch (e) {
+                assert.instanceOf(e, IntentToJoinError);
+              }
+              assert.isFalse(joinSucceeded);
+
+              // IntentToJoinError means that client should call join() again
+              // with moderator and pin explicitly set
+              MeetingUtil.joinMeeting = sinon.stub().returns(Promise.resolve());
+              await meeting.join({pin: '1234', moderator: false});
+              assert.calledWith(MeetingUtil.joinMeeting, meeting, {moderator: false, pin: '1234'});
+            });
           });
           it('should fail if password is required', async () => {
             meeting.passwordStatus = PASSWORD_STATUS.REQUIRED;

package/test/unit/spec/meetings/index.js

@@ -68,6 +68,12 @@ skipInBrowser(describe)('plugin-meetings', () => {
         }
       });
 
+      Object.assign(webex.meetings.config, {
+        experimental: {
+          enableUnifiedMeetings: true
+        }
+      });
+
       Object.assign(webex.internal, {
         device: {
           deviceType: 'FAKE_DEVICE',
@@ -97,6 +103,29 @@ skipInBrowser(describe)('plugin-meetings', () => {
       assert.calledOnce(MeetingsUtil.triggerH264Codec);
     });
 
+    describe('#_toggleUnifiedMeetings', () => {
+      it('should have toggleUnifiedMeetings', () => {
+        assert.equal(typeof webex.meetings._toggleUnifiedMeetings, 'function');
+      });
+
+      describe('success', () => {
+        it('should update meeting info to v1', () => {
+          webex.meetings._toggleUnifiedMeetings(false);
+          assert.equal(webex.meetings.config.experimental.enableUnifiedMeetings, false);
+          assert.equal(webex.meetings.meetingInfo.constructor.name, 'MeetingInfo');
+        });
+      });
+
+      describe('failure', () => {
+        it('should not accept non boolean input', () => {
+          const currentEnableUnifiedMeetings = webex.meetings.config.experimental.enableUnifiedMeetings;
+
+          webex.meetings._toggleUnifiedMeetings('test');
+          assert.equal(webex.meetings.config.experimental.enableUnifiedMeetings, currentEnableUnifiedMeetings);
+        });
+      });
+    });
+
     describe('Public API Contracts', () => {
       describe('#register', () => {
         it('emits an event and resolves when register succeeds', (done) => {

package/test/unit/spec/peerconnection-manager/index.js

@@ -3,9 +3,23 @@ import {assert} from '@webex/test-helper-chai';
 import sinon from 'sinon';
 import PeerConnectionManager from '@webex/plugin-meetings/src/peer-connection-manager/index';
 import StaticConfig from '@webex/plugin-meetings/src/common/config';
+import {IceGatheringFailed, InvalidSdpError} from '@webex/plugin-meetings/src/common/errors/webex-errors';
 
 describe('Peerconnection Manager', () => {
   describe('Methods', () => {
+    let peerConnection = null;
+    let sdp = null;
+
+    beforeEach(() => {
+      sdp = 'v=0\r\no=- 1026633665396855335 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE 0 1 2\r\nr\na=msid-semantic: WMS\r\nm=audio 40903 UDP/TLS/RTP/SAVPF 111 63 103 104 9 0 8 106 105 13 110 112 113 126\r\nb=TIAS:64000\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:602151403 1 udp 2122262783 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 47974 typ host generation 0 network-id 2 network-cost 900\r\na=candidate:675071982 1 udp 2122197247 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 41234 typ host generation 0 network-id 3 network-cost 900\r\na=candidate:1835525403 1 tcp 1518283007 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 9 typ host tcptype active generation 0 network-id 2 network-cost 900\r\na=candidate:1723808542 1 tcp 1518217471 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 9 typ host tcptype active generation 0 network-id 3 network-cost 900\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\nm=video 43875 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:602151403 1 udp 2122262783 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 41619 typ host generation 0 network-id 2 network-cost 900\r\na=candidate:675071982 1 udp 2122197247 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 47098 typ host generation 0 network-id 3 network-cost 900\r\na=candidate:1835525403 1 tcp 1518283007 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 9 typ host tcptype active generation 0 network-id 2 network-cost 900\r\na=candidate:1723808542 1 tcp 1518217471 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 9 typ host tcptype active generation 0 network-id 3 network-cost 900\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\nm=video 49298 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=candidate:602151403 1 udp 2122262783 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 37670 typ host generation 0 network-id 2 network-cost 900\r\na=candidate:675071982 1 udp 2122197247 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 37790 typ host generation 0 network-id 3 network-cost 900\r\na=candidate:1835525403 1 tcp 1518283007 2401:4900:2301:c2cb:5ea9:46d5:7321:2531 9 typ host tcptype active generation 0 network-id 2 network-cost 900\r\na=candidate:1723808542 1 tcp 1518217471 2401:4900:33fc:314c:ad57:3e1d:befe:34b7 9 typ host tcptype active generation 0 network-id 3 network-cost 900\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f;\r\na=content:slides\r\n';
+
+      peerConnection = {
+        iceGatheringState: 'new',
+        onicecandidate: null,
+        onicecandidateerror: null,
+        localDescription: {sdp}
+      };
+    });
     describe('setRemoteSessionDetails', () => {
       it('change the start bitrate on remoteSDP', async () => {
         StaticConfig.set({bandwidth: {audio: 50, video: 500, startBitrate: 2000}});
@@ -62,5 +76,60 @@ describe('Peerconnection Manager', () => {
         assert.equal(result.sdp, remoteSdp);
       });
     });
+
+    describe('iceCandidate', () => {
+      beforeEach(() => {
+        StaticConfig.set({bandwidth: {audio: 50, video: 500, startBitrate: 0}});
+        peerConnection.sdp = null;
+      });
+      it('ice gathering already completed', async () => {
+        peerConnection.iceGatheringState = 'complete';
+
+        await PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'});
+        console.error('Came her with sdp resolved');
+        assert(peerConnection.sdp.search('max-fs:8192'), true);
+      });
+
+      it('listen onIceCandidate,onicecandidateerror and onIceGatheringStateChange', async () => {
+        peerConnection.iceGatheringState = 'none';
+        setTimeout(() => {
+          peerConnection.onicecandidate({candidate: null});
+        }, 1000);
+        await PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'});
+        assert.isFunction(peerConnection.onIceGatheringStateChange);
+        assert.isFunction(peerConnection.onicecandidate);
+        assert.isFunction(peerConnection.onicecandidateerror);
+      });
+
+      it('generate sdp with iceGatheringstate is `complet`', async () => {
+        peerConnection.iceGatheringState = 'none';
+        setTimeout(() => {
+          peerConnection.iceGatheringState = 'complete';
+          peerConnection.onIceGatheringStateChange();
+        }, 1000);
+        await PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'})
+          .then(() => {
+            assert(peerConnection.sdp.search('max-fs:8192'), true);
+          });
+      });
+
+      it('should not generate sdp if onicecandidateerror errors out ', async () => {
+        peerConnection.iceGatheringState = 'none';
+        setTimeout(() => {
+          peerConnection.onicecandidateerror();
+        }, 1000);
+        await assert.isRejected(PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'}), IceGatheringFailed);
+        assert.equal(peerConnection.sdp, null);
+      });
+
+      it('should throw generated SDP does not have candidates ', async () => {
+        peerConnection.iceGatheringState = 'none';
+        peerConnection.localDescription.sdp = 'v=0\r\no=- 1026633665396855335 2 IN IP4 127.0.0.1\r\ns=-\r\nt=0 0\r\na=group:BUNDLE 0 1 2\r\nr\na=msid-semantic: WMS\r\nm=audio 40903 UDP/TLS/RTP/SAVPF 111 63 103 104 9 0 8 106 105 13 110 112 113 126\r\nb=TIAS:64000\r\nc=IN IP4 0.0.0.0\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\nm=video 43875 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f\r\nm=video 49298 UDP/TLS/RTP/SAVPF 96 97 98 99 100 101 122 121 127\r\nb=TIAS:4000000\r\nc=IN IP4 0.0.0.0\r\na=periodic-keyframes:20\r\na=rtcp:9 IN IP4 0.0.0.0\r\na=ice-ufrag:zK3G\r\na=ice-pwd:e9xgQIGnRsJvaFpvTAenr5JQ\r\na=ice-options:trickle\r\na=fmtp:100 level-asymmetry-allowed=1;packetization-mode=1;profile-level-id=42e01f;\r\na=content:slides\r\n';
+        setTimeout(() => {
+          peerConnection.onicecandidate({candidate: null});
+        }, 1000);
+        await assert.isRejected(PeerConnectionManager.iceCandidate(peerConnection, {remoteQualityLevel: 'HIGH'}), InvalidSdpError);
+      });
+    });
   });
 });

package/test/unit/spec/peerconnection-manager/utils.js

@@ -0,0 +1,25 @@
+
+import {assert} from '@webex/test-helper-chai';
+import PeerConnectionUtils from '@webex/plugin-meetings/src/peer-connection-manager/util';
+
+describe('Peerconnection Manager', () => {
+  describe('Utils', () => {
+    describe('convertCLineToIpv4', () => {
+      it('changes ipv6 to ipv4 default', () => {
+        const localSdp = 'v=0\r\n' +
+        'm=video 5004 UDP/TLS/RTP/SAVPF 102 127 97 99\r\n' +
+        'c=IN IP6 2607:fb90:d27c:b314:211a:32dd:c47f:ffe\r\n' +
+        'a=rtpmap:127 H264/90000\r\n';
+        const resultSdp = 'v=0\r\n' +
+        'm=video 5004 UDP/TLS/RTP/SAVPF 102 127 97 99\r\n' +
+        'c=IN IP4 0.0.0.0\r\n' +
+        'a=rtpmap:127 H264/90000\r\n';
+
+
+        const temp = PeerConnectionUtils.convertCLineToIpv4(localSdp);
+
+        assert.equal(temp, resultSdp);
+      });
+    });
+  });
+});