@webex/plugin-meetings 1.147.1 → 1.149.2

package/test/unit/spec/meeting/index.js

@@ -1902,7 +1902,9 @@ describe('plugin-meetings', () => {
 
       describe('#usePhoneAudio', () => {
         beforeEach(() => {
-          meeting.meetingRequest.dialIn = sinon.stub().returns(Promise.resolve());
+          meeting.meetingRequest.dialIn = sinon.stub().returns(Promise.resolve({body: {locus: 'testData'}}));
+          meeting.meetingRequest.dialOut = sinon.stub().returns(Promise.resolve({body: {locus: 'testData'}}));
+          meeting.locusInfo.onFullLocus = sinon.stub().returns(Promise.resolve());
         });
 
         it('with no parameters triggers dial-in, delegating request to meetingRequest correctly', async () => {
@@ -1915,8 +1917,11 @@ describe('plugin-meetings', () => {
             locusUrl: meeting.locusUrl,
             clientUrl: meeting.deviceUrl
           });
+          assert.calledWith(meeting.locusInfo.onFullLocus, 'testData');
+          assert.notCalled(meeting.meetingRequest.dialOut);
 
           meeting.meetingRequest.dialIn.resetHistory();
+          meeting.locusInfo.onFullLocus.resetHistory();
 
           // try again. the dial in urls should match
           await meeting.usePhoneAudio();
@@ -1927,6 +1932,65 @@ describe('plugin-meetings', () => {
             locusUrl: meeting.locusUrl,
             clientUrl: meeting.deviceUrl
           });
+          assert.calledWith(meeting.locusInfo.onFullLocus, 'testData');
+          assert.notCalled(meeting.meetingRequest.dialOut);
+        });
+
+        it('given a phone number, triggers dial-out, delegating request to meetingRequest correctly', async () => {
+          const phoneNumber = '+442088241000';
+
+          await meeting.usePhoneAudio(phoneNumber);
+          const DIAL_OUT_URL = meeting.dialOutUrl;
+
+          assert.calledWith(meeting.meetingRequest.dialOut, {
+            correlationId: meeting.correlationId,
+            dialOutUrl: DIAL_OUT_URL,
+            locusUrl: meeting.locusUrl,
+            clientUrl: meeting.deviceUrl,
+            phoneNumber
+          });
+          assert.calledWith(meeting.locusInfo.onFullLocus, 'testData');
+          assert.notCalled(meeting.meetingRequest.dialIn);
+
+          meeting.meetingRequest.dialOut.resetHistory();
+          meeting.locusInfo.onFullLocus.resetHistory();
+
+          // try again. the dial out urls should match
+          await meeting.usePhoneAudio(phoneNumber);
+
+          assert.calledWith(meeting.meetingRequest.dialOut, {
+            correlationId: meeting.correlationId,
+            dialOutUrl: DIAL_OUT_URL,
+            locusUrl: meeting.locusUrl,
+            clientUrl: meeting.deviceUrl,
+            phoneNumber
+          });
+          assert.calledWith(meeting.locusInfo.onFullLocus, 'testData');
+          assert.notCalled(meeting.meetingRequest.dialIn);
+        });
+
+        it('rejects if the request failed (dial in)', () => {
+          const error = 'something bad happened';
+
+          meeting.meetingRequest.dialIn = sinon.stub().returns(Promise.reject(error));
+
+          return meeting.usePhoneAudio().then(() => Promise.reject(new Error('Promise resolved when it should have rejected'))).catch((e) => {
+            assert.equal(e, error);
+
+            return Promise.resolve();
+          });
+        });
+
+        it('rejects if the request failed (dial out)', async () => {
+          const error = 'something bad happened';
+
+          meeting.meetingRequest.dialOut = sinon.stub().returns(Promise.reject(error));
+
+          return meeting.usePhoneAudio('+441234567890').then(() => Promise.reject(new Error('Promise resolved when it should have rejected'))).catch((e) => {
+            assert.equal(e, error);
+
+            return Promise.resolve();
+          });
         });
       });
 

package/test/unit/spec/meeting/request.js

@@ -152,23 +152,48 @@ describe('plugin-meetings', () => {
         assert.equal(requestParams.body.device.clientUrl, 'clientUrl');
       });
 
-      it('sends leave pstn request', async () => {
+      it('sends dial out pstn request', async () => {
+        const locusUrl = 'locusUrl';
+        const clientUrl = 'clientUrl';
+        const correlationId = 'random-uuid';
+        const dialOutUrl = 'url';
+        const phoneNumber = '+442088241000';
+
+        await meetingsRequest.dialOut({
+          locusUrl,
+          clientUrl,
+          correlationId,
+          dialOutUrl,
+          phoneNumber
+        });
+        const requestParams = meetingsRequest.request.getCall(0).args[0];
+
+        assert.equal(requestParams.method, 'POST');
+        assert.equal(requestParams.uri, `${locusUrl}/participant`);
+        assert.equal(requestParams.body.device.url, dialOutUrl);
+        assert.equal(requestParams.body.device.deviceType, 'PROVISIONAL');
+        assert.equal(requestParams.body.device.provisionalType, 'DIAL_OUT');
+        assert.equal(requestParams.body.device.clientUrl, 'clientUrl');
+        assert.equal(requestParams.body.device.dialoutAddress, phoneNumber);
+      });
+
+      it('sends disconnect phone audio request', async () => {
         const locusUrl = 'locusUrl';
         const selfId = 'selfId';
         const correlationId = 'random-uuid';
-        const dialInUrl = 'url';
+        const phoneUrl = 'url';
 
-        await meetingsRequest.leavePstn({
+        await meetingsRequest.disconnectPhoneAudio({
           locusUrl,
           selfId,
           correlationId,
-          dialInUrl
+          phoneUrl
         });
         const requestParams = meetingsRequest.request.getCall(0).args[0];
 
         assert.equal(requestParams.method, 'PUT');
         assert.equal(requestParams.uri, `${locusUrl}/participant/${selfId}/leave`);
-        assert.equal(requestParams.body.device.url, dialInUrl);
+        assert.equal(requestParams.body.device.url, phoneUrl);
         assert.equal(requestParams.body.device.deviceType, 'PROVISIONAL');
       });
     });