@webex/plugin-logger 2.60.1-next.10 → 2.60.1-next.11

package/dist/logger.js

@@ -288,7 +288,7 @@ var Logger = _webexCore.WebexPlugin.extend({
     }
     return buffer.join('\n');
   },
-  version: "2.60.1-next.10"
+  version: "2.60.1-next.11"
 });
 
 /**

package/package.json

@@ -24,20 +24,20 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/test-helper-chai": "2.60.1-next.10",
-    "@webex/test-helper-mocha": "2.60.1-next.10",
-    "@webex/test-helper-mock-webex": "2.60.1-next.10",
-    "@webex/test-helper-test-users": "2.60.1-next.10",
+    "@webex/test-helper-chai": "2.60.1-next.11",
+    "@webex/test-helper-mocha": "2.60.1-next.11",
+    "@webex/test-helper-mock-webex": "2.60.1-next.11",
+    "@webex/test-helper-test-users": "2.60.1-next.11",
     "eslint": "^8.24.0",
     "prettier": "^2.7.1",
     "sinon": "^9.2.4"
   },
   "dependencies": {
-    "@webex/common": "2.60.1-next.10",
-    "@webex/test-helper-chai": "2.60.1-next.10",
-    "@webex/test-helper-mocha": "2.60.1-next.10",
-    "@webex/test-helper-mock-webex": "2.60.1-next.10",
-    "@webex/webex-core": "2.60.1-next.10",
+    "@webex/common": "2.60.1-next.11",
+    "@webex/test-helper-chai": "2.60.1-next.11",
+    "@webex/test-helper-mocha": "2.60.1-next.11",
+    "@webex/test-helper-mock-webex": "2.60.1-next.11",
+    "@webex/webex-core": "2.60.1-next.11",
     "lodash": "^4.17.21"
   },
   "scripts": {
@@ -45,10 +45,9 @@
     "build:src": "webex-legacy-tools build -dest \"./dist\" -src \"./src\" -js -ts -maps",
     "deploy:npm": "yarn npm publish",
     "test": "yarn test:style && yarn test:unit && yarn test:integration && yarn test:browser",
-    "test:browser": "webex-legacy-tools test --integration --unit --runner karma",
-    "test:integration": "webex-legacy-tools test --integration --runner mocha",
+    "test:browser": "webex-legacy-tools test --unit --runner karma",
     "test:style": "eslint ./src/**/*.*",
     "test:unit": "webex-legacy-tools test --unit --runner jest"
   },
-  "version": "2.60.1-next.10"
+  "version": "2.60.1-next.11"
 }

package/test/unit/spec/logger.js

@@ -6,7 +6,7 @@
 import {assert} from '@webex/test-helper-chai';
 import MockWebex from '@webex/test-helper-mock-webex';
 import sinon from 'sinon';
-import {browserOnly, nodeOnly} from '@webex/test-helper-mocha';
+import {browserOnly, nodeOnly, inBrowser} from '@webex/test-helper-mocha';
 import Logger, {levels} from '@webex/plugin-logger';
 import {WebexHttpError} from '@webex/webex-core';
 
@@ -636,11 +636,20 @@ describe('plugin-logger', () => {
             trackingid: '123',
           },
         });
-        assert.calledWith(console[impl(level)], 'wx-js-sdk', {
-          headers: {
-            trackingid: '123',
-          },
-        });
+
+        if(inBrowser()) {
+          assert.calledWith(console[impl(level)], 'wx-js-sdk', JSON.stringify({
+            headers: {
+              trackingid: '123',
+            },
+          }));
+        } else {
+          assert.calledWith(console[impl(level)], 'wx-js-sdk', {
+            headers: {
+              trackingid: '123',
+            },
+          });
+        }
       });
     });
   });
@@ -654,15 +663,25 @@ describe('plugin-logger', () => {
       });
 
       // Assert auth was filtered
-      assert.calledWith(console.log, 'wx-js-sdk', {Key: 'myKey'});
 
-      webex.logger.log({
+      if(inBrowser()) { 
+        assert.calledWith(console.log, "wx-js-sdk", JSON.stringify({Key: 'myKey'}));
+      } else {
+        assert.calledWith(console.log, "wx-js-sdk", {Key: 'myKey'});
+      }
+        webex.logger.log({
         authorization: 'XXXXXXX',
         Key: 'myKey',
       });
+9
+      
+      if(inBrowser()) { 
+      assert.calledWith(console.log, "wx-js-sdk", JSON.stringify({Key: 'myKey'}));
 
-      assert.calledWith(console.log, 'wx-js-sdk', {Key: 'myKey'});
-    });
+      } else {
+      assert.calledWith(console.log, "wx-js-sdk", {Key: 'myKey'});
+
+      } });
 
     it('redact emails', () => {
       webex.config.logger.level = 'trace';
@@ -694,7 +713,7 @@ describe('plugin-logger', () => {
       assert.calledWith(console.log, 'wx-js-sdk', 'https://example.com/example/j.php?MTID=[REDACTED]#abcdefg');
     });
 
-    it('handle circular references', () => {
+    nodeOnly(it)('handle circular references', () => {
       webex.config.logger.level = 'trace';
 
       const object = {
@@ -713,12 +732,19 @@ describe('plugin-logger', () => {
         Key: 'myKey',
       };
 
+      // Has self reference which is bad 
       expected.selfReference = expected;
 
-      assert.calledWith(console.log, 'wx-js-sdk', expected);
-    });
+      if(inBrowser()) { 
+        assert.calledWith(console.log, "wx-js-sdk", JSON.stringify(expected));
+  
+        } else {
+        assert.calledWith(console.log, "wx-js-sdk", expected);
+  
+        } 
+      });
 
-    it('handle circular references in complex objects', () => {
+    nodeOnly(it)('handle circular references in complex objects', () => {
       webex.config.logger.level = 'trace';
 
       const func = () => true;
@@ -747,7 +773,7 @@ describe('plugin-logger', () => {
 
       webex.logger.log(object);
 
-      assert.calledWith(console.log, 'wx-js-sdk', {
+      const res = {
         primativeString: 'justastring',
         primativeNum: 5,
         primativeBool: true,
@@ -764,9 +790,18 @@ describe('plugin-logger', () => {
           circularObjectRef: object,
           circularFunctionRef: func,
         },
+      }
+
+
+      if(inBrowser()) { 
+        assert.calledWith(console.log, "wx-js-sdk", JSON.stringify(res));
+  
+        } else {
+        assert.calledWith(console.log, "wx-js-sdk", res);
+  
+        }
       });
     });
-  });
 
   describe('#formatLogs()', () => {
     function sendRandomLog(log) {