@webex/internal-plugin-metrics 3.9.0 → 3.10.0-multi-llms.1

package/dist/types/metrics.types.d.ts

@@ -32,6 +32,7 @@ export type SubmitClientEventOptions = {
     triggeredTime?: string;
     emailInput?: ClientEmailInput;
     userNameInput?: ClientUserNameInput;
+    vendorId?: string;
 };
 export type SubmitMQEOptions = {
     meetingId: string;

package/package.json

@@ -11,7 +11,7 @@
     "directory": "packages/@webex/internal-plugin-metrics"
   },
   "engines": {
-    "node": ">=16"
+    "node": ">=18"
   },
   "browserify": {
     "transform": [
@@ -26,21 +26,21 @@
     "@webex/eslint-config-legacy": "0.0.0",
     "@webex/jest-config-legacy": "0.0.0",
     "@webex/legacy-tools": "0.0.0",
-    "@webex/test-helper-chai": "3.9.0",
-    "@webex/test-helper-mocha": "3.9.0",
-    "@webex/test-helper-mock-webex": "3.9.0",
-    "@webex/test-helper-test-users": "3.9.0",
+    "@webex/test-helper-chai": "3.9.0-multi-llms.1",
+    "@webex/test-helper-mocha": "3.9.0-multi-llms.1",
+    "@webex/test-helper-mock-webex": "3.9.0-multi-llms.1",
+    "@webex/test-helper-test-users": "3.9.0-multi-llms.1",
     "eslint": "^8.24.0",
     "prettier": "^2.7.1",
     "sinon": "^9.2.4"
   },
   "dependencies": {
-    "@webex/common": "3.9.0",
-    "@webex/common-timers": "3.9.0",
-    "@webex/event-dictionary-ts": "^1.0.1819",
-    "@webex/test-helper-chai": "3.9.0",
-    "@webex/test-helper-mock-webex": "3.9.0",
-    "@webex/webex-core": "3.9.0",
+    "@webex/common": "3.9.0-multi-llms.1",
+    "@webex/common-timers": "3.9.0-multi-llms.1",
+    "@webex/event-dictionary-ts": "^1.0.1930",
+    "@webex/test-helper-chai": "3.9.0-multi-llms.1",
+    "@webex/test-helper-mock-webex": "3.9.0-multi-llms.1",
+    "@webex/webex-core": "3.10.0-multi-llms.1",
     "ip-anonymize": "^0.1.0",
     "lodash": "^4.17.21",
     "uuid": "^3.3.2"
@@ -53,5 +53,5 @@
     "test:style": "eslint ./src/**/*.*",
     "test:unit": "webex-legacy-tools test --unit --runner mocha"
   },
-  "version": "3.9.0"
+  "version": "3.10.0-multi-llms.1"
 }

package/src/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -1,6 +1,7 @@
 /* eslint-disable class-methods-use-this */
 /* eslint-disable valid-jsdoc */
 import {WebexPlugin} from '@webex/webex-core';
+import {clamp} from 'lodash';
 
 import {MetricEventNames, PreComputedLatencies} from '../metrics.types';
 
@@ -16,6 +17,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
   precomputedLatencies: Map<PreComputedLatencies, number>;
   // meetingId that the current latencies are for
   private meetingId?: string;
+  private MAX_INTEGER = 2147483647;
 
   /**
    * @constructor
@@ -162,13 +164,9 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
 
     const diff = end - start;
 
-    if (!clampValues) {
-      return diff;
-    }
-
-    const {minimum = 0, maximum} = clampValues;
+    const {minimum = 0, maximum = this.MAX_INTEGER} = clampValues || {};
 
-    return Math.min(maximum ?? Infinity, Math.max(diff, minimum));
+    return clamp(diff, minimum, maximum);
   }
 
   /**
@@ -318,7 +316,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
   public getPageJMT() {
     const latency = this.precomputedLatencies.get('internal.client.pageJMT');
 
-    return typeof latency === 'number' ? latency : undefined;
+    return typeof latency === 'number' ? clamp(latency, 0, this.MAX_INTEGER) : undefined;
   }
 
   /**
@@ -328,7 +326,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
   public getDownloadTimeJMT() {
     const latency = this.precomputedLatencies.get('internal.download.time');
 
-    return typeof latency === 'number' ? latency : undefined;
+    return typeof latency === 'number' ? clamp(latency, 0, this.MAX_INTEGER) : undefined;
   }
 
   /**
@@ -349,7 +347,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     );
 
     if (typeof clickToInterstitialLatency === 'number') {
-      return clickToInterstitialLatency;
+      return clamp(clickToInterstitialLatency, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -373,7 +371,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     );
 
     if (typeof clickToInterstitialWithUserDelayLatency === 'number') {
-      return clickToInterstitialWithUserDelayLatency;
+      return clamp(clickToInterstitialWithUserDelayLatency, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -420,7 +418,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     if (interstitialJoinClickTimestamp && connectedMedia) {
       const interstitialToMediaOKJmt = connectedMedia - interstitialJoinClickTimestamp - lobbyTime;
 
-      return Math.max(0, interstitialToMediaOKJmt);
+      return clamp(interstitialToMediaOKJmt, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -435,7 +433,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const interstitialToJoinOk = this.getInterstitialToJoinOK();
 
     if (typeof clickToInterstitial === 'number' && typeof interstitialToJoinOk === 'number') {
-      return clickToInterstitial + interstitialToJoinOk;
+      return clamp(clickToInterstitial + interstitialToJoinOk, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -453,7 +451,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
       typeof clickToInterstitialWithUserDelay === 'number' &&
       typeof interstitialToJoinOk === 'number'
     ) {
-      return clickToInterstitialWithUserDelay + interstitialToJoinOk;
+      return clamp(clickToInterstitialWithUserDelay + interstitialToJoinOk, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -468,7 +466,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const ICESetupTime = this.getICESetupTime();
 
     if (joinReqResp && ICESetupTime) {
-      return joinReqResp + ICESetupTime;
+      return clamp(joinReqResp + ICESetupTime, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -485,12 +483,16 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const lobbyTime = this.getStayLobbyTime();
 
     if (clickToInterstitial && interstitialToJoinOk && joinConfJMT) {
-      const totalMediaJMT = Math.max(0, clickToInterstitial + interstitialToJoinOk + joinConfJMT);
+      const totalMediaJMT = clamp(
+        clickToInterstitial + interstitialToJoinOk + joinConfJMT,
+        0,
+        Infinity
+      );
       if (this.getMeeting()?.allowMediaInLobby) {
-        return totalMediaJMT;
+        return clamp(totalMediaJMT, 0, this.MAX_INTEGER);
       }
 
-      return Math.max(0, totalMediaJMT - lobbyTime);
+      return clamp(totalMediaJMT - lobbyTime, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -506,7 +508,11 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const joinConfJMT = this.getJoinConfJMT();
 
     if (clickToInterstitialWithUserDelay && interstitialToJoinOk && joinConfJMT) {
-      return Math.max(0, clickToInterstitialWithUserDelay + interstitialToJoinOk + joinConfJMT);
+      return clamp(
+        clickToInterstitialWithUserDelay + interstitialToJoinOk + joinConfJMT,
+        0,
+        this.MAX_INTEGER
+      );
     }
 
     return undefined;
@@ -521,7 +527,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const joinConfJMT = this.getJoinConfJMT();
 
     if (typeof interstitialToJoinOk === 'number' && typeof joinConfJMT === 'number') {
-      return Math.max(0, interstitialToJoinOk - joinConfJMT);
+      return clamp(interstitialToJoinOk - joinConfJMT, 0, this.MAX_INTEGER);
     }
 
     return undefined;
@@ -548,7 +554,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const reachablityClusterReqResp = this.precomputedLatencies.get('internal.get.cluster.time');
 
     return typeof reachablityClusterReqResp === 'number'
-      ? Math.floor(reachablityClusterReqResp)
+      ? clamp(Math.floor(reachablityClusterReqResp), 0, this.MAX_INTEGER)
       : undefined;
   }
 
@@ -582,7 +588,9 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
   public getExchangeCITokenJMT() {
     const exchangeCITokenJMT = this.precomputedLatencies.get('internal.exchange.ci.token.time');
 
-    return typeof exchangeCITokenJMT === 'number' ? Math.floor(exchangeCITokenJMT) : undefined;
+    return typeof exchangeCITokenJMT === 'number'
+      ? clamp(Math.floor(exchangeCITokenJMT), 0, this.MAX_INTEGER)
+      : undefined;
   }
 
   /**
@@ -592,7 +600,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     const refreshCaptchaReqResp = this.precomputedLatencies.get('internal.refresh.captcha.time');
 
     return typeof refreshCaptchaReqResp === 'number'
-      ? Math.floor(refreshCaptchaReqResp)
+      ? clamp(Math.floor(refreshCaptchaReqResp), 0, this.MAX_INTEGER)
       : undefined;
   }
 
@@ -606,7 +614,7 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
     );
 
     return typeof downloadIntelligenceModelsReqResp === 'number'
-      ? Math.floor(downloadIntelligenceModelsReqResp)
+      ? clamp(Math.floor(downloadIntelligenceModelsReqResp), 0, this.MAX_INTEGER)
       : undefined;
   }
 
@@ -618,6 +626,6 @@ export default class CallDiagnosticLatencies extends WebexPlugin {
   public getOtherAppApiReqResp() {
     const otherAppApiJMT = this.precomputedLatencies.get('internal.other.app.api.time');
 
-    return otherAppApiJMT > 0 ? Math.floor(otherAppApiJMT) : undefined;
+    return otherAppApiJMT > 0 ? clamp(Math.floor(otherAppApiJMT), 0, this.MAX_INTEGER) : undefined;
   }
 }

package/src/call-diagnostic/call-diagnostic-metrics.ts

@@ -75,6 +75,7 @@ type GetOriginOptions = {
   browserLaunchMethod?: BrowserLaunchMethodType;
   environment?: EnvironmentType;
   newEnvironment?: NewEnvironmentType;
+  vendorId?: string;
 };
 
 type GetIdentifiersOptions = {
@@ -297,6 +298,10 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
         origin.clientInfo.browserLaunchMethod = options.browserLaunchMethod;
       }
 
+      if (options?.vendorId) {
+        origin.clientInfo.vendorId = options.vendorId;
+      }
+
       return origin;
     }
 
@@ -1410,8 +1415,11 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
    */
   public setDeviceInfo(device: any): void {
     // This was created to fix the circular dependency between internal-plugin-device and internal-plugin-metrics
-    this.logger.log('CallDiagnosticMetrics: @setDeviceInfo called', device);
-
+    this.logger.log('CallDiagnosticMetrics: @setDeviceInfo called', {
+      userId: device?.userId,
+      deviceId: device?.url,
+      orgId: device?.orgId,
+    });
     this.device = device;
   }
 }

package/src/metrics.types.ts

@@ -138,6 +138,7 @@ export type SubmitClientEventOptions = {
   triggeredTime?: string;
   emailInput?: ClientEmailInput;
   userNameInput?: ClientUserNameInput;
+  vendorId?: string;
 };
 
 export type SubmitMQEOptions = {

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -131,7 +131,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     describe('getDiffBetweenTimestamps with clamping', () => {
-      it('should return diff without clamping when no clampValues provided', () => {
+      it('should apply default clamping (min: 0, max: 2147483647) when no clampValues provided', () => {
         cdl.saveTimestamp({key: 'client.alert.displayed', value: 10});
         cdl.saveTimestamp({key: 'client.alert.removed', value: 50});
         const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed');
@@ -204,6 +204,20 @@ describe('internal-plugin-metrics', () => {
         });
         assert.deepEqual(res, undefined);
       });
+
+      it('should apply default minimum clamping (0) when no clampValues provided and diff is negative', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 100});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 50});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed');
+        assert.deepEqual(res, 0);
+      });
+
+      it('should clamp the value when a number greater than 2147483647', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 0});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 2147483648});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed');
+        assert.deepEqual(res, 2147483647);
+      });
     });
 
     it('calculates getMeetingInfoReqResp correctly', () => {
@@ -303,6 +317,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getRefreshCaptchaReqResp(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.refresh.captcha.time', 4294967400);
+
+        assert.deepEqual(cdl.getRefreshCaptchaReqResp(), 2147483647);
+      });
     });
 
     describe('getReachabilityClustersReqResp', () => {
@@ -321,6 +341,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getReachabilityClustersReqResp(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.get.cluster.time', 4294967400);
+
+        assert.deepEqual(cdl.getReachabilityClustersReqResp(), 2147483647);
+      });
     });
 
     describe('getExchangeCITokenJMT', () => {
@@ -339,6 +365,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getExchangeCITokenJMT(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.exchange.ci.token.time', 4294967400);
+
+        assert.deepEqual(cdl.getExchangeCITokenJMT(), 2147483647);
+      });
     });
 
     describe('saveTimestamp', () => {
@@ -492,6 +524,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getPageJMT(), 10);
     });
 
+    it('calculates getPageJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.client.pageJMT', 2147483648);
+      assert.deepEqual(cdl.getPageJMT(), 2147483647);
+    });
+
     it('calculates getClickToInterstitial correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -522,6 +559,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getClickToInterstitial(), 0);
     });
 
+    it('calculates getClickToInterstitial without join button timestamp when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 2147483648);
+      assert.deepEqual(cdl.getClickToInterstitial(), 2147483647);
+    });
+
     it('calculates getClickToInterstitialWithUserDelay correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -552,6 +594,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 0);
     });
 
+    it('calculates getClickToInterstitialWithUserDelay without join button timestamp when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
+      assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 2147483647);
+    });
+
     it('calculates getInterstitialToJoinOK correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -660,6 +707,19 @@ describe('internal-plugin-metrics', () => {
         assert.deepEqual(cdl.getTotalJMT(), undefined);
       });
 
+    it('calculates getTotalJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 5,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 40,
+      });
+      cdl.saveLatency('internal.click.to.interstitial', 2147483648);
+      assert.deepEqual(cdl.getTotalJMT(), 2147483647);
+    });
+
     it('calculates getTotalJMTWithUserDelay correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -732,6 +792,19 @@ describe('internal-plugin-metrics', () => {
         assert.deepEqual(cdl.getTotalJMTWithUserDelay(), undefined);
       });
 
+      it('calculates getTotalJMTWithUserDelay correctly when it is greater than MAX_INTEGER', () => {
+        cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
+        cdl.saveTimestamp({
+          key: 'internal.client.interstitial-window.click.joinbutton',
+          value: 20,
+        });
+        cdl.saveTimestamp({
+          key: 'client.locus.join.response',
+          value: 40,
+        });
+        assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 2147483647);
+      });
+
     it('calculates getTotalMediaJMT correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -768,6 +841,42 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalMediaJMT(), 27);
     });
 
+    it('calculates getTotalMediaJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.click.joinbutton',
+        value: 5,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 8,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 10,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.request',
+        value: 12,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 2147483700,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.host.meeting.participant.admitted',
+        value: 2147483800,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.start',
+        value: 30,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 100,
+      });
+      assert.deepEqual(cdl.getTotalMediaJMT(), 2147483647);
+    });
+
     it('calculates getTotalMediaJMT correctly with allowMediaInLobby true', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -805,6 +914,43 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalMediaJMT(), 31);
     });
 
+    it('calculates getTotalMediaJMT correctly with allowMediaInLobby true and it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.click.joinbutton',
+        value: 5,
+        options: {meetingId: 'meeting-id'},
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 100,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 1000,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.request',
+        value: 2000,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 2147483700,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.host.meeting.participant.admitted',
+        value: 2147483800,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.start',
+        value: 2147483900,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 4294967400,
+      });
+      assert.deepEqual(cdl.getTotalMediaJMT(), 2147483647);
+    });
+
     it('calculates getTotalMediaJMTWithUserDelay correctly', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 7);
       cdl.saveTimestamp({
@@ -890,6 +1036,28 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getJoinConfJMT(), 20);
     });
 
+    it('calculates getJoinConfJMT correctly when it is greater than MAX_INTEGER', () => {
+      // Since both getJoinReqResp and getICESetupTime are individually clamped to 1200000,
+      // the maximum possible sum is 2400000, which is less than MAX_INTEGER (2147483647).
+      // This test should verify that the final clamping works by mocking the intermediate methods
+      // to return values that would sum to more than MAX_INTEGER.
+      
+      const originalGetJoinReqResp = cdl.getJoinReqResp;
+      const originalGetICESetupTime = cdl.getICESetupTime;
+      
+      // Mock the methods to return large values that would exceed MAX_INTEGER when summed
+      cdl.getJoinReqResp = () => 1500000000;
+      cdl.getICESetupTime = () => 1000000000;
+      
+      const result = cdl.getJoinConfJMT();
+      
+      // Restore original methods
+      cdl.getJoinReqResp = originalGetJoinReqResp;
+      cdl.getICESetupTime = originalGetICESetupTime;
+      
+      assert.deepEqual(result, 2147483647);
+    });
+
     it('calculates getClientJMT correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -982,6 +1150,26 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 8);
     });
 
+    it('calculates getInterstitialToMediaOKJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 4,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 10,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.host.meeting.participant.admitted',
+        value: 12,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 2147483700,
+      });
+      assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 2147483647);
+    });
+
     it('calculates getInterstitialToMediaOKJMT correctly without lobby', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -1029,6 +1217,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getDownloadTimeJMT(), 1000);
     });
 
+    it('calculates getDownloadTimeJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.download.time', 2147483648);
+      assert.deepEqual(cdl.getDownloadTimeJMT(), 2147483647);
+    });
+
     describe('getOtherAppApiReqResp', () => {
       it('returns undefined when no precomputed value available', () => {
         assert.deepEqual(cdl.getOtherAppApiReqResp(), undefined);
@@ -1051,6 +1244,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getOtherAppApiReqResp(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.other.app.api.time', 4294967400);
+
+        assert.deepEqual(cdl.getOtherAppApiReqResp(), 2147483647);
+      });
     });
   });
 });

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics.ts

@@ -264,6 +264,41 @@ describe('internal-plugin-metrics', () => {
         });
       });
 
+      it('should build origin correctly and vendorId can be passed in options', () => {
+        sinon.stub(CallDiagnosticUtils, 'anonymizeIPAddress').returns('1.1.1.1');
+
+        //@ts-ignore
+        const res = cd.getOrigin(
+          {
+            subClientType: 'WEB_APP',
+            clientType: 'TEAMS_CLIENT',
+            clientLaunchMethod: 'url-handler',
+            vendorId: 'GoogleMeet',
+          },
+          fakeMeeting.id
+        );
+
+        assert.deepEqual(res, {
+          clientInfo: {
+            browser: getBrowserName(),
+            browserVersion: getBrowserVersion(),
+            clientType: 'TEAMS_CLIENT',
+            clientVersion: 'webex-js-sdk/webex-version',
+            publicNetworkPrefix: '1.1.1.1',
+            localNetworkPrefix: '1.1.1.1',
+            os: getOSNameInternal(),
+            osVersion: getOSVersion() || 'unknown',
+            subClientType: 'WEB_APP',
+            clientLaunchMethod: 'url-handler',
+            vendorId: 'GoogleMeet',
+          },
+          environment: 'meeting_evn',
+          name: 'endpoint',
+          networkType: 'unknown',
+          userAgent,
+        });
+      });
+
       it('should build origin correctly with browserLaunchMethod', () => {
         sinon.stub(CallDiagnosticUtils, 'anonymizeIPAddress').returns('1.1.1.1');
 
@@ -3871,7 +3906,7 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(webexLoggerLogCalls[0].args, [
           'CallDiagnosticMetrics: @setDeviceInfo called',
-          device,
+          {userId: 'userId', deviceId: 'deviceUrl', orgId: 'orgId'},
         ]);
 
         assert.deepEqual(cd.device, device);