@webex/internal-plugin-metrics 3.9.0-webinar5k.1 → 3.10.0-multi-llms.1

package/src/call-diagnostic/call-diagnostic-metrics.ts

@@ -75,6 +75,7 @@ type GetOriginOptions = {
   browserLaunchMethod?: BrowserLaunchMethodType;
   environment?: EnvironmentType;
   newEnvironment?: NewEnvironmentType;
+  vendorId?: string;
 };
 
 type GetIdentifiersOptions = {
@@ -105,6 +106,8 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
   private delayedClientFeatureEvents: DelayedClientFeatureEvent[] = [];
   private eventErrorCache: WeakMap<any, any> = new WeakMap();
   private isMercuryConnected = false;
+  private eventLimitTracker: Map<string, number> = new Map();
+  private eventLimitWarningsLogged: Set<string> = new Set();
 
   // the default validator before piping an event to the batcher
   // this function can be overridden by the user
@@ -295,6 +298,10 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
         origin.clientInfo.browserLaunchMethod = options.browserLaunchMethod;
       }
 
+      if (options?.vendorId) {
+        origin.clientInfo.vendorId = options.vendorId;
+      }
+
       return origin;
     }
 
@@ -665,6 +672,144 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
     this.eventErrorCache = new WeakMap();
   }
 
+  /**
+   * Checks if an event should be limited based on criteria defined in the event dictionary.
+   * Returns true if the event should be sent, false if it has reached its limit.
+   * @param event - The diagnostic event object
+   * @returns boolean indicating whether the event should be sent
+   */
+  private shouldSendEvent({event}: Event): boolean {
+    const eventName = event?.name as string;
+    const correlationId = event?.identifiers?.correlationId;
+
+    if (!correlationId || correlationId === 'unknown') {
+      return true;
+    }
+
+    const limitKeyPrefix = `${eventName}:${correlationId}`;
+
+    switch (eventName) {
+      case 'client.media.render.start':
+      case 'client.media.render.stop':
+      case 'client.media.rx.start':
+      case 'client.media.rx.stop':
+      case 'client.media.tx.start':
+      case 'client.media.tx.stop': {
+        // Send only once per mediaType-correlationId pair (or mediaType-correlationId-shareInstanceId for share/share_audio)
+        const mediaType = event?.mediaType;
+        if (mediaType) {
+          if (mediaType === 'share' || mediaType === 'share_audio') {
+            const shareInstanceId = event?.shareInstanceId;
+            if (shareInstanceId) {
+              const limitKey = `${limitKeyPrefix}:${mediaType}:${shareInstanceId}`;
+
+              return this.checkAndIncrementEventCount(
+                limitKey,
+                1,
+                `${eventName} for ${mediaType} instance ${shareInstanceId}`
+              );
+            }
+          } else {
+            const limitKey = `${limitKeyPrefix}:${mediaType}`;
+
+            return this.checkAndIncrementEventCount(
+              limitKey,
+              1,
+              `${eventName} for mediaType ${mediaType}`
+            );
+          }
+        }
+        break;
+      }
+
+      case 'client.roap-message.received':
+      case 'client.roap-message.sent': {
+        // Send only once per correlationId and roap.messageType/roap.type
+        const roapMessageType = event?.roap?.messageType || event?.roap?.type;
+        if (roapMessageType) {
+          const limitKey = `${limitKeyPrefix}:${roapMessageType}`;
+
+          return this.checkAndIncrementEventCount(
+            limitKey,
+            1,
+            `${eventName} for ROAP type ${roapMessageType}`
+          );
+        }
+        break;
+      }
+
+      default:
+        return true;
+    }
+
+    return true;
+  }
+
+  /**
+   * Checks the current count for a limit key and increments if under limit.
+   * @param limitKey - The unique key for this limit combination
+   * @param maxCount - Maximum allowed count
+   * @param eventDescription - Description for logging
+   * @returns true if under limit and incremented, false if at/over limit
+   */
+  private checkAndIncrementEventCount(
+    limitKey: string,
+    maxCount: number,
+    eventDescription: string
+  ): boolean {
+    const currentCount = this.eventLimitTracker.get(limitKey) || 0;
+
+    if (currentCount >= maxCount) {
+      // Log warning only once per limit key
+      if (!this.eventLimitWarningsLogged.has(limitKey)) {
+        this.logger.log(
+          CALL_DIAGNOSTIC_LOG_IDENTIFIER,
+          `CallDiagnosticMetrics: Event limit reached for ${eventDescription}. ` +
+            `Max count ${maxCount} exceeded. Event will not be sent.`,
+          `limitKey: ${limitKey}`
+        );
+        this.eventLimitWarningsLogged.add(limitKey);
+      }
+
+      return false;
+    }
+
+    // Increment count and allow event
+    this.eventLimitTracker.set(limitKey, currentCount + 1);
+
+    return true;
+  }
+
+  /**
+   * Clears event limit tracking
+   */
+  public clearEventLimits(): void {
+    this.eventLimitTracker.clear();
+    this.eventLimitWarningsLogged.clear();
+  }
+
+  /**
+   * Clears event limit tracking for a specific correlationId only.
+   * Keeps limits for other meetings intact.
+   */
+  public clearEventLimitsForCorrelationId(correlationId: string): void {
+    if (!correlationId) {
+      return;
+    }
+    // Keys are formatted as "eventName:correlationId:..." across all limiters.
+    const hasCorrIdAtSecondToken = (key: string) => key.split(':')[1] === correlationId;
+    for (const key of Array.from(this.eventLimitTracker.keys())) {
+      if (hasCorrIdAtSecondToken(key)) {
+        this.eventLimitTracker.delete(key);
+      }
+    }
+    for (const key of Array.from(this.eventLimitWarningsLogged.values())) {
+      if (hasCorrIdAtSecondToken(key)) {
+        this.eventLimitWarningsLogged.delete(key);
+      }
+    }
+  }
+
   /**
    * Generate error payload for Client Event
    * @param rawError
@@ -1099,6 +1244,10 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
     );
     const diagnosticEvent = this.prepareClientEvent({name, payload, options});
 
+    if (!this.shouldSendEvent(diagnosticEvent)) {
+      return Promise.resolve();
+    }
+
     if (options?.preLoginId) {
       return this.submitToCallDiagnosticsPreLogin(diagnosticEvent, options?.preLoginId);
     }
@@ -1266,8 +1415,11 @@ export default class CallDiagnosticMetrics extends StatelessWebexPlugin {
    */
   public setDeviceInfo(device: any): void {
     // This was created to fix the circular dependency between internal-plugin-device and internal-plugin-metrics
-    this.logger.log('CallDiagnosticMetrics: @setDeviceInfo called', device);
-
+    this.logger.log('CallDiagnosticMetrics: @setDeviceInfo called', {
+      userId: device?.userId,
+      deviceId: device?.url,
+      orgId: device?.orgId,
+    });
     this.device = device;
   }
 }

package/src/call-diagnostic/call-diagnostic-metrics.util.ts

@@ -239,6 +239,20 @@ export const prepareDiagnosticMetricItem = (webex: any, item: any) => {
 
   // Set upgradeChannel to 'gold' if buildType is 'prod', otherwise to the buildType value
   const upgradeChannel = buildType === 'prod' ? 'gold' : buildType;
+  if (webex.devicemanager) {
+    const pairedDevice = webex.devicemanager.getPairedDevice();
+    if (pairedDevice) {
+      const devicePayload = {
+        deviceId: pairedDevice.deviceInfo?.id,
+        devicePairingType: webex.devicemanager.getPairedMethod(),
+        deviceURL: pairedDevice.url,
+        isPersonalDevice: pairedDevice.mode === 'personal',
+        productName: pairedDevice.devices[0]?.productName,
+      };
+      item.eventPayload.event.pairingState = 'paired';
+      item.eventPayload.event.pairedDevice = devicePayload;
+    }
+  }
 
   const origin: Partial<Event['origin']> = {
     buildType,

package/src/metrics.types.ts

@@ -138,6 +138,7 @@ export type SubmitClientEventOptions = {
   triggeredTime?: string;
   emailInput?: ClientEmailInput;
   userNameInput?: ClientUserNameInput;
+  vendorId?: string;
 };
 
 export type SubmitMQEOptions = {
@@ -160,7 +161,9 @@ export type InternalEvent = {
     | 'internal.client.meeting.interstitial-window.showed'
     | 'internal.client.interstitial-window.click.joinbutton'
     | 'internal.client.add-media.turn-discovery.start'
-    | 'internal.client.add-media.turn-discovery.end';
+    | 'internal.client.add-media.turn-discovery.end'
+    | 'internal.client.share.initiated'
+    | 'internal.client.share.stopped';
 
   payload?: never;
   options?: never;

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -130,6 +130,96 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(res2, undefined);
     });
 
+    describe('getDiffBetweenTimestamps with clamping', () => {
+      it('should apply default clamping (min: 0, max: 2147483647) when no clampValues provided', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 10});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 50});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed');
+        assert.deepEqual(res, 40);
+      });
+
+      it('should return diff without clamping when value is within range', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 10});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 50});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          minimum: 0,
+          maximum: 100
+        });
+        assert.deepEqual(res, 40);
+      });
+
+      it('should clamp to minimum when diff is below minimum', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 50});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 45});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          minimum: 10,
+          maximum: 100
+        });
+        assert.deepEqual(res, 10);
+      });
+
+      it('should clamp to maximum when diff is above maximum', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 10});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 210});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          minimum: 0,
+          maximum: 100
+        });
+        assert.deepEqual(res, 100);
+      });
+
+      it('should use default minimum of 0 when only maximum is specified', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 50});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 45});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          maximum: 100
+        });
+        assert.deepEqual(res, 0);
+      });
+
+      it('should not clamp maximum when maximum is undefined', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 10});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 2000});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          minimum: 5
+        });
+        assert.deepEqual(res, 1990);
+      });
+
+      it('should handle negative differences correctly with clamping', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 100});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 50});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          minimum: 10,
+          maximum: 1000
+        });
+        assert.deepEqual(res, 10);
+      });
+
+      it('should return undefined when timestamps are missing even with clamping', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 10});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed', {
+          minimum: 0,
+          maximum: 100
+        });
+        assert.deepEqual(res, undefined);
+      });
+
+      it('should apply default minimum clamping (0) when no clampValues provided and diff is negative', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 100});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 50});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed');
+        assert.deepEqual(res, 0);
+      });
+
+      it('should clamp the value when a number greater than 2147483647', () => {
+        cdl.saveTimestamp({key: 'client.alert.displayed', value: 0});
+        cdl.saveTimestamp({key: 'client.alert.removed', value: 2147483648});
+        const res = cdl.getDiffBetweenTimestamps('client.alert.displayed', 'client.alert.removed');
+        assert.deepEqual(res, 2147483647);
+      });
+    });
+
     it('calculates getMeetingInfoReqResp correctly', () => {
       cdl.saveTimestamp({key: 'internal.client.meetinginfo.request', value: 10});
       cdl.saveTimestamp({key: 'internal.client.meetinginfo.response', value: 20});
@@ -227,6 +317,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getRefreshCaptchaReqResp(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.refresh.captcha.time', 4294967400);
+
+        assert.deepEqual(cdl.getRefreshCaptchaReqResp(), 2147483647);
+      });
     });
 
     describe('getReachabilityClustersReqResp', () => {
@@ -245,6 +341,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getReachabilityClustersReqResp(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.get.cluster.time', 4294967400);
+
+        assert.deepEqual(cdl.getReachabilityClustersReqResp(), 2147483647);
+      });
     });
 
     describe('getExchangeCITokenJMT', () => {
@@ -263,6 +365,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getExchangeCITokenJMT(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.exchange.ci.token.time', 4294967400);
+
+        assert.deepEqual(cdl.getExchangeCITokenJMT(), 2147483647);
+      });
     });
 
     describe('saveTimestamp', () => {
@@ -416,6 +524,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getPageJMT(), 10);
     });
 
+    it('calculates getPageJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.client.pageJMT', 2147483648);
+      assert.deepEqual(cdl.getPageJMT(), 2147483647);
+    });
+
     it('calculates getClickToInterstitial correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -446,6 +559,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getClickToInterstitial(), 0);
     });
 
+    it('calculates getClickToInterstitial without join button timestamp when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.click.to.interstitial', 2147483648);
+      assert.deepEqual(cdl.getClickToInterstitial(), 2147483647);
+    });
+
     it('calculates getClickToInterstitialWithUserDelay correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -476,6 +594,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 0);
     });
 
+    it('calculates getClickToInterstitialWithUserDelay without join button timestamp when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
+      assert.deepEqual(cdl.getClickToInterstitialWithUserDelay(), 2147483647);
+    });
+
     it('calculates getInterstitialToJoinOK correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -584,6 +707,19 @@ describe('internal-plugin-metrics', () => {
         assert.deepEqual(cdl.getTotalJMT(), undefined);
       });
 
+    it('calculates getTotalJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 5,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 40,
+      });
+      cdl.saveLatency('internal.click.to.interstitial', 2147483648);
+      assert.deepEqual(cdl.getTotalJMT(), 2147483647);
+    });
+
     it('calculates getTotalJMTWithUserDelay correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -656,6 +792,19 @@ describe('internal-plugin-metrics', () => {
         assert.deepEqual(cdl.getTotalJMTWithUserDelay(), undefined);
       });
 
+      it('calculates getTotalJMTWithUserDelay correctly when it is greater than MAX_INTEGER', () => {
+        cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 2147483648);
+        cdl.saveTimestamp({
+          key: 'internal.client.interstitial-window.click.joinbutton',
+          value: 20,
+        });
+        cdl.saveTimestamp({
+          key: 'client.locus.join.response',
+          value: 40,
+        });
+        assert.deepEqual(cdl.getTotalJMTWithUserDelay(), 2147483647);
+      });
+
     it('calculates getTotalMediaJMT correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -692,6 +841,42 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalMediaJMT(), 27);
     });
 
+    it('calculates getTotalMediaJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.click.joinbutton',
+        value: 5,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 8,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 10,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.request',
+        value: 12,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 2147483700,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.host.meeting.participant.admitted',
+        value: 2147483800,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.start',
+        value: 30,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 100,
+      });
+      assert.deepEqual(cdl.getTotalMediaJMT(), 2147483647);
+    });
+
     it('calculates getTotalMediaJMT correctly with allowMediaInLobby true', () => {
       cdl.saveTimestamp({
         key: 'internal.client.meeting.click.joinbutton',
@@ -729,6 +914,43 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getTotalMediaJMT(), 31);
     });
 
+    it('calculates getTotalMediaJMT correctly with allowMediaInLobby true and it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.click.joinbutton',
+        value: 5,
+        options: {meetingId: 'meeting-id'},
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.meeting.interstitial-window.showed',
+        value: 100,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 1000,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.request',
+        value: 2000,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 2147483700,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.host.meeting.participant.admitted',
+        value: 2147483800,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.start',
+        value: 2147483900,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 4294967400,
+      });
+      assert.deepEqual(cdl.getTotalMediaJMT(), 2147483647);
+    });
+
     it('calculates getTotalMediaJMTWithUserDelay correctly', () => {
       cdl.saveLatency('internal.click.to.interstitial.with.user.delay', 7);
       cdl.saveTimestamp({
@@ -814,6 +1036,28 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getJoinConfJMT(), 20);
     });
 
+    it('calculates getJoinConfJMT correctly when it is greater than MAX_INTEGER', () => {
+      // Since both getJoinReqResp and getICESetupTime are individually clamped to 1200000,
+      // the maximum possible sum is 2400000, which is less than MAX_INTEGER (2147483647).
+      // This test should verify that the final clamping works by mocking the intermediate methods
+      // to return values that would sum to more than MAX_INTEGER.
+      
+      const originalGetJoinReqResp = cdl.getJoinReqResp;
+      const originalGetICESetupTime = cdl.getICESetupTime;
+      
+      // Mock the methods to return large values that would exceed MAX_INTEGER when summed
+      cdl.getJoinReqResp = () => 1500000000;
+      cdl.getICESetupTime = () => 1000000000;
+      
+      const result = cdl.getJoinConfJMT();
+      
+      // Restore original methods
+      cdl.getJoinReqResp = originalGetJoinReqResp;
+      cdl.getICESetupTime = originalGetICESetupTime;
+      
+      assert.deepEqual(result, 2147483647);
+    });
+
     it('calculates getClientJMT correctly', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -906,6 +1150,26 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 8);
     });
 
+    it('calculates getInterstitialToMediaOKJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.interstitial-window.click.joinbutton',
+        value: 4,
+      });
+      cdl.saveTimestamp({
+        key: 'client.locus.join.response',
+        value: 10,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.host.meeting.participant.admitted',
+        value: 12,
+      });
+      cdl.saveTimestamp({
+        key: 'client.ice.end',
+        value: 2147483700,
+      });
+      assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 2147483647);
+    });
+
     it('calculates getInterstitialToMediaOKJMT correctly without lobby', () => {
       cdl.saveTimestamp({
         key: 'internal.client.interstitial-window.click.joinbutton',
@@ -918,6 +1182,18 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getInterstitialToMediaOKJMT(), 10);
     });
 
+    it('calculates getShareDuration correctly', () => {
+      cdl.saveTimestamp({
+        key: 'internal.client.share.initiated',
+        value: 5,
+      });
+      cdl.saveTimestamp({
+        key: 'internal.client.share.stopped',
+        value: 7,
+      });
+      assert.deepEqual(cdl.getShareDuration(), 2);
+    });
+
     describe('calculates getU2CTime correctly', () => {
       it('returns undefined when no precomputed value available', () => {
         assert.deepEqual(cdl.getU2CTime(), undefined);
@@ -941,6 +1217,11 @@ describe('internal-plugin-metrics', () => {
       assert.deepEqual(cdl.getDownloadTimeJMT(), 1000);
     });
 
+    it('calculates getDownloadTimeJMT correctly when it is greater than MAX_INTEGER', () => {
+      cdl.saveLatency('internal.download.time', 2147483648);
+      assert.deepEqual(cdl.getDownloadTimeJMT(), 2147483647);
+    });
+
     describe('getOtherAppApiReqResp', () => {
       it('returns undefined when no precomputed value available', () => {
         assert.deepEqual(cdl.getOtherAppApiReqResp(), undefined);
@@ -963,6 +1244,12 @@ describe('internal-plugin-metrics', () => {
 
         assert.deepEqual(cdl.getOtherAppApiReqResp(), 321);
       });
+
+      it('returns the correct number when it is greater than 2147483647', () => {
+        cdl.saveLatency('internal.other.app.api.time', 4294967400);
+
+        assert.deepEqual(cdl.getOtherAppApiReqResp(), 2147483647);
+      });
     });
   });
 });