@webex/internal-plugin-metrics 3.5.0-wxcc.1 → 3.6.0

package/test/unit/spec/business/business-metrics.ts

@@ -20,6 +20,8 @@ describe('internal-plugin-metrics', () => {
 
     beforeEach(() => {
       now = new Date();
+      sinon.createSandbox();
+      sinon.useFakeTimers(now.getTime());
 
       webex = {
         canAuthorize: true,
@@ -74,7 +76,7 @@ describe('internal-plugin-metrics', () => {
     });
 
     describe('#sendEvent', () => {
-      it('should send correctly shaped business event (check name building and internal tagged event building)', () => {
+      it('should send correctly shaped business event (check name building and internal tagged event building) and default correctly', () => {
         // For some reasons `jest` isn't available when testing form build server - so can't use `jest.fn()` here...
         const requestCalls = [];
         const request = function(arg) { requestCalls.push(arg) }
@@ -86,6 +88,7 @@ describe('internal-plugin-metrics', () => {
         assert.equal(requestCalls.length, 1)
         assert.deepEqual(requestCalls[0], {
           eventPayload: {
+            appType: 'Web Client',
             context: {
               app: {version: 'webex-version'},
               device: {id: 'deviceId'},
@@ -113,8 +116,72 @@ describe('internal-plugin-metrics', () => {
           },
           type: ['business'],
         });
-        assert.isNumber(requestCalls[0].eventPayload.client_timestamp)
+        assert.isString(requestCalls[0].eventPayload.client_timestamp)
+        assert.equal(requestCalls[0].eventPayload.client_timestamp, now.toISOString())
       })
+
+      describe('when table is provided', () => {
+        it('should send correctly shaped business event with table: wbx_app_callend_metrics and ignore the key name', () => {
+          // For some reasons `jest` isn't available when testing form build server - so can't use `jest.fn()` here...
+          const requestCalls = [];
+          const request = function(arg) { requestCalls.push(arg) }
+
+          businessMetrics.clientMetricsBatcher.request = request;
+          
+          assert.equal(requestCalls.length, 0)
+          businessMetrics.submitBusinessEvent({ name: "foobar", payload: {bar:"gee"}, table: 'wbxapp_callend_metrics' })
+          assert.equal(requestCalls.length, 1)
+          assert.deepEqual(requestCalls[0], {
+            eventPayload: {
+              key: 'callEnd',
+              client_timestamp: requestCalls[0].eventPayload.client_timestamp, // This is to bypass time check, which is checked below.
+              appType: 'Web Client',
+              value: {
+                bar: 'gee'
+              }
+            },
+            type: ['business'],
+          });
+          assert.isString(requestCalls[0].eventPayload.client_timestamp)
+          assert.equal(requestCalls[0].eventPayload.client_timestamp, now.toISOString())
+        });
+
+        it('should send correctly shaped business event with table: business_metrics', () => {
+          // For some reasons `jest` isn't available when testing form build server - so can't use `jest.fn()` here...
+          const requestCalls = [];
+          const request = function(arg) { requestCalls.push(arg) }
+
+          businessMetrics.clientMetricsBatcher.request = request;
+          
+          assert.equal(requestCalls.length, 0)
+          businessMetrics.submitBusinessEvent({ name: "foobar", payload: {bar:"gee"}, table: 'business_metrics' })
+          assert.equal(requestCalls.length, 1)
+          assert.deepEqual(requestCalls[0], {
+            eventPayload: {
+              key: 'foobar',
+              appType: 'Web Client',
+              client_timestamp: requestCalls[0].eventPayload.client_timestamp, // This is to bypass time check, which is checked below.
+              value: {
+                bar: "gee",
+                browser: getBrowserName(),
+                browserHeight: window.innerHeight,
+                browserVersion: getBrowserVersion(),
+                browserWidth: window.innerWidth,
+                domain: window.location.hostname,
+                inIframe: false,
+                locale: window.navigator.language,
+                os: getOSNameInternal(),
+                app: {version: 'webex-version'},
+                device: {id: 'deviceId'},
+                locale: 'language',
+              }
+            },
+            type: ['business'],
+          });
+          assert.isString(requestCalls[0].eventPayload.client_timestamp)
+          assert.equal(requestCalls[0].eventPayload.client_timestamp, now.toISOString())
+        });
+      });
     })
   });
 });

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics-batcher.ts

@@ -441,7 +441,7 @@ describe('plugin-metrics', () => {
         // item also gets assigned a delay property but the key is a Symbol and haven't been able to test that..
         assert.deepEqual(calls.args[0].eventPayload, {
           event: 'my.event',
-          origin: {buildType: 'test', networkType: 'unknown'},
+          origin: {buildType: 'test', networkType: 'unknown', upgradeChannel: 'test'},
         });
 
         assert.deepEqual(calls.args[0].type, ['diagnostic-event']);
@@ -455,6 +455,7 @@ describe('plugin-metrics', () => {
           origin: {
             buildType: 'test',
             networkType: 'unknown',
+            upgradeChannel: 'test',
           },
         });
         assert.deepEqual(prepareDiagnosticMetricItemCalls[0].args[1].type, ['diagnostic-event']);

package/test/unit/spec/call-diagnostic/call-diagnostic-metrics-latencies.ts

@@ -12,12 +12,10 @@ describe('internal-plugin-metrics', () => {
       sinon.useFakeTimers(now.getTime());
       const webex = {
         meetings: {
-          meetingCollection: {
-            get: (id: string) => {
-              if (id === 'meeting-id') {
-                return {id: 'meeting-id', allowMediaInLobby: true};
-              }
-            },
+          getBasicMeetingInformation: (id: string) => {
+            if (id === 'meeting-id') {
+              return {id: 'meeting-id', allowMediaInLobby: true};
+            }
           },
         },
       };